Commit Graph

16122 Commits

Author SHA1 Message Date
Winson Chung 83f58f2d2c Fix incorrect reporting of launch failure
- Launcher uses the same consumer to handle task launch failure and
  animation-cancel, so only show the notification when it is an
  actual launch failure.

Bug: 79209142
Change-Id: I6b708ac9888673056f2c6de1d5aee4a281c61027
2018-05-03 20:37:35 +00:00
Winson Chung 3f596f649d Also setEarlyWakeup for single frame transaction to hide window.
Bug: 79204453
Change-Id: Ib13f8a0c49b03fdce960b3f480c598bb70a113ef
2018-05-03 18:24:06 +00:00
Winson Chung 9ebc88a381 Fixing transaction regression.
- Need to call setEarlyWakeup() for each transaction, not just the
  first

Bug: 79204453
Change-Id: Ib83bddb9eaeb7563954bc9d7f584fdd5d302b501
2018-05-03 10:57:23 -07:00
Winson Chung 94262dedb7 Skip snapping to page when there are no pages
- This scrolls the recents view, which affects the empty recents icon
  position.

Bug: 79170402
Test: Clear all tasks, then quickscrub
Change-Id: I316805c0083d4ad65a8df0fafd88545859054405
2018-05-02 17:45:14 -07:00
android-build-team Robot b8e5bf3e42 Merge "Handling activity recreate due to configuration changes in the middle of the long fling" into ub-launcher3-edmonton 2018-05-02 23:16:13 +00:00
android-build-team Robot d5efb650af Merge "Using a custom view instead of ImageView to avoid relayout when the icon changes" into ub-launcher3-edmonton 2018-05-02 22:59:02 +00:00
Sunny Goyal 16593d7932 Handling activity recreate due to configuration changes
in the middle of the long fling

Bug: 77651657
Change-Id: I8107c424eb37512ce78c943da04a6e7faf33be65
2018-05-02 15:53:22 -07:00
Sunny Goyal 85c53f2af5 Using a custom view instead of ImageView to avoid relayout when the icon changes
Bug: 78585335
Change-Id: I078aec5b80ec45933ba4974df68cab23ac4a0ca0
2018-05-02 15:38:21 -07:00
Hyunyoung Song 960ab6c085 Merge "Clear all task button should not log as individual swipe up Bug: 78895803" into ub-launcher3-edmonton 2018-05-02 22:32:55 +00:00
Mehdi Alizadeh 553de87c80 Merge "Refactors ButtonDropTarget to add extension data" into ub-launcher3-edmonton 2018-05-02 22:23:20 +00:00
android-build-team Robot 433ef09d29 Merge "Moving some callbacks from LauncherCallbacks to OverviewCallbacks" into ub-launcher3-edmonton 2018-05-02 22:06:10 +00:00
android-build-team Robot 145cb8420d Merge "Log OVERVIEW_ACTIVITY via MetricsLogger in quickstep Bug: 77920179" into ub-launcher3-edmonton 2018-05-02 21:53:59 +00:00
Hyunyoung Song a05860421f Log OVERVIEW_ACTIVITY via MetricsLogger in quickstep
Bug: 77920179

Change-Id: Id4c7dc3d535c7a8009d340183e640b04ab07408a
2018-05-02 14:34:23 -07:00
Tony Wickham 1817942d8a Merge "Add a quick scrub threshold" into ub-launcher3-edmonton 2018-05-02 21:21:24 +00:00
android-build-team Robot a978a24d09 Merge "Making Clear-all a "button" for accessibility." into ub-launcher3-edmonton 2018-05-02 21:20:37 +00:00
Mehdi Alizadeh bda47cf925 Refactors ButtonDropTarget to add extension data
Also fixes a bug where DeleteDropTarget was logging Remove instead of
Cancel.

Bug: 78793340
Test: Enable verbose logging and manual test
Change-Id: I0f0cfff070eab003ebb745292630bc6ce3243f4d
2018-05-02 14:20:09 -07:00
android-build-team Robot 55e6665067 Merge "Fixing Launcher3Quickstep build, broken due to SDK changes" into ub-launcher3-edmonton 2018-05-02 21:07:47 +00:00
Vadim Tryshev 1e3687d5a1 Making Clear-all a "button" for accessibility.
To get it announced as "Clar all button", not just "clear all".

Bug: 72222505
Test: Manual
Change-Id: Ied1a036fda77c38af39db868d3dc1ae443982bcd
2018-05-02 13:54:38 -07:00
android-build-team Robot 9b83fe225d Merge "Quickstep onboarding backward compatibility for devices release with Android N & O." into ub-launcher3-edmonton 2018-05-02 20:51:37 +00:00
android-build-team Robot f1db5a0b81 Merge "Settling scrolls over clear-all button." into ub-launcher3-edmonton 2018-05-02 20:44:06 +00:00
Tracy Zhou 8b23c6f60b Quickstep onboarding backward compatibility for devices release with Android N & O.
Quickstep introduces swipe up gesture to open Overview and removes the
Recents button. We still want to show shelf bounce animation for Android
N & O users with Recents button because Overview is updated and swiping
up from there takes users to All Apps.

Test: manual test
Change-Id: I917c91564c47c78d2dc3883b8a7bf7824b5f5bc8
Fixes: 78647939
2018-05-02 13:41:28 -07:00
android-build-team Robot d79759556d Merge "New calculation for clear-all alpha." into ub-launcher3-edmonton 2018-05-02 20:39:15 +00:00
Vadim Tryshev a9283beebc Settling scrolls over clear-all button.
Per UX feedback, we divide the "overscroll area" 50/50 and settle to the
closest of the most recent task position and the fully scrolled
position.

Bug: 72222505
Test: Manual
Change-Id: Ic98fa5ae2f14f274f6a425ac687f13f7b3a4332e
2018-05-02 13:30:27 -07:00
Vadim Tryshev 80cd825c0f New calculation for clear-all alpha.
Per UX feedback, alpha changes from the central position of the last
task and its overscrolled position. Button location is not used.

Bug: 72222505
Test: Manual
Change-Id: Ifc22c935940eaeb1b1ec6e4a5f2709ac7ae8253b
2018-05-02 13:14:16 -07:00
Tony Wickham cf563e5f2d Add a quick scrub threshold
Change-Id: I184ca2bd3d97e58f8fe8841a66571ca101ee3dc2
2018-05-02 12:03:22 -07:00
Sunny Goyal ea992acc2f Fixing Launcher3Quickstep build, broken due to SDK changes
Change-Id: I7228c036e023f94d3f47b303c7e7b4395bc8a1b7
2018-05-02 12:00:53 -07:00
android-build-team Robot 5574460607 Merge "Setting correct font for clear-all button" into ub-launcher3-edmonton 2018-05-02 18:10:04 +00:00
android-build-team Robot cb83d8d9b4 Merge "Increase DELAY_MS for DiscoveryBounce." into ub-launcher3-edmonton 2018-05-02 18:04:46 +00:00
Tony Wickham f325b19de3 Merge "Gracefully handle some edge cases in quick scrub" into ub-launcher3-edmonton 2018-05-02 16:21:21 +00:00
Tony Wickham 7a5d4ae64f Merge "Fix some state issues with user-controlled animations" into ub-launcher3-edmonton 2018-05-02 16:20:19 +00:00
Jorim Jaggi bbeedd1d2f Merge "Fix some jank with transitions" into ub-launcher3-edmonton 2018-05-02 13:17:42 +00:00
Jon Miranda 8d945e497f Increase DELAY_MS for DiscoveryBounce.
We need it to be longer, otherwise it interferes with the app closing
animation.

Change-Id: Id50e54362564eb8f7c083495fe8ca039c68fba3f
2018-05-01 21:21:48 -07:00
Vadim Tryshev 9beaa177f4 Setting correct font for clear-all button
Not it looks exactly like the one for notifications in SystemUI.

Bug: 72222505
Test: Manual
Change-Id: I9db2f403746386f9d807d4e3c250f4a1c7a46b68
2018-05-01 20:10:26 -07:00
Sunny Goyal 8e1fbc5103 Moving some callbacks from LauncherCallbacks to OverviewCallbacks
Bug: 78780639
Change-Id: I90f868c741834efbe542367bdc3539f6d14f1939
2018-05-01 16:58:52 -07:00
android-build-team Robot cacf90cc48 Merge "Reusing the same bitmap and pixel array for shape detection" into ub-launcher3-edmonton 2018-05-01 23:32:17 +00:00
Hyunyoung Song 78e278e9db Clear all task button should not log as individual swipe up
Bug: 78895803

Change-Id: I3a8c40e892396ea0781423fa1791a9e13a116c45
2018-05-01 15:47:26 -07:00
android-build-team Robot 4d9c414cdb Merge "Bound overscroll shift amount to avoid content from drawing on top (Y-val) of the QSB." into ub-launcher3-edmonton 2018-05-01 21:07:59 +00:00
android-build-team Robot 3adb0b9f2a Merge "Fade in LauncherRootView in finishFirstPageBind." into ub-launcher3-edmonton 2018-05-01 20:59:00 +00:00
Jon Miranda 5916709219 Bound overscroll shift amount to avoid content from drawing on top (Y-val)
of the QSB.

Bug: 77538324
Change-Id: Idabc4365c5fe5cb1894fa0eb84ea9309b85f99a3
2018-05-01 13:57:33 -07:00
Jon Miranda dbd9286abd Fade in LauncherRootView in finishFirstPageBind.
This ensures that the fade in animation will actually run, as DragLayer alpha
can be set by other means.

Bug: 72728697
Change-Id: I3ca0a6811b113e331119c74539a4421cfbdb51c9
2018-05-01 13:49:54 -07:00
Tony f47e5ce3cf Gracefully handle some edge cases in quick scrub
- Switch to normal overview if task fails to launch in onQuickScrubEnd()
- Stop auto-advancing if recents isn't visible
- Wait until transition to quick scrub completes before launching

Bug: 77521777
Bug: 78557737
Change-Id: I5206c0d3c52bf792f52cf3e7adcf03f8a2de18bb
2018-05-01 14:21:04 -05:00
Tony 31fbd4c08b Fix some state issues with user-controlled animations
Previously, user-controlled animations weren't properly being canceled when a
non-user-controlled animation started, e.g. when hitting home. Thus, we could
end in the wrong or inconsistent state because the user-controlled animation's
end runnable was still used. Now we add a cleanup callback for when we reset
the user-controlled animation for one that isn't user-controlled.

Also fixed a couple typos.

Tests (easier with animation durations extended):
- Swipe up and hit home before reaching overview -> land on home
- Go to overview, swipe down slightly (before threshold to go to workspace)
  and let go -> return to overview without flash (recents was resetting)
- Swipe up, press home while swiping -> goes home, stops responding to drag
- Start dismissing task and hit home before it finishes (or while dragging)
  -> goes home, stops responding to drag

Bug: 78249220
Change-Id: If11d8999e3fadba38c987b25af67cd2304cd859b
2018-05-01 13:45:27 -05:00
Winson Chung 976047647e Merge "Also notify the user when a task view fails to launch." into ub-launcher3-edmonton 2018-05-01 18:41:02 +00:00
android-build-team Robot a269a81881 Merge "Accessibility of clear-all button" into ub-launcher3-edmonton 2018-05-01 18:31:25 +00:00
Winson Chung 6dceb7755a Also notify the user when a task view fails to launch.
Bug: 78660939

Change-Id: I8041d3bdd6da1caed72affb1e295c416214a92d4
2018-05-01 11:27:02 -07:00
Vadim Tryshev 4e3e54a45a Accessibility of clear-all button
Making it visible to accessibility even when it’s completely hidden
behind a task. I had to mark it visible as a view. Now it’s invisible
only when there are no tasks in RecensView, to hide it from
accessibility.

Focusing on the button completely reveals it.

Bug: 72222505
Test: Manual
Change-Id: Ia31a1136e07faed93b4a44d5be69483d3b88364d
2018-05-01 11:20:14 -07:00
android-build-team Robot 954157a228 Merge "Remove associated task views if task is removed while Overview is showing" into ub-launcher3-edmonton 2018-05-01 18:12:34 +00:00
Winson Chung 3b0c3b981b Remove associated task views if task is removed while Overview is showing
Bug: 78660939
Change-Id: Iccfb09c985662c150f42d382b92d17f853abaaea
2018-05-01 10:04:46 -07:00
android-build-team Robot c62cafe149 Merge "Import translations. DO NOT MERGE" into ub-launcher3-edmonton 2018-05-01 03:17:29 +00:00
Bill Yi f65f5221b7 Import translations. DO NOT MERGE
Change-Id: Ia39b69f4fb3da457065d1416b387f920fdd51106
Auto-generated-cl: translation import
2018-04-30 18:41:54 -07:00