Commit Graph

2028 Commits

Author SHA1 Message Date
Greg Kaiser 486c96be87 Merge "Revert "App Pairs: Implement Overview Actions View button"" into main 2023-12-18 15:15:59 +00:00
Greg Kaiser 45ba84268c Revert "App Pairs: Implement Overview Actions View button"
Revert submission 25143701-app-pairs-action-button

Reason for revert: Causes P0 b/315292030

Reverted changes: /q/submissionid:25143701-app-pairs-action-button

Change-Id: I1fcbb9f333ca29c5db255232dc9475dec465ac81
2023-12-18 14:53:19 +00:00
Jeremy Sim 789414190f Merge "App Pairs: Implement Overview Actions View button" into main 2023-12-18 05:07:36 +00:00
Jeremy Sim e1fcb5390b App Pairs: Implement Overview Actions View button
[App Pairs 6/?]

This patch includes:
- Ability to "save app pair" from Overview Actions
- The actions bar is not longer hidden for GroupedTasks; instead the individual buttons for "Select", "Screenshot", and "Split screen" are toggled off and "Save app pair" is toggled on.

Note: This patch introduces a slight regression (b/315545418) where users are now able to long-press to select text on task 1 of a paired GroupedTaskView (previously we did not let them select text on either task for consistency.) Will follow up with a fix -- see bug for details.

Flag: ACONFIG com.android.wm.shell.enable_app_pairs DEVELOPMENT
Bug: 315545418
Bug: 315292030
Test: Manual, all action buttons still work and "Save app pair" appears and disappears correctly
Change-Id: I0eb1fa9520ba14074ede3480e771b340cf2f6e2c
2023-12-18 02:25:22 +00:00
Bill Yi 51b2982acc Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2023-12-15 00:13:22 +00:00
Bill Yi 7a65495bef Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Ic31a5d47d4eb0cc6d6d08ef09e4289eca31ae180
2023-12-13 15:10:28 -08:00
Charlie Anderson 797ed83700 Merge "Add wrapper for logging backup & restore metrics from Launcher" into main 2023-12-13 19:33:26 +00:00
Tracy Zhou 9ccd5d4257 Introduce taskbar_phone_size
In small screen, we use 48dp for nav bar height, while it's 60dp for task bar.

Bug: 230395757
Test: manual
Change-Id: Ia7083a1b2246981466e1163404c63b645a6bf5b1
2023-12-13 00:38:15 -08:00
Charlie Anderson 489f1ada5c Add wrapper for logging backup & restore metrics from Launcher
Bug: 25177913
Flag: ACONFIG com.android.launcher3.enable_launcher_br_metrics DEVELOPMENT
Test: locally

Change-Id: I220721f705eb7244a1f13ef8997682999d799f51
2023-12-11 17:01:28 -05:00
William Leshner 5836cec7ec Merge "Show Launcher's widget picker in an activity." into main 2023-12-07 19:23:58 +00:00
Greg Kaiser d806c0abd1 Merge "Revert^3 "Refactor/clean up Overview Actions buttons"" into main 2023-12-07 14:06:19 +00:00
Greg Kaiser e8b1d45485 Revert^3 "Refactor/clean up Overview Actions buttons"
6b99fe1a00

Change-Id: I8f4054335b7bdee898ce3943f4a3798ba51c6fbc
2023-12-07 13:54:39 +00:00
Bill Yi aa84ba761e Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2023-12-07 00:09:23 +00:00
Bill Yi 42dc5249ad Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Ia0be1d60e62b547645acee5bb5e34af457ade67c
2023-12-05 18:25:53 -08:00
Will Leshner 9dce65e05a Show Launcher's widget picker in an activity.
Bug: 307306823
Test: atest Launcher3Tests
Flag: NA

Change-Id: I28ef731abcdf1bd44c66366d42a135912dbcc5be
2023-12-05 13:12:05 -08:00
Jeremy Sim 6b99fe1a00 Revert^2 "Refactor/clean up Overview Actions buttons"
Second attempt after ag/25292769 was reverted (fixed the screenshot test failure)

Bug: 274835596
Test: atest OverviewImageTest#testOverview
Flag: NA
Change-Id: I3e442264e946b3a0979ca3e401b9ffd30671a291
2023-12-05 11:36:01 +00:00
randypfohl 1338dc41df Fixing regression where icon view became focusable
Description: in ag/24721149 we stopped inflating IconView
from Task.xml and instead used a viewstub. When creating
files to fill the viewstub, we forgot to place the correct
attributes on Icon_view.xml. We did place them correctly
elsewhere. Anyways this is why we were seeing focusable
icons.

Flag: None

Test: Built locally, will follow up with automation

Bug: 307461880

Change-Id: I45f895c8545a80f80c79709180f2878476d10221
2023-12-01 14:35:48 +00:00
Saumya Prakash 89b93d4bbd Merge "Add taskbar pinning education for new users and update other steps" into main 2023-11-30 20:08:13 +00:00
Bill Yi b72796db31 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I8827e64a1ba84eb28febabd33f591faf7113f362
2023-11-29 12:47:12 -08:00
Alex Chau 4745e95ea7 Merge "Adjust app chip menu top margin." into main 2023-11-29 14:40:12 +00:00
Vinit Nayak eabb37822f Merge "Change SplitInstructionsView cancel from X to "Cancel"" into main 2023-11-29 00:18:42 +00:00
Pat Manning ad6b044412 Adjust app chip menu top margin.
Include adjusting gap of menu when expanding app chip.

Fix: 313648444
Test: OverviewImageTest
Flag: ACONFIG com.android.launcher3.enable_overview_icon_menu TEAMFOOD
Change-Id: Iea8ea76873ac008b90b6a8f183dc99cba9237041
2023-11-28 22:38:22 +00:00
Vinit Nayak d6efde5cbb Change SplitInstructionsView cancel from X to "Cancel"
* Styling (accent color) is still a TODO,
just made it bold for now.

Flag: ACONFIG com.android.wm.shell.enable_split_contextual DEVELOPMENT
Bug: 295983387
Test: Tested w/ flag on and off, cancel doesn't show
with flag off

Change-Id: Id5214a86abbe0cf095e32f6f75522ea51d6b1f3c
2023-11-28 14:34:12 -08:00
Saumya Prakash 5feb491549 Add taskbar pinning education for new users and update other steps
This change updates the current transient taskbar education to include
the pinning feature and additional updates to Lottie animations. It also
removes the tutorial that teaches users to switch navigation modes. The
pinning education is gated behind an additional pinning education static flag.

Fixes: 302588455,300161174
Test: Went through taskbar education for persistent and transient
taskbar with the flag on and off.
Flag: ACONFIG com.android.launcher3.enable_taskbar_pinning DISABLED

Change-Id: I836467091bfe694eee89ac46c4be597c490e1b3f
2023-11-28 20:20:25 +00:00
Pat Manning 0f395e8a11 Update text style for icon app chip menu.
Bug: 311657856
Test: OverviewImageTest
Flag: ACONFIG com.android.launcher3.enable_overview_icon_menu TEAMFOOD
Change-Id: Ied1c5fddb94e3093729846cacfef9b257aad8df7
2023-11-25 11:24:45 +00:00
Bill Yi 66f0200e50 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Ie7f789feff97a375ab542ea6fc7fd841c66dc15e
2023-11-21 16:55:56 -08:00
Pat Manning 37edf2ed08 Merge "Add background to app chip menu so elevation shadow renders." into main 2023-11-21 18:09:32 +00:00
Sanatt Abrol a6b4e1bc43 Bug: b/307278302
Fix clipping of DesktopTaskView border on focus/ hover

Hover border: https://screenshot.googleplex.com/B9CUW49q6inMW75
Focus border: https://screenshot.googleplex.com/36uLJ4jC295t7PZ

`android:clipToOutline` prevents drawing outside view bounds and results in the focus/ hover border getting clipped, instead we can use `android:clipToPadding` with a small non-zero padding to clip children and allow drawing a border outside the bounds

Change-Id: I7e763f7ee8c7fd1090c7778c2c000d2b792bef06
2023-11-21 10:48:08 +00:00
Saumya Prakash 15bbd17775 Merge "Update Gesture nav edu animations for overview gesture" into main 2023-11-20 18:07:23 +00:00
Pat Manning c5b7cf9e4e Add background to app chip menu so elevation shadow renders.
Fix: 312146447
Flag: ACONFIG com.android.launcher3.enable_overview_icon_menu TEAMFOOD
Test: OverviewImageTest.
Change-Id: I43113acd0eaafac2955cd4bbebafc103bdba6d98
2023-11-20 15:15:54 +00:00
Jagrut Desai a2825e011c Merge "New Meta Action Icon for Taskbar" into main 2023-11-17 17:59:45 +00:00
Pat Manning d3f3308d12 Merge "Update Icon App Chip Menu to new specs." into main 2023-11-17 15:06:42 +00:00
Pat Manning 43c4b50c17 Update Icon App Chip Menu to new specs.
Fix: 304228083
Test: TaplOverviewIconAppChipMenuTest
Flag: ACONFIG com.android.launcher3.enable_overview_icon_menu DEVELOPMENT

Change-Id: Ib018c7f59e1141b6f21618b28d411facc937ac7c
2023-11-16 18:18:48 +00:00
Jagrut Desai deb22d9e78 New Meta Action Icon for Taskbar
Test: Presubmit, Manual
Bug: 310942087
Flag: LEGACY ENABLE_ALL_APPS_SEARCH_IN_TASKBAR ENABLED
Change-Id: Ia1783a1afa92181efded4cfdbd5e7ae3d4e081e8
2023-11-16 08:33:03 -08:00
Bill Yi 66e843c8d0 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I2bf597eaf2c3fc4abb5b701974cc95b1e1d2ec6d
2023-11-14 19:31:01 -08:00
Saumya Prakash 4ee354f20a Update Gesture nav edu animations for overview gesture
Change the lottie files used to demonstrate the overview gesture for
mobile, foldable, and tablet.

Test: Went through overview gesture tutorial on mobile, foldable, and
tablet and ensured the animation played smoothly.
Fix: 283765711
Flag: N/A

Change-Id: I567eece9348d4c88b6f02fd267416ae155bcaf86
2023-11-14 19:04:36 +00:00
Uwais Ashraf 6dfa8521e5 Merge "Revert "Refactor/clean up Overview Actions buttons"" into main 2023-11-14 10:25:11 +00:00
Uwais Ashraf 60a2d85b68 Revert "Refactor/clean up Overview Actions buttons"
Revert submission 25292769-cleanup-action-buttons

Reason for revert: Causes a 100% failure of OverviewImageTest

Reverted changes: /q/submissionid:25292769-cleanup-action-buttons

Change-Id: Iedd51290e2d6fb7efafc814f1d3d51863b3d3ab7
2023-11-14 09:45:55 +00:00
Jeremy Sim ed56be4fbc Merge "Refactor/clean up Overview Actions buttons" into main 2023-11-13 22:20:47 +00:00
Vinit Nayak a20e964cbd Merge "Prevent widgets from entering split" into main 2023-11-13 06:06:41 +00:00
Jagrut Desai 56c85bbbc1 Merge "Fix RTL issue with TaskbarDividerPopupMenu" into main 2023-11-11 16:25:45 +00:00
Vinit Nayak 1d3035e024 Prevent widgets from entering split
Bug: 296502210
Test: Manual
Flag: ACONFIG com.android.wm.shell.enable_split_contextual DEVELOPMENT
Change-Id: I1a166f6ca0fe5fd2fa1d29b97b8856e52985e0c1
2023-11-10 12:17:12 -08:00
Jagrut Desai dc165fcf90 Fix RTL issue with TaskbarDividerPopupMenu
Test: Presubmit, Manual
Bug: 310217447
Flag: LEGACY ENABLE_TASKBAR_PINNING TEAMFOOD
Change-Id: I00a9088274ee6716250da7f6c79caf6820955803
2023-11-10 09:50:25 -08:00
Bill Yi 4dec607fec Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Idf14fea5b132a4871252134e07263e7dd51feccd
2023-11-09 16:38:08 -08:00
Jeremy Sim 7030216f48 Refactor/clean up Overview Actions buttons
Since the number of Overview actions is growing, this patch factors out the button hiding logic so it's not all handled in OverviewActionsView.

Also, since splitscreen can now be carried out on Taskbar targets, the split button is no longer ever disabled (only hidden), so removed unused code for that.

Bug: 274835596
Test: Manual
Flag: NA
Change-Id: Icacdee6d0e6071ccb400dfc25a84572e7e9ce772
2023-11-08 13:43:19 -08:00
Jagrut Desai 61526a7413 Merge "Improvements to TaskbarDividerPopupView" into main 2023-11-03 02:02:28 +00:00
Jagrut Desai 9af2084a56 Improvements to TaskbarDividerPopupView
- Close Animation improvement for popup.
- Popup location changed to  16dp above the taskbar view.
- Support for disabled state when user is in 3-button mode. (design changes to come in separate cl)

Test: Manual
Bug: 265170176
Flag: LEGACY ENABLE_TASKBAR_PINNING DISABLED
Change-Id: I9c91e6eb2b29c85433ba1c3d34505f0519448a6f
2023-11-02 17:24:50 -07:00
Jagrut Desai c554d5fa46 Fix TaskbarDividerPopupMenu Switch Style
we recently added support for settings app style switches to Launcher. Use that style for TaskbarDividerPopupMenu Switch

Test: Manual
Bug: 308682758
Flag: LEGACY ENABLE_TASKBAR_PINNING DISABLED
Change-Id: If61a426e4051ebce67601055942667ed93928d15
2023-11-02 14:23:48 -07:00
Bill Yi bb8419b8f9 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I2e57af4db51bc722d5fe7560c92b371ab61cfcf9
2023-10-30 19:58:19 -07:00
Uwais Ashraf aa7fa886d6 Add margins to top and bottom when grid only overview enabled
Fix: 299100244
Test: OverviewImageTest and dump tests
Flag: ACONFIG com.android.launcher3.enable_grid_only_overview TEAMFOOD
Change-Id: I22ebced5bf1e27974036d6e2ef72d2b8d63df824
2023-10-24 16:15:39 +00:00