Commit Graph

73373 Commits

Author SHA1 Message Date
Vadim Tryshev 83d42f71ca Merge "Waiting for Launcher stop from quick switch gesture" into main 2023-12-18 18:04:49 +00:00
Vadim Tryshev b083ace4ad Merge "Waiting for Fallback Overview to stop after pressing Home" into main 2023-12-18 18:04:33 +00:00
Federico Baron a06a171874 Merge "Remove unused flag UNFOLDED_WIDGET_PICKER" into main 2023-12-18 17:57:21 +00:00
Treehugger Robot afdac4066d Merge "Removing myself from owners" into main 2023-12-18 17:38:23 +00:00
Greg Kaiser 486c96be87 Merge "Revert "App Pairs: Implement Overview Actions View button"" into main 2023-12-18 15:15:59 +00:00
Greg Kaiser 45ba84268c Revert "App Pairs: Implement Overview Actions View button"
Revert submission 25143701-app-pairs-action-button

Reason for revert: Causes P0 b/315292030

Reverted changes: /q/submissionid:25143701-app-pairs-action-button

Change-Id: I1fcbb9f333ca29c5db255232dc9475dec465ac81
2023-12-18 14:53:19 +00:00
Liran Binyamin ca516b0249 Merge "Make BubbleBarView initially hidden" into main 2023-12-18 14:23:57 +00:00
Thales Lima c66ebc2c5c Removing myself from owners
Change-Id: I2cbf1c5b428d7f22263dc68da7648fdf8cdad616
2023-12-18 14:15:34 +00:00
Jeremy Sim 789414190f Merge "App Pairs: Implement Overview Actions View button" into main 2023-12-18 05:07:36 +00:00
Vadim Tryshev e281a5fb7e Merge "Disabling a failing test from presubmit" into main 2023-12-18 03:02:43 +00:00
Jeremy Sim e1fcb5390b App Pairs: Implement Overview Actions View button
[App Pairs 6/?]

This patch includes:
- Ability to "save app pair" from Overview Actions
- The actions bar is not longer hidden for GroupedTasks; instead the individual buttons for "Select", "Screenshot", and "Split screen" are toggled off and "Save app pair" is toggled on.

Note: This patch introduces a slight regression (b/315545418) where users are now able to long-press to select text on task 1 of a paired GroupedTaskView (previously we did not let them select text on either task for consistency.) Will follow up with a fix -- see bug for details.

Flag: ACONFIG com.android.wm.shell.enable_app_pairs DEVELOPMENT
Bug: 315545418
Bug: 315292030
Test: Manual, all action buttons still work and "Save app pair" appears and disappears correctly
Change-Id: I0eb1fa9520ba14074ede3480e771b340cf2f6e2c
2023-12-18 02:25:22 +00:00
Vadim Tryshev de1e88da74 Waiting for Fallback Overview to stop after pressing Home
Bug: 313926097
Flag: N/A
Test: presubmit
Change-Id: I1128ca6eabe29e02d8039445696f7a006f6448bf
2023-12-17 15:45:51 -08:00
William Leshner c43435c063 Merge "Handle widget taps in WidgetPickerActivity." into main 2023-12-15 23:20:23 +00:00
fbaron e03af75df4 Remove unused flag UNFOLDED_WIDGET_PICKER
this flag was made long before we actually implemented unfolded two pane picker and by that point we migrated to using aconfig so this flag is not used.

Bug: 301918659
Flag: NONE
Test: NONE
Change-Id: Ibc541826d85ae251337567ae0275e1cd02c7bb43
2023-12-15 14:46:39 -08:00
Vadim Tryshev 149dc53f85 Waiting for Launcher stop from quick switch gesture
Bug: 313926097
Flag: N/A
Test: presubmit
Change-Id: I31ae3af36b71c73ed4750b92ccc3704df9714ea6
2023-12-15 13:57:38 -08:00
Federico Baron ff2eec89ea Merge "Stop interrupt to see if it fixes failing tests" into main 2023-12-15 21:26:54 +00:00
Liran Binyamin 447ddf0b63 Make BubbleBarView initially hidden
The BubbleBarView visibility is updated as part of the initial state change.
This CL fixes the issue where switching from floating bubbles to bubble bar
ends up in a state where both the handle and the bar are visible.

Note: once the initial TAPL tests land I will add a test for mode switching

Flag: LEGACY persist.wm.debug.bubble_bar DISABLED
Fixes: 316356971
Test: Manual
      - Add bubble in floating mode
      - Switch to bubble bar
      - Observe that the bubble bar is not visible (only the handle is)
Change-Id: Ib8fc76f90dbf1fee83e594b7f28eed00f1589ae1
2023-12-15 15:49:37 -05:00
fbaron e392955e37 Stop interrupt to see if it fixes failing tests
Bug: 316394228
Test: atest WidgetsListContentEntryTest
Flag: NONE
Change-Id: Iaabbcb0c00040f78ad4d6355fef9bc91f4b66ed7
2023-12-15 11:30:58 -08:00
Bill Yi 50c0b9a20c [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: e70a1cae2e -s ours am: 18372d32bd -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/25648470

Change-Id: I531b1e0aa89d6064ad144b19578ea6a5962c3387
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-12-15 19:23:48 +00:00
Winson Chung de778ab5b8 Merge "Workaround for handling single device specific state in dump tests" into main 2023-12-15 19:22:00 +00:00
Bill Yi 18372d32bd [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: e70a1cae2e -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/25648470

Change-Id: Ic56c87d388555ac9080bc6f5e78408fda68a41e5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-12-15 18:53:14 +00:00
Vadim Tryshev 971358567d Disabling a failing test from presubmit
Bug: 316588649
Test: presubmit
Flag: N/A
Change-Id: I98487a4786fdab7f0ee5b10d59fc8df0e621b4f0
2023-12-15 10:33:09 -08:00
Vadim Tryshev ae625f3d6a Merge "Converting more pressBack calls to calls that wait for animation" into main 2023-12-15 18:07:20 +00:00
Vadim Tryshev b33f831e79 Merge "Waiting for Launcher stop when starting a task from keyboard quick switch" into main 2023-12-15 18:05:01 +00:00
Vadim Tryshev 56a5898331 Merge "Waiting for Fallback Overview to stop after pressing Home" into main 2023-12-15 18:04:55 +00:00
Helen Cheuk 9c0f738cdb Merge "Add focus outline to launcher" into main 2023-12-15 18:03:36 +00:00
helencheuk b4626f4698 Add focus outline to launcher
Fix: 310953377
Test: TBC
Flag: ACONFIG com.android.launcher3.enable_focus_outline Development
Change-Id: Ie395ec74c8a4a13a68539ca7ec6496481d96b860
2023-12-15 16:56:31 +00:00
Jeremy Sim 8379c985f0 Merge "Fixes crash when launching app pairs with intent+intent" into main 2023-12-15 09:50:00 +00:00
Jeremy Sim 9330619ee0 Fixes crash when launching app pairs with intent+intent
This CL adds a new case for app pair launches. When we launch app pairs with intents, we receive initialTaskId and secondTaskId as -1, which was previously unhandled and caused a crash. With this change, we find the left/top app leash a different way, by looking for windowingMode=WINDOWING_MODE_MULTI_WINDOW and endAbsBounds.left/top == 0.

Fixes: 316050315
Test: Clear all running tasks from Overview, launch app pair, no longer crashes
Flag: ACONFIG com.android.wm.shell.enable_app_pairs DEVELOPMENT
Change-Id: Ic356d71ad267f079242213ebc59322bf1fb86b7c
2023-12-15 17:17:24 +09:00
Winson Chung 734c6f3974 Workaround for handling single device specific state in dump tests
- There's a DeviceProfile state that is dynamic on a specific device
  class (based on a fw resource), this causes problems with the dump
  tests which compare the device profile against static prior dumps.
  For now, we can just update the expected dump based on the state
  of the resource to ensure that the current device profile state on
  this device matches.  To do this, we also need to consolidate the
  various duplicate methods to assert the current and golden dumps
  match to have a common place to adjust the expected dump.

Bug: 315230497
Test: atest DeviceProfileDumpTest
Test: atest DeviceProfileAlternativeDisplaysDumpTest
Change-Id: I5130d330878757702af07e166a669cc76452b271
2023-12-15 05:10:04 +00:00
Tracy Zhou 3e3ee0b190 Merge "Fix crash from folding/unfolding" into main 2023-12-15 03:49:38 +00:00
Tracy Zhou 95c4c8d268 Fix crash from folding/unfolding
This is fundamentally caused by the phone device profile not having task bar related attributes, which crashes in icon alignment animation. We had resolved it by skipping this animation based on isPhoneMode check. However, we passed in launcherDp instead of taskbarDp (from TaskbarActivityContext) which doesn't always have the most up to date information in race conditions (e.g. repetitively fold/unfold)

Fixes: 311431054
Test: repetively fold/unfold, make sure it doesn't crash
Change-Id: I65f600112da4123d337b3f59a2fe6dd13ac7af74
2023-12-14 18:39:42 -08:00
Bill Yi f431ab4db7 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2023-12-15 00:13:22 +00:00
Bill Yi 51b2982acc Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2023-12-15 00:13:22 +00:00
Catherine Liang 7e3721692c Merge "Fix Launcher preview display size" into main 2023-12-14 21:33:25 +00:00
Vadim Tryshev df14dad927 Waiting for Launcher stop when starting a task from keyboard quick switch
This will help to ensure that Launcher state has settled before continuing the test.

Bug: 313926097
Flag: N/A
Test: presubmit
Change-Id: I4ba5dd2eaa8cf2fbfe21f2cafd9835ef42b19341
2023-12-14 12:33:35 -08:00
Anushree Ganjam 493ee68819 Merge "[Refactor] Use constants from Cuj.java instead of InteractionJankMonitorWrapper." into main 2023-12-14 19:14:28 +00:00
Catherine Liang b0de412e47 Fix Launcher preview display size
When previewing the Launcher in the Wallpaper Picker for a different
display size than the current screen, the preview no longer adapts to
that screen size.

Flag: ACONFIG com.android.wallpaper.multi_crop_preview_ui_flag DEVELOPMENT
Bug: 316000567
Test: manually verified
Change-Id: Ib10f2c9acec98ed99cadd40a588e2ffdea900ba6
2023-12-14 19:08:39 +00:00
Fengjiang Li e228112c33 Merge "Cancel all apps icons preinflation when device profile has changed" into main 2023-12-14 18:16:30 +00:00
Sebastián Franco d93bb98e02 Merge "Remove ENABLE_NO_LONG_PRESS_DRAG flag." into main 2023-12-14 17:20:45 +00:00
Fengjiang Li b7a5eb9ef4 Merge "Remove duplicated widget host view reinflation on screen rotation" into main 2023-12-14 07:02:17 +00:00
Charlie Anderson 97eedb9570 Merge "fix font-scaling from clipping folder child icons" into main 2023-12-14 03:30:55 +00:00
Tony Wickham 2c00a542c2 Merge "Fix layering issue when launching from side TaskView" into main 2023-12-14 01:05:01 +00:00
Anushree Ganjam b8a71816e1 [Refactor] Use constants from Cuj.java instead of InteractionJankMonitorWrapper.
Bug: 303105164
Test: Manual
Flag: NA
Change-Id: I05a36fc0421502cd472dd79035b73a69d05592d2
2023-12-13 16:43:16 -08:00
Fengjiang Li 939ca48bae Cancel all apps icons preinflation when device profile has changed
Bug: 312816372
Test: perinflate large number of App Icons then rotate screen. Verified 1) preinflation runnable is cancelled and 2) no ViewHolder created from this cancelled runnable is added to RecyclerViewPool
Flag: LEGACY ENABLE_ALL_APPS_RV_PREINFLATION ENABLED
Change-Id: I1a6110278e1af2b32387ab27273106d30513886f
2023-12-13 15:31:30 -08:00
Bill Yi 7c68b61e09 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Idd965f2d99f1a2d07b0844424d6d300a2302d8d4
2023-12-13 15:11:53 -08:00
Bill Yi e70a1cae2e Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Ic9fd0692331857c52c909e8c7abbe9b015a96bda
2023-12-13 15:10:54 -08:00
Bill Yi 7a65495bef Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Ic31a5d47d4eb0cc6d6d08ef09e4289eca31ae180
2023-12-13 15:10:28 -08:00
Anushree Ganjam 8a401e8817 Merge "Fix the server side flag name for LPNH_HAPTIC_HINT_DELAY" into main 2023-12-13 22:57:59 +00:00
Vadim Tryshev fb3ae6a6c4 Converting more pressBack calls to calls that wait for animation
Bug: 313926097
Flag: N/A
Test: presubmit
Change-Id: Ib4e08b4778a24ac617ea1e0101147612b0f53967
2023-12-13 13:07:46 -08:00