Commit Graph

75901 Commits

Author SHA1 Message Date
Sihua Ma 8128575f46 Merge "Move cell layout tests to deviceless tests" into main 2024-05-08 16:50:44 +00:00
Orhan Uysal 906df388ef Merge "Add quick switch flag for desktop windowing cases." into main 2024-05-08 11:17:56 +00:00
Anna Zhuravleva 9f3bca37e6 Merge "Log animation jank" into main 2024-05-08 08:22:57 +00:00
Andy Wickham 48d3d47c1f Merge "Use ValueAnimator instead of property setter" into main 2024-05-08 01:25:13 +00:00
Sihua Ma 1593bb4af2 Move cell layout tests to deviceless tests
Excluding Tapl tests

Also adding Launcher3 test assets to Launcher3TestResources

Bug: 297950111
Flag: None
Test: atest Launcher3RoboTests
Test: atest NexusLauncherRoboTests
Test: SysUI studio
Change-Id: I101fc7229252016ec7e5015ed5f6a5b4dbba894d
2024-05-08 00:52:43 +00:00
Andy Wickham 2ce2b5ea03 [automerger skipped] Merge "Implement animateNavBarLongPress for stashed taskbar." into 24D1-dev am: 8b75bde581 -s ours
am skip reason: Merged-In I6ecbc849ac1c066a4c018325f0237a61641d99aa with SHA-1 3a7a76f88e is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/27235887

Change-Id: I80d339e8e21cd5fd9655c08387b93c53cc979cd4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-07 22:24:51 +00:00
Andy Wickham 52a38761cc [automerger skipped] Implement animateNavBarLongPress for stashed taskbar. am: 1b6a08abd6 -s ours
am skip reason: Merged-In I6ecbc849ac1c066a4c018325f0237a61641d99aa with SHA-1 3a7a76f88e is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/27235887

Change-Id: I3646a2ce719314c0308637d61bb6a1319196cac6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-07 22:24:48 +00:00
Andy Wickham 8b75bde581 Merge "Implement animateNavBarLongPress for stashed taskbar." into 24D1-dev 2024-05-07 22:07:51 +00:00
Sunny Goyal 85fe0d96cf Merge "Fixing LauncherIcons leaking outside sandbox context" into main 2024-05-07 21:42:59 +00:00
Holly Jiuyu Sun 8834a6c450 Merge "[PS] Update Install button string." into main 2024-05-07 21:35:02 +00:00
Anushree Ganjam 0a5241519d Merge "Add dump for PredictionRowView." into 24D1-dev am: 03d13287d8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/27212127

Change-Id: I46ed1e62c54944f5c916b56f9e66a3f874ac8cef
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-07 20:42:55 +00:00
Anushree Ganjam 03d13287d8 Merge "Add dump for PredictionRowView." into 24D1-dev 2024-05-07 20:28:04 +00:00
Sunny Goyal bf3efe8af0 Fixing LauncherIcons leaking outside sandbox context
Since LauncherIcons was using a global static pool, a custom
instance for a test could leak into the global pool, affecting
other tests

Bug: 335280439
Test: Verified image test on device
Flag: None
Change-Id: Iedd19c8e69c928e44b65eae7eba0167b03b5df6b
2024-05-07 12:13:37 -07:00
Anushree Ganjam 405817f5f8 Merge "Remove Verify getProfileUser calls since it's making test flaky." into main 2024-05-07 18:19:57 +00:00
Vinit Nayak 99f11290e3 Merge "Determine split leash position by taskId instead of bounds" into 24D1-dev am: eaf9f083dc
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/27212613

Change-Id: If9e5ff14a29f04a01bd7213572c607999b40ea79
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-07 18:15:41 +00:00
Vinit Nayak cc7107d82e Merge "Disable gestures when split apps are animating in from shell" into main 2024-05-07 18:12:00 +00:00
Shamali Patwa b257ac4289 Merge "Fix close animation issue during predictive back / swipe up" into main 2024-05-07 18:07:28 +00:00
Ats Jenk 31e9455718 Merge "Use translation to move bubble bar during bubble drag" into main 2024-05-07 18:04:31 +00:00
Vinit Nayak eaf9f083dc Merge "Determine split leash position by taskId instead of bounds" into 24D1-dev 2024-05-07 18:02:44 +00:00
Brandon Dayauon c2ce6254c3 Use ValueAnimator instead of property setter
Referencing the view by ID animates correctly. Passed in views are supposedly not the same
and therefore, not animating the correct thing. (fixes on the device that can repro issue).

Bug:339179262
Bug:299294792
Test manually verified on device that can repro:https://drive.google.com/file/d/16L4wEroGEDsp_BIkmoARg9vR43upF6_8/view?usp=sharing
Flag: aconfig com.android.launcher3.enable_private_space nextfood

Change-Id: I20b06cc50928c35afa3dc1e8800b3a5bff0769be
2024-05-07 10:30:18 -07:00
Tracy Zhou ef8872bb01 Merge "Update SUW swipe home logic for taskbar stashing" into 24D1-dev am: 63da44e7eb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/27239028

Change-Id: I422db33acd92b6c87ba65a6c96a146fd1d2be8e4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-07 15:53:30 +00:00
Tracy Zhou 63da44e7eb Merge "Update SUW swipe home logic for taskbar stashing" into 24D1-dev 2024-05-07 15:33:00 +00:00
Treehugger Robot 22283fd1b8 Merge "Use TaskContainer as source of truth around Task handling" into main 2024-05-07 15:00:24 +00:00
Schneider Victor-tulias c6c8a22daf Merge "Add debug logs for b/319168409" into main 2024-05-07 13:56:56 +00:00
Shamali P ac5c6c775b Fix close animation issue during predictive back / swipe up
Bug: 333714698
Test: Manual
Flag: N/A
Change-Id: I07859bc0a3783356cc27358bb23a0d6555aa1492
2024-05-07 13:47:24 +00:00
Liran Binyamin 8f266507fd Merge "Animate the bubble bar for the first bubble" into main 2024-05-07 13:08:21 +00:00
Orhan Uysal d3f3200c5f Add quick switch flag for desktop windowing cases.
Add quick switch flag to desktop windowing cases. Quick switch should
work out of the box for desktop windowing when the flag is enabled.

Bug: 322759294
Bug: 322759294
Test: Manually enable/disable the flag
Flag: ACONFIG com.android.window.flags.enable_desktop_windowing_quick_switch DEVELOPMENT

Change-Id: Ifb531368552449f70ce9d883418d26c7f272c6e9
2024-05-07 12:38:05 +00:00
Alex Chau 5b15bfe20b Use TaskContainer as source of truth around Task handling
- Renamed TaskIdAttributeContainer into TaskContainer so it's shorter
- Make mTaskContainers the source of truth for Task handling, removing mTask, mSecondaryTask, mTaskIdContainer and use mTaskContainers to derive all related information
- Remove mTasks/mSnapshotViewMap in DesktopTaskView and replace with mTaskContainers
- Mark methods that assumes a single Task as deprecated e.g. getTask, getItemInfo, getThumbnail to discourage further usage of such methods; "First" is added to the method name to make it explicit only first Task is considered; getTaskContainers is encouraged to access such information

Bug: 249371338
Test: Manual
Flag: None
Change-Id: Ieb15e0e8432913c89dc46c1011f0148095c665f8
2024-05-07 11:51:26 +01:00
Himanshu Gupta 8b0d1fb614 Merge "Adding Tapl test for locking/unlocking Private Space" into main 2024-05-07 09:57:59 +00:00
Alex Chau 6526706721 Merge "Remove TaskView.isDesktopTask" into main 2024-05-07 08:26:21 +00:00
Holly Sun 64f36f3679 [PS] Update Install button string.
Screenshot: https://screenshot.googleplex.com/B6UrJt92QMMgSuG

Bug: 338357091
Test: manual
Flag: aconfig com.android.launcher3.private_space_app_installer_button nextfood
Change-Id: Ia408ccfa20ea3c142bd22c326954d278fa571815
2024-05-06 20:35:01 -07:00
Andy Wickham 96adbcb2a8 Merge "Remove unused AssistStateManager methods." into main 2024-05-07 01:43:46 +00:00
Tracy Zhou afe3701c74 Merge "Fix 3-button showing up briefly on the AllSet page in setup" into 24D1-dev am: 2155a925fc
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/27237053

Change-Id: I96c0ce0c4909e3e8663f1616ed22791cb6e1a7e8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-07 01:38:44 +00:00
Tracy Zhou 2155a925fc Merge "Fix 3-button showing up briefly on the AllSet page in setup" into 24D1-dev 2024-05-07 01:26:01 +00:00
Willie Koomson c81ffaf821 Merge "Remove shadow on Add button" into main 2024-05-07 01:15:37 +00:00
Ats Jenk 5a03549797 Use translation to move bubble bar during bubble drag
Revert logic to set translation on each BubbleView and background.
Background translation was set with bounds offset and BubbleView was
using setTranslationX(). This made it hard to synchronise background and
child view translations. And led to flickers.

Applying translation on the BubbleBarView itself, but applying the
reverse of the translation to the dragged BubbleView. This ensures that
the dragged bubble position is not affected by the parent translation.

Introducing a new property for BubbleView that is used to apply
translation during drag. It takes into account the offset of the
BubbleBarView.

Bug: 330585402
Flag: ACONFIG com.android.wm.shell.enable_bubble_bar DEVELOPMENT
Test: drag bubble to other side and release before the bubble bar
  animation finishes, observe no flickers
Test: drag expanded view to other side and release before the bar
  animation finishes, observe no flickers
Change-Id: I1712ed6ac26831f10466dbaf0378f8aabb29629d
2024-05-06 17:39:29 -07:00
Liran Binyamin aa73f595cf Animate the bubble bar for the first bubble
This change animates the bubble bar for the first bubble.
When we're in home -- the bubble bar bounces in and stays visible
When we're in app -- the bubble bar bounces in, then animates to
the stashed handle.
When the bubble bar auto expands, we currently animate the bubble
bar already expanded. In the future we'll time the expansion
until after the bubble bar settles in.

Demo: http://recall/-/bJtug1HhvXkkeA4MQvIaiP/hIGwtb3YKyCT9Ke9adZNgY

Flag: ACONFIG com.android.wm.shell.enable_bubble_bar DEVELOPMENT
Bug: 339066271
Test: atest BubbleBarViewAnimatorTest
Change-Id: I80ce55676b72a50bab23623e0b5c1e602690682f
2024-05-06 20:17:28 -04:00
Andy Wickham 1b6a08abd6 Implement animateNavBarLongPress for stashed taskbar.
I think ideally we would tie this into the taskbar's outline
provider, but it seemed more complicated to deal with existing
stashing animations.

Instead I've just animated the stashed taskbar scale to 0.85 or
1.18, depending on the SHRINK_NAV_HANDLE_ON_PRESS flag. These
are based on the existing navbar shrink/expand animations.

Demo (the flickering doesn't happen on-device):
https://drive.google.com/file/d/1CWCPRsuD3kjtOUbwXspkQ_ZJ6Ln7FnUo/view?usp=sharing&resourcekey=0-kJjfgnuEca1de4u8mbHrig

Bug: 308693847
Test: Manual
Flag: LEGACY SHRINK_NAV_HANDLE_ON_PRESS DISABLED
Flag: LEGACY ANIMATE_LPNH DISABLED
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:3a7a76f88e51453cc4b70fa68aef2724cccc02c6)
Merged-In: I6ecbc849ac1c066a4c018325f0237a61641d99aa
Change-Id: I6ecbc849ac1c066a4c018325f0237a61641d99aa
2024-05-06 23:46:21 +00:00
Andy Wickham 17526db32a Merge "Implement animateNavBarLongPress for stashed taskbar." into main 2024-05-06 23:12:32 +00:00
Treehugger Robot 8ba31bedb3 Merge "Fix null pointer in FloatingWidgetView" into 24D1-dev am: c5fec774b2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/27238353

Change-Id: I95c1eca1587c91e3406d4e50764a7c8fc26e125c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-06 23:10:58 +00:00
Treehugger Robot c5fec774b2 Merge "Fix null pointer in FloatingWidgetView" into 24D1-dev 2024-05-06 22:55:57 +00:00
Shamali Patwa 4f8ef8f54b Merge "Readjust the available size for the recommendations in 2-pane sheet" into main 2024-05-06 22:53:19 +00:00
Tracy Zhou 6d3a1d8f50 Update SUW swipe home logic for taskbar stashing
- Reverted the previous change. It doesn't fix the issue when launching setup mode with command line. The fact that it looked as if it's fixed from factory reset might be a fluke
- Found out that we unstash the task bar to home from setup somewhere in TaskbarStashController. This is related to stashed alpha only.

Fixes: 337738795
Test: Finish setup, swipe home in folded, and observe home handle is visible.
Change-Id: I04daf41ae9a1c3b7e6e4962dd4a8c62b708e0a54
(cherry picked from commit b297d4fb83)
2024-05-06 22:34:36 +00:00
Tracy Zhou 052b4c924f Merge "Update SUW swipe home logic for taskbar stashing" into main 2024-05-06 22:34:24 +00:00
Willie Koomson 49e364cd0b Remove shadow on Add button
Set android:stateListAnimator to @null to remove default shadow on Add
button.

Bug: 333736273
Test: manual, check shadow on device
Flag: ACONFIG com.android.launcher3.enable_widget_tap_to_add NEXTFOOD
Change-Id: Ifa66801963e69582935806eb8a39dcfe624ffdc7
2024-05-06 22:26:24 +00:00
Tony Wickham bc549958d9 [automerger skipped] Merge "Remove obsolete binder calls to TaskTransitionSpec" into 24D1-dev am: 4f54ccebb5 -s ours
am skip reason: Merged-In Ie20dc8d4bb0c85a8a256b001fbb92405679618a8 with SHA-1 a179a77e09 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/27214071

Change-Id: I6525e3bb8ccfc6bd0823e9813675a0014a03615b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-06 21:29:32 +00:00
Tony Wickham 7b4ac19a7d [automerger skipped] Remove obsolete binder calls to TaskTransitionSpec am: 35b08fe4b2 -s ours
am skip reason: Merged-In Ie20dc8d4bb0c85a8a256b001fbb92405679618a8 with SHA-1 a179a77e09 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/27214071

Change-Id: Ia168669b664ae781fb8091bf246dfb7c16b4f34e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-06 21:29:28 +00:00
Tony Wickham 4f54ccebb5 Merge "Remove obsolete binder calls to TaskTransitionSpec" into 24D1-dev 2024-05-06 21:09:27 +00:00
fbaron 7435831cbd Fix null pointer in FloatingWidgetView
Flag: NONE
Test: NONE
Bug: 331868669
Change-Id: I350e6660ea1936bb9ee799c3d2c840c57876fef4
(cherry picked from commit c0c0bdbc38)
2024-05-06 20:58:14 +00:00
Sunny Goyal 499b9d067f Merge "Creating a custom runner for multivalent tests with Launcher specific features" into main 2024-05-06 20:55:00 +00:00