Commit Graph

22927 Commits

Author SHA1 Message Date
Winson Chung 80da0bdce1 Merging ub-launcher3-qt-r1-dev, build 5749827 am: 3fc9a1cf69
am: 33e8612e8c

Change-Id: I075b9d5647a9263696fd0ba03111c7ec2297c924
2019-07-24 12:38:15 -07:00
Winson Chung 33e8612e8c Merging ub-launcher3-qt-r1-dev, build 5749827
am: 3fc9a1cf69

Change-Id: Id05a484ba74b5ef29c22992e7997eabf3c523011
2019-07-24 12:27:16 -07:00
Winson Chung 3fc9a1cf69 Merging ub-launcher3-qt-r1-dev, build 5749827
Test: Manual

Bug:136282913 P1 Swipe up from Assistant Fulfillment Card Jank
Bug:137129923 P1 Pixel launcher is leaking memory
Bug:137161198 P1 Unable to pull notification panel down with a swipe on home screen
Bug:137253043 P1 "Pixel Launcher keeps stopping" when scrolling through recent apps
Bug:137487381 P1 Overview goes back to fullscreen when swiping up during transition
Bug:137836033 P4 Fail to stop music due to "Swipe failed to receive an event for the swipe end"
Bug:138152531 P2 [Android Q][04713598] Launcher test cases are failed
Bug:138236583 P1 Icon scale is wrong when dragging from all apps or folders
Bug:138251824 P1 Flake: want to switch from background to overview; Swipe failed to receive an event for the swipe end
Bug:138252347 P1 qt-r1-dev Pixel Launcher flag ENABLE_HINTS_IN_OVERVIEW is Disable by Default
Change-Id: Idd0e987d26e1ffc75cdb9f90e9c08c26bb8c6503
2019-07-23 20:54:13 -07:00
Vadim Tryshev 7b0520afe4 Merge "Checking Launcher internal integrity from tests" into ub-launcher3-qt-r1-dev 2019-07-24 01:30:06 +00:00
vadimt 0dd1c782f0 Checking Launcher internal integrity from tests
In particular, we check that the stable Launcher state equals its
current state. This can help detect Launcher being in a corrupted state
as in b/133867119.

The check gets called by tests when the Launcher is not transitioning
from state to state.

Bug: 137307838
Change-Id: I3d36edff35e42d14be6b9a52351bd6f709be75e8
2019-07-23 18:07:25 -07:00
Anna Wasewicz 064cba4560 Changing ENABLE_HINTS_IN_OVERVIEW flag to be true in qt-r1-dev. It
should be false in qt-dev and true in qt-r1-dev.

Bug: 138252347
Change-Id: If9de47ef937ecb3da9c8d43eea8ad4b6e6885582
2019-07-23 17:34:34 -07:00
Winson Chung 0727d59576 Merge "Fix regression in assistant window handling" into ub-launcher3-qt-r1-dev 2019-07-24 00:12:28 +00:00
Tony Wickham b2e6a77b0d Merge "Set FastBitmapDrawable scale=1 before drawing it in DragView" into ub-launcher3-qt-r1-dev 2019-07-24 00:07:18 +00:00
TreeHugger Robot 8578309f1b Merge "Adding debug tracing" into ub-launcher3-qt-r1-dev 2019-07-24 00:01:25 +00:00
vadimt cd7b00853b Adding debug tracing
Bug: 138251824
Change-Id: Ibe3de964aeacbf83fd46cc53fda7d15c9401fe4d
2019-07-23 16:49:48 -07:00
Winson Chung 48ba8c864c Fix regression in assistant window handling
- Skip the assistant as the running task when handling swipe up
- Also ensure that we fall into the overview input consumer if we are
  swiping it from the assistant over home
- Skip accounting for the scroll offset when there is no running task

Bug: 136282913
Change-Id: I28e45e407702d6d6aebaa0232cd96ccb10047644
2019-07-23 16:25:46 -07:00
Vadim Tryshev 068f4bde88 Merge "TAPL: adding 1 to gesture margins to avoid accidentally triggering back" into ub-launcher3-qt-r1-dev 2019-07-23 23:17:08 +00:00
Zak Cohen 87477f5996 Merge "TaskView - add a getter for the bitmap data." into ub-launcher3-qt-r1-dev 2019-07-23 22:51:28 +00:00
vadimt a505381980 TAPL: adding 1 to gesture margins to avoid accidentally triggering back
Change-Id: I7152d60dffc2085313dc1466693b599e4efe0394
2019-07-23 15:48:02 -07:00
vadimt 34828b1942 Improving "Add automatically" recognition
Bug: 138152531
Change-Id: I204233f06a80d2d17b24dd9622c7a2152b1303a0
2019-07-23 13:54:05 -07:00
Tony Wickham d418f3c3fa Set FastBitmapDrawable scale=1 before drawing it in DragView
When we draw the icon to the DragView, we draw it
with the current scale, which is > 1 when animating
the icon down. Instead, we should always draw the
icon with scale 1 since the DragView itself is scaled.

Bug: 138236583
Change-Id: I6bca5cf28c54d58476240e0e68900a8f08ffe60b
2019-07-23 13:48:08 -07:00
vadimt 44515f42c0 Allowing both normal-case and uppercase versions of widget prompt
The prompt is "Add automatically"

Bug: 138152531
Change-Id: I5f1a15563e1e11768579711108a28070b72b4454
2019-07-23 12:41:13 -07:00
Vadim Tryshev 2f0fdd6a7f Merge "Logging start and end of linear gesture" into ub-launcher3-qt-r1-dev 2019-07-23 19:26:54 +00:00
vadimt 20aa2e4f51 Logging start and end of linear gesture
Change-Id: Ie0756c89e3871b3f4e12849ef52c44f84a5ceeee
2019-07-22 16:54:29 -07:00
Tony Wickham b6841ac630 Revert the changes that prevented touch on RecentsView during animation
The original bug that was solving seems to be fixed by other changes,
and this allows users to scroll, dismiss, etc on recent tasks before
fully reaching overview from an app.

Bug: 137487381
Change-Id: I28a708811bba3ce739ce261f19eb29558d8f0e7d
2019-07-22 12:39:59 -07:00
Winson Chung a3ed013179 Merging ub-launcher3-qt-r1-dev, build 5736932
am: 5841e40a95

Change-Id: Icd0e789912b0198e884a9c1cd222a134a380cf67
2019-07-20 08:46:34 -07:00
Tony Wickham 3fca6aaec2 Finish recents animation when touching during animation to recents
This regressed in ag/8542000, where we cancel the animation instead of
ending it. We should only cancel when going to home; in other cases, we
should still call end().

Bug: 137487381
Change-Id: I093954908c3ac747ec3132aa700c8be2f927631a
2019-07-19 16:53:00 -07:00
Zak Cohen bc4d213535 TaskView - add a getter for the bitmap data.
This allows other components to get it directly from the view, rather
than retaining their own copy.

Bug: 137129923
Tested: Manual

Change-Id: Ibab307517c31cd3cb59b4d77ff390fd97546e86d
2019-07-19 15:14:53 -07:00
Vadim Tryshev 3ab3c768f5 Merge "Logging original exception in PortraitLandscapeRunner" into ub-launcher3-qt-r1-dev 2019-07-19 19:25:46 +00:00
vadimt 21cd128141 Logging original exception in PortraitLandscapeRunner
Change-Id: I672e563df45f1f0dcdda5b1f863919f0150e73e6
2019-07-19 12:12:49 -07:00
Vadim Tryshev a7b3de9e45 Merge "Improving system health diags" into ub-launcher3-qt-r1-dev 2019-07-19 17:59:14 +00:00
vadimt 76d2a6fcc3 Improving system health diags
Change-Id: I207c5b9c9ad9e99646419b7a4bd77b59a067f26d
2019-07-19 10:40:25 -07:00
vadimt c8d496fe00 Fix waiting for launcher initialization
Bug: 137836033

Change-Id: Ifc8ce867abd85eaeacd09a2b39636ecc4109c046
2019-07-18 18:31:49 -07:00
Hyunyoung Song b1b4562a46 Merge "Guard against NPE inside BaseIconFactory Bug: 137253043" into ub-launcher3-qt-r1-dev 2019-07-18 23:31:45 +00:00
Vadim Tryshev 4c557438bc Merge "Improving TAPL code around fallback recents" into ub-launcher3-qt-r1-dev 2019-07-18 22:31:30 +00:00
Tony Wickham 6670435c14 Merge "Allow TouchControllers to override shouldDisableGestures" into ub-launcher3-qt-r1-dev 2019-07-18 22:27:54 +00:00
vadimt c0a1b7046d Improving TAPL code around fallback recents
Change-Id: I9cd1caa2725f1d3967447130f4e34c4cf878514b
2019-07-18 15:12:24 -07:00
Tony Wickham f33b6d4378 Allow TouchControllers to override shouldDisableGestures
Currently only StatusBarTouchController overrides this to always return
false, so that you can swipe down for notifications during transition to
home screen from an app (in gesture nav).

Bug: 137161198
Change-Id: I803c37937d5294810cbe0c1bbffcd5dddcc5ca3b
2019-07-18 15:10:21 -07:00
Winson Chung 5841e40a95 Merging ub-launcher3-qt-r1-dev, build 5736932
Test: Manual

Bug:111935715 P2 Incorrect parent type when logging drag and drop from All Apps
Bug:131315856 P1 [PO restore] No work profile launcher shortcuts restore ~50% of the time
Bug:132900132 P1 Apparently, tests start running while provisioning is still in progress
Bug:133009122 P2 Rare flake: dragged launchable to workspace, but the current state is not WORKSPACE; Can't find a launcher object; selector: BySelector [RES='\Qcom.google.android.apps.nexuslauncher:id/apps_view\E']
Bug:133765434 P1 [Flaky test] Launching task didn't open a new window
Bug:133867119 P2 Lab-only flake: want to switch from workspace to all apps; Swipe failed to receive an event for the swipe end
Bug:133891845 P2 TAPL: need clearer diags when a crash dialog is over Launcher or there is lock screeen
Bug:134532571 P1 Launcher flake: java.lang.AssertionError: http://go/tapl : want to switch from background to overview, but the current state is not BASE_OVERVIEW; Can't find a launcher object; selector: BySelector [RES='\Qcom.google.android.apps.nexuslauncher:id/overview_panel\E']
Bug:135165284 P2 [Q-Preview4] Gestural navigation animation glitch on RTL
Bug:135567630 P1 testBackground crashes in Landscape
Bug:135636137 P1 Workspace is clipped at the top when transitioning from app -> home
Bug:135687618 P4 Task shows between back and swiping up to overview
Bug:135952890 P1 Drag up on home indicator does not track finger if recently entered split screen
Bug:136033787 P0 Vzw DoU: sendexchangeemail wifi test fails with failed dismissal exception
Bug:136215685 P1 Flake: swiping up from Home to Overview in 2-button mode sometimes fails
Bug:137197916 P1 Add gesture support for 3p Launcher
Bug:137215697 P2 FloatingIcon and workspace icon visible at the same time when touch input during app to close animation
Bug:137290162 P1 Overview suggest chip showing on apps due to misconfigured flag
Bug:137316430 P1 Jank when swiping quickly back down to home when overview is peeking
Bug:64712476 P3 Import translations for dev branches
Change-Id: Ib228c0f291884050904fa069e25519755071c40a
2019-07-18 11:36:39 -07:00
Jon Miranda 11b5535556 Skip TouchInteractionService preload if restore task is pending.
Otherwise the preload may cause launcher to restore too early, resulting
in data loss.

Bug: 131315856
Change-Id: I4412c8f691286ba142e9c748a908a3ed42713a82
2019-07-17 21:24:07 -07:00
Jon Miranda 49bc4241d9 Fix bug where icon is no present during app close animation. am: bc27826478
am: aca4f39f0e

Change-Id: Icb96aa94b13b5b468d4b3ff9bf4fbc9b7e625e9d
2019-07-17 20:25:42 -07:00
Jon Miranda 6383a5b89f Fix bug where icon is no present during app close animation. am: bc27826478
am: ea8fb85c75

Change-Id: I9c221088cec598b735fb5174ebfe266e5c4ffb79
2019-07-17 20:24:44 -07:00
Jon Miranda ea8fb85c75 Fix bug where icon is no present during app close animation.
am: bc27826478

Change-Id: I6db3c48ca4bda8c776885cf605835d7b3dbe9efb
2019-07-17 20:05:40 -07:00
Jon Miranda aca4f39f0e Fix bug where icon is no present during app close animation.
am: bc27826478

Change-Id: I2d3f7ebea67bdc7c08e06e5c6427d2a58ba5f14d
2019-07-17 20:04:38 -07:00
vadimt 04ca73b590 Fixing starting scrolls outside of view
Change-Id: I0237603d25edc60522c41a3d20615391d5b4f3b6
2019-07-17 18:55:53 -07:00
Hyunyoung Song ae86d22dfb Guard against NPE inside BaseIconFactory
Bug: 137253043

This is a bandage fix.

Ideally, we should really figure out why TaskIconCache will be sending
null icon drawable to BaseIconFactory.

Change-Id: Ie005006baeddc9a3379283fe7139e590daad9a57
2019-07-18 00:06:04 +00:00
TreeHugger Robot aaf6c7ce56 Merge "Using correct gesture margins in overview" into ub-launcher3-qt-r1-dev 2019-07-17 23:02:50 +00:00
vadimt 2f7d1fa4a8 Using correct gesture margins in overview
Change-Id: I0108858279559e10633825f7de22211515f0e9b7
2019-07-17 15:18:21 -07:00
Jon Miranda bc27826478 Fix bug where icon is no present during app close animation.
* WindowTransformSwipeHandler closes all AbstractFloatingViews, including
  ListenerView, which results in FloatingIconView getting removed.
* In IconLoadResult.onIconLoaded, we remove the check for isIconLoaded since
  its not needed. This was also causing a race condition since isIconLoaded
  is not set to true until after we tell onIconLoaded to run.
* In BaseDragLayer, we have a delay before checking if the view is open and
  then closing the floating view if true. This caused issues since we reycle
  the view. Now we check if the view is open before running the delay to call
  close.

Bug: 136044361
Change-Id: I7442a589a62c3cdf90b70d146e0ecf3e4300ddf7
(cherry picked from commit 826cdcd32f)
2019-07-17 22:16:40 +00:00
Android Build Merger (Role) 3c5c17f0ca Merge "Set the chips flag to false in QP1A. This flag should be off by default. Chips should not be running in QP1A. Bug:137290162 am: 31d0a9c562 am: e47e525026" into qt-r1-dev-plus-aosp 2019-07-17 22:05:59 +00:00
Anna Wasewicz 82f6f470b6 Set the chips flag to false in QP1A. This flag should be off by default. Chips should not be running in QP1A. Bug:137290162 am: 31d0a9c562
am: 711ed0aa49

Change-Id: I7cc7c076159014ca70a6734217bc9254acdf9652
2019-07-17 15:05:44 -07:00
Anna Wasewicz 4b03eb994f Set the chips flag to false in QP1A. This flag should be off by default. Chips should not be running in QP1A. Bug:137290162 am: 31d0a9c562
am: e47e525026

Change-Id: Iecda9104ac5cb2e6f88251c395463f790c12427b
2019-07-17 15:05:43 -07:00
Anna Wasewicz e47e525026 Set the chips flag to false in QP1A. This flag should be off by default. Chips should not be running in QP1A. Bug:137290162
am: 31d0a9c562

Change-Id: I2bee4ff3706448fe3ca39afed3bbf84beee67c52
2019-07-17 14:57:06 -07:00
Anna Wasewicz 711ed0aa49 Set the chips flag to false in QP1A. This flag should be off by default. Chips should not be running in QP1A. Bug:137290162
am: 31d0a9c562

Change-Id: I96577840454d6453b60cc5ff9ce38883362482bb
2019-07-17 14:57:05 -07:00
TreeHugger Robot 6f818e03a7 Merge "Adding spring animation when swiping up to home in 3P Launcher" into ub-launcher3-qt-r1-dev 2019-07-17 21:41:18 +00:00