Commit Graph

77927 Commits

Author SHA1 Message Date
Android Build Coastguard Worker 7a77b3cffd Snap for 12313714 from fae91d5e57 to 24Q4-release
Change-Id: I1d508a219251bd568de38361a51367668e433b44
2024-09-03 23:21:02 +00:00
Alex Chau fae91d5e57 Include DigitalWelllBeing banner in task XML to avoid addView during animation
- Also simplified DigitalWellBeingToast to be an actual View that is a children of TaskView
- Split out getDwbLayoutTranslations into 2 methods
  - One that update layout will be called earlier during TaskView.updateTaskSize. It now takes calcualted split snaphsot size and layoutParams sizes instead of using measured sizes so it can run before onMeasure. Also make sure updateLayoutParams is called.
  - One that calulate translations only can be called more frequently without causing jank during animation
- TaskView.updateTaskSize now always set the exact sizes as layoutParams instead of MATCH_PARENT, so we can use the values for updateDwbBannerLayout
- Simplified outline and splitOffsetTranslation calculations

Fix: 345789862
Fix: 362435532
Test: Presubmit and manually testing DWB banner in variaous configuration single/split real/fake portrait/landscape/fake
Flag: EXEMPT bugfix
Change-Id: Ibde877c5f983689e0ef8104ba344b5947d0e3948
2024-09-03 17:02:31 +00:00
Alex Chau 09623dd5e5 Merge "Fix talkback in split mode" into main 2024-09-03 17:02:04 +00:00
Ats Jenk 32f22de97d Merge "Reuse stash handle alpha animation constants" into main 2024-09-03 16:09:51 +00:00
vinayjoglekar 3359fa7f32 Fix talkback in split mode
1. Announce description of both snapshot in GroupedTaskView.
2. Announce them in correct order.

After setting right content description for both the apps in split mode, announcement order was reverse. Seems that order of the node tree which android sees was wrong. Also order did not change even in RTL mode.

see here https://paste.googleplex.com/6492038621298688.

The correct order is manually set using addChildrenForAccessibility in GroupedTaskView. (similarly being used in RecentsView since we use reverse order for overview). Also considered RTL.
See order after fix here
https://paste.googleplex.com/6492038621298688

https://drive.google.com/file/d/1BA1YKkcNsovEu4us9cvq5xOdXviTR1OV/view?usp=drive_link

Other alternatives tried were fixing order using android:accessibilityTraversalAfter and android:accessibilityTraversalBefore, both in layout and programatically which doesn't seem to work.

Test: Manual - Using Node tree debugging of talkback developer options.(Print and filter by tag TreeDebug)
BUG: 330424779
Flag: EXEMPT bugfix
Change-Id: If3c360277bd951d2d2b223bab7844e078e9c7d27
2024-09-03 15:22:30 +01:00
Android Build Coastguard Worker 3dbf2f6484 Snap for 12309590 from d75eacf30d to 24Q4-release
Change-Id: I363bad6c4b1053dcf187024c521afb42b4d96b3e
2024-09-02 23:20:57 +00:00
Alex Chau e6eca9c195 Promote TaplTestsQuickstep.testBackground to presubmit
- http://android-build/test_hub/search/?filter=&invfilter=unhealthyInvocations&invfilter=staleInvocations&query=test%3Acom.android.quickstep.TaplTestsQuickstep%23testBackground
- Latest result is <0.5% flaky

Bug: 364036214
Test: presubmit
Flag: EXEMPT TEST_ONLY
Change-Id: I97315a23e09c75a5f72cd3f6c959607598d9222d
2024-09-02 19:08:59 +01:00
Luca Zuccarini d75eacf30d 3/3 Move some Shell utils to the Shared package.
Bug: 322791067
Flag: EXEMPT move only
Test: NA
Change-Id: Iabc42e4c1d9c13667e9d91be5789cf295f3332e1
2024-09-02 09:23:34 +00:00
Android Build Coastguard Worker d5ca212b59 Snap for 12305894 from ba6c9f06ed to 24Q4-release
Change-Id: I017ce5f9dd5820ec8307ec714236eea6d547d513
2024-08-31 21:20:58 +00:00
Android Build Coastguard Worker e55b69ea4b Snap for 12304452 from a4ce092bea to 24Q4-release
Change-Id: I5217a8dc04051904a2ae9546a6c0c5cc215c4ed6
2024-08-31 01:21:00 +00:00
Ats Jenk ba6c9f06ed Merge "Scale bubble bar to the width of the handle" into main 2024-08-30 23:06:43 +00:00
Schneider Victor-tulias a4ce092bea Merge "Add a test base for AbsSwipeUpHandler and its subclasses" into main 2024-08-30 20:48:09 +00:00
Jihoon Kang a2dc65a2a1 Merge "Make java_sdk_library dependencies explicit" into main am: 10f0f9a93b am: 612b153591
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/3250185

Change-Id: I37d8a779985f820befa52be51df8101f53ed12bd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-08-30 20:41:29 +00:00
Tracy Zhou 98febb5fa4 Merge "Skip updating taskbar background alpha in phone mode" into main 2024-08-30 20:31:27 +00:00
Jihoon Kang 612b153591 Merge "Make java_sdk_library dependencies explicit" into main am: 10f0f9a93b
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/3250185

Change-Id: Ic156ed0a774b6d6a40af20a1852846503e229b77
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-08-30 20:11:39 +00:00
Ats Jenk 673b88535c Reuse stash handle alpha animation constants
Taskbar and bubble bar stash handle should use a similar animation for
stash and unstash.
Remove duplicate alpha animation constants and use only the ones defined
in taskbar controller for taskbar and bubble bar.

Bug: 345680453
Flag: EXEMPT refactor
Test: m
Change-Id: I9edf847fc4148bc731051de60a883011e6bfb848
2024-08-30 13:07:24 -07:00
Jihoon Kang 10f0f9a93b Merge "Make java_sdk_library dependencies explicit" into main 2024-08-30 19:45:46 +00:00
Ats Jenk dff855e702 Merge "Update bubble bar stash and unstash animation" into main 2024-08-30 19:30:14 +00:00
Mady Mellor 669445f707 Merge "Don't show the app badge on app bubbles" into main 2024-08-30 19:08:24 +00:00
Schneider Victor-tulias f5035847b1 Add a test base for AbsSwipeUpHandler and its subclasses
- Added a few basic tests for scenarios that should be contant across subclasses. These tests will not run on their own, they will only run when a subclass' test suite is run.
- Added test suites for LauncherSwipeHandlerV2 and FallbackSwipeHandler

Flag: EXEMPT adding tests
Bug: 353763639
Test: LauncherSwipeHandlerV2Test, FallbackSwipeHandlerTest
Change-Id: Ib44199f5d5281a544b433649d6ed49ae2a65ed70
2024-08-30 14:14:03 -04:00
Sebastián Franco f24aea0f64 Merge "Add waiting to test to wait for the Workspace to be in Edit mode" into main 2024-08-30 17:31:15 +00:00
Ats Jenk da9e36e4e7 Scale bubble bar to the width of the handle
When animating bubble bar from the stash handle, scale the width to the
handle.
Bubble bar is already almost the size of the handle, but a small scale
is still added.

Bug: 345488489
Flag: com.android.wm.shell.enable_bubble_bar
Test: atest TransientBubbleStashControllerTest
Test: slow animations down and unstash and stash bubble bar, observe
  that the width of the bubble bar scales down to the handle
Change-Id: I54dc228fa41d4d494bfb15e191d2ba563c0970c7
2024-08-30 10:17:29 -07:00
Mady Mellor 3808adc58c Don't show the app badge on app bubbles
Flag: com.android.wm.shell.enable_bubble_anything
Test: manual - add an app bubble to bubble bar, observe it's not
               badged (with sysui CL)
Bug: 342245211
Change-Id: I768fa9bb478eeaba587b90d478f32f8c2ee88be1
2024-08-30 09:52:45 -07:00
Mady Mellor c4c5057c08 Merge "Follow RegionSamplingHelper being moved into shell" into main 2024-08-30 16:49:32 +00:00
Treehugger Robot 5b0e061b4e Merge "Only refresh TaskThumbnailViewDeprecated if runningTaskShowScreenshot has changed" into main 2024-08-30 15:46:20 +00:00
Treehugger Robot 5a5ff5235f Merge "Fixes wrong colors in SUW -> AllSet" into main 2024-08-30 15:19:47 +00:00
Schneider Victor-tulias 211751676c Merge changes I3e97ec83,Ib47a8a7f into main
* changes:
  Update KQS UX to better support square aspect ratio devices
  Update KQS recents apps and desktop mode launching UX
2024-08-30 13:48:05 +00:00
Schneider Victor-tulias f0a6d1df57 Update KQS UX to better support square aspect ratio devices
Flag: EXEMPT ENABLE_KEYBOARD_QUICK_SWITCH
Bug: 357512178
Test: Used KQS on a square device
Change-Id: I3e97ec834512521b417f2e707a6838c96bef5752
2024-08-30 13:47:38 +00:00
Schneider Victor-tulias 55c0c5e75d Update KQS recents apps and desktop mode launching UX
- Updated recent apps KQS task view
- Added a desktop mode KQS task view
- Did some code cleanup to support this more cleanly

Flag: EXEMPT ENABLE_KEYBOARD_QUICK_SWITCH
Fixes: 357512178
Test: Used KQS with and without desktop mode; opened recent apps and desktop mode
Change-Id: Ib47a8a7f41b56af1ba9d0cbec65ababf8aad7881
2024-08-30 13:46:23 +00:00
Alex Chau 31d465937b Only refresh TaskThumbnailViewDeprecated if runningTaskShowScreenshot has changed
- This is a follow-up of ag/28922223, which caused a RECENTS_SCROLLING jank regression
- The regression is probably caused by TaskThumbnailViewDeprecated unnecessarily redrawing, the fix is to only redraw when needed
- Also combined setShouldShowScreenshot and refreshThumbnails into a single method, so we can easily check inside TaskView if a refresh is necessary
- Centralize screenshotTasks logic into RecentsViewUtils, and centralize thumbnailView refreshing inside TaksView.setShouldShowScreenshot

Fix: 362294538
Test: Invoke Omnient or Screenshot hardware button on live tile, verify running task switches to screenshot after overlay closes
Test: Select/Screenshot swithces to screenshot normally
Flag: EXEMPT BUG_FIX
Change-Id: I7c6e73e52ebf18e7c59bb9afea029246b92681d2
2024-08-30 14:46:22 +01:00
Treehugger Robot 8da23e8c91 Merge "Refactoring OverviewCommandHelper (2/3)" into main 2024-08-30 13:31:58 +00:00
Treehugger Robot 09398bf183 Merge "Refactoring OverviewCommandHelper (1/3)" into main 2024-08-30 12:44:26 +00:00
Marcelo Arteiro c6fca0e16b Fixes wrong colors in SUW -> AllSet
Screenshot: https://screenshot.googleplex.com/6Yy9bQuQqox2rPB.png
Fixes: 355462084
Flag: EXEMPT bugfix
Test: Manual
Change-Id: I92b9839d345ab16f0229b546fb6c0e00ced02671
2024-08-30 12:41:34 +00:00
Jordan Silva ebfae18529 Refactoring OverviewCommandHelper (2/3)
This CL should not affect the behavior of OverviewCommandHelper.
- It splits executeCommand into smaller functions
- Rearrange public/private functions
- Adds extra logs.

Bug: 352046797
Bug: 351122926
Flag: EXEMPT bugfix.
Test: Manual.
Change-Id: I283f179794af812973a559db6291febe19e3c6d7
2024-08-30 12:30:54 +01:00
Ats Jenk 9ab2b8c785 Update bubble bar stash and unstash animation
Bubble bar should stash and unstash from the handle.
Update the animation to match what is used for the taskbar animation.
Fix the stash handle reveal animation to animate the stash bounds to
bubble bar bounds and back.
This gives the effect of the handle morphing into the bubble bar and
bubble bar morphing back into the handle.

Bug: 345680453
Flag: com.android.wm.shell.enable_bubble_bar
Test: atest TransientBubbleStashControllerTest
Test: have bubbles in bubble bar and be in app, swipe up for taskbar and
  observe the bubble bar handle transforming into the bubble bar
Test: with taskbar and bubbles expanded, check that bubble bar
  transforms into the handle
Change-Id: I8508e9207092774cbdb990e65f7f84e56a924d0c
2024-08-29 22:34:19 -07:00
Winson Chung 380f11e9d5 Merge "5/ Remove unused recents code" into main 2024-08-30 03:00:49 +00:00
Treehugger Robot 5cfb887b68 Merge "Fix bug where PredictedIcon circle/dot flicker." into main 2024-08-30 01:02:19 +00:00
Jihoon Kang 9f8e4b6b62 Make java_sdk_library dependencies explicit
modules should specify the submodule of java_sdk_library that the module
actually depends on

Test: CI
Bug: 358613520
Change-Id: If1b96a7ffa7ddde50c44817e0d96257ae2967a0e
2024-08-30 00:29:41 +00:00
Treehugger Robot e7efecc52c Merge "Add some info about the overflow in bubble bar dump" into main 2024-08-30 00:24:53 +00:00
Android Build Coastguard Worker 2fa56e3ffc Snap for 12296955 from 1398d2268f to 24Q4-release
Change-Id: I99ccb430b59f2162084d3888b4aed5aa54f2aeae
2024-08-29 23:18:34 +00:00
Winson Chung d159e61166 5/ Remove unused recents code
- The shell transit flag is already hardcoded to true in Launcher
  so we can remove the non-shell transit paths
- The minimized split was from legacy splitscreen where launcher would
  show in a minimized state, which is no longer the case

Flag: EXEMPT bugfix
Bug: 359608026
Test: atest NexusLauncherTests
Change-Id: Idea46fc065485233b9e508dae3ebc4ee87c29ba6
Signed-off-by: Winson Chung <winsonc@google.com>
2024-08-29 23:17:23 +00:00
Treehugger Robot 313b559076 Merge "[Predictive Back] Clean up flags" into main 2024-08-29 22:46:13 +00:00
Jagrut Desai a68e4fe0de Merge "Promote TaplAddWidgetTest#testResizeWidget" into main 2024-08-29 22:43:30 +00:00
Treehugger Robot 03cace2e6b Merge "Only handle taps on bubble bar when it was collapsed/stashed on down" into main 2024-08-29 22:37:49 +00:00
Jagrut Desai 9657710f29 Merge "Refactor TaskbarIconSpecs and TaskbarSpecsEvaluator" into main 2024-08-29 21:44:04 +00:00
Jagrut Desai bc98db6820 Merge "Use TaskbarAllAppsButtonContainer and TaskbarDividerContainer in TaskbarView" into main 2024-08-29 21:44:04 +00:00
Mady Mellor cc843823a6 Add some info about the overflow in bubble bar dump
Flag: com.android.wm.shell.enable_bubble_bar
Test: manual - add some bubbles to bubble bar, take a BR and look
               at the dump
Bug: 358304168
Change-Id: I91e50591df166e928d06ba9a29f69f923218de71
2024-08-29 14:20:38 -07:00
Treehugger Robot 9025fe918b Merge "FloatingWidgetView - avoid calling position callback when nothing changes." into main 2024-08-29 21:02:17 +00:00
Mark Fasheh 6a5a6f9593 Merge "Update launcher cold startup trace" into main 2024-08-29 20:46:49 +00:00
Fengjiang Li 1f25f6405c [Predictive Back] Clean up flags
Fix: 270614790
Flag: NONE - clean up flag
Test: presubmit
Change-Id: I956ce6067dca5d2517b45046ae8a392df1023e49
2024-08-29 13:38:05 -07:00