Commit Graph

79310 Commits

Author SHA1 Message Date
Kevin Lim 79fb6dfbdb Merge "[a11y] Fix talkback column and item count for AllAppsGrid" into main 2024-12-02 20:52:54 +00:00
Brandon Dayauon 345901fdb0 Merge "Fix close button in workEDU card not 48dp." into main 2024-12-02 20:39:20 +00:00
Liran Binyamin 35b7616cd9 Merge "Reset the bubble bar scale when the animation is interrupted" into main 2024-12-02 19:51:19 +00:00
Treehugger Robot 27c2f4ddc1 Merge "Decouple Backup / Restore Error Codes" into main 2024-12-02 18:57:17 +00:00
Saumya Prakash 5b878bbf1a Merge "Add animations to Manage Windows menu in Taskbar" into main 2024-12-02 17:58:32 +00:00
Liran Binyamin 3931b671b4 Reset the bubble bar scale when the animation is interrupted
Flag: com.android.wm.shell.enable_bubble_bar
Fixes: 381283214
Test: atest BubbleBarViewAnimatorTest
Test: manual
       - have a bubble in the bubble bar
       - launch an app
       - set animator scale to 5x to slow down animation
       - send a bubble
       - when the bubble bar animates interrupt the animation by
         touching the bubble bar
       - observe the bubble bar scale is reset correctly
Change-Id: I1abd81e3df987ba749a13eb1b7506d5c1d8fdddd
2024-12-02 11:23:35 -05:00
Liran Binyamin 495fe1d255 Merge "Animate the bubble bar on dismiss" into main 2024-12-02 14:28:30 +00:00
Andy Wickham 3be4c7d458 Merge "Cleanup the null checks added in ag/30408877" into main 2024-12-01 06:00:19 +00:00
Treehugger Robot fedf7fa5e2 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-11-30 21:27:38 +00:00
Treehugger Robot add782b869 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-11-30 21:27:38 +00:00
Treehugger Robot 16740cd22a Merge "Make TaskView not clickable when in select mode for switch access and touchscreen usage." into main 2024-11-29 21:13:31 +00:00
Uwais Ashraf a8f01bac1d Make TaskView not clickable when in select mode for switch access and touchscreen usage.
Fix: 320228423
Flag: EXEMPT BUG_FIX
Test: Manual - steps from bug
Change-Id: Ib831ab52ce3cc3a19e73f6b255cab519074c24b6
2024-11-29 16:38:14 +00:00
Treehugger Robot 2f3d9aae18 Merge "Mock UserCache in TaskViewItemInfoTest to avoid NPE" into main 2024-11-29 14:37:53 +00:00
Johannes Gallmann cc6e7f09c9 Merge "Fix ConcurrentModificationException in TouchInteractionService" into main 2024-11-29 13:13:39 +00:00
Alex Chau 9e52a665a6 Mock UserCache in TaskViewItemInfoTest to avoid NPE
- Also added test for runtimeStatusFlags on regular/private apps

Fix: 381295678
Test: TaskViewItemInfoTest
Flag: EXEMPT BUG_FIX
Change-Id: I928a8f128957885d33ac8001493eef0fd4b23ec7
2024-11-29 12:42:15 +00:00
Johannes Gallmann 108dc037a0 Fix ConcurrentModificationException in TouchInteractionService
Bug: 381018493
Test: Manual, i.e. verified that unregistering listener during set iteration works
Flag: EXEMPT bugfix
Change-Id: Ia4600797ce579b80621b32977fcd9712d4fc26bb
2024-11-29 11:15:40 +00:00
Treehugger Robot b5bf7820e6 Merge "Adding MSDL haptics for dragging app icons in Workspace and Hotseat." into main 2024-11-29 08:14:34 +00:00
Treehugger Robot b1629b250d Merge "Add missing overview state event to tests" into main 2024-11-28 22:38:13 +00:00
Treehugger Robot 9ba4899872 Merge "Wait until AllSetActivity.onResume to start the background animation" into main 2024-11-28 16:42:01 +00:00
Gustav Sennton 68648283a8 Use bugfix flags for desktop mode transitions (exit, applaunch, alttab)
The transitions changes are bug fixes / polish, so use bugfix flags
for these changes.
An existing non-bugfix flag cannot be changed into a bugfix flag, so
instead we create new flags with the bugfix type.

Bug: 380224768
Bug: 380225486
Bug: 380224832
Test: manual - disable main flags, use bugfix flags
Flag: com.android.window.flags.enable_desktop_windowing_enter_transition_bugfix
Change-Id: I1c9ea635a362db741f4a632e6360aee87c12750e
2024-11-28 12:32:34 +00:00
Mykola Podolian 6baca730ff Merge "Only adjust the hotseat if bubble bar is visible." into main 2024-11-28 04:09:00 +00:00
Bill Yi 5e7bda3b84 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I1688b8e845f0eb1185950e16c6ab11d686edc873
2024-11-27 17:35:47 -08:00
Bill Yi 02925dcda5 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Id3dd3f3a10edac962c71d7695073179515feceec
2024-11-27 17:34:56 -08:00
mpodolian 24521dd6f8 Only adjust the hotseat if bubble bar is visible.
The change avoids setting up the hotseat if there is no bubble bar.

Fixes: 379809704
Test: EXEMPT bugfix
Flag: com.android.wm.shell.enable_bubble_bar

Change-Id: I26820e3a13a4eaceb0897e44852c0d70aa71918b
2024-11-27 17:12:25 -08:00
Stefan Andonian 6df13d3b8e Decouple Backup / Restore Error Codes
Bug: 381315244
Test: Simply looked at emitted error codes and changed names if they were used in multiple locations.
Flag: EXEMPT bug fix
Change-Id: Iab4a8d6ff410682f448b2ac32e44b766d79a7616
2024-11-27 16:48:28 -08:00
Andy Wickham cdcfaa80b2 Cleanup the null checks added in ag/30408877
These checks should be safe, but could be hiding other issues.
They were originally added as a workaround for presubmit failures
only on mokey_go32 (32 bit Android Go).

Bug: NA
Flag: EXEMPT cleanup
Test: Manual and existing presubmit tests
Change-Id: Ifcd136f61c885dba316e492a2408b67b42dcffcf
2024-11-27 15:36:37 -08:00
Andy Wickham 28d920ef05 Merge changes from topic "rm-lph-flag" into main
* changes:
  Make ContextualSearchInvoker not a ResourceBasedOverride.
  End live tile when invoking Circle to Search over Overview.
2024-11-27 23:32:29 +00:00
Brandon Dayauon 9f1b9d1b13 Fix close button in workEDU card not 48dp.
Can use insets to make it appear the same small visual but have a 48dp tap target. Since delegating the touch to the 48dp,
we can make the imageButton clickable to false as it's instead being used by the 48dp frame.

- since there's no rtl catering for insets insets must have equal left and right values.
   * this means to reduce the end margin of the text to be given to the LEFT inset of the inset_rounded_action_button
   * reduce end margin of the linearlayout to be given to the right inset of the drawable.

bug:379794419
Test manually photos:
beforeRTL:https://drive.google.com/file/d/1-DzcjOTywgk6SFjfCX7AVnmfqsIfa1lh/view?usp=sharing
afterRTL:https://drive.google.com/file/d/1UERlZ7XdoF0NhFuQE-oMulqgW9sDq9cy/view?usp=sharing
before:https://drive.google.com/file/d/1h5_Ljsx1rLyKum1PK7IRwD14ps2SPKC3/view?usp=sharing
after:https://drive.google.com/file/d/1b_8rgrC8WlDIdQuO7gOXS0MDNCISfxWr/view?usp=sharing
Flag: EXEMPT bug fix

Change-Id: I017d4d34ef6e42fa49543c5f787063b061c382dc
2024-11-27 14:02:31 -08:00
Liran Binyamin 7e387fa505 Animate the bubble bar on dismiss
When the last remaining bubble is dismissed by drag or from the menu
we now fade out the bubble bar.

Flag: com.android.wm.shell.enable_bubble_bar
Fixes: 347062801
Test: manual
       - create a single bubble in the bar
       - expand
       - dismiss by drag or from menu
       - observe animation
Change-Id: I86fcaf04c6f5949126744b81e0042b0e58318a13
2024-11-27 16:23:26 -05:00
Treehugger Robot c4a90de0e9 Merge "Convert px to dp for determining minWidth and minHeight for each row count, and add breakpoints" into main 2024-11-27 21:17:43 +00:00
Ana Salazar Maldonado ffef53ecb6 Merge "Fix condition for showing contraste tile" into main 2024-11-27 21:16:38 +00:00
Andy Wickham 2ae01adf71 Make ContextualSearchInvoker not a ResourceBasedOverride.
This was previously only used to honor the INVOKE_OMNI_LPH flag
which has been enabled for a long time. So this is part of that
cleanup.

Bug: 297561673
Test: Manual
Flag: EXEMPT deleting legacy flag
Change-Id: Ife9f14faa2099f579f631da2aadaa6a56cbba51d
2024-11-27 13:03:18 -08:00
Andy Wickham 03a96eb8f7 End live tile when invoking Circle to Search over Overview.
This fixes many animation/state issues related to switching tasks
from the live tile to AGA.

Demo before: https://drive.google.com/file/d/1aBsn_-4tRHRsfGSqsx44_1B7dgdPOq_v/view?usp=drive_link&resourcekey=0-EHyEiKRVEC2ooUo-0rcjHg
Demo after: https://drive.google.com/file/d/1Sf5cUh8hC-slUZc_efOChzxxw710pG65/view?usp=drive_link&resourcekey=0-Wr33tL3ytedMibcVNd6auw

Bug: 372592549
Bug: 297831970
Test: Manual, updated ContextualSearchInvokerTest.
Flag: EXEMPT bugfix
Change-Id: I538cb1de61e48de4cf7c6fca8710a655933d07a3
2024-11-27 13:03:08 -08:00
Mykola Podolian 400fc4ad98 Merge changes I239f9357,I57a32ac5 into main
* changes:
  Update setting taskbar window height
  Set bubble bar aligned to QSB
2024-11-27 20:44:53 +00:00
Charlie Anderson cc4b2217f8 Merge "add Launcher flag for launcher icon shapes" into main 2024-11-27 20:40:43 +00:00
Uwais Ashraf bfede7eb48 Merge "Exclude cleanup methods from CUJ for entering split select." into main 2024-11-27 20:28:40 +00:00
Treehugger Robot d7b3369036 Merge "Ignore events that occur between app icons on the taskbar" into main 2024-11-27 20:22:17 +00:00
Liran Binyamin ed249f0451 Merge "Show the bubble bar edu view" into main 2024-11-27 20:09:07 +00:00
Vinay Joglekar 721d6c968d Merge "Add missing test from ag/30322765" into main 2024-11-27 18:19:48 +00:00
mpodolian 3111daf2f1 Update setting taskbar window height
Updated the logic to set the taskbar window height to accommodate the
bubble bar with its maximum flyout height before the bubble bar
animation begins. The height is reverted to the default value once the
animation is completed.

Fixes: 378400160
Flag: com.android.wm.shell.enable_bubble_bar
Test: Manual. Set 3-button navigation mode and have the QSB placed
above the hotseat. Send a notification that will display a bubble, and
observe the bubble bar animation and final placement aligned with the
QSB.
Next, set gesture navigation mode and repeat the flow above. Observe
that the bubble bar is aligned with the hotseat icons.
Felix video:
http://recall/-/gx8ASgewUeUS3QYohfrd1J/gYMVt0sH4si0KOpaBxIPem
Tangor video:
http://recall/-/gx8ASgewUeUS3QYohfrd1J/fz95MbjcjW3awStnuOl8BJ

Change-Id: I239f935743c3936fed44822c3c62652073ffefe2
2024-11-27 10:19:24 -08:00
mpodolian 28907bcbd6 Set bubble bar aligned to QSB
Change logic to updated bubble bar alignment with the QSB vertical
center for 3 buttons navigation mode.

Fixes: 378400160
Flag: com.android.wm.shell.enable_bubble_bar
Test: PersistentBubbleStashControllerTest
Test: TransientBubbleStashControllerTest
Test: Manual. Set the buttons navigation mode and observe that the
bubble bar is centered with the QSB when the QSB is not aligned with the
hotseat. Then, switch to gestures navigation mode and observe that the
bubble bar is centered with the hotseat when the QSB is not aligned with
the hotseat.

Change-Id: I57a32ac5bde7a7055b54a89727429424e5c0ca4f
2024-11-27 10:15:08 -08:00
Ana Salazar Maldonado 1e392d6679 Fix condition for showing contraste tile
Merge error caused the condition to only draw contrast tiles for empty
labels.

Bug: 381062398
Flag: com.android.launcher3.enable_contrast_tiles
Test: Manual, visual change
Change-Id: Id2d55d3bc16e76613faca07b0fd28ef01921f016
2024-11-27 10:00:58 -08:00
Artsiom Mitrokhin 75974d8361 Merge "Prevent spawning multiple pinning popups on right click" into main 2024-11-27 15:49:19 +00:00
Schneider Victor-Tulias c062d5aa43 Add missing overview state event to tests
This missing event was causing FallbackRecentsTest to fail when using the recents window

Flag: com.android.launcher3.enable_fallback_overview_in_window
Fixes: 380440464
Test: FallbackRecentsTest
Change-Id: I13a69e58811a14ffa88187acd42a1a12016d081d
2024-11-27 15:28:39 +00:00
Schneider Victor-Tulias 0a1dbd4dc7 Wait until AllSetActivity.onResume to start the background animation
The background animation was originally getting started through AllsetActivity.onCreate, which is a lot of work to put on the main thread during the launch animation. The animation will now instead start onResume through AllSetActivity.maybeResumeOrPauseBackgroundAnimation

Flag: EXEMPT bug fix
Fixes: 380392303
Test: started AllSetActivity locally and checked that the animation still starts
Change-Id: I201428dd9e7b754e9ab3199432d0754f2529e6c9
2024-11-27 15:28:24 +00:00
Charlie Anderson 7e0cad5e10 add Launcher flag for launcher icon shapes
Bug: 348708061
Test: EXEMPT adding flag
Flag: com.android.launcher3.enable_launcher_icon_shapes
Change-Id: I95d5ecd79261d2dad62386f08fa3c6da13054728
2024-11-27 14:59:19 +00:00
Marcelo Arteiro 8b63ee3420 Merge "Migrate materialColor* attributes into colors" into main 2024-11-27 14:55:47 +00:00
vinayjoglekar 50354ed693 Add missing test from ag/30322765
Test: SplitSelectStateControllerTest
Fix: 376409147
Flag: EXEMPT test only
Change-Id: I2f40dfb370ac861b69216ebee30c6e330f6d756d
2024-11-27 14:36:26 +00:00
Vinay Joglekar 0bb2421c94 Merge "Fix animation while hiding Desktop tasks during split" into main 2024-11-27 13:33:59 +00:00
Treehugger Robot 02038f4deb Merge "Log various TaskView properties in TaksContainer.itemInfo" into main 2024-11-27 12:59:31 +00:00