* In ag/23680185, a null check was removed that was
checking if individual mLastAppearedTaskTargets were null;
we check if the array overall is null, but individual
elements can also be null, ex 3P launcher
Bug: 289609734
Test: Repro steps from b/289609734 don't cause crash
Flag: none
Change-Id: Iddfde6d9ac2b708380b70b5fb6301b629506619c
We currently won't be able to run test locally on Android 14 devices as the flag is required for all braodcast recievers, so the change here.
Test: Presubmit
Bug: 292118103
Flag: not needed
Change-Id: I85f9d1b9717b85b30a15e825ebd500508dd3ca5d
When the first bubble is added we set the visibility of the bubble bar
to VISIBLE if the stash controller is unstashed. The issue is that once
bubbles are gone we no longer update the stash state in the controller,
so it becomes stale and can't be used when the first bubble is added.
This change introduces a new method for handling the transition from
the state where both bar and handle are invisible into the state where
one of them becomes visible. We can't use the existing stashBubbleBar
and showBubbleBar methods because those transition from one to the other.
Using them when both are invisible results in one of them becoming visible
and then invisible again.
Fixes: 290992144
Fixes: 291074646
Test: Manual:
- Add bubble in the test app by double-tapping on a chat (non expanding notification)
- Observe that the handle becomes visible and the bar is invisible
- Dismiss bubble
- Add bubble in the test app by tapping on the button on the right (auto expanding)
- Observe that the bar becomes visible and expanded
Change-Id: I61334c67c255a6ed074fa8c834f4a5a1547539bf
This patch makes it so that Overview will return the correct GroupedTaskView even when the set of taskIds passed in is in the opposite order.
Previously, we didn't account for order variation when checking for a GroupedTaskView, which would cause bugs when the GroupedTaskView had had its ordering swapped.
Fixed by modifying getTaskViewByTaskIds() to return true even if the order of ids was swapped.
Fixes: 290135090
Test: Manual
Change-Id: I2d94fadfee3cd478801b25cdbc699295179c8bd1
Revert submission 23784831-launcher-test-rule
Reason for revert: Checking if these changes are the cause of a 10 min timeout in the instrumentation
Bug: 291171782
Reverted changes: /q/submissionid:23784831-launcher-test-rule
Change-Id: Id77ee089b8302992f3a5d91f35f655bb618137f0
* Hypothesis for why ALL_APPS isn't showing is that
directly navigating to it via state manager might have
some more hiccups (historically it has), so we do it
now via swiping up on workspace
Bug: 288152874
Flag: None
Test: Passes locally
Change-Id: I8ada7d3bde88fa54c9aab84012a9b0e3e045069e
When work profile is disabled, we should also let main RV use AllAppsStore's recycler view pool.
Test: Turn off work profile, kill launcher process, swipe up all apps, start record perfetto trace, scroll down all apps, then stop record, verify no BubbleTextView inflation after change
Bug: 287523421
Flags: ENABLE_ALL_APPS_RV_PREINFLATION
Change-Id: Idd5f8193e85fc2a250877affc3b2e4ab4a704797
This avoids re-adding bubbles that have already been removed
after dismissing multiple bubbles at once.
Fixes: 291738088
Test: Manual
- Add 2 bubbles A and B to the bubble bar
- Expand the bubble bar
- Tap 3 dot menu and dismiss
- Repeat for the next bubble
- Observe that bubble bar is gone
- Add a new bubble C
- Observe that the bubble bar contains only bubble C
Change-Id: Id53811a103d245647489ab8d442cbb2004e0e700
Bill Yi
Winson Chung
Vinit Nayak
Brian Isganitis
Helen Cheuk
Jagrut Desai
Fengjiang Li
Treehugger Robot
Jordan Silva
Sunny Goyal
Liran Binyamin
Alex Chau
Anushree Ganjam
Uwais Ashraf
Brandon Dayauon
Thales Lima
Pat Manning
Jeremy Sim
Federico Baron