Commit Graph

33884 Commits

Author SHA1 Message Date
Jonathan Miranda 6fbcbc7a4c Merge "Add more extra space to hotseat for taller devices." into sc-dev am: 0c7153bbdf
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15363650

Change-Id: I3ff54d0d1559305b8e501abeba31ab3cec8c37f1
2021-07-23 22:02:13 +00:00
Jonathan Miranda 0c7153bbdf Merge "Add more extra space to hotseat for taller devices." into sc-dev 2021-07-23 21:41:27 +00:00
Jon Miranda 80cddbccb6 Add more extra space to hotseat for taller devices.
Bug: 192520231
Test: manual test on taller devices
Change-Id: I3eccada67f0ba07d01f823c4156f02c3feb97f84
2021-07-23 20:01:16 +00:00
TreeHugger Robot 61eb1fe0ac Merge "Hide taskbar on lockscreen" into sc-v2-dev 2021-07-23 19:01:26 +00:00
TreeHugger Robot 2ed55ed9de Merge "Folder polish: unbold folder title, ensure icons not cropped in folder." into sc-dev am: 3f062ab8b6
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15365040

Change-Id: I0fccfe7fdf32f7bcbcddb3633e34acb1c7c979f6
2021-07-23 18:23:49 +00:00
TreeHugger Robot 3f062ab8b6 Merge "Folder polish: unbold folder title, ensure icons not cropped in folder." into sc-dev 2021-07-23 18:10:48 +00:00
Alex Chau 261708ba00 Clean up debug flags and add more screen record
Bug: 193440212
Bug: 194484556
Test: manual
Change-Id: I1b09ae74462c86afb8effb0a2635fd0e70a59bf8
2021-07-23 15:42:01 +01:00
Alex Chau f4afdc4167 Merge "Avoid seeing ClearAllButton for overview grid's snap position" into sc-v2-dev 2021-07-23 11:27:27 +00:00
Jonathan Miranda c7c86dffe7 Merge "Update size limits to match spec." into sc-dev am: adeb26b0dc
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15338351

Change-Id: Ie62dc91fc76d49e443b38ecf4ce6b62ddb710211
2021-07-23 07:00:28 +00:00
Jonathan Miranda adeb26b0dc Merge "Update size limits to match spec." into sc-dev 2021-07-23 06:46:27 +00:00
TreeHugger Robot 8a4a99ed95 Merge "Improving diags for launching an app." into sc-v2-dev 2021-07-23 04:12:08 +00:00
TreeHugger Robot 8aac1952af Merge "Dump accessibility hierarchy on test failure" into sc-v2-dev 2021-07-23 03:42:48 +00:00
TreeHugger Robot ec4be03dd3 Merge "Improving diags when Launcher is invisible when the test fails" into sc-v2-dev 2021-07-23 03:42:39 +00:00
vadimt 771da0c00f Improving diags for launching an app.
Test: presubmit
Bug: 187761685
Change-Id: I8c304dbabc474e39aa8fe1cca234140823764099
2021-07-22 19:02:51 -07:00
Jon Miranda f33f5b3fc5 Folder polish: unbold folder title, ensure icons not cropped in folder.
- Ensure folder items are scaled to fit within the height/width in 4x5 mode.
- This bug surfaced now since  we increased the icon size.

Bug: 194356039
Test: set display to large, set font to large
Change-Id: Ie360ca67c3c91649a471bce920b2fc6a82fb9661
2021-07-22 17:19:28 -07:00
Jon Miranda e4413cc6ae Update size limits to match spec.
Bug: 194124461
Test: Verified using screnshots over spec
      Only 4x5 grid is affected
      Tested on multiple devices, multiple display options

Change-Id: I301c512e416ed81f6d41f6f0ecbf5994d47d82bf
2021-07-22 16:26:18 -07:00
vadimt cf1c28ef73 Dump accessibility hierarchy on test failure
This will allow seeing exactly what the test sees.

Test: local runs
Bug: 187761685
Change-Id: Ibf4b97bd9b99d4b40def4eb3db9a2cd1b47defb1
2021-07-22 16:00:53 -07:00
Adam Cohen 2a0516f6cc Fix widget drop preview outline on 4x5 grids am: ed82e0daef
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15351419

Change-Id: I37f0cde316ac0a4c7b793ad25b23d5208ca90b65
2021-07-22 22:55:49 +00:00
Ben Lin 1800f916ad Merge "PIP: Implement auto-rotate with gesture nav for Shell transitions." into sc-v2-dev 2021-07-22 21:25:11 +00:00
TreeHugger Robot f2af895b20 Merge "Animate SplitPlaceholderView when entering split from overview" into sc-v2-dev 2021-07-22 21:17:35 +00:00
Vinit Nayak 2f4b18bada Hide taskbar on lockscreen
Add new animated float to disable taskbar
background value when keyguard is visible.

Fixes: 191857724
Test: Tested w/ and w/o bouncer for gesture + 3 button
Tested w/ IME pw on lock screen.

Change-Id: I2e1696fd25f4c170bfb2bc0694ccd644e453b1fe
2021-07-22 13:14:51 -07:00
Vinit Nayak 7903758d08 Animate SplitPlaceholderView when entering split from overview
Bugs tracked in b/181704764

Bug: 181704764
Test: Tested on phone and large screen in multiple orientations

Change-Id: I07509006ae3d1f4425dc5119d0c8ed52b41a3bc2
2021-07-22 20:12:26 +00:00
Adam Cohen ed82e0daef Fix widget drop preview outline on 4x5 grids
=> We were not account for mBorderSpacing in the outline calculation
=> This was fine in most cases as this value is 0, but 4x5 appears to be the exception

Bug: 194227752

Test: manual, see video in bug.
Change-Id: Ib590bc142a0f65e75f92ee057f8b4f4b0f81521b
2021-07-22 12:31:21 -07:00
TreeHugger Robot d327290762 Merge "Removing UI dependency from LauncherModel in case of 2-panel layout" into sc-v2-dev 2021-07-22 19:16:52 +00:00
TreeHugger Robot c48e4fa64d Merge "Measure WidgetsFullSheet before estimating the recommended table size" into sc-dev am: 6a01fe49a5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15359118

Change-Id: I0004e2f55347e018fa553f8b56c26a754a93e0f1
2021-07-22 19:11:55 +00:00
TreeHugger Robot 6a01fe49a5 Merge "Measure WidgetsFullSheet before estimating the recommended table size" into sc-dev 2021-07-22 18:53:32 +00:00
Sunny Goyal 12e3f1f2f7 Removing UI dependency from LauncherModel in case of 2-panel layout
Bug: 175939730
Bug: 192431856
Bug: 185515153
Test: Manual
Change-Id: I8baa1cf9e5a8a04d5b8bc38c1f4b0755265cd8a9
2021-07-22 10:34:25 -07:00
Jason Chang 12a0357c31 Merge "Fix unable to swipe up to exit one-handed mode under 2 button navigation" into sc-dev am: 1b3f5d3883
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15311532

Change-Id: I6459733abb399137224fe9c24ac7cdc63282dd9e
2021-07-22 16:54:17 +00:00
TreeHugger Robot f3a387d731 Merge "resolve merge conflicts of 46378eb881 to sc-v2-dev" into sc-v2-dev 2021-07-22 16:49:35 +00:00
Alex Chau 41e77de54e Avoid seeing ClearAllButton for overview grid's snap position
- This is a follow-up of http://ag/15220572
- When determining if task's snap position is too close to ClearAllButton, avoid positions that will see part of ClearAllButton

Bug: 192254835
Test: manual
Change-Id: I09425075ff0c24835ac3c4e79856aef7985476b2
2021-07-22 16:14:15 +01:00
Steven Ng a606d344a6 Measure WidgetsFullSheet before estimating the recommended table
size

Issue: The header view height was obtained before any measurement.

Test: On Pixel 5 4x5 gird with Photo widget shown in recommended
      table, make the device in landscape. Then open the full widgets
      picker. The widgets picker can be scrolled. Before this fix,
      scrolling is not possible.
Fix: 194172597
Change-Id: Ib30cf4b95d2ed23ff28f3d24e103f0e919b3a551
2021-07-22 16:08:15 +01:00
TreeHugger Robot b971baefe1 Merge "Fix scaling on widget previews that have width / height set to wrap_content" into sc-v2-dev 2021-07-22 12:05:03 +00:00
TreeHugger Robot d32a472e5c Merge "Add null check for recents scaling during quick switch." into sc-v2-dev 2021-07-22 10:28:50 +00:00
Steven Ng 2b90d043f6 Fix scaling on widget previews that have width / height set to
wrap_content

If the widget preview has width / height set to wrap_content, we should
set the layout param width / height to the exact dimension after
measurement. Otherwise, we will end up clipping the previews.

Test: manual
Fix: 193144010
Change-Id: I101f7c6d3dbd264fee448b85c54029d5650d6630
2021-07-22 11:19:25 +01:00
Jason Chang 1b3f5d3883 Merge "Fix unable to swipe up to exit one-handed mode under 2 button navigation" into sc-dev 2021-07-22 09:43:13 +00:00
Thales Lima 496ca0081e Merge "launcher: correct page spacing for multiple panels" into sc-v2-dev 2021-07-22 09:41:56 +00:00
Thales Lima e445774ab5 launcher: correct page spacing for multiple panels
This fixes 2 things:
- adding the correct space between pages as insets (eg camera) were
being discarded
- adding the space between pages instead of between panels as was before

This solution should work with more panels and don't create problems for
phones, where panels = 1.

Fixes 193194192
Test: manual testing in unfolded state in portrait and landscape, both
rotations

Change-Id: Ia3b148ceb773c6d5b6f8848ced07d7f9c1459e92
2021-07-22 09:41:43 +00:00
Pat Manning b442aee4c4 Add null check for recents scaling during quick switch.
Test: manual - FallbackRecentsTest.goToOverviewFromHome and
StartLauncherViaGestureTests.testStressPressHome were previously failing
due to null mActivity in AbsSwipeUpHandler#getScaleProgressDueToScroll.
Bug: 192470757
Change-Id: I562171c22ad3c89e64b4dc853a266c8b8b78402c
2021-07-22 08:52:28 +00:00
vadimt 6c1331ca42 Improving diags when Launcher is invisible when the test fails
Test: presubmit
Bug: 187761685
Change-Id: I69a930ef076dbf6cca5af516228ebe689fac91eb
2021-07-21 18:50:32 -07:00
Jonathan Miranda c2a49ee2bc resolve merge conflicts of 46378eb881 to sc-v2-dev
Folder icon polish.

- Increase the overlap between the preview items and the background
  so that it appears more intentional (lots of reports of users
  thinking that its a bug)
- Fix bug where clip path was still clipping icons when
  dragging and swiping to home.

Bug: 194339057
Bug: 193701705
Bug: 191225536
Test: test 2 icon, 3 icon, and 4 icon folders
      close folder on 2nd page, ensure clipping
      ensure no preview items are clipped in drag view
      ensure no preview items are clipped in swipe up to home
      test 2x2, 3x3, 4x4, 4x5, and 5x5 grids to ensure no clipping
      of folder icons
      drag and drop folder in and out of hotseat
      create folders (2 icon, 3 icon, 4 icon)

Change-Id: I09ce9ef59e340b1009de3d26eed430a0a8dc4b33
Merged-In: Id49bae33438e10248bef05450d7e2c92c2140748
2021-07-22 00:43:27 +00:00
Jonathan Miranda 46378eb881 Merge "Folder icon polish." into sc-dev 2021-07-22 00:15:29 +00:00
TreeHugger Robot eb894b577a Merge "Scale recents during quick switch for large screens." into sc-v2-dev 2021-07-21 21:35:12 +00:00
Brian Isganitis a9b1814d42 Support overriding All Apps EDU animation on drag am: ec4a56a311
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15349065

Change-Id: Ie0caf9308989d8f3ba0b23ffb68b0157c5d2c22e
2021-07-21 20:15:33 +00:00
TreeHugger Robot 246b450f16 Merge "Reland "Move focused task to front when attaching RecentsView"" into sc-v2-dev 2021-07-21 20:08:41 +00:00
TreeHugger Robot 6c71f688b2 Merge "End recents animation when entering split select" into sc-v2-dev 2021-07-21 18:55:54 +00:00
Evan Rosky 2102a89ef6 Merge "Part of fixing Splashcreen cts tests" into sc-v2-dev 2021-07-21 18:01:09 +00:00
TreeHugger Robot 582a23260a Merge "Always use INSIDE_TO_OUTSIDE scope when swiping to home in tablets" into sc-v2-dev 2021-07-21 17:45:53 +00:00
Pat Manning 3786fa188d Scale recents during quick switch for large screens.
Test: manual
Fix: 192470757
Change-Id: I4522455e488213a6f461549a31e78edef35aac21
2021-07-21 17:43:04 +00:00
Brian Isganitis ec4a56a311 Support overriding All Apps EDU animation on drag
Test: Dragging during All Apps EDU animation overrides the animation.
Bug: 160218103
Change-Id: I1c0a2d047bcb43ea7ce30cf87182b392dac313e4
2021-07-21 17:39:00 +00:00
Alex Chau 2450adf56f Always use INSIDE_TO_OUTSIDE scope when swiping to home in tablets
- In tablets user is either in home screen or there is a taskbar on screen, so swipe to home will always touches the launcher

Bug: 193653850
Test: StartLauncherViaGestureTests
Change-Id: Id1b05708324302eb4b4c2d623ca9fe27090188fc
2021-07-21 14:52:01 +01:00