Commit Graph

33199 Commits

Author SHA1 Message Date
Hyunyoung Song 6e72c8bbba All apps memory leak fix / unregister data observer
Bug: 197702957

Test: adb shell dumpsys meminfo com.google.android.apps.nexuslauncher, ahat

Change-Id: Ia5732cced959e4a199d9c2b59f1f3941a2e23552
2021-08-26 15:18:47 -07:00
Lucas Dupin 6d7a006302 Constrain scroll amount
Test: scroll vertically and horizontally
Fixes: 196309367
Change-Id: Ibf16fb72cf95e29ed820d5f511e764a388c93bb0
Merged-In: Ibf16fb72cf95e29ed820d5f511e764a388c93bb0
(cherry picked from commit b259a896f5)
2021-08-25 16:45:20 +00:00
Alex Chau d688120ee1 Merge "Fix animation problem when swipeing up app to screen edge and release" into sc-qpr1-dev 2021-08-25 09:08:03 +00:00
Lucas Dupin e3cf162169 Synchronize surface transaction am: 0a2076e8d3
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15669618

Change-Id: I494543d4183689bfcec9ed4e384be4ad3e660707
2021-08-25 03:35:43 +00:00
Lucas Dupin 0a2076e8d3 Synchronize surface transaction
Until now the SurfaceControl transaction was being applied
asynchronously, which could lead to it being executed out of sync with
launcher drawing.
This became an issue at higher refresh rates, where frames are produced
at a much faster pace.

In order to fix this issue, we can use BLAST transactions, which are
annotated with a frame number.

Test: record video, go through it manually
Fixes: 194320152
Change-Id: I1636a1ded4f9dd84c54ba12239e3549b92ed7567
Merged-In: I1636a1ded4f9dd84c54ba12239e3549b92ed7567
2021-08-24 21:28:50 +00:00
Alex Chau df2b9e14d6 Fix animation problem when swipeing up app to screen edge and release
- Consider scroll diff between currentPage and primary scroll when calculating adjacent page offset
- Removed setEnableFreeScroll call in onPrepareGestureAnimation that calls setCurrentPage and causes jumping

Fixes: 197012570
Fixes: 195740577
Test: Swipe up from app to end of screen, adjacent task should come from screen edge, and app should snap smoothly to position
Test: Swipe up from app, scroll immediately, free scroll should be enabled
Test: Swipe up immediately after quick switch, task thumbnails are loaded
Change-Id: Id88266634183dfcb18d5ba8a803883b7d6f50ab4
Merged-In: I1964b8c3bd82b22396340d2352833b2aee73a6fc
(cherry picked from commit 8ebd11af14)
2021-08-24 10:11:41 +00:00
Lucas Dupin f52fb6f632 Act on scrim visibility am: a8382dc052
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15655786

Change-Id: I40626071bdaadd997cc1479118224847b78229d3
2021-08-23 21:34:23 +00:00
Lucas Dupin a8382dc052 Act on scrim visibility
The scrim visibility drives whether the launcher window is opaque or
not. We should track it and apply the flag instead of trying to catch it
through other Launcher life cycles.

Fixes: 195365607
Bug: 196403152
Test: tap on home button while launching app from overview
Change-Id: I2a00b86b602b5dd12c901433b92adcf0170be15e
(cherry picked from commit e4a9469156)
2021-08-23 19:22:02 +00:00
TreeHugger Robot 70dd01be85 Merge "Fix NPE when converting final screen to empty screen." into sc-qpr1-dev 2021-08-19 15:30:20 +00:00
TreeHugger Robot 686d42a1d4 Merge "New app animation specs." into sc-qpr1-dev 2021-08-19 00:45:05 +00:00
Jon Miranda bda98de9f8 New app animation specs.
- New values and interpolators.

Bug: 173107751
Test: open apps from different parts of the home screen
Change-Id: I81bec0221aec9c04dac0bb3e926c879999699e57
2021-08-18 18:26:46 +00:00
Lucas Dupin 482f983a7b Add depth to -1 screen
Wallpaper will zoom out as you drag the overlay

Test: manually pull overlay
Fixes: 192502999
Change-Id: I9067b70d10497d4e16a5ef601161fbedfa9307e1
Merged-In: I9067b70d10497d4e16a5ef601161fbedfa9307e1
(cherry picked from commit 87d752062e)
2021-08-18 15:34:45 +00:00
TreeHugger Robot 8782ad4f99 Merge "Fixing ModelPreload cancelling existing load" into sc-qpr1-dev 2021-08-18 05:09:49 +00:00
Bill Yi e0b69a2ae5 [automerger skipped] Merge "Import translations. DO NOT MERGE ANYWHERE" into sc-dev am: 3b8415e58a -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15595326

Change-Id: I9d66bd5008a21418a1e061329c1dcb20ea0c91ed
2021-08-17 22:23:00 +00:00
Bill Yi 0610d4c802 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: cea66b3a81 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15595229

Change-Id: If74688fff1cbeb04de75f0da8908642d485c4186
2021-08-17 22:22:24 +00:00
Bill Yi 3b8415e58a Merge "Import translations. DO NOT MERGE ANYWHERE" into sc-dev 2021-08-17 22:05:47 +00:00
TreeHugger Robot 5baa4e8c45 Merge "Import translations. DO NOT MERGE ANYWHERE" into sc-qpr1-dev 2021-08-17 19:54:28 +00:00
Bill Yi f07084c8f4 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I2e99b63e1092bd252b2052280d05e765cbe799ac
2021-08-17 02:16:14 -07:00
Bill Yi c864f6c50e Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I7fb2cb94cefd0abab06ebaf0f6a54d5ef2b225aa
2021-08-17 02:15:20 -07:00
Bill Yi af65b6d3d2 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I945a5fbf0a31fe983fe20c6f173d80e6d9423e26
2021-08-17 02:11:45 -07:00
Bill Yi cea66b3a81 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I1827e8d2469c9c7993b5b15ea5a964e1fa562dbb
2021-08-17 02:11:04 -07:00
Jon Miranda 26de7be984 Fix NPE when converting final screen to empty screen.
Bug: 194553613
Test: manual
Change-Id: Id29b8574964688f6f6aa96dd5b1b8a4d8b9110c0
2021-08-16 16:47:11 +00:00
Sunny Goyal 57e0866fdd Fixing ModelPreload cancelling existing load
When a model preload call was made while the loader task is running
(eg: on enabling/disabling icon theme, Launcher reloads and then
launcher preview start a model-preload), it would cancel the original
loader and then start a new loader with empty callbacks. So the
model indeed get loaded, but the original callbacks never got notified
of it.

> Instead we only start preload if an existing task is not running.
> Also when preloading, we use existing callbacks, instead of using
  empty callbacks

Bug: 193851085
Bug: 195155924
Test: Verified repro steps
Change-Id: I0a96310be8489756f364aa2a12e4345e1418733d
2021-08-12 21:33:33 +00:00
Brian Isganitis e52a4e39af Merge "Update preferences to Material Next styling" into sc-qpr1-dev 2021-08-12 18:57:49 +00:00
TreeHugger Robot 3be0173b14 Merge "Adjust all apps zoom level" into sc-dev am: 6b10f4649c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15530106

Change-Id: Id2a24af3aed6fa4819a2fc46c8a305b06ff31d84
2021-08-12 00:31:19 +00:00
TreeHugger Robot 6b10f4649c Merge "Adjust all apps zoom level" into sc-dev 2021-08-12 00:09:14 +00:00
Steven Ng 8facf46000 Fix pending restore widget touch issue am: bdffb53843
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15517689

Change-Id: Ie1cd0fccfcb7377853f326e6e0476c3ec08be97a
2021-08-11 23:49:30 +00:00
Steven Ng bdffb53843 Fix pending restore widget touch issue
After http://ag/14980850, we block updateAppWidget until app widget
is restored. However, PendingAppWidgetHostView constructor relies
on updateAppWidget(null) to trigger set listener in getDefaultView().
We should call super.updateAppWidget(null) in the constructor instead.

Test: manual
Bug: 14980850
Change-Id: I30af9778a636af2ad822e7abc152b6f0bfdea1bf
2021-08-11 22:40:06 +01:00
Lucas Dupin 3f6a4e6bf5 Adjust all apps zoom level
The All Apps scrim fades in early, covering part of the zoom animation.
We need to adjust the max zoom in order to make All Apps consistent with
Overview, -1, and Shade.

Test: pull up the all apps drawer
Fixes: 195992422
Change-Id: Ia7bbe17fe7f227dd0a16ba7d21b402cff57176f0
(cherry picked from commit f168bb7aaf)
2021-08-11 15:55:04 +00:00
Thales Lima 931bc2a38e navigation: don't run gesture animation if gestures are not enabled
Makes the animation when using 3 button navigation be closer to what we
have in non fallback mode, also fixing the problem when fallback recents
just started and don't have any views.

Fix 194487871
Test: manual with gestures, 2 button and 3 button nav

Change-Id: If3925d6bef1d14f51b86169d06607786972f5f1f
(cherry picked from commit 8d49c4bb29)
2021-08-11 10:26:22 +00:00
Brian Isganitis ec8a994d54 Update preferences to Material Next styling
There should be enough free space to merge this change into S V2.

Test: Settings root, all apps, and about have new style on S
Bug: 187732263
Fix: 188254205, 188012913
Change-Id: I346bbf819f3fe1eb13b47125b53c15baab11e439
Merged-In: I346bbf819f3fe1eb13b47125b53c15baab11e439
2021-08-10 23:29:54 +00:00
Tony Wickham 0b3b2921c3 Don't recreate touch controllers when ending gesture
Test: swipe up to overview from an app and swipe up to dismiss it during the transition
Bug: 189700453
Change-Id: I303696f90dbb236ea93e06d94a3c92d783850fa4
(cherry picked from commit 0e9ecaeea8)
2021-08-10 23:26:33 +00:00
Bill Yi be96e2e3e5 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 8bc9c6355a -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15505516

Change-Id: I56065f18ab7ede2373c279263ef8bf6abc53ca98
2021-08-10 19:39:12 +00:00
Bill Yi 8bc9c6355a Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I8a0be2eb6ceb321440efdf75d2b8f6232de201fe
2021-08-09 22:32:00 +00:00
Jonathan Miranda dd16ecbc61 Merge "Update extra space allocations for taller devices." into sc-dev 2021-08-05 18:33:56 +00:00
TreeHugger Robot 9d5749fd7f Merge "Import translations. DO NOT MERGE ANYWHERE" into sc-dev 2021-08-05 03:03:29 +00:00
TreeHugger Robot a85c40ebd6 Merge "Import translations. DO NOT MERGE ANYWHERE" into sc-dev 2021-08-05 02:53:48 +00:00
Brian Isganitis 200d7634d1 Merge "Fix crash from previewing launcher with unknown wallpaper colors." into sc-dev 2021-08-05 01:08:00 +00:00
Bill Yi 315b29c87e Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Id83c1f3b8772c671e8a8836da2435f75d21cf40e
2021-08-04 22:16:53 +00:00
Bill Yi ff049aae0f Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I8da912b3e7ec23e63a5c1436773cd86b8cb8dffc
2021-08-04 22:14:26 +00:00
Steven Ng 5fc53cbc22 Merge "Don't delete widgets that violate min size requirement" into sc-dev 2021-08-04 20:15:45 +00:00
Jon Miranda a56cb84141 Update extra space allocations for taller devices.
- Take less space from cells
- Distribute some of the empty space above the workspace
- Already confirmed from previous testing that these thresholds
  only affect taller devices

Bug: 194688362
Test: long press on app icons,
      test drag and drop bounds
      test drop target bounds
      test folder opening bounds
      test all grids on taller devices

Change-Id: If90b7663ab4afedca1193bdd73a0ae38a1f25243
2021-08-04 12:00:36 -07:00
Brian Isganitis dafa5040ef Fix crash from previewing launcher with unknown wallpaper colors.
Test: Open wallpaper app with live wallpaper applied should not crash.
Fix: 195246865
Change-Id: Id64de32b35aa7a553daa752438060d7f6822bec8
2021-08-04 18:31:20 +00:00
Steven Ng b269cc5150 Don't delete widgets that violate min size requirement
Test: Manual
Bug: 194766124
Change-Id: I4713e65e27da23d833bb60fb556ae8924a63e305
2021-08-04 11:14:09 +01:00
Tracy Zhou 25399db1e7 Merge "[DO NOT MERGE] Disable live tile in split mode for S" into sc-dev 2021-08-03 21:50:06 +00:00
Tracy Zhou 145bd74749 [DO NOT MERGE] Disable live tile in split mode for S
Recall link: https://recall.googleplex.com/projects/debb8388-5e38-42c5-99ab-20bdfb92d25e/sessions/655af962-b4bd-4dc4-93aa-178852c0d701

Bug: 193991436
Test: enter split screen and swipe up
Change-Id: I7adffcdefb12d225db207542716a436f29df0377
2021-08-03 20:50:27 +00:00
vadimt 21091ada88 Logging to figure out why first dump didn't result in assertion
Bug: 195319692
Test: presubmit
Change-Id: I4a80541a58eb8f630211de4b90836c435f6d41b2
2021-08-03 18:47:35 +00:00
Jonathan Miranda 4a17e66166 Merge "Add more restrictions on whether we increase the hotseat size for tall devices." into sc-dev 2021-07-30 20:37:29 +00:00
Alex Chau e20208e9d1 Merge "Always treat FallbackRecentsView as visible if isInLiveTileMode is true" into sc-dev 2021-07-30 17:53:34 +00:00
Alex Chau fb5ae9060d Always treat FallbackRecentsView as visible if isInLiveTileMode is true
- activity.hasBeenResumed is no longer an accurate indicator after live tile has been introduced, indeed it's always false
- Return recentsView regardless if there is a runningTask as well

Bug: 194286330
Test: In fallback Recents with 3 button, tap overview button from home screen, then tap overview button again. Try combination with back and home button
Change-Id: Ib2775a11f5466abc433763f24192e7bfdcf191a2
(cherry picked from commit 455718e842)
2021-07-30 08:22:03 +00:00