Commit Graph

12553 Commits

Author SHA1 Message Date
Mateusz Cicheński 4573658e7b Merge "Remove enable_pip_keep_clear_algorithm flag" into udc-qpr-dev 2023-08-17 18:27:21 +00:00
Wei Sheng Shih e457c6d5bb Merge "Fix NPE crash when using MockProperties" into udc-qpr-dev am: e6866f3f32
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24458447

Change-Id: I3eeafd70e622d6696ac82a7d4ae16a1e748d8dd9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-17 06:46:24 +00:00
Wei Sheng Shih e6866f3f32 Merge "Fix NPE crash when using MockProperties" into udc-qpr-dev 2023-08-17 06:34:03 +00:00
wilsonshih 6df52eb6f9 Fix NPE crash when using MockProperties
Override the setShow method in MockProperties as it is used for invalid
surface.

Bug: 295775097
Test: build
Change-Id: Id601fa3ce7408f236c77e41ccd60b7d8359c2e8c
2023-08-17 12:09:33 +08:00
Sunny Goyal 746613f591 Merge "Using CUJ_APP_CLOSE_TO_HOME_FALLBACK when fallback animaiton is playing" into udc-qpr-dev am: c480860744
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24448719

Change-Id: Ifc40189607fa0c02c6ff7ad14b853af460cac6d4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-17 00:26:46 +00:00
Sunny Goyal c480860744 Merge "Using CUJ_APP_CLOSE_TO_HOME_FALLBACK when fallback animaiton is playing" into udc-qpr-dev 2023-08-16 23:36:10 +00:00
Jagrut Desai e6a895ed6c Correcting Taskbar Icon Layout bounds when Taskbar Divider is present
- Breakout CL part 2
- This is a breakout cl from ag/24272821 to make it more readable and atomic.
- This cl consist of change to correct the icon layout bound calculation when taksbar divider line is present in taskbar view.

Test: Manual, Visual
Bug: 265170176
Flag: ENABLE_TASKBAR_PINNING
Change-Id: I259faf2cc0aa302b83337d104c4820885b925a6a
2023-08-16 13:50:08 -07:00
Treehugger Robot f4bbe54f97 Merge "Revert "Prevent setting mIsStashed in TaskbarStashController"" into udc-qpr-dev am: 12cd6076d3
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24447385

Change-Id: I9719eb5349bc4a0cbbfde7383c11d3b56d5f4077
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-16 20:43:49 +00:00
Jagrut Desai 579188aee0 Refactor taskbar divider view to IconButtonView
- Breakout CL part 1
- This is a breakout cl from ag/24272821 to make it more readable and atomic.
- This cl consist refactoring of Taskbar Divider Line to be using IconButtonView.

Test: Manual, Visual
Bug: 265170176
Flag: ENABLE_TASKBAR_PINNING
Change-Id: I6719dd568986dce7cf9cdf0f287c3f079fd35ba6
2023-08-16 13:11:14 -07:00
Treehugger Robot 12cd6076d3 Merge "Revert "Prevent setting mIsStashed in TaskbarStashController"" into udc-qpr-dev 2023-08-16 20:03:00 +00:00
Sunny Goyal 57a83b5732 Using CUJ_APP_CLOSE_TO_HOME_FALLBACK when fallback animaiton is playing
Bug: 281873427
Test: N/A
Flag: N/A
Change-Id: I7745b8b7d7b48fa5a4f58e8db7e99865226e81d5
2023-08-16 12:30:27 -07:00
Vinit Nayak a725e48879 Revert "Prevent setting mIsStashed in TaskbarStashController"
This reverts commit 51a210d787.

Reason for revert: test may have been fixed before this got merged, will merge revert to confirm

Change-Id: Ib26b94af971eceb02e6bf58f39a578ee04eb72e8
2023-08-16 18:45:51 +00:00
Mateusz Cicheński 23ed054a6d Remove enable_pip_keep_clear_algorithm flag
Bug: 296239520
Test: presubmit, removing flag
Change-Id: I135d4b5fedaf094dd136924655d55c70616fa838
2023-08-16 17:55:14 +00:00
Hongwei Wang 247a2cfe03 Merge "Cleanup ENABLE_PIP_APP_ICON_OVERLAY" into udc-qpr-dev am: 3ca497b646
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24435526

Change-Id: I59f4e0f1051b5f96c7a5e4d3834ccb497cb31711
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-16 17:22:07 +00:00
Hongwei Wang 7aded94e94 Cleanup ENABLE_PIP_APP_ICON_OVERLAY
Bug: 296125301
Test: manual, enter PiP from Google Maps
Change-Id: I571fd5450ccf00232c450d82d32783beb99cfecf
2023-08-15 15:44:39 -07:00
mattsziklay 56329b03cf Create IconView for generated TaskIdAttributeContainers.
When creating a TaskIdAttributeContainer for a desktop task, creates an
IconView to avoid an NPE when picking a desktop app as the second split
target (see TaskBarUIController#triggerSecondAppForSplit).

Test: Select an app open in Desktop Mode as the second split target.
Bug: 279586624
Change-Id: I1949d923523b6e9e6112b3e909edf1e8d632b3e2
2023-08-15 10:06:05 -07:00
Sunny Goyal 0ae8f5c91d Merge "Removing some unused overrides in Launcher" into udc-qpr-dev am: 12bf58feb9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24407042

Change-Id: I113cc9bb779a3d09d1e2914c85d249695ffba931
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-14 21:02:39 +00:00
Sunny Goyal 12bf58feb9 Merge "Removing some unused overrides in Launcher" into udc-qpr-dev 2023-08-14 20:40:28 +00:00
Colin Cross efada45adf Merge "Fix kotlin nullable errors in Launcher3" into udc-qpr-dev-plus-aosp 2023-08-14 17:55:18 +00:00
Treehugger Robot 1c4cb11662 Merge "Add relayout debug support in Launcher" into udc-qpr-dev 2023-08-14 09:43:51 +00:00
Nicolo' Mazzucato 93e7e4b1c0 Add relayout debug support in Launcher
This adds support for measure/layout tracing in Launcher (in sysui it has already been enabled in T)

When enabled, traces for each class measure and layout are output in
a perfetto trace. This adds some overhead, so it's disabled by default, but extremely useful for testing and debugging long doFrames.

To enable request layout tracing for a specific class X, the following helper can be used:

trace_class_layouts() {
        adb shell setprop persist.debug.trace_request_layout  1
        adb shell setprop persist.debug.trace_request_layout_class $1

        adb shell am force-stop com.google.android.apps.nexuslauncher
        adb shell am force-stop com.android.systemui
}

Then, use `trace_class_layouts X` and record a perfetto trace
e.g. `trace_class_layout BubbleTextView`

To just see class breakdown of measure/layout setting `persist.debug.trace_request_layout` is sufficient.

Test: record a trace after enabling options
Bug: 266090955
Change-Id: I4f621ebaaec6a07cd7c0693aa8876158cc60e208
2023-08-14 08:18:27 +00:00
Vinit Nayak 8488a7e757 Merge "Animate Split invocation with shell transitions" into udc-qpr-dev 2023-08-11 22:29:59 +00:00
Vinit Nayak 6458c11699 Animate Split invocation with shell transitions
* SplitRoot1/2 and the split left/right roots, but
they also have a parent that's the top-most split root.
* We have to explicitly set the alpha on top most parent
for animations on children to be visible
* This path wasn't being used even w/ shell transitions
enabled but became active after ag/24346391

Test: Launch split from overview and workspace
Flag: None
Bug: 276361926
Change-Id: I267dccbf3402af9b0972371b856a79b7785f986c
2023-08-11 12:59:18 -07:00
Sunny Goyal c1d1e68a82 Removing some unused overrides in Launcher
> Changing AddItemActivity to use RemoteAnimation directly
  to avoidTransitionManager override

Bug: 273828110
Test: Manual
Flag: N/A
Change-Id: I49777e7eeba00319476b0a239bc1cdac37833457
2023-08-11 12:31:49 -07:00
Vinit Nayak f49367cd96 Merge "Prevent setting mIsStashed in TaskbarStashController" into udc-qpr-dev 2023-08-11 18:32:43 +00:00
Colin Cross abf18e9c03 Fix kotlin nullable errors in Launcher3
Fix kotlin nullable errors that were exposed by setting the retention
of android.annotation.NonNull and android.annotation.Nullable to
class retention.

This relands I26edfec35dca14abe90b08e3c74de0446eda95d2 with a fix in
SplitSelectDataHolder.kt to call createPackageContext when user is null
instead of asserting that it is not null.

Bug: 294110802
Test: builds
Test: WMShellFlickerServiceTests
Change-Id: I4525d0fa83a1db9cc5cff90f340fc3f863537c01
2023-08-11 11:28:54 -07:00
Colin Cross 7b5878e03e Fix kotlin nullable errors in Launcher3
Fix kotlin nullable errors that were exposed by setting the retention
of android.annotation.NonNull and android.annotation.Nullable to
class retention.

Bug: 294110802
Test: builds
Change-Id: I26edfec35dca14abe90b08e3c74de0446eda95d2
Merged-In: I26edfec35dca14abe90b08e3c74de0446eda95d2
2023-08-10 11:16:55 -07:00
Brian Isganitis c4247d85b4 Merge changes from topic "taskbar-search-ime" into udc-qpr-dev
* changes:
  Support customizing open-close PendingAnimation for Taskbar search.
  Animate AbstractSlideInView translation shift with PendingAnimation.
2023-08-10 16:10:39 +00:00
Schneider Victor-tulias 087990668b Merge "Update All Set page vibrations on large screens" into udc-qpr-dev 2023-08-10 13:49:17 +00:00
Brian Isganitis a7ee532d47 Support customizing open-close PendingAnimation for Taskbar search.
Test: Manual
Bug: 289290185
Flag: No
Change-Id: I9f076875c4bd13c98a3ace8c02d512defa013fdf
2023-08-09 22:23:43 +00:00
Brian Isganitis 0a036e9c15 Animate AbstractSlideInView translation shift with PendingAnimation.
The PendingAnimation gives us more flexibility than the AnimatorSet.

Test: Manual
Bug: 289290185
Flag: No
Change-Id: I3156a659098c44ce9e6b20e5e79e88742add629a
2023-08-09 22:23:41 +00:00
Vinit Nayak 51a210d787 Prevent setting mIsStashed in TaskbarStashController
* Partial revert of ag/24139629
* Taskbar showing up where it shouldn't in gesturenav,
this change isn't behind the flag

Bug: 295047555
Change-Id: Ib36b1fed5e25c667e396291a30a68730e1daa517
2023-08-09 12:28:44 -07:00
Tracy Zhou 59aa5e696b Merge "Fix nav buttons in task bar disppearing when unfolding from landscape small screen" into udc-qpr-dev 2023-08-09 17:46:27 +00:00
Tracy Zhou a7e48fa6d7 Fix nav buttons in task bar disppearing when unfolding from landscape small screen
Previously we reuse layout params when we switch to a new layout, but not all of the fields we reuse are reset. Due to the variety of fields we update in different layouts and the fact that it's relatively cheap to instantiate a new layout params object, let's start fresh every time.

Fixes: 295057715
Bug: 288311605
Test: put the device to landscape in small screen and then unfold, make sure that the nav buttons show in the task bar
Change-Id: I8e600c2553436f563dd4509a83cc46ce47c0114d
2023-08-09 17:37:38 +00:00
Matt Sziklay aad3a8e34f Merge "Allow split select transition from desktop mode." into udc-qpr-dev 2023-08-09 17:26:48 +00:00
mattsziklay 95c85034ea Allow split select transition from desktop mode.
Introduces a new controller to manage an app entering split select mode
from desktop mode.

Video: http://recall/-/gjymLwjdDT07aWqaK6101a/gU56zTDcWov6ukbKuH8tFx
Flag: ENABLE_SPLIT_FROM_DESKTOP_TO_WORKSPACE
Bug: 286550932
Bug: 279586624
Test: Manual

Change-Id: Ib94402553c88286894d94c95c38cac125be23a0d
2023-08-09 17:23:03 +00:00
Brian Isganitis 18dd200832 Merge "Launch Taskbar All Apps with Meta key when it's available." into udc-qpr-dev 2023-08-09 17:15:12 +00:00
Randy Pfohl 6ff6c00b26 Merge "Adding minimal logs to investigate overview floating bug" into udc-qpr-dev 2023-08-08 22:11:19 +00:00
Andy Wickham c15fd5c248 Merge "Revert^3 "Change Overview Actions to round buttons."" into udc-qpr-dev 2023-08-08 20:58:04 +00:00
Vinit Nayak 6682d58d0a Merge "Move splitInstructionsView reference out of RecentsView" into udc-qpr-dev 2023-08-08 20:40:57 +00:00
Brian Isganitis a8ad7e448c Launch Taskbar All Apps with Meta key when it's available.
Taskbar All Apps will be chosen over Launcher's when we are in an app or
in overview. Otherwise, we fallback to toggling Launcher All Apps.

Test: Manual, adb shell input keyevent 117
Fix: 282111244
Flag: ENABLE_ALL_APPS_SEARCH_IN_TASKBAR
Change-Id: I68e4cb3a80d42e233f7d9ad33fc3791b5c75d219
2023-08-08 19:32:02 +00:00
Andy Wickham bc3bac4113 Revert^3 "Change Overview Actions to round buttons."
Awaiting UX alignment.

Test: N/A
Flag: N/A
Change-Id: I05e9627d8b44ea16d29445e005534af2a1abd439
2023-08-08 12:09:59 -07:00
Jeremy Sim 6390654526 Merge "App Pairs: Implement save, inflate, launch, and delete" into udc-qpr-dev 2023-08-08 00:56:04 +00:00
Tracy Zhou ed96865005 Merge "Center taskbar nav buttons in small screen" into udc-qpr-dev 2023-08-08 00:12:54 +00:00
Vinit Nayak 257bb9641e Move splitInstructionsView reference out of RecentsView
* Consolidate it to be same object as workspace
SplitInstructionsView

Bug: 276361926
Test: Created split from home and overview, disapears
on exit or success as expected

Change-Id: I837a7c37fb4d1a39c13fe0d66b2e3ecefedef2df
2023-08-07 15:29:50 -07:00
Treehugger Robot 77204f4608 Merge "Add better logging around long launcher operations during unfold" into udc-qpr-dev 2023-08-07 17:25:05 +00:00
Treehugger Robot 93e088dc1c Merge changes Ifa66cfb7,Ied7867fb into udc-qpr-dev
* changes:
  Add dynamic thresholds for taskbar based on screen size.
  Add ENABLE_DYNAMIC_TASKBAR_THRESHOLDS feature flag.
2023-08-07 16:27:36 +00:00
Nicolo' Mazzucato e120fcfa47 Add better logging around long launcher operations during unfold
This logging helps understanding what's going on in Launcher main thread
 during unfold from perfetto traces.

Test: Perfetto trace after unfolding
Bug: 292472402
Change-Id: I7a037d9a129deb4bfe4310fdba664b87164ef2ca
2023-08-07 12:18:10 +00:00
Tracy Zhou dcae0e86ac Center taskbar nav buttons in small screen
Bug: 288311605
Test: All the buttons are in centered in all orientations
Change-Id: Ibb9dc57e38a2e61c426f1edfbf771634d5e3cbb1
2023-08-06 21:03:04 -07:00
Tracy Zhou b7cd64d5b7 Merge "Update nav button color when nav button layout changes" into udc-qpr-dev 2023-08-05 07:01:07 +00:00