PawletOS/Lawnchair
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
78,380 Commits 1 Branch 0 Tags
6bb9d56ded70fed1335b36d3bc5fd99208990936
Commit Graph

12553 Commits

Author SHA1 Message Date
Andy Wickham 04f5b767c2 Rename AssistUtilsBase -> AssistUtils am: b2ac210120 am: a8c9d7161f 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24555400

Change-Id: I5d17902c7fe76dcdd07728fc4c7935e68aec82f4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-08-28 20:17:58 +00:00
Treehugger Robot a3f7992c84 Merge "Cap the width of the bubble bar when collapsed" into udc-qpr-dev am: dddd60e84f am: dc1b080293 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24446027

Change-Id: I21ee0ac1a10c9769e9091d2743fdcc88fe64f0a1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-08-28 19:32:21 +00:00
Vinit Nayak db248cf94f Move ending CUJ_SPLIT_SCREEN_ENTER to after we show tasks to user 
* Previously the CUJ was ending after only the launcher side
animation was completing, before we actually made the
call into shell to launch the tasks

Test: Compiles (no baseline to test metrics/latency off of)
Bug: 285578568
Change-Id: I958e4a5265cb2fd81f2358343846385058b4465a
 2023-08-28 19:03:39 +00:00
Vinit Nayak bb9fe16254 Revert "Revert "Hold WeakReference to split callback"" 
This reverts commit 06be7eb88e.

Reason for revert: Potential forward fix with ag/24562796

Change-Id: I1f01dda728491e627ec0cc34fd364cbd794854d5
 2023-08-28 17:07:03 +00:00
Treehugger Robot 5cf32b27d0 Merge "Revert "Hold WeakReference to split callback"" into main 2023-08-25 22:23:38 +00:00
Matt Sziklay a5e28a3af2 Merge "Specify stage and bounds for desktop split." into udc-qpr-dev am: 8020100928 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24376138

Change-Id: I38e200140074f2f2ee3dd4ffa5068babb1886e96
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-08-25 21:50:24 +00:00
Andy Wickham a8c9d7161f Rename AssistUtilsBase -> AssistUtils am: b2ac210120 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24555400

Change-Id: Idde965260aef41cd3fe662557051ccc92418e8c0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-08-25 21:49:54 +00:00
Vinit Nayak 06be7eb88e Revert "Hold WeakReference to split callback" 
This reverts commit 3f5e3ad419.

Reason for revert: b/297562709

Change-Id: I889d126e622e9cf13513365145eac28eaefa8627
 2023-08-25 20:52:45 +00:00
Matt Sziklay 8020100928 Merge "Specify stage and bounds for desktop split." into udc-qpr-dev 2023-08-25 20:50:59 +00:00
Andy Wickham b2ac210120 Rename AssistUtilsBase -> AssistUtils 
Bug: n/a
Test: n/a
Flag: n/a
Change-Id: Ia227b180732d0acfdc4b648885d5ce208d86ee49
 2023-08-25 12:12:17 -07:00
Treehugger Robot 061c9b2542 Merge "Hold WeakReference to split callback" into main 2023-08-25 17:53:56 +00:00
Treehugger Robot dc1b080293 Merge "Cap the width of the bubble bar when collapsed" into udc-qpr-dev am: dddd60e84f 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24446027

Change-Id: If09506013aaf6cfe5249c7948216c6f675cb859d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-08-25 15:34:29 +00:00
Treehugger Robot dddd60e84f Merge "Cap the width of the bubble bar when collapsed" into udc-qpr-dev 2023-08-25 15:07:56 +00:00
Tracy Zhou 1d71563b56 Merge "Ignore touch slop threshold for trackpad gestures using gesture nav" into udc-qpr-dev am: 17f50eb8a8 am: 5f37111e05 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24542608

Change-Id: I0cd151ce2d05cb654c8b54f74f051928ad991293
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-08-25 06:06:47 +00:00
Tracy Zhou 5f37111e05 Merge "Ignore touch slop threshold for trackpad gestures using gesture nav" into udc-qpr-dev am: 17f50eb8a8 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24542608

Change-Id: Ie8ad90ddb686f684cdb424e0f7c74f05bca1a31c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-08-25 05:23:35 +00:00
Tracy Zhou 17f50eb8a8 Merge "Ignore touch slop threshold for trackpad gestures using gesture nav" into udc-qpr-dev 2023-08-25 04:29:58 +00:00
Tracy Zhou a2227658db Ignore touch slop threshold for trackpad gestures using gesture nav 
Gesture library has a threshold for 3-finger swipes, and if it's recoginized as one, it only reports movement in one axis. There is no point waiting for it to pass the initial threshold, unlike gestures on the screen.

Bug: 291771975
Test: swipe up slowly, observe the smoothness of the gesture nav animation.
Change-Id: I0904efb1d5cd26f6566da46279d0153e19a9618c
 2023-08-24 18:29:44 -07:00
Merissa Mitchell a779330a56 Fix NPE from NavbarButtonsViewController on FEATURE_PC devices. 
When FEATURE_PC is enabled on a device,
DesktopNavbarButtonsViewController is instantiated. Previously,
DesktopNavbarButtonsViewController saves an internal copy of
mControllers and the mControllers field in NavbarButtonsViewController
is left unset. This was not a problem because mControllers in
NavbarButtonsViewController was not used in any code that was not
overridden by DesktopNavbarButtonsViewController.

ag/17944073 added some code that accesses mControllers in
NavbarButtonsViewController. Even though the code would be skipped for
FEATURE_PC devices (due to the TaskbarUIController check, which is
overridden by DesktopTaskbarUIController) in the end, it still caused an
NPE.

DesktopNavbarButtonsViewController does not require most of the button
updates done in NavbarButtonsViewController. Regardless, this CL
provides a workaround to avoid the NPE by setting mControllers in
NavbarButtonsViewController in FEATURE_PC devices.

Bug: 296623609
Bug: 297260211
Test: Manual; build and launch sdk_gpc emulator. Ensure that no crash
occurs

Change-Id: Ica22359b96fd0a277c575a238abb194d762e81ea
 2023-08-24 17:22:48 -07:00
Treehugger Robot fd77e2350a Merge "Adding support for clearing overview suggestion state when overview is disabled" into udc-qpr-dev am: 830524d883 am: 646722fdaf 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24516473

Change-Id: If42b71351fa049457d4660f56dde56a9a375c6d5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-08-24 23:27:38 +00:00
Treehugger Robot 646722fdaf Merge "Adding support for clearing overview suggestion state when overview is disabled" into udc-qpr-dev am: 830524d883 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24516473

Change-Id: I74804233367ebab71086b6f6f0d27c881f8927e5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-08-24 22:44:29 +00:00
Vinit Nayak ddc9d5eb73 Merge "Add back gesture support when split selection active" into main 2023-08-24 22:27:39 +00:00
Treehugger Robot 830524d883 Merge "Adding support for clearing overview suggestion state when overview is disabled" into udc-qpr-dev 2023-08-24 22:19:01 +00:00
Mady Mellor dd1b2af955 Merge "Set a view id for the bubble dismiss view (launcher)" into main 2023-08-24 21:48:52 +00:00
Andy Wickham ce2f0de10f Merge "Use new AssistUtils(Base) to override SysUI Assist invocations." into udc-qpr-dev am: 5ed1b4001b am: 77baaf6f25 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24454133

Change-Id: If7c2b5051faa713baa3aed6cee8c5d1f44fa5594
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-08-24 20:10:53 +00:00
Andy Wickham 77baaf6f25 Merge "Use new AssistUtils(Base) to override SysUI Assist invocations." into udc-qpr-dev am: 5ed1b4001b 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24454133

Change-Id: I90a87cf156213c2dfad374f3410f9ac766b69711
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-08-24 20:05:48 +00:00
Andy Wickham 5ed1b4001b Merge "Use new AssistUtils(Base) to override SysUI Assist invocations." into udc-qpr-dev 2023-08-24 19:36:12 +00:00
Vinit Nayak 3f5e3ad419 Hold WeakReference to split callback 
Bug: 297135374
Change-Id: I6763cd56fe25735998bf11ec9c682831b5d80beb
 2023-08-24 18:55:06 +00:00
fbaron 6707ddd016 Add logs around hotseat suggested apps 
Bug: 295892343
Test: n/a
Flag: no flag
Change-Id: Id6f464c8614317f58f6886734ad1f9b9709d6aa3
 2023-08-24 11:15:46 -07:00
Vinit Nayak 654604037a Add back gesture support when split selection active 
* Currently this exits the current launcher state
back to homescreen whenever back is performed while
split selection is active.
* Open UX question if that needs to be changed.

Test: Did back gesture from workspace, overview, all apps
http://recall/-/cMb5xTTxhmZtFt04eYnmQj/g0kpGTsqlj0RSt4OfDBkpf
Bug: 295449659
Flag: ENABLE_SPLIT_FROM_WORKSPACE_TO_WORKSPACE
Change-Id: I74fe51aaf4301fb723d2e69e6b1b39d127f492d8
 2023-08-24 17:52:37 +00:00
Andy Wickham f7554ff718 Use new AssistUtils(Base) to override SysUI Assist invocations. 
AssistUtils#getSysUiAssistOverrideInvocationTypes(): Sent
over SysUiProxy to request overriding these invocation types.

AssistUtils#tryStartAssistOverride(): Called by OverviewProxy
(TouchInteractionService) for previously requested overrides.
Also used within Launcher for Taskbar and QSB to override
other invocation logic. May return false to indicate that
the override was not handled, so a fallback may be desired.

Bug: 295874732
Test: Manual
Change-Id: I488f3b7da1feb2663feab5d04dfa8d605c070efb
 2023-08-23 15:49:02 -07:00
Liran Binyamin a624495513 Merge "Handle touches on the bubble bar in Overview" into udc-qpr-dev am: 5e7ca0c0b3 am: 8482a8d7b6 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24512108

Change-Id: I5d0740b6b25968212199fd3f383e78e38ca68afd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-08-23 20:03:06 +00:00
Treehugger Robot 52b0632649 Merge "Taskbar: use ENABLE_HIDE_IME_CAPTION_BAR" into udc-qpr-dev am: 7c183e2987 am: 5137e0561c 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24511367

Change-Id: Icd169ccf8dfb6f60d06b50a3151fb37828225958
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-08-23 19:59:55 +00:00
Liran Binyamin 8482a8d7b6 Merge "Handle touches on the bubble bar in Overview" into udc-qpr-dev am: 5e7ca0c0b3 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24512108

Change-Id: I76d072fbf6bad5d0b779b8a753e934ccb23a8ec2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-08-23 19:15:22 +00:00
Treehugger Robot 5137e0561c Merge "Taskbar: use ENABLE_HIDE_IME_CAPTION_BAR" into udc-qpr-dev am: 7c183e2987 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24511367

Change-Id: I8eb92f31d8a02603e38f78263425803d232d957e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-08-23 19:11:41 +00:00
Randy Pfohl 73a7064c1a Merge changes I3394267d,Idf9ef20e into udc-qpr-dev am: f18305ac08 am: e50232a877 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24503147

Change-Id: I2a156efb7dd5acd749f5dfc75e87d5e5cd9a6f17
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-08-23 18:24:25 +00:00
Vinit Nayak e2b8dcab77 Merge "Null out Activity in split controller" into udc-qpr-dev am: 0989216160 am: 87f6c0aed6 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24503472

Change-Id: Ie9425a34a99418852eb352e0d7da71a935f33674
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-08-23 18:22:26 +00:00
Pat Manning 8eff50626f Do not consume hover events not coming from cursor for a11y. am: c7087e8f9f am: e040d5be5b 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24446431

Change-Id: Ied5c4978242696d72b28987bd7633511819f721a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-08-23 18:10:28 +00:00
Treehugger Robot d91a5858a2 Merge "Clean up RECEIVE_UNFOLD_EVENTS_FROM_SYSUI flag" into udc-qpr-dev am: a5f24d709e am: 6c7fdd42cc 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24501121

Change-Id: Idc0265fc910f5e5ece0d9a97f2c09cf4a4a0c925
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-08-23 18:07:34 +00:00
Tracy Zhou 89e44432d4 Merge "Init nav mode in TaskbarActivityContext between fold/unfold" into udc-qpr-dev am: b038bac666 am: 5eae18306c 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24493282

Change-Id: I405d3817876db08d3c6156cae9b342c9e5456683
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-08-23 18:06:51 +00:00
Randy Pfohl e50232a877 Merge changes I3394267d,Idf9ef20e into udc-qpr-dev am: f18305ac08 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24503147

Change-Id: I88dbb4b6fd28916964b48ddbbe4dd13dab67a904
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-08-23 17:53:06 +00:00
Vinit Nayak 87f6c0aed6 Merge "Null out Activity in split controller" into udc-qpr-dev am: 0989216160 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24503472

Change-Id: Icb070c092a4097015a20eabaa7d755f7f2e157bc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-08-23 17:52:53 +00:00
Pat Manning e040d5be5b Do not consume hover events not coming from cursor for a11y. am: c7087e8f9f 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24446431

Change-Id: Ia46648d8d4ff9f338d5f21e910c540b45e154681
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-08-23 17:52:29 +00:00
Treehugger Robot 6c7fdd42cc Merge "Clean up RECEIVE_UNFOLD_EVENTS_FROM_SYSUI flag" into udc-qpr-dev am: a5f24d709e 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24501121

Change-Id: Ieb275c6a69efc1e061fd38a284b9218f61b18433
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-08-23 17:43:52 +00:00
Tracy Zhou 5eae18306c Merge "Init nav mode in TaskbarActivityContext between fold/unfold" into udc-qpr-dev am: b038bac666 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24493282

Change-Id: I3bfd26f70ba8b7b968c3a5fa610a59f458fd07b8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-08-23 17:42:00 +00:00
Liran Binyamin 90d3a422f8 Cap the width of the bubble bar when collapsed 
When the bubble bar is collapsed we now show at most 2 bubbles.

Fixes: 295020145
Test: Manual
      - Add 1 bubble to the bubble bar
      - Collapse bubble bar
      -- Observe that only that bubble is visible
      - Expand the bubble bar
      -- Observe that both that bubble and the overflow are visible
      - Add another bubble
      -- Observe that 2 bubbles are visible when collapsed
      - Add another bubble
      -- Observe that only the first 2 bubbles are visible when collapsed
Change-Id: I5f534f53eefe9a920b8b3258813d67d021c5f2a8
 2023-08-23 07:40:56 +00:00
Liran Binyamin 5e7ca0c0b3 Merge "Handle touches on the bubble bar in Overview" into udc-qpr-dev 2023-08-23 07:13:16 +00:00
Treehugger Robot 7c183e2987 Merge "Taskbar: use ENABLE_HIDE_IME_CAPTION_BAR" into udc-qpr-dev 2023-08-22 22:05:32 +00:00
Mady Mellor c62e37305d Set a view id for the bubble dismiss view (launcher) 
There is a flake in the drag to dismiss bubble test, I think it's
because sometimes it misses the dismiss target since the test drags
the bubble to the bottom of the screen instead of the target location.

In attempt to fix this I'm setting an ID on the dismiss target to
look up where it is on screen and drag the bubble to it directly.

Test: treehugger
Bug: 296933279
Change-Id: I7949aa0131020651214e9ebaa834dda8fc25971a
 2023-08-22 20:56:27 +00:00
Sunny Goyal 52a7f05681 Adding support for clearing overview suggestion state when overview is disabled 
Bug: 297037290
Test: Presubmit
Flag: N/A
Change-Id: I38f7fd38564c7c529cbd9aa5acead08b181b1b92
 2023-08-22 13:46:29 -07:00
Randy Pfohl f18305ac08 Merge changes I3394267d,Idf9ef20e into udc-qpr-dev 
* changes:
  Adding some logging to track test failure in post submit
  enable testWidgets for postsubmit for long term debugging
 2023-08-22 17:14:40 +00:00