Commit Graph

13651 Commits

Author SHA1 Message Date
Tony Wickham 503575a9e4 Merge "Distinguish mDragHandleProgress from mMidProgress" into ub-launcher3-qt-r1-dev
am: cfbdb91a7f

Change-Id: Id41c02c6543a4b0a12fc364e5c8e41dd6ccf9fc1
2019-07-24 12:57:34 -07:00
Sunny Goyal 6d9eed757f Merge "Using the first frame delay based on the display refresh rate instead of hardcoding it to 16ms" into ub-launcher3-qt-r1-dev
am: b7094fcf36

Change-Id: Icd4e52b33b33718cb91b2fd082d85637e820390f
2019-07-24 12:57:15 -07:00
Tony Wickham cfbdb91a7f Merge "Distinguish mDragHandleProgress from mMidProgress" into ub-launcher3-qt-r1-dev 2019-07-24 19:39:48 +00:00
TreeHugger Robot b7094fcf36 Merge "Using the first frame delay based on the display refresh rate instead of hardcoding it to 16ms" into ub-launcher3-qt-r1-dev 2019-07-24 19:32:17 +00:00
Jon Miranda e734efba8d Fix bug where rounded corners were being set despite being disabled.
Bug: 138117089
Change-Id: Icb852e2e07d80c45ad3406ef432b89720887fccf
2019-07-24 17:15:13 +00:00
Sunny Goyal 4e6c45bcd3 Using the first frame delay based on the display refresh rate instead of
hardcoding it to 16ms

> Creating a utility class for caching display property changes

Bug: 128940249
Change-Id: I6f9a214548de65bd1c8530508d665ee88312da4a
2019-07-24 10:12:37 -07:00
Winson Chung 3fc9a1cf69 Merging ub-launcher3-qt-r1-dev, build 5749827
Test: Manual

Bug:136282913 P1 Swipe up from Assistant Fulfillment Card Jank
Bug:137129923 P1 Pixel launcher is leaking memory
Bug:137161198 P1 Unable to pull notification panel down with a swipe on home screen
Bug:137253043 P1 "Pixel Launcher keeps stopping" when scrolling through recent apps
Bug:137487381 P1 Overview goes back to fullscreen when swiping up during transition
Bug:137836033 P4 Fail to stop music due to "Swipe failed to receive an event for the swipe end"
Bug:138152531 P2 [Android Q][04713598] Launcher test cases are failed
Bug:138236583 P1 Icon scale is wrong when dragging from all apps or folders
Bug:138251824 P1 Flake: want to switch from background to overview; Swipe failed to receive an event for the swipe end
Bug:138252347 P1 qt-r1-dev Pixel Launcher flag ENABLE_HINTS_IN_OVERVIEW is Disable by Default
Change-Id: Idd0e987d26e1ffc75cdb9f90e9c08c26bb8c6503
2019-07-23 20:54:13 -07:00
Winson Chung 73b4cf7bb2 Merge "Fix regression in assistant window handling" into ub-launcher3-qt-r1-dev
am: 0727d59576

Change-Id: I9fbde5b101705ad9254a6ba668ff079a4f15c41f
2019-07-23 17:29:14 -07:00
vadimt 443f05052c Merge "Adding debug tracing" into ub-launcher3-qt-r1-dev
am: 8578309f1b

Change-Id: If2f3b4d4a849e94449c4b06a567c12610547fc61
2019-07-23 17:28:32 -07:00
Winson Chung 0727d59576 Merge "Fix regression in assistant window handling" into ub-launcher3-qt-r1-dev 2019-07-24 00:12:28 +00:00
TreeHugger Robot 8578309f1b Merge "Adding debug tracing" into ub-launcher3-qt-r1-dev 2019-07-24 00:01:25 +00:00
Tony Wickham fbd77c48cc Distinguish mDragHandleProgress from mMidProgress
mMidProgress is intended to be the point at which we reach Overview when
swiping up and thus start scrimming it as All Apps shows above it. For
that reason, mMidProgress needs to match OverviewState's progress. In
contrast, the drag handle (accessibility arrow) can move up sooner to
avoid overlapping with the QSB; for this, we added mDragHandleProgress.

Bug: 136800511
Change-Id: I2825ff798707530420855257350e492b4b9b77dc
2019-07-23 16:58:45 -07:00
vadimt cd7b00853b Adding debug tracing
Bug: 138251824
Change-Id: Ibe3de964aeacbf83fd46cc53fda7d15c9401fe4d
2019-07-23 16:49:48 -07:00
Winson Chung 48ba8c864c Fix regression in assistant window handling
- Skip the assistant as the running task when handling swipe up
- Also ensure that we fall into the overview input consumer if we are
  swiping it from the assistant over home
- Skip accounting for the scroll offset when there is no running task

Bug: 136282913
Change-Id: I28e45e407702d6d6aebaa0232cd96ccb10047644
2019-07-23 16:25:46 -07:00
Zak Cohen 344bc96ae1 Merge "TaskView - add a getter for the bitmap data." into ub-launcher3-qt-r1-dev
am: 87477f5996

Change-Id: Id798408bcbf5a9ad10a58b6987a970b6c5ed28b8
2019-07-23 16:13:16 -07:00
Zak Cohen 87477f5996 Merge "TaskView - add a getter for the bitmap data." into ub-launcher3-qt-r1-dev 2019-07-23 22:51:28 +00:00
Jon Miranda 9566a04400 Fix bug where rounded corners were being set despite being disabled.
Bug: 138117089
Change-Id: Icb852e2e07d80c45ad3406ef432b89720887fccf
2019-07-23 22:24:35 +00:00
Vinit Nayak 15abc500ea Refactor RecentTasksList ctor to be testable
Made ctor accept more arguments so we can
pass in mock objects for unit testing.

Test: Created RecentsTasksListTest.java, passes
adb shell am instrument -w -r -e debug false -e \
class 'com.android.quickstep.RecentTasksListTest' \
com.google.android.apps.nexuslauncher.tests/androidx.test.runner.AndroidJUnitRunner

Fixes: 135687618
Change-Id: Iffda661e9d5329a2a403060bde674ab81e4e720e
2019-07-23 11:49:19 -07:00
Tony Wickham f05d3f8fd4 Revert the changes that prevented touch on RecentsView during animation
am: b6841ac630

Change-Id: Ia0c9ec7a600e5d3064297630d16eb862d486bf45
2019-07-22 15:57:55 -07:00
Tony Wickham b6841ac630 Revert the changes that prevented touch on RecentsView during animation
The original bug that was solving seems to be fixed by other changes,
and this allows users to scroll, dismiss, etc on recent tasks before
fully reaching overview from an app.

Bug: 137487381
Change-Id: I28a708811bba3ce739ce261f19eb29558d8f0e7d
2019-07-22 12:39:59 -07:00
Tony Wickham d9515f72f5 Finish recents animation when touching during animation to recents
am: 3fca6aaec2

Change-Id: Ibb855543b828a47f110275343d7b18b771c583bd
2019-07-22 11:57:51 -07:00
Tony Wickham 3fca6aaec2 Finish recents animation when touching during animation to recents
This regressed in ag/8542000, where we cancel the animation instead of
ending it. We should only cancel when going to home; in other cases, we
should still call end().

Bug: 137487381
Change-Id: I093954908c3ac747ec3132aa700c8be2f927631a
2019-07-19 16:53:00 -07:00
Zak Cohen bc4d213535 TaskView - add a getter for the bitmap data.
This allows other components to get it directly from the view, rather
than retaining their own copy.

Bug: 137129923
Tested: Manual

Change-Id: Ibab307517c31cd3cb59b4d77ff390fd97546e86d
2019-07-19 15:14:53 -07:00
Vinit Nayak f9b585b507 Don't specify 1P Launcher3 type if 3P Launcher is active
Instead of referencing Launcher directly (which may not be
present when there's a 3P launcher), reference the lowest
common ancestor of Launcher and RecentActivity to avoid
ClassCastExceptions.

Test: Visually inspected that Pixel Launcher crash dialog
no longer pops up.
* Install 3P launcher
* In developer options enable "enable freeform windows"
* Restart phone for settings to take effect
* Try to use it on any app you have in recent tasks

Fixes: 135419782
Change-Id: Ie1f54880ab46956b23e253850ca7f79b161da9bd
2019-07-19 11:11:35 -07:00
vadimt d3c2a6cecf Fix waiting for launcher initialization
am: c8d496fe00

Change-Id: I7d764152d5d9da8c9df8db479dd01683d9e6148a
2019-07-18 19:10:06 -07:00
vadimt c8d496fe00 Fix waiting for launcher initialization
Bug: 137836033

Change-Id: Ifc8ce867abd85eaeacd09a2b39636ecc4109c046
2019-07-18 18:31:49 -07:00
Tony Wickham 6e6ebe9db3 Merge "Allow TouchControllers to override shouldDisableGestures" into ub-launcher3-qt-r1-dev
am: 6670435c14

Change-Id: If4a2599b3011001d1ef09fb36e07778383b60fe1
2019-07-18 16:01:53 -07:00
Tony Wickham 6670435c14 Merge "Allow TouchControllers to override shouldDisableGestures" into ub-launcher3-qt-r1-dev 2019-07-18 22:27:54 +00:00
Tony Wickham f33b6d4378 Allow TouchControllers to override shouldDisableGestures
Currently only StatusBarTouchController overrides this to always return
false, so that you can swipe down for notifications during transition to
home screen from an app (in gesture nav).

Bug: 137161198
Change-Id: I803c37937d5294810cbe0c1bbffcd5dddcc5ca3b
2019-07-18 15:10:21 -07:00
Winson Chung 5841e40a95 Merging ub-launcher3-qt-r1-dev, build 5736932
Test: Manual

Bug:111935715 P2 Incorrect parent type when logging drag and drop from All Apps
Bug:131315856 P1 [PO restore] No work profile launcher shortcuts restore ~50% of the time
Bug:132900132 P1 Apparently, tests start running while provisioning is still in progress
Bug:133009122 P2 Rare flake: dragged launchable to workspace, but the current state is not WORKSPACE; Can't find a launcher object; selector: BySelector [RES='\Qcom.google.android.apps.nexuslauncher:id/apps_view\E']
Bug:133765434 P1 [Flaky test] Launching task didn't open a new window
Bug:133867119 P2 Lab-only flake: want to switch from workspace to all apps; Swipe failed to receive an event for the swipe end
Bug:133891845 P2 TAPL: need clearer diags when a crash dialog is over Launcher or there is lock screeen
Bug:134532571 P1 Launcher flake: java.lang.AssertionError: http://go/tapl : want to switch from background to overview, but the current state is not BASE_OVERVIEW; Can't find a launcher object; selector: BySelector [RES='\Qcom.google.android.apps.nexuslauncher:id/overview_panel\E']
Bug:135165284 P2 [Q-Preview4] Gestural navigation animation glitch on RTL
Bug:135567630 P1 testBackground crashes in Landscape
Bug:135636137 P1 Workspace is clipped at the top when transitioning from app -> home
Bug:135687618 P4 Task shows between back and swiping up to overview
Bug:135952890 P1 Drag up on home indicator does not track finger if recently entered split screen
Bug:136033787 P0 Vzw DoU: sendexchangeemail wifi test fails with failed dismissal exception
Bug:136215685 P1 Flake: swiping up from Home to Overview in 2-button mode sometimes fails
Bug:137197916 P1 Add gesture support for 3p Launcher
Bug:137215697 P2 FloatingIcon and workspace icon visible at the same time when touch input during app to close animation
Bug:137290162 P1 Overview suggest chip showing on apps due to misconfigured flag
Bug:137316430 P1 Jank when swiping quickly back down to home when overview is peeking
Bug:64712476 P3 Import translations for dev branches
Change-Id: Ib228c0f291884050904fa069e25519755071c40a
2019-07-18 11:36:39 -07:00
Jon Miranda e522e1a48b Skip TouchInteractionService preload if restore task is pending.
am: 11b5535556

Change-Id: Ib171b70a1f65f8e40909e9e587cc2b970df14c8b
2019-07-17 22:02:40 -07:00
Jon Miranda 11b5535556 Skip TouchInteractionService preload if restore task is pending.
Otherwise the preload may cause launcher to restore too early, resulting
in data loss.

Bug: 131315856
Change-Id: I4412c8f691286ba142e9c748a908a3ed42713a82
2019-07-17 21:24:07 -07:00
vadimt 2254bcae3f Merge "Using correct gesture margins in overview" into ub-launcher3-qt-r1-dev
am: aaf6c7ce56

Change-Id: I9e32e16101a837a61c9488f4b0d4484982778092
2019-07-17 16:27:12 -07:00
TreeHugger Robot aaf6c7ce56 Merge "Using correct gesture margins in overview" into ub-launcher3-qt-r1-dev 2019-07-17 23:02:50 +00:00
vadimt 2f7d1fa4a8 Using correct gesture margins in overview
Change-Id: I0108858279559e10633825f7de22211515f0e9b7
2019-07-17 15:18:21 -07:00
Jon Miranda bc27826478 Fix bug where icon is no present during app close animation.
* WindowTransformSwipeHandler closes all AbstractFloatingViews, including
  ListenerView, which results in FloatingIconView getting removed.
* In IconLoadResult.onIconLoaded, we remove the check for isIconLoaded since
  its not needed. This was also causing a race condition since isIconLoaded
  is not set to true until after we tell onIconLoaded to run.
* In BaseDragLayer, we have a delay before checking if the view is open and
  then closing the floating view if true. This caused issues since we reycle
  the view. Now we check if the view is open before running the delay to call
  close.

Bug: 136044361
Change-Id: I7442a589a62c3cdf90b70d146e0ecf3e4300ddf7
(cherry picked from commit 826cdcd32f)
2019-07-17 22:16:40 +00:00
Sunny Goyal fab5a8ec23 Merge "Adding spring animation when swiping up to home in 3P Launcher" into ub-launcher3-qt-r1-dev
am: 6f818e03a7

Change-Id: I60aa1b60687ef18b1d1d632f81bf1e4eef9be016
2019-07-17 14:57:06 -07:00
Sunny Goyal e88d8acd85 Adding spring animation when swiping up to home in 3P Launcher
Bug: 137197916
Change-Id: Ic9808a30e8cd4e0b2a221c4b03bc29489038e092
2019-07-17 11:39:25 -07:00
Vinit Nayak 10d278f3d5 Merge "Reload task list when task is removed" into ub-launcher3-qt-r1-dev 2019-07-17 00:49:52 +00:00
vadimt 83a4a53c3d Merge "Getting starting point of swipe from overview to all apps via protocol" into ub-launcher3-qt-r1-dev
am: 401583f9b6

Change-Id: I0ab7dfa7310bc72e5b05050abc52369d18871669
2019-07-16 17:48:44 -07:00
TreeHugger Robot 401583f9b6 Merge "Getting starting point of swipe from overview to all apps via protocol" into ub-launcher3-qt-r1-dev 2019-07-17 00:24:55 +00:00
vadimt 6a75e52f85 Getting starting point of swipe from overview to all apps via protocol
Change-Id: Idf04579b67011dac45b081a81367cde2d1274117
2019-07-16 16:46:53 -07:00
vadimt 475553ac64 Merge "Removing tracing for fixed bugs" into ub-launcher3-qt-r1-dev
am: f2de54b275

Change-Id: I46a1207125a1346ac6c2b41649b3bf04306e1b59
2019-07-16 16:35:18 -07:00
Vinit Nayak 2c7917d100 Reload task list when task is removed
Instead of individually removing tasks,
ask for all tasks to get accurate list.
This method is invoked whenever user presses
back on a root activity, which causes the task to
be killed from perspective of the activity.

Test: Visually inspected, recent task no longer
disappears.
Open any app, hit back, and then go to overview quickly.
App should remain in recents list.

Fixes: 135687618
Change-Id: I1c135673ae987016db5df0b83f5ea8e345d3c7c1
(cherry picked from commit 8651219f7e)
2019-07-16 23:24:36 +00:00
Vinit Nayak 79b7e16666 Merge "Reload task list when task is removed" into ub-launcher3-master 2019-07-16 23:22:23 +00:00
TreeHugger Robot f2de54b275 Merge "Removing tracing for fixed bugs" into ub-launcher3-qt-r1-dev 2019-07-16 23:15:07 +00:00
Vinit Nayak 8651219f7e Reload task list when task is removed
Instead of individually removing tasks,
ask for all tasks to get accurate list.
This method is invoked whenever user presses
back on a root activity, which causes the task to
be killed from perspective of the activity.

Test: Visually inspected, recent task no longer
disappears.

Fixes: 135687618
Change-Id: I1c135673ae987016db5df0b83f5ea8e345d3c7c1
2019-07-16 13:09:19 -07:00
Sunny Goyal 6d63bbd4de Adding support for swipe operation when on home screen
am: 365f29e577

Change-Id: If4844724be3de143c0c37493c94c4ef5fa257af7
2019-07-16 11:32:57 -07:00
Sunny Goyal a688dd4686 Fixing multiwindow transition when using 3P launcher
am: 587c3cef51

Change-Id: Ia5e69e74322d03563f10f84376438d90468c245d
2019-07-16 11:04:51 -07:00
Tony 22e5235556 Merge "Fix overshoot velocity in 2-button landscape mode" into ub-launcher3-qt-r1-dev
am: 160134e0b1

Change-Id: I921f30bbb37736d9519413b2803f5e0a6480748c
2019-07-16 10:55:51 -07:00