Commit Graph

13651 Commits

Author SHA1 Message Date
Tony Wickham f489a71365 Return mIconLastSetTextAlpha from TEXT_ALPHA property
am: 8ed3b437b1

Change-Id: I01cada1a1cca22e2e7792b019dd74221c0451cf3
2019-08-01 15:44:40 -07:00
Jon Miranda 3ff3991f48 Merge "Fix bug where rounded corners were being set despite being disabled." into ub-launcher3-qt-dev am: 9da9a2bd21 am: f20a7d252c
am: 783717c0c6

Change-Id: I2c9738fa84d781cbfa9a6fbc071468a5247190ef
2019-08-01 15:31:05 -07:00
Tony 3a54ba9296 Don't end launcher components anim early even if it does nothing am: 03c548901f am: 1d7e474c69
am: 13bdbffe29

Change-Id: I1fdc0c3fff32c05da159d61b8a8a7b484b24f147
2019-08-01 15:30:42 -07:00
Becky Qiu 84fa94e2fc Fill the log container as hotseat or workspace based on position.
Test: manual
Bug: 137953006

Swipe from workspace:
07-30 15:15:44.031  9779  9779 D UserEvent: action:FLING direction=UP direction=UP
07-30 15:15:44.031  9779  9779 D UserEvent:  Source child:WORKSPACE id=0 span(951,1313)	parent:WORKSPACE id=0
07-30 15:15:44.031  9779  9779 D UserEvent:  Destination child:ALLAPPS
07-30 15:15:44.031  9779  9779 D UserEvent:  Elapsed container 826 ms, session 9361 ms, action 0 ms

Swipe from hotseat:
07-30 15:15:46.010  9779  9779 D UserEvent: action:FLING direction=UP direction=UP
07-30 15:15:46.010  9779  9779 D UserEvent:  Source child:HOTSEAT id=0 span(786,1908)	parent:WORKSPACE id=0
07-30 15:15:46.010  9779  9779 D UserEvent:  Destination child:ALLAPPS
07-30 15:15:46.010  9779  9779 D UserEvent:  Elapsed container 1139 ms, session 11339 ms, action 0 ms

Change-Id: I959528889fda778efc569bb59e7f44d3bd5b81bc
2019-08-01 22:24:44 +00:00
Tony Wickham 8ed3b437b1 Return mIconLastSetTextAlpha from TEXT_ALPHA property
This was supposed to go in the last CL but I forgot to commit...

Bug: 132455160
Change-Id: Ieb66b1f256d7b14c84bbd4d10af1aa8b073d5ac3
2019-08-01 15:20:03 -07:00
Jon Miranda 783717c0c6 Merge "Fix bug where rounded corners were being set despite being disabled." into ub-launcher3-qt-dev am: 9da9a2bd21
am: f20a7d252c

Change-Id: I3fcfe4dc137756d5b4a049468632d111ca7fa4f6
2019-08-01 15:19:01 -07:00
Tony 13bdbffe29 Don't end launcher components anim early even if it does nothing am: 03c548901f
am: 1d7e474c69

Change-Id: I1f1f70c2791755535d1318b636e37a745e97d057
2019-08-01 15:18:36 -07:00
Jon Miranda f20a7d252c Merge "Fix bug where rounded corners were being set despite being disabled." into ub-launcher3-qt-dev
am: 9da9a2bd21

Change-Id: Icae4fd3fef3ad221d45e8d9ecdcc018813d560f3
2019-08-01 15:05:00 -07:00
Tony 1d7e474c69 Don't end launcher components anim early even if it does nothing
am: 03c548901f

Change-Id: Ifb228b935659e971facfd8d6bb4c56ab54424e68
2019-08-01 15:04:36 -07:00
TreeHugger Robot 9da9a2bd21 Merge "Fix bug where rounded corners were being set despite being disabled." into ub-launcher3-qt-dev 2019-08-01 21:47:47 +00:00
Tony 03c548901f Don't end launcher components anim early even if it does nothing
The janky animation that ends on the home screen with an invisible
task on top is caused by the following scenario (for example):
- Quick switch from task A to task B
- After landing on B, but before we get the callback that it was
  successfully launched, switch back to A (or you could go to C)

Now we are animating back to A, but we are still waiting to hear
whether B was successfully launched. If we hear that the launch
was indeed successful, we dutifully clean up after ourselves  by
returning launcher to its default state. Unfortunately, that
clobbers the current animation that is scrolling back to A, and
we end up in the bad state where we are showing the default
launcher state even though we just launched task B and were
about to launch task A.

Normally we avoid cleaning up the state animation if the user
is still controlling it. The reason we weren't doing that here
is because we ended the launcher animation early even though
the window animation was still running. Instead, we should keep
the launcher animation running for the full duration, so that
it prevents a cleanup from occurring in the middle.

Bug: 138620399
Change-Id: I959e62a52638a5b974ef9b406555078c928b91f1
2019-08-01 13:28:43 -07:00
Tracy Zhou 8e8a36f673 Change RecentsAnimationListenerSet interface (Launcher)
Bug: 138683199
Test: N/A
Change-Id: Ic53ef92fe4d5b55ff1d105a250accdf6f6c0916b
2019-08-01 11:18:15 -07:00
Tony Wickham dd53ba5065 Merge changes Ib3e373c2,Ia5d6f545 into ub-launcher3-qt-r1-dev am: 1343f03e2e
am: 70f539cd45

Change-Id: Ifddcba1cd63950424f88ad1d8e01fa9a11f73a2e
2019-07-31 15:50:44 -07:00
Tony Wickham 70f539cd45 Merge changes Ib3e373c2,Ia5d6f545 into ub-launcher3-qt-r1-dev
am: 1343f03e2e

Change-Id: Ie3f4c2c15e331c84f0f048c6337ae4e58111ec56
2019-07-31 15:36:50 -07:00
Tony Wickham 1343f03e2e Merge changes Ib3e373c2,Ia5d6f545 into ub-launcher3-qt-r1-dev
* changes:
  Tie prediction text to all apps interpolator
  Add OverviewScrim to show below overview but above workspace
2019-07-31 22:12:54 +00:00
Tony Wickham 35a4e0eec9 Tie prediction text to all apps interpolator
Now floating headers get 2 interpolators: one for the header content
itselt, and one for the all apps content that follows. That way, they
can choose to intperolate part of their content as if it were part of
all apps instead of the header. Currently, we do this to animate
predicted icons quickly, followed by the all apps icons, predictions
text, all apps scrollbar, and all apps divider as you continue swiping.

Bug: 132455160
Change-Id: Ib3e373c291e174e1306a53854d0ad4dc29eb4b76
2019-07-31 14:45:18 -07:00
Tony Wickham c088051c29 Add OverviewScrim to show below overview but above workspace
- Refactor some basic scrim logic to Scrim class and have
  WorkspaceAndHotseatScrim and OverviewScrim extend it
- Draw OverviewScrim under recents unless predictions are disabled, in
  which case draw it under hotseat (since that is in recents)
- Remove sysui scrim (behind status bar and nav bar) when overview is
  peeking

Bug: 132455160
Change-Id: Ia5d6f54582a4c5a70e3b2d4a98281567edd68519
2019-07-31 14:44:28 -07:00
Vinit Nayak 6482ab1e36 Merge "Set recents view to be visible from alt+tab" into ub-launcher3-qt-qpr1-dev
am: b5d2ab59a5

Change-Id: I032cb7b9a5a63461adbbefb58172eb0977705a7f
2019-07-31 13:43:41 -07:00
Vinit Nayak 45c12ff1b5 Set recents view to be visible from alt+tab
Recents was being initialized but was not
marked as attached to app window. This
was causing it's animator to never make it
View.VISIBLE.

Test: Open any app
On physical keyboard press alt+tab
Observe that overview shows up

fixes: 138396234
Change-Id: I9e6c001242f4552027e79b162fb812f476823a37
2019-07-31 20:10:55 +00:00
Jon Miranda ddd8071092 Tune window/icon alpha for swipe up to home animation. am: f462b251e1
am: 3d690ce28a

Change-Id: Id31b162c9c1238a50cc660ba9b89985c94229b5d
2019-07-31 11:40:11 -07:00
Jon Miranda f462b251e1 Tune window/icon alpha for swipe up to home animation.
Bug: 136591785
Change-Id: Ib781bc77cfd49b6f4529a609d7025f510e219575
2019-07-31 10:05:16 -07:00
Winson Chung 8822dc0018 Merging ub-launcher3-qt-r1-dev, build 5766606
Test: Manual

Bug:135926478 P2 Work Profile calendar widget not copied over correctly
Bug:135969043 P2 Easily mis trigger full gesture swipe to home when play the app with landscape mode
Bug:137196872 P1 Launcher stays visible when cancelling recents transition
Bug:138403212 P2 Send back action update to tips app
Change-Id: I2e10798216034f52374240f5fbc577cbb903250d
2019-07-31 09:38:49 -07:00
Sunny Goyal d1ca8f4e5e Notifying the geature guide app when back gesture is performed so that user onboarding can the updated accordingly am: c302baced0
am: 342c2e9065

Change-Id: Ibbceb1fae2240afc3f4e7a0714aae84ef1751672
2019-07-29 15:28:30 -07:00
Sunny Goyal c302baced0 Notifying the geature guide app when back gesture is performed
so that user onboarding can the updated accordingly

Bug: 138403212
Change-Id: Ib4e1cde0b2c746f955d5a58251c8ab653dadbc67
2019-07-29 11:55:11 -07:00
TreeHugger Robot c5b8e77a80 Merge "Separating apps list callback from model callback and simplifying various events" into ub-launcher3-master 2019-07-29 16:56:35 +00:00
Winson Chung 7404f35490 Updating to use deferred cancel api am: fa652a8a4f
am: c0974870e4

Change-Id: Ifcab654d42c286c6d7288d219d2ad7b06cd249d5
2019-07-28 12:14:00 -07:00
Winson Chung fa652a8a4f Updating to use deferred cancel api
- Also updating the sysui flag to home's flags when passing some
  threshold
- Also ensure we don't allow swipe up when QS is open

Bug: 137196872
Bug: 135969043
Change-Id: I476eee7f02ae86aa795fceabb304bcaa7416ef9c
2019-07-27 10:08:52 -07:00
Adam Cohen 574d6c152c Merging ub-launcher3-qt-r1-dev, build 5758528
Test: Manual

Bug:128940249 P2 Investigate performance options for 90Hz when swiping to -1
Bug:134074554 P2 Enable test testPressHomeOnAllAppsContextMenu()
Bug:134181439 P3 Missing drag down gesture to open shade while in landscape
Bug:134981174 P1 [Google] Search bar disappears from home screen
Bug:136800511 P1 Brightness shifts when swipe up + hold to recents
Bug:137137090 P2 Improve swipe down noti shade (landscape, logging) and other swipe up home gesture logging
Bug:138025252 P4 Pixel Launcher keeps stopping when changing system language
Bug:138144992 P4 NullPointer in TouchInteractionService.dump
Bug:138227387 P1 Remove 2-button option where not appropriate
Bug:138245847 P4 On a third party wallpaper, long press not highlighting home screen folder name.
Bug:138251824 P1 Flake: want to switch from background to overview; Swipe failed to receive an event for the swipe end
Bug:138401738 P1 Master: java.lang.AssertionError: Navigation mode didn't change to TWO_BUTTON
Change-Id: Ib66a27de5515957a42d0791b76dfca8ed7b248d7
2019-07-26 22:08:16 +00:00
Vinit Nayak a04997b081 Use new onTaskListUpdated() callback
Migrated to general method for receiving updates
whenever the recents list undergoes any additions or
removals.

Test: Opened apps, and as I closed them I ensured
via debugger and log statements that the callback was
being triggered from the framework module. See
tests in RecentTasksTest

fixes: 111077107
Change-Id: Ia9bddb50861a1b107e6a88c9f9bb89944800d5d8
2019-07-26 12:19:57 -07:00
Winson Chung 3874e556a5 Merge "Fix NPE in service dump" into ub-launcher3-qt-r1-dev am: 1d3d19f2e1
am: a7d12b227f

Change-Id: Ic97e416874c2989ab293b69d54190a02f281a043
2019-07-26 10:09:45 -07:00
Winson Chung 1d3d19f2e1 Merge "Fix NPE in service dump" into ub-launcher3-qt-r1-dev 2019-07-26 16:46:35 +00:00
Winson Chung 02a9aec015 Skip tests for overlays that don't exist on device am: 0ef10a458d
am: 6439337cee

Change-Id: I14243ecbda7ade7c1e7db9794bc22a533cc6dd73
2019-07-25 18:01:03 -07:00
vadimt da0d8de65e More diags in TouchInteractionService am: f88d0b5a8a
am: 808b788c14

Change-Id: I8a1acb9d42bab44ba0a866394b63bcb3acdcbadd
2019-07-25 18:00:46 -07:00
Tony Wickham efa4a48231 Merge "Fix incorrect task index bounds" into ub-launcher3-qt-r1-dev am: 3bbb20262b
am: cc740c8932

Change-Id: I14cbb1dd9e0e6366e13d1f62575d162eb6c4adb3
2019-07-25 18:00:16 -07:00
Winson Chung 0ef10a458d Skip tests for overlays that don't exist on device
Bug: 138401738
Bug: 138227387
Change-Id: If661fd342e1382915485bccdf6ae2c9e77a92bc4
2019-07-26 00:09:43 +00:00
vadimt f88d0b5a8a More diags in TouchInteractionService
Bug: 138251824
Change-Id: I0909a2c85b1b2bdd8b67da59c978d6a3bbb58ee5
2019-07-25 16:38:39 -07:00
TreeHugger Robot 3bbb20262b Merge "Fix incorrect task index bounds" into ub-launcher3-qt-r1-dev 2019-07-25 23:17:21 +00:00
Winson Chung 5089140cda Fix NPE in service dump
Bug: 138144992
Change-Id: I608ea209b04fce13a63190ec424849dc909a6a9a
2019-07-25 15:22:47 -07:00
Hyunyoung Song c37af4325f Merge "Add several missing swipe logging Enable swipe down to open noti shade from landscape" into ub-launcher3-qt-r1-dev
am: 2cccb134a4

Change-Id: I6fd477dc398e55358a5110a552430eb61c29373d
2019-07-25 15:14:33 -07:00
TreeHugger Robot 2cccb134a4 Merge "Add several missing swipe logging Enable swipe down to open noti shade from landscape" into ub-launcher3-qt-r1-dev 2019-07-25 21:55:16 +00:00
James O'Leary b1d239405f Merge "Fix QSB becoming invisible" into ub-launcher3-qt-r1-dev
am: 93dceb8a48

Change-Id: Id0a72f39d828535f177992fdf2c674cc84c5a629
2019-07-25 13:57:54 -07:00
James O'Leary 93dceb8a48 Merge "Fix QSB becoming invisible" into ub-launcher3-qt-r1-dev 2019-07-25 20:41:34 +00:00
Hyunyoung Song e299a45944 Add several missing swipe logging
Enable swipe down to open noti shade from landscape

Bug: 137137090
Bug: 137954767
Bug: 134181439

Change-Id: I47b4d17c9ae0586565fce101eb478e33ed8f7e3d
2019-07-25 13:18:48 -07:00
Vadim Tryshev 46d0c36cc6 Merge "NavigationModeSwitchRule: log exception before 'finally'" into ub-launcher3-qt-r1-dev
am: 2870df0776

Change-Id: I37cbd53aaa575915374e41d9535a6d7cf21b72d2
2019-07-25 13:11:45 -07:00
Vadim Tryshev 2870df0776 Merge "NavigationModeSwitchRule: log exception before 'finally'" into ub-launcher3-qt-r1-dev 2019-07-25 19:47:42 +00:00
Tony Wickham 2b365ae7f0 Fix incorrect task index bounds
Should have been using min, not max. Added lower bound for good measure.

Bug: 138025252
Change-Id: Icd8c7d62dca7605fe63e83602e4c9fceb91f68a6
2019-07-25 12:27:29 -07:00
vadimt 7593dc995b NavigationModeSwitchRule: log exception before 'finally'
Change-Id: I158105da467e2759fec6fa5d8acd582b2e95f7c5
2019-07-25 12:16:31 -07:00
Sunny Goyal 87dcde6d6c Separating apps list callback from model callback and simplifying various events
Bug: 137568159
Change-Id: I4d8bb5c01cabe642731ebd3f57fe15bdc5a569b7
2019-07-25 11:29:16 -07:00
James O'Leary 74ece6b021 Fix QSB becoming invisible
This could not be reproduced until I removed a line that wouldn't call
onAssistantVisiblityChanged if the argument was the same value as the
argument as the previous call.

After that, the bug became readily reproducible. I traced through
Launcher till I found that FallbackActivityControllerHelper
.onAssistantVisibilityChanged was being called while the screen was
locked, proving that onAssistantVisiblityChanged was _not_ reaching
launcher.

Test: Verify bug no longer reproduces.
Bug: 134981174
Bug: 135247753
Bug: 135572849
Bug: 135733393
Bug: 136386749
Bug: 136776987
Bug: 137534772
Bug: 137764419

Change-Id: Ib5e8df3b5030a77c5df351a1fcd993db6bd602fc
2019-07-25 10:22:02 -04:00
Jon Miranda b6ce5eb1de Merge "Fix bug where rounded corners were being set despite being disabled." into qt-dev
am: 95bc50fafa

Change-Id: Ia00ea7d1298a6f46c1ff779f13a3bf015ec5cd8a
2019-07-24 19:16:18 -07:00