Commit Graph

50482 Commits

Author SHA1 Message Date
Pat Manning 616b46ef2e Scale using workspace width for handheld device on swiping from home to overview.
Continue to use height to compute scale for two panel home.

Fix: 272735870
Test: manual. Swipe from home to overview.
Change-Id: If7da8c504c389eab3ca337a69eb60dfe28467ed2
2023-03-10 15:35:15 +00:00
Eddie Lan cbdd6493f1 Merge "Revert "Hide the splash icon when launching with no view and no ..."" into tm-qpr-dev 2023-03-09 09:06:11 +00:00
Eddie Lan 293688a9a0 Revert "Hide the splash icon when launching with no view and no ..."
Revert submission 21447384-no-splash

Reason for revert: build break
Bug: 272383391

Reverted changes: /q/submissionid:21447384-no-splash

Change-Id: I73565b1f4e5dd969237980b2b5dbeee7b563abcb
2023-03-09 09:00:29 +00:00
Jon Miranda 4c368373cb Merge "Polish taskbar un/stash animation." into tm-qpr-dev 2023-03-09 03:33:39 +00:00
Jon Miranda 1671b704b3 Merge "Hide taskbar view for app open/close animation." into tm-qpr-dev 2023-03-09 00:33:27 +00:00
Ats Jenk bac6d4946a Merge "Remove empty desktop tile" into tm-qpr-dev 2023-03-09 00:31:50 +00:00
Mateusz Cicheński 321127d14a Merge "Fix entry bounds for 3 button nav" into tm-qpr-dev 2023-03-08 23:52:41 +00:00
Brian Isganitis 84261f9d9b Ensure taskbar background always transparent in notification tray.
Persistent, taskbar can be in light or dark modes. Since notification
tray has its own background color, we should hide ours to avoid clashing
with it.

Test: Manual
Fix: 270758899
Change-Id: Iedc6aae42aac30987af3259ccee11c5998e10517
2023-03-08 23:51:34 +00:00
Jon Miranda 67d4b0ed6b Polish taskbar un/stash animation.
- When QSB is inline, we add it to the reveal animation
  so that it moves in coordination with the rest of the
  taskbar icons
- Hide All Apps button when transitioning from Home -> App
  to match spec
- Shorten duration icons move in x duration so that they
  stay within the taskbar background bounds.

Bug: 267806083
Bug: 246635237
Bug: 246660243
Test: transient taskbar
      with isQsbInline = true and false

Change-Id: Ie6b866311cc2ceba88cdf01652b30fee457d0359
Merged-In: Ie6b866311cc2ceba88cdf01652b30fee457d0359
2023-03-08 23:47:29 +00:00
Jagrut Desai d301c9b628 Merge "Announce for accessiblity when taskbar is invoked/closed" into tm-qpr-dev 2023-03-08 23:34:01 +00:00
Andreas Miko 121bbf6a3f Merge "Add unlock animation for foldables" into tm-qpr-dev 2023-03-08 22:40:22 +00:00
TreeHugger Robot 19c0877745 Merge "Revert "Create TAPL test suite for splitscreen"" into tm-qpr-dev 2023-03-08 20:04:50 +00:00
Ats Jenk 4d01acf44e Remove empty desktop tile
Do not show the desktop tile in overview when there are no apps on the
desktop.

Bug: 270399069
Test: have desktop mode proto 2 enabled, launch an app in fullscreen,
  open overview, observe no desktop tile
Test: move an app to desktop, be on desktop, open overview, observe
  overview is opened with desktop tile focused
Test: have an app on desktop, go home and launch an app in fullscreen,
  open overview, observe fullscreen app is focused, desktop is peeking
  in from right
Test: have an app on desktop and a fullscreen app in overview, open
  desktop from overview, close the desktop app, open overview, observe
  desktop tile is not shown
Change-Id: Ia8657d5b260043a630f32b35f2560ea93273d421
2023-03-08 11:49:48 -08:00
Sunny Goyal 839fc20feb Merge "Removing flag management UI states from flag definition" into tm-qpr-dev 2023-03-08 19:45:21 +00:00
Ats Jenk 8efad6b111 Merge "Set desktop icon to always use black for the icon" into tm-qpr-dev 2023-03-08 19:10:09 +00:00
Brian Isganitis ba5b25c198 Merge "Log when taskbar is in task switcher container." into tm-qpr-dev 2023-03-08 18:56:02 +00:00
Jon Miranda acdf07e0b7 Hide taskbar view for app open/close animation.
Bug: 246635237
Test: open app in hotseat
      close app in hotseat
      the 'matching' view in taskbar should be hidden
      tested icon, predicted icon, folders in taskbar/hotseat
Change-Id: I74382480826afafe6ae58e78faf26fe10812e29b
2023-03-08 10:37:25 -08:00
Sihua Ma 792dda2344 Merge "Set the original drawable for floating widget view" into tm-qpr-dev 2023-03-08 18:26:59 +00:00
Jagrut Desai 1dc99f3848 Announce for accessiblity when taskbar is invoked/closed
Test: Manual
Bug: 265620540
Change-Id: I6660be7716ec59c765f3d54f8fe9889eaaf56e10
2023-03-08 09:54:10 -08:00
Charlie Anderson e3b583277c Merge "Fix bug by allowing popup notifications to be dismissed via swipe" into tm-qpr-dev 2023-03-08 16:48:26 +00:00
Andreas Miko 8e4192fa4f Add unlock animation for foldables
Test: Unit tests added
Test: Manual tests on foldable device going through unlock on outer and inner screens
Bug: b/261584499

Change-Id: I9cdb717400c82e7a0bb4d58d6d25d8b794200af3
2023-03-08 15:58:25 +01:00
Charlie Anderson 3b072b9a07 Merge "Fixes several Visual issues with the app shortcut popup" into tm-qpr-dev 2023-03-08 14:15:17 +00:00
Charlie Anderson 5023c2f65b Fix bug by allowing popup notifications to be dismissed via swipe
Bug: 271218648
Test: manually tested swiping notifications
Change-Id: I3b522639c59b599a14922e4f93deb0e96addb8f8
2023-03-08 13:58:34 +00:00
TreeHugger Robot e83196187a Merge "Adding dither to workspace scrim" into tm-qpr-dev 2023-03-08 02:00:36 +00:00
Schneider Victor-tulias bd98aef4a4 Merge "Fix flaky RequestPinItemTests" into tm-qpr-dev 2023-03-07 23:36:10 +00:00
Randy Pfohl 1e42ff6353 Merge "fixing rare NPE" into tm-qpr-dev 2023-03-07 23:22:01 +00:00
Sihua Ma 914549b482 Set the original drawable for floating widget view
This ensures that the background of the widget will not disappear after cancelling opening the widget activity.

Normally, when opening and closing the widget activity, the following procedures are executed:

tap on widget
-> opening animation initialized -> opening animation finished
-> close the activity
-> closing animation initialized -> closing animation finished

The steps above would work fine. However, a different set of procedures is followed if we try to cancel opening the widget activity:

tap on widget
-> opening animation initialized
-> opening animation started
-> swipe back before opening animation is completed
-> closing animation initialized
-> opening animation finished
-> closing animation started
-> closing animation finished

During the animation initialization process, FloatingWidgetBackgroundView would be initialized. It will then cache the original background and replace with a temporary drawable with alpha set to 0. The background is only restored at the end of the animation.

If two FloatingWidgetBackgroundView is initialized on the same app widget view before one of them is finished, the second floating view will treat the temporary drawable as the original background. At the end of the closing animation, the temporary drawable with an alpha value of 0 will be set for the app widget view, causing the background of the widget view to disappear.

This CL stores the original drawables into the background view so they could be retrieved during the initialization process of the floating background view.

Test: Manual
Fix: 259526083
Change-Id: Iefa29b22b690076a4fc3fc77fe6eea4b6316f852
2023-03-07 15:20:22 -08:00
Ats Jenk 80f4c20f6c Set desktop icon to always use black for the icon
Desktop icon in overview was using a themed color for the icon. But the
background is always a white circle. When using a dark theme, the themed
primary text color is too light. Fixing the color of the icon to be
black always.

Bug: 267326722
Test: enable dark mode, open overview and check the desktop tile icon
Change-Id: Ibcfdfd92ffe2db41cf6ed75c3da8f6457773c2bf
2023-03-07 14:24:37 -08:00
Anushree Ganjam c01068f42e Merge "Creating enum alias ALL_APPS_SEARCH_RESULT_FALLBACK for ALL_APPS_SEARCH_RESULT_SUGGEST." into tm-qpr-dev 2023-03-07 22:19:45 +00:00
Schneider Victor-tulias f1a0bd61f4 Merge "Translate the navigation setting text to prevent overlapping with home gesture hint" into tm-qpr-dev 2023-03-07 20:49:22 +00:00
Jon Miranda 05f08214be Merge "Use dY to determine if taskbar nav threshold is met." into tm-qpr-dev 2023-03-07 20:07:24 +00:00
Brandon Dayauon 9de1c05cbf Merge "Add logging to testDragAppIconToWorkspaceCell()" into tm-qpr-dev 2023-03-07 19:37:44 +00:00
Sihua Ma a245873fed Merge "Update widget picker row logic to resolve cropping" into tm-qpr-dev 2023-03-07 18:42:46 +00:00
Schneider Victor-tulias c3281a42a8 Fix flaky RequestPinItemTests
RequestPinItemTest is flaking because launcher hasn't started yet before the tests try to complete gestures. Waiting for launcher to intitialize before running tests.

Fixes: 267201968
Test: RequestPinItemTest
Change-Id: Ib52e00a1ce68fba5d9af9d1c875078f2f60ea248
2023-03-07 10:36:02 -08:00
Thiru Ramasamy bc8b854c51 Creating enum alias ALL_APPS_SEARCH_RESULT_FALLBACK for ALL_APPS_SEARCH_RESULT_SUGGEST.
This is avoid confusing with ALL_APPS_SEARCH_RESULT_WEB_SUGGEST attribute.

Bug: 271186742
Test: Local - http://gpaste/4919299188719616
Change-Id: I2778316feaae4c76a0726cbee61be5d7a72868ed
2023-03-07 17:00:36 +00:00
Jon Miranda 3ed72b4f92 Use dY to determine if taskbar nav threshold is met.
Prior to this change, we used absoulte screen values.
With this change, the nav threshold is aligned with all other taskbar
thresholds.

Fixes: 269167210
Bug: 267646355
Test: swipe up to show taskbar
Change-Id: Ie2017577fd640b4173fd5ba10122d6906e74f90a
2023-03-07 16:50:42 +00:00
Randy Pfohl 583241e655 fixing rare NPE
test: replaced callback with null pointer and noted same crash error as provided in bug. testing crash to see if it was just small jank or obvious crash. its an obvious cash to user. by exiting earlier the UI isn't as fluid but we will stop crashing.

bug: 261071811
Change-Id: Ia54ee8d4bccdb9de8c042bae8e837216eaac67bb
2023-03-07 16:16:46 +00:00
Mateusz Cicheński c5cbf0f326 Fix entry bounds for 3 button nav
The fix uses the similar approach to shelf height to ensure that the
keep clear area is being updated as soon as possible for quickstep.

Without this, the entry animation finishes before the actual keep
clear area from the view is registered, which causes the PiP to enter
lower right corner and then move up, which was the regression.

Bug: 260779127
Test: manually
Test: http://recall/-/g8x7ZkgdfbqscttAA9wzl9/72aNHwWH5wihwN4gf3mfj

Change-Id: Ide11a903558d7e6cb9e477abe12b81129a7f7afc
2023-03-07 07:50:06 +00:00
Brian Isganitis c762ef68d4 Log when taskbar is in task switcher container.
Test: wwdebug & wwlogcat
Bug: 261177876
Change-Id: Id4eda7ee7e4e2c1aa60e07d5b65410b3847d9ac6
2023-03-07 03:29:21 +00:00
Brandon Dayauon d0838d3ac1 Merge "Correctly make to spec the color for "Turn on work apps" button and add stroke" into tm-qpr-dev 2023-03-07 02:55:01 +00:00
Sebastián Franco 90ff89e2b9 Merge "Decoupling the reorder logic from the CellLayout view" into tm-qpr-dev 2023-03-07 00:24:33 +00:00
Tony Wickham 7fa1e32f21 Merge "Align taskbar children to Y value instead of X." into tm-qpr-dev 2023-03-06 23:51:50 +00:00
Vinit Nayak 313a44039f Revert "Create TAPL test suite for splitscreen"
This reverts commit 03815e6c79.

Reason for revert: b/271852893

Change-Id: I165a15b29e41ce1114f6b7d92d22cdd8e0dfb5b0
2023-03-06 23:47:20 +00:00
Brian Isganitis 2790c9dbbf Merge "Implement light mode for persistent Taskbar." into tm-qpr-dev 2023-03-06 23:07:41 +00:00
Sihua Ma 16180801e8 Update widget picker row logic to resolve cropping
Using pixels instead of cell spans for calculating the widget picker row
binding logic.

Before: https://screenshot.googleplex.com/3uXX2m7xWh3om5t
Now: https://screenshot.googleplex.com/C593mrQfqTahNrQ

Test: Manual
Fix: 269790954
Change-Id: Ib591a6f6d3cf8b72766e0714b9bc8ceb86b2ba4f
2023-03-06 13:41:24 -08:00
Charlie Anderson 52caf63404 Fixes several Visual issues with the app shortcut popup
- Fix system shortcut alignment and ordering.
- Replace horizontal split icon with correct size drawable.
- Remove popup shortcut reversing logic, and instead show same order of shortcuts regardless of orientation.

Test: tested manually on tablet and phone
Bug:269343928
Change-Id: I1700ad1ee04abf0820c87d89e1dc07d6880fd519
2023-03-06 16:40:51 -05:00
TreeHugger Robot f22345eace Merge "Fix an issue with concurrent modification on widget holders list" into tm-qpr-dev 2023-03-06 20:05:29 +00:00
Vadim Tryshev 8f7ca126b0 Merge "Making Launcher3Tests "abtd atest"-compatible" into tm-qpr-dev 2023-03-06 19:59:03 +00:00
Schneider Victor-tulias ec76d6e4b9 Translate the navigation setting text to prevent overlapping with home gesture hint
On large fonts and display sizes, the navigation settings text can overlap with the home gesture hint. Adding some additional translation to account for this.

Fixes: 269716511
Test: Launched all set page on the largest and default font and display sizes on a phone
Change-Id: I4a40b06b827667de9b0bdb893320b0a9890f6699
2023-03-06 19:14:40 +00:00
Johannes Gallmann 83683829f7 Merge "Add onEndCallback to ContainerAnimationRunner" into tm-qpr-dev 2023-03-06 18:55:49 +00:00