Commit Graph

48790 Commits

Author SHA1 Message Date
Winson Chung 607a976635 Merge "Fix missing call to super cancel method" into tm-qpr-dev 2022-09-09 16:16:09 +00:00
Aurélien Pomini 687c6e415c Merge "Hide keyboard when transitioning from all-apps state to overview state." into tm-qpr-dev 2022-09-09 14:25:16 +00:00
Winson Chung 82638f6ef1 Fix missing call to super cancel method
- Without the call, it's interpreted as a successful animation to the
  listener even though it was canceled

Bug: 245829938
Test: Swipe to previous task, immediately after settling touch the
      swipe area again
Change-Id: I531cbda0c2bc8168a312a14854a7a73fafd8f678
2022-09-09 05:58:27 +00:00
Raj Garg 2e106277d7 Merge "Introducing new variable to enable/disable shortcuts." into tm-qpr-dev 2022-09-09 03:41:47 +00:00
TreeHugger Robot 3426372ff8 Merge "Explicit Nullbility in Launcher (Part 3)" into tm-qpr-dev 2022-09-08 21:37:30 +00:00
Vinit Nayak 5aa6deff8d Merge "Disable split pair long press smart actions" into tm-qpr-dev 2022-09-08 18:51:05 +00:00
Schneider Victor-tulias 5f4e93d669 Merge "Add STATE_LAUNCHER_DRAWN printing" into tm-qpr-dev 2022-09-08 18:14:20 +00:00
Schneider Victor-tulias 0b828e291c Merge "Finish recents animation to the matching state." into tm-qpr-dev 2022-09-08 18:11:43 +00:00
Schneider Victor-tulias 82e112c2a4 Merge "Enable input consumer selection reason logging and gesture navigation error detection." into tm-qpr-dev 2022-09-08 17:53:26 +00:00
Federico Baron 8cb0383efb Merge "Fix pagination broken when opening folder after restart bug." into tm-qpr-dev 2022-09-08 17:07:50 +00:00
Pinyao Ting 96d3c589ef Explicit Nullbility in Launcher (Part 3)
This CL updates the nullabality on ItemInfo related classes.

Bug: 242895652
Test: manual
Change-Id: I5fa17a17ff876486431f48d750abdc31afbc56a0
2022-09-08 09:36:00 -07:00
Ats Jenk accde3a686 Merge "Filter out active freeform tasks from recents" into tm-qpr-dev 2022-09-08 16:07:19 +00:00
Jeremy Sim 8611800206 Merge "Prevent Overview Actions from appearing during split from home" into tm-qpr-dev 2022-09-08 00:45:41 +00:00
Vinit Nayak e6c1c0ebf6 Disable split pair long press smart actions
Fixes: 236891562
Test: Long press launches task on split pairs.
Fullscreen overview tasks unchanged.

Change-Id: I5ff5377ddbf2bad60b3158dfef7ed2a8073fa0c4
2022-09-07 16:29:17 -07:00
Schneider Victor-tulias 07211eaed4 Add STATE_LAUNCHER_DRAWN printing
Added loging to only print and/or track multistatecallback states

Bug: 227514916
Test: tried various gestures and printed logs
Change-Id: I487b09ca0660fb385c34b49523a2417f11fcde00
2022-09-07 15:46:49 -07:00
Ats Jenk 461c3b3bd0 Filter out active freeform tasks from recents
Freeform tasks will show up as a separate, single tile in recents.
Filtering them out right now.

Bug: 244348395
Test: atest RecentTasksControllerTest RecentTasksListTest
Change-Id: Ifb197031076a8d8934cea78c6b68cb059477a81a
2022-09-07 15:32:02 -07:00
Anushree Ganjam 94a54203f3 Merge "Add a feature flag for showing Search Educard in QSB" into tm-qpr-dev 2022-09-07 22:05:38 +00:00
Federico Baron e796a6816a Fix pagination broken when opening folder after restart bug.
The alpha wasn't initialized properly so the footer would show up before it was expected to. Alpha is now initalized in the XML file so that the footer starts to appear only once the animation begins.

Test: Manual
Fix: 233690408
Change-Id: I9e08547401cb37ce2f9e711fc4ba000250c49c2e
2022-09-07 20:05:03 +00:00
Anushree Ganjam c74ef95d50 Add a feature flag for showing Search Educard in QSB
Bug: 243680092
Test: Manual
Change-Id: I3ba1f577df2a5cfb2eb5f7acad20b47980c20916
2022-09-07 19:14:35 +00:00
Jeremy Sim 7af10ad02c Prevent Overview Actions from appearing during split from home
Overview Actions will no longer erroneously appear when initiating a split from home.

The bug occurred because split from home causes an irregular state where the user is in split select, yet there is still a focused (main) task in Overview. Overview Actions did not anticipate this state and had no case to handle it.

Fixed by adding a check to Overview Actions so that they will never show when split selection is active.

Fixes: 244499708
Test: Manual
Change-Id: Idf1762c306dceb5048cefec8fa68ac9ca5468379
2022-09-07 12:13:47 -07:00
Alex Chau 0f1001c7b1 Merge "Use real IDP in DeviceProfileTest" into tm-qpr-dev 2022-09-07 13:45:16 +00:00
Alex Chau e818bcb997 Use real IDP in DeviceProfileTest
- Mock WindowManagerProxy instead of IDP in DeviceProfileTest
- Extracted NavigationMode to standalone class
- Moved parseNavigationMode to WindowManagerProxy so it can be mocked
- Moved DeviceProfileTest to internal repo

Bug: 242086027
Test: DeviceProfileTest
Change-Id: Ia5a43293b1380f04d786d2adf8503cfd10f7674a
2022-09-07 10:35:21 +01:00
Sunny Goyal 7a6c610626 Merge "Moving view capture dump to a service to allow longer timeout" into tm-qpr-dev 2022-09-07 04:47:19 +00:00
Schneider Victor-tulias 2ae4420a12 Merge "Expand on gesture navigation error detection." into tm-qpr-dev 2022-09-06 17:32:02 +00:00
TreeHugger Robot db32818a4e Merge "Made getOnBoardingPrefs @Nullable & avoid NPE" into tm-qpr-dev 2022-09-06 17:29:28 +00:00
Brian Isganitis 2d82ad2664 Merge "Fix SecondaryDisplayLauncher crash by initializing OnBoardingPrefs after initializing UI" into tm-qpr-dev 2022-09-06 17:21:51 +00:00
Mateusz Cicheński 77593150da Merge "The shelf height was mistakenly provided as width, making it equal to 0." into tm-qpr-dev 2022-09-06 16:36:48 +00:00
Alex Chau cec6e2c914 Merge "Enable adjacent task animation for grid" into tm-qpr-dev 2022-09-06 15:26:43 +00:00
Pat Manning b11dedc254 Merge "Use full screen width for drop target buttons to support higher screen densities from truncating text." into tm-qpr-dev 2022-09-06 14:59:48 +00:00
Alex Chau 4a206837c9 Enable adjacent task animation for grid
- Enable adjacent task animation for grid tasks
- Only parallax for focused task and only when it's fully visible

Bug: 236963497
Test: manual
Change-Id: I6c681e112f3eb2c7075bc98fab405d978f5057d1
2022-09-05 11:09:28 +01:00
TreeHugger Robot cd8541495a Merge "Import translations. DO NOT MERGE ANYWHERE" into tm-qpr-dev 2022-09-04 23:48:18 +00:00
Bill Yi 3a949898b4 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: eecc252d3e -s ours am: 73663a709f -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19842462

Change-Id: I6434bd7394f8f9ac247753900d0ae0f97259e999
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-04 21:22:04 +00:00
Bill Yi 73663a709f [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: eecc252d3e -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19842462

Change-Id: I0d5ca7ad7a67a855d65b9341827a558d5bc2625b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-04 21:09:12 +00:00
Bill Yi b88f80d9e6 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 6b45e961e6 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19843464

Change-Id: I7c03e38c77a394d564562d6e051e698a52e7620c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-04 21:07:31 +00:00
Bill Yi 6b45e961e6 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I88f3baf3db5611997baedd8103dc47b8333f5c97
2022-09-03 21:09:03 -07:00
Bill Yi 13819a863e Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I59eca0cc685c2dfd6dfe6c33cdd4f3820fe9ae21
2022-09-03 21:08:16 -07:00
Bill Yi eecc252d3e Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I48768bc2e0067c8c7ce19862439256d5ce790d6e
2022-09-03 21:07:28 -07:00
Mateusz Cicheński 26db3bb62a The shelf height was mistakenly provided as width, making it equal to 0.
Bug: 244797561
Test: manually
Change-Id: I28e9c34bb0feb643c5d7b652c055d5fdceaec878
2022-09-03 04:33:18 +00:00
Schneider Victor-tulias 7ad70b6066 Expand on gesture navigation error detection.
- Added some missing error detection:
    1. screenshot capture errors
    2. recents scrolling errors
    3. end-of-gesture callbacks
- Added some more explanation for OverviewInputConsumer selection reason
- Added logging the current task's package name to help identify gestures

Bug: 227514916
Bug: 243471493
Test: Ran launcher, performed multiple gestures and checked logs
Change-Id: I8b10cc75f8640a674c6fed6b06efa4763c9635a2
2022-09-02 15:53:24 -07:00
Jeremy Sim afff936235 Merge "Fix bug with Launcher animation canceling, esp. around OverviewSplitSelect" into tm-qpr-dev 2022-09-02 20:46:41 +00:00
Tracy Zhou 1649163334 Merge "Do not change layering for non live tile tasks rendering" into tm-qpr-dev 2022-09-02 19:18:22 +00:00
Sebastián Franco 8236313204 Merge "Adding support to add icons in the workspace for tests" into tm-qpr-dev 2022-09-02 17:12:50 +00:00
Anushree Ganjam 37bcfaddba Merge "Add a boolean to track QSB edu card dismissal." into tm-qpr-dev 2022-09-02 15:37:17 +00:00
Alex Chau f28c9f14a4 Merge "Change wallpaper depth value in AllApps bottomsheet" into tm-qpr-dev 2022-09-02 10:06:37 +00:00
Tracy Zhou 668eec1e08 Do not change layering for non live tile tasks rendering
TaskViewSimulator#onBuildTargetParams is called for every single task rendering. Given the layering change doesn't work for the non live tile case (and we shouldn't change the layering in that case anyways), an additional check is added to prevent that from happening

Fixes: 242593058
Test: launch overview from home and app, and make sure that in both cases, task launch animation is intact
Change-Id: Ia242dc767499689547dfa8acae56d39e9b0c3189
2022-09-02 00:43:03 -07:00
Jerry Chang bf9ce9c096 Support launching a shortcut and a task to split screen
Fix: 243101552
Test: long press on a shortcut to enter split screen works
Change-Id: Icaabf2e1c8be086bd1b79e0a2cf05878767caa15
2022-09-02 06:58:08 +00:00
Mateusz Cicheński f6b782344c Merge "Replace shelf height with keep clear areas registration in Launcher." into tm-qpr-dev 2022-09-02 05:19:13 +00:00
Jeremy Sim b33471a21f Fix bug with Launcher animation canceling, esp. around OverviewSplitSelect
This commit fixes a bug where the user could cancel animations when transitioning between Launcher states, potentially resulting in a state where Overview elements (task thumbnails etc.) were wrongly hidden or invisible.

The bug occurred because functions such as createInitialSplitSelectAnimation() and createAtomicAnimation() did not carry out any cleanup upon animation failure. This resulted in RecentsView potentially being in a polluted state for the next launch.

Bug was fixed by adding cleanup routines to two onAnimationEnd listeners.

Fixes: 242715097
Test: Manual
Change-Id: I05415ecf515e247aa535e3ca8371e540c3189b01
2022-09-01 20:51:53 -07:00
Sukesh Ram 8d3d944d5d Fix SecondaryDisplayLauncher crash by initializing OnBoardingPrefs after initializing UI
Bug: 238325716
Test: Manual
Change-Id: I66a85eb79cda89a63c3116a56a52b51526720158
Merged-In: I66a85eb79cda89a63c3116a56a52b51526720158
2022-09-02 00:44:39 +00:00
Hyunyoung Song c9be6ca870 Merge "Update container for ItemInfo." into tm-qpr-dev 2022-09-01 23:38:36 +00:00