Commit Graph

72357 Commits

Author SHA1 Message Date
Jeremy Sim 5ff90cd057 Prevent app pairs rank from resetting on Launcher model reload
This fixes a bug where app pairs rank was mistakenly reset upon Launcher reload, causing app pairs to launch with the wrong ratio.

Bug: 274835596
Test: App pairs restore properly even after Launcher restart
Flag: ENABLE_APP_PAIRS
Change-Id: I5d37190cd994628886f77e089c71fc5e5dddc03e
2023-10-24 00:37:52 +00:00
Wei Sheng Shih aa5b85628a Merge "Separate rotationHint as different object of WindowBounds" into main 2023-10-19 01:53:16 +00:00
Pat Manning 131495745c Merge "Add flag guarding around setText in TaskView." into main 2023-10-18 17:38:47 +00:00
Randy Pfohl 8fb1d8f295 Merge "Removing obselete logging used for flaky test investigation" into main 2023-10-18 16:33:06 +00:00
Pat Manning 04dcce8333 Add flag guarding around setText in TaskView.
Bug: 303266975
Test: Forrest runs & Crystalball performance metrics.
Flag: enableOverviewIconMenu
Change-Id: I79e325f9d3377bc078634232c53fd3587d05acc4
2023-10-18 17:13:28 +01:00
wilsonshih ca129bc5ca Separate rotationHint as different object of WindowBounds
Some WindowBounds object with different rotation would be ignore in
DisplayController#supportedBounds due to there already exists an object
with the same bounds.

Bug: 304284870
Test: open app then rotate tablet device to 90 or 270, close app and
monitor the closing target flying back to the expected position.
Flag: N/A

Change-Id: I97f070cfaf7c6243ae3cd95cb728f7041a3736d1
2023-10-18 07:35:10 +00:00
Andreas Agvard 6a9f888201 Update LPNH detection
Replaces GestureDetector usage in LPNH handler with internal implementation that we can tweak
in follow up CLs. It's also a pre-requisite for doing a hint haptic.

Flag: CUSTOM_LPNH_THRESHOLDS
Bug: 300219375
Test: Manual
Change-Id: I5a010d8828bf400e9151236554b29f60edba044c
2023-10-18 09:33:51 +02:00
Holly Jiuyu Sun 6b47dccd73 Merge "[PS] Add private space icon and strings." into main 2023-10-17 22:16:16 +00:00
Holly Jiuyu Sun 0fadf743cc Merge "[DMA] Add withFeature API in StatsLogManager." into main 2023-10-17 21:17:38 +00:00
Alex Chau d08c5d169d [automerger skipped] Avoid drawing live tile behind recents when launching on grid overview am: c44b3cdda9 am: a0e3ed90ac -s ours
am skip reason: Merged-In I91dd8b4088f02af9dc5e603853d8e26606acc38f with SHA-1 1f5de2483b is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/25086887

Change-Id: Ibd599b42c813114428452b7432711a4efc365db2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-17 19:27:56 +00:00
Tracy Zhou 0254ae5480 Merge "Dynamically adjust the paddings of the contextual buttons" into main 2023-10-17 19:26:41 +00:00
randypfohl e07068a0c9 Removing obselete logging used for flaky test investigation
Bug: 293191790

Test: not needed.

Flag: not needed.

Change-Id: I0378c1cc16ae25006d226db3b858394e5f20a22b
2023-10-17 11:47:00 -07:00
Alex Chau a0e3ed90ac Avoid drawing live tile behind recents when launching on grid overview am: c44b3cdda9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/25086887

Change-Id: I4f3a129dd63a672f66fe2997c6a8bda58c5c2244
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-17 18:29:16 +00:00
Pat Manning df72740384 Merge "Revert "Revert "Combine icon app tests to allow overriding flag ..."" into main 2023-10-17 17:28:24 +00:00
Schneider Victor-tulias 3c732aa71b Merge "Default to using AppLaunchAnimationRunner when no LaunchableView can be found" into main 2023-10-17 17:22:07 +00:00
Pat Manning 24cec69361 Revert "Revert "Combine icon app tests to allow overriding flag ..."
Revert submission 25032768-revert-25007147-tapl-flag-SBORVHYDTI

Reason for revert: Resubmitting for b/304470271

Reverted changes: /q/submissionid:25032768-revert-25007147-tapl-flag-SBORVHYDTI

Change-Id: Ib0bd13a5c2a366160b185a2c6409c607ed7525a1
2023-10-17 15:56:48 +00:00
Schneider Victor-tulias 7802dfb44d Default to using AppLaunchAnimationRunner when no LaunchableView can be found
Flag: not needed:
Fixes: 305699288
Test: ran launcher and launched apps
Change-Id: I5ab4f3c7d976e463c29340a4a00edf37e15abf47
2023-10-17 11:30:21 -04:00
Uwais Ashraf c1eecf21e9 Merge "[Trunk Stable] Use SetFlagsRule.initAllFlagsToReleaseConfigDefault instead of disabling all flags in setUp." into main 2023-10-17 14:09:47 +00:00
Riddle Hsu a60c091c94 Merge "Finish recents animation for standalone recents on home" into main 2023-10-17 10:56:28 +00:00
Anushree Ganjam 6ee3a32b12 [Trunk Stable] Use SetFlagsRule.initAllFlagsToReleaseConfigDefault instead of disabling all flags in setUp.
Bug: 294913042
Flag: NA
Test: Unit tests
Change-Id: Ib570ce67f53d4af7407b36f6fee1a3517800155f
2023-10-17 10:27:54 +00:00
Alex Chau c44b3cdda9 Avoid drawing live tile behind recents when launching on grid overview
Fix: 304911154
Flag: none
Test: Swipe up in tablet, scroll to side, launch focused task
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:1f5de2483bc9eb36128a7f700ca4539591afd186)
Merged-In: I91dd8b4088f02af9dc5e603853d8e26606acc38f
Change-Id: I91dd8b4088f02af9dc5e603853d8e26606acc38f
2023-10-17 08:32:22 +00:00
Riddle Hsu aeb3ff6b5c Finish recents animation for standalone recents on home
(This is to reland with fixing FallbackRecentsTest#testOverview
by excluding fallback overview panel which doesn't show visual
difference from AnomalyDetector)
There was a check from RunningTask to avoid using transient-launch
when launching recents activity on a 3rd party home. But the info
may not be updated in time (from TaskStackChangeListener) if there
are several changes happen in a short time.

Then it may misjudge that home is still on top but the current top
is a normal app. Then the app will be paused unexpected because
setTransientLaunch() is not called.

Since FLAG_MOVED_TO_TOP is introduced, task reorder will also be
collected in transition, so the check of isHomeTask is longer needed.
But RecentsTransitionHandler still needs to cooperate with it about
how to animate the merging animation while recents animation is running.
To simplify it, just finish the recents animation when recents activity
is launched on top of home activity, i.e. consider it as a regular
launch because only the recents activity is on top and there are no
other apps need to keep visible for live-tile.

Note that setTransientLaunch() is still called for the case. However
its effect will be gone after the transition is finished.

This can also fix various issues when using a 3p launcher:
 - When auto rotation is enabled and put device in landscape:
    - Unable to enter recents from gesture mode
    - System bars are disappeared when pressing recents key
 - Jump-cut when pressing home key to leave recents on home.

Bug: 302703228
Bug: 294029838
Test: WindowInsetsBehaviorTests
Test: Rapidly click navigation bar while a regular app is on top.
      The app should not receive onPause.
Change-Id: I387fcb26aa01072dfd5a215107c9c15b28513a82
2023-10-17 05:45:16 +00:00
Fengjiang Li c4f9dd2c04 Merge "Double pre-inflate counts if work profile is enabled" into main 2023-10-16 21:36:52 +00:00
Pat Manning d0bf41bcc6 Set FastBitmapDrawable's badge alpha when updating drawable alpha. am: 08f89425bb am: 43f230bcc8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/25058707

Change-Id: Ied1832fbaf8d95f23283e6e6201d97dfc41822f9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-16 21:13:43 +00:00
Pat Manning 43f230bcc8 Set FastBitmapDrawable's badge alpha when updating drawable alpha. am: 08f89425bb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/25058707

Change-Id: Id7103d1ac790e02434df1a891913d70ba9c67280
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-16 20:44:43 +00:00
Alex Chau d7bd142267 Merge "Avoid drawing live tile behind recents when launching on grid overview" into main 2023-10-16 19:48:23 +00:00
Sebastián Franco 879efc7b2a Merge "Cleaning up some and removing unused calculations code in CellLayout" into main 2023-10-16 18:35:56 +00:00
Alex Chau 1f5de2483b Avoid drawing live tile behind recents when launching on grid overview
Fix: 304911154
Flag: none
Test: Swipe up in tablet, scroll to side, launch focused task
Change-Id: I91dd8b4088f02af9dc5e603853d8e26606acc38f
2023-10-16 18:27:10 +01:00
Shan Huang 90f17d44d2 Merge "Fix scrim attachment and detachment issues." into main 2023-10-16 17:17:14 +00:00
Pat Manning 7365f575e1 Merge "Fix condition checking that scale of taskbar changes on hover." into main 2023-10-16 15:49:22 +00:00
Pat Manning 02eab16f2d Fix condition checking that scale of taskbar changes on hover.
Fix: 304455999
Test: TaplTestsTransientTaskbar
Flag: ENABLE_CURSOR_HOVER_STATES
Change-Id: I95e6a5a34c433b5fbe19b9dbcc9c6b7b8bdc43a7
2023-10-16 14:22:00 +01:00
Pat Manning 08f89425bb Set FastBitmapDrawable's badge alpha when updating drawable alpha.
Test: FastBitmapDrawableTest
Fix: 304559962
Change-Id: Ie545cc5da506c77af18f99b5d045cafc37110a5a
2023-10-16 09:52:06 +00:00
Alex Chau 74e68c69e8 Merge "Use SandboxContext in AbstractDeviceProfileTest" into main 2023-10-16 09:41:59 +00:00
Uwais Ashraf d174fcaa99 Merge "Revert "Finish recents animation for standalone recents on home"" into main 2023-10-16 08:57:59 +00:00
Uwais Ashraf 35af2d967c Revert "Finish recents animation for standalone recents on home"
Revert submission 24941288-b302703228

Reason for revert: Most likely cause of droidmonitored test failures. b/305629625. Original change was merged at this point https://screenshot.googleplex.com/99p3F266XUYYbA2 causing a 100% failure on main.

Reverted changes: /q/submissionid:24941288-b302703228

Bug: 305629625

Change-Id: Id27c68ec70410d16aeae3bde8b361d9b347ec7eb
2023-10-16 08:56:24 +00:00
Riddle Hsu 290aa6f266 Merge "Finish recents animation for standalone recents on home" into main 2023-10-16 05:46:48 +00:00
Tracy Zhou 33132dc48c Dynamically adjust the paddings of the contextual buttons
- Dynamically adjust the paddings of both start and end contextual containers in different layouts

Test: manual
Bug: 230395757

Change-Id: I2c6a1350e0dab36f6d5100b8d4e2012d8a97cd9b
2023-10-13 20:10:44 -07:00
Sebastián Franco c3a2919fd1 Merge "Moving getPagesToBindSynchronously to ModelCallbacks" into main 2023-10-13 23:49:02 +00:00
Tracy Zhou 6bfdfd011b Merge "Correct signal for showing contextual buttons for taskbar" into main 2023-10-13 21:04:13 +00:00
Shan Huang b78f7de733 Fix scrim attachment and detachment issues.
Attaching: The surface control from Launcher's ViewRootImpl is
occiasionally invalid when back gesture starts, and parenting scrim to
it would fail. We work around this by retrying later on back progressed.

Dettaching: The scrim is not detached in all code paths. We now always
check and detach in finishAnimation() if needed.

This also fixes a possible flicker at the beginning of the transition.
We wait until Launcher is started (and draws at least one frame) to animate the top window.

Test: m -j
Test: Repeatedly trigger back to home animation. Make sure the scrim
attaches and detaches always.

Bug:271606843
Bug:297808832
Bug:217988970
Fixes:271606843
Fixes:297808832
Fixes:217988970

Change-Id: I8b9b023f1fd54bcedd0be15196165e19e8400af7
2023-10-13 13:51:46 -07:00
Jon @ 189fc92d90 Merge "Fix bug where All Apps button loads in late in taskbar." into udc-qpr-dev am: 5838767cc2 am: 9f3945cfff
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/25021492

Change-Id: Iac125aa58535a5d6e23f8b05ba37d291aa8af559
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-13 19:29:25 +00:00
Holly Sun 6ec3d23a4b [PS] Add private space icon and strings.
Bug: 298227797
Test: manual and unit
Flag: inject_private_space_tile
Change-Id: Ic7ec649ac69f02a82a6ee0b4e63262d8ad3e0916
2023-10-13 12:29:19 -07:00
Jon @ 9f3945cfff Merge "Fix bug where All Apps button loads in late in taskbar." into udc-qpr-dev am: 5838767cc2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/25021492

Change-Id: I027ebf7933332b48434144f9776fb8a29c783fb6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-13 18:58:06 +00:00
Jon @ 5838767cc2 Merge "Fix bug where All Apps button loads in late in taskbar." into udc-qpr-dev 2023-10-13 18:37:04 +00:00
Sebastian Franco 69fd742a60 Moving getPagesToBindSynchronously to ModelCallbacks
Changes are part of go/launcher_SoR .

Bug: 301108526
Test: This is a no-op change, compiling should be the test
Change-Id: I5e57b73edfa23e9f12ea94c0f9c5005e2d8fccd2
2023-10-13 11:34:23 -07:00
Sebastián Franco 87d482cd3e Merge "Unifying constant app names used in Tests" into main 2023-10-13 18:28:38 +00:00
Sebastian Franco 0dd5db84e4 Cleaning up some and removing unused calculations code in CellLayout
Using cellToRect and removing some calculation that where unnecesary
because the variable are later overwritten.

Fix: 194414754
Bug: 294841331
Test: ImageTest
Change-Id: I31e0527cbbea463a32a36a172185a41985ed0d57
2023-10-13 18:24:41 +00:00
Ats Jenk a89365c2be Merge "Use desktop mode flag for split logic" into main 2023-10-13 18:00:53 +00:00
Schneider Victor-tulias a96537fa65 Merge "Increase the ActiveGestureLog tracked gesture limit" into main 2023-10-13 16:08:32 +00:00
Fengjiang Li c83d96daea Merge "Trace unlock animation progress" into main 2023-10-13 15:35:11 +00:00