Commit Graph

54293 Commits

Author SHA1 Message Date
Bill Yi 5fbbc7c35f [automerger skipped] Merge "Import translations. DO NOT MERGE ANYWHERE" into tm-qpr-dev am: 95623d83d8 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21608131

Change-Id: Idf8ce5ab81f16f2cd75933a66230aff141e9dc8b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-28 22:34:49 +00:00
Bill Yi 89a768b1a3 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 3f4d577e24 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21608131

Change-Id: I111fde18f26cec433e5e1f767915b2ddf659fa2a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-28 22:34:25 +00:00
Bill Yi 95623d83d8 Merge "Import translations. DO NOT MERGE ANYWHERE" into tm-qpr-dev 2023-02-28 22:15:43 +00:00
Alex Chau 694a0a8685 Merge "Skip updateIconAlphaForHome if Taskbar is already destroyed" into tm-qpr-dev am: 81b1d3576a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21610408

Change-Id: I35d9bcf444bd9fb8b5ac5223f5579e0eb0901a03
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-28 22:02:13 +00:00
Alex Chau 81b1d3576a Merge "Skip updateIconAlphaForHome if Taskbar is already destroyed" into tm-qpr-dev 2023-02-28 21:23:53 +00:00
Anushree Ganjam 2fbffbad9f Merge "Add logging for EDUCARD resultType." into tm-qpr-dev am: 409b17eee4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21620428

Change-Id: Ifcff2926479aa14217337a060224855937e029bc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-28 21:05:15 +00:00
Anushree Ganjam 409b17eee4 Merge "Add logging for EDUCARD resultType." into tm-qpr-dev 2023-02-28 20:10:07 +00:00
Sunny Goyal e7fe6b57ff Merge "Moving flag creation to a separate file" into tm-qpr-dev am: 1297f400bc
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21586607

Change-Id: I0b50d9286e8abab8b3d5f54853f8bfc74141cbb4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-28 19:48:41 +00:00
Sunny Goyal 1297f400bc Merge "Moving flag creation to a separate file" into tm-qpr-dev 2023-02-28 19:18:25 +00:00
Sunny Goyal 98204add71 Moving flag creation to a separate file
> This provides better control over proguarding descriptions
> Enforcing bug number in flag creation

Bug: 270386012
Test: Presubmit and verified on device
Change-Id: I31014e397690379024d2e42c0e913ce806b9569c
Merged-In: I31014e397690379024d2e42c0e913ce806b9569c
2023-02-28 18:05:42 +00:00
Alex Chau 7fee161cd5 Skip updateIconAlphaForHome if Taskbar is already destroyed
Bug: 269409332
Test: Switch display with and without Tasxkbar at home and in-app, Taskbar and Hotseat visibility are correct
Change-Id: I598f618c336067bf795b77ccdf3b03f420634047
2023-02-28 12:46:50 +00:00
Anushree Ganjam 03b69e4f32 Add logging for EDUCARD resultType.
For Impression logging, the educard resultType is not logged correctly.

Bug: 267503356
Test: Manual
Change-Id: Ibca6392a85d2fbd7b6d26a4f3665307af0ead8f3
2023-02-28 00:40:58 +00:00
TreeHugger Robot 946ed114c4 [automerger skipped] Merge "Import translations. DO NOT MERGE ANYWHERE" into stage-aosp-master am: eadf7a67bf -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21604291

Change-Id: Ie41d308163540025c11656cb29c4134d0d746837
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-27 23:40:04 +00:00
Bill Yi 080b719694 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 96fbc57162 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21604291

Change-Id: I01b137725497df5662210cb83515fb2de6adb7bd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-27 23:39:55 +00:00
TreeHugger Robot d40129a0d0 [automerger skipped] Merge "Import translations. DO NOT MERGE ANYWHERE" into stage-aosp-master am: e1e12ea5dd -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21604290

Change-Id: I4d51f14eb54b44fa62956caed5d47f9e8537daa3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-27 23:39:48 +00:00
Bill Yi d2026fc4ed [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 80b5644087 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21604290

Change-Id: Ic17ff0f24e5d1654e40a56b1a63f8466252c5348
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-27 23:39:36 +00:00
Bill Yi 7079a3301f [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 9650b930e2 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21603491

Change-Id: I1297ffda0cb277086e7017f1194e962a19abc752
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-27 23:39:16 +00:00
TreeHugger Robot eadf7a67bf Merge "Import translations. DO NOT MERGE ANYWHERE" into stage-aosp-master 2023-02-27 23:05:13 +00:00
TreeHugger Robot e1e12ea5dd Merge "Import translations. DO NOT MERGE ANYWHERE" into stage-aosp-master 2023-02-27 23:05:13 +00:00
Helen Cheuk e129994b8b Merge "Update folder row and column for 5x5 grid to 4x4. Update dump method to include changed properties and add dump test for 5x5 grid" into tm-qpr-dev am: a695986d56
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21549709

Change-Id: Ief8665d9d3f48f4d356830bb386f0c13f3f68ce2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-27 18:34:19 +00:00
Helen Cheuk a695986d56 Merge "Update folder row and column for 5x5 grid to 4x4. Update dump method to include changed properties and add dump test for 5x5 grid" into tm-qpr-dev 2023-02-27 17:55:42 +00:00
Bill Yi 3f4d577e24 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I945470f393b326f16958e50d928972d159a3bda6
2023-02-27 06:57:17 -08:00
Bill Yi 96fbc57162 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I58b416c43fda20b9b028106e6bb4e451addbbbaa
2023-02-26 20:19:06 -08:00
Bill Yi 80b5644087 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Id26fda6e2fff9c389ab01e55763e9d5100b66925
2023-02-26 20:18:36 -08:00
Bill Yi 9650b930e2 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I3a98cb65b2a5cf2ba80c4ac3d49f7fbdf34b7909
2023-02-26 20:18:09 -08:00
Alex Chau 110007f68e Merge "Remove focus task" into tm-qpr-dev am: 019f8a640a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20980936

Change-Id: Ia72b6f482b13fe76ee172ae859a3ade06bc1c695
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-25 11:53:58 +00:00
Alex Chau 019f8a640a Merge "Remove focus task" into tm-qpr-dev 2023-02-25 11:25:34 +00:00
Jagrut Desai 8a8bda5b3c Merge "Implement All Apps Icon upto the visual Specs." into tm-qpr-dev am: 3addf0b66d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21470199

Change-Id: I6239794dc53cc85288b8496c1862df1d803ba0e8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-25 02:21:40 +00:00
Jagrut Desai 3addf0b66d Merge "Implement All Apps Icon upto the visual Specs." into tm-qpr-dev 2023-02-25 01:49:59 +00:00
Sunny Goyal 68cf24e532 Merge "Moving IS_DEBUG_DEVICE to a compile time flag for better proguard support" into tm-qpr-dev am: ae030217db
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21550341

Change-Id: Ic8c7908f5e44f4c1ab6b1462ff10cc4149c4a95a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-25 00:59:46 +00:00
Sebastián Franco df3741cb62 Merge "Binding tests to TouchInteractionService to preventing it from getting destroyed" into tm-qpr-dev am: 2e1524ec2f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21186951

Change-Id: I00ec06d94c55eacbb4aee745f1e7882cc4e77d84
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-25 00:59:04 +00:00
Sunny Goyal ae030217db Merge "Moving IS_DEBUG_DEVICE to a compile time flag for better proguard support" into tm-qpr-dev 2023-02-25 00:53:56 +00:00
Sebastián Franco 2e1524ec2f Merge "Binding tests to TouchInteractionService to preventing it from getting destroyed" into tm-qpr-dev 2023-02-25 00:45:46 +00:00
Jagrut Desai d3f23005af Merge "Prevent Taskbar from stashing in immersive mode overview." into tm-qpr-dev am: 0355c793c0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21560134

Change-Id: I75a8b22ad44b3ccf78a546f7d7569be9fc1dbff2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-25 00:39:22 +00:00
Jagrut Desai 560b0eac62 Implement All Apps Icon upto the visual Specs.
Test: Visual
Bug: 267382941

Change-Id: If675c2f4767014598b23d8a2c2e684f5a8fb4f19
2023-02-24 15:41:06 -08:00
Jagrut Desai 0355c793c0 Merge "Prevent Taskbar from stashing in immersive mode overview." into tm-qpr-dev 2023-02-24 23:34:56 +00:00
Alex Chau d56e6a6306 Merge "Set split button drawable to start instead of left" into tm-qpr-dev am: 346b970942
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21566803

Change-Id: I8c40f21252aedc829cab8de34f77b137ff8529cd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-24 21:58:14 +00:00
Alex Chau 2248a0e941 Merge "Fix various animation issues when total width of grid tasks < screen width" into tm-qpr-dev am: a8c2ffc128
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21549707

Change-Id: Id3f5805bdda91219419b0a1b784dae6655d6d2bb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-24 21:57:58 +00:00
Schneider Victor-tulias 4f4962fbc9 Merge "Add debug logs to debug flaky workspace binding" into tm-qpr-dev am: cd17310656
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21542943

Change-Id: I04412352aa7b773103cd08a9c7ce14fe75c2b789
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-24 21:57:41 +00:00
Alex Chau 346b970942 Merge "Set split button drawable to start instead of left" into tm-qpr-dev 2023-02-24 21:44:02 +00:00
Alex Chau a8c2ffc128 Merge "Fix various animation issues when total width of grid tasks < screen width" into tm-qpr-dev 2023-02-24 21:42:58 +00:00
Schneider Victor-tulias cd17310656 Merge "Add debug logs to debug flaky workspace binding" into tm-qpr-dev 2023-02-24 21:12:41 +00:00
Ats Jenk d12b90b711 Merge "Hide overview actions when desktop is focused" into tm-qpr-dev am: 8fc3a1df82
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21568620

Change-Id: If4b3739c2f1aa855a33d1f721872851a60df9382
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-24 19:46:22 +00:00
Ats Jenk 8fc3a1df82 Merge "Hide overview actions when desktop is focused" into tm-qpr-dev 2023-02-24 18:45:28 +00:00
Alex Chau aec9d3136f Remove focus task
- Focus task is only removed under ENABLE_GRID_ONLY_OVERVIEW, but many fixes/refactoring are generic and apply with the flag off
- Keep moving running task to front if go to overvied after quick switch, so live tile is always on top right

Grid calculation:
- Fixed some top/bottom calculation assumption that assume focus task is always present

Size calculation:
- With ENABLE_GRID_ONLY_OVERVIEW, taskSize == gridTaskSize, and task is aligned to top-right of gridRect (instead of focusTaskRect)

Bug: 257952455
Test: Enter overview from home
Test: Enter overview from app, with variations that quick switch and enter
Test: Dismiss task from different position
Test: Split select task from different position
Test: Repeat with/without GRID_ONLY_OVERVIEW flag
Test: Repeat with handheld
Change-Id: I6580a8ac6c2c2059c33c4daca05b7d0354513e74
2023-02-24 18:43:30 +00:00
Alex Chau 359ac14d13 Fix various animation issues when total width of grid tasks < screen width
Bug fixes:
- Unusual long scroll when only focus task left after split select
- Animation jump when tasks cannot fit screen width after dismiss or split select

To fix the above issue, generified calculations when total grid task width < screen width:
- Removed some special case handling when only focus task left (getSnapToFocusedTaskScrollDiff), and instead replace with generic logic that calculation that extra scroll position (shortTotalCompensation) needed when long row width is smaller than the grid size
- Fixed snapped task grid translation calculation to account for shortTotalCompensation
- Last task scroll calculation should account for shortTotalCompensation too
- Calculate the expected shortTotalCompensation after dismiss, and use that to adjust the close gap between clearAll distance

splitScrollOffset that we applied during split screen does not work well when shortTotalCompensation != 0. splitScrollOffset is not a good solution to handle split placeholder, as it allow tasks to scroll to weird position. I removed splitScrollOffset completely, and only apply split translation when split placeholder covers the tasks:
- Removed splitScrollOffset on TaskView/ClearAll, so scroll position of TaskView will not change while in split to splify things.
- When split placehodler will cover task's natural position (taskSize) in overview grid, apply split translation on all tasks similar to handheld
- Removed isSplitPlaceholderFirstInGrid/isSplitPlaceholderLastInGrid adjustments

Bug: 257952455
Test: Enter overview from home
Test: Enter overview from app, with variations that quick switch and enter
Test: Dismiss task from different position
Test: Split select task from different position
Test: Repeat with/without GRID_ONLY_OVERVIEW flag
Test: Repeat with handheld
Change-Id: I7689b5384845f03491041b6d910835c9ac4fab08
2023-02-24 18:42:13 +00:00
Alibek Manabayev b60e6b0e60 Merge "Extend tests to check Transient Taskbar Autohide" into tm-qpr-dev am: 4424f6636e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21445185

Change-Id: Iaec5904ced44f1ea776b986cfa798736da7ad0b0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-24 15:18:30 +00:00
Helen Cheuk 599109b23f Update folder row and column for 5x5 grid to 4x4. Update dump method to include changed properties and add dump test for 5x5 grid
Originally folder row and column for 5x5 grid was 3x3. This change is to update it to 4x4 in config to increase the max number of cells displayed. It also adds corresponding test for 5x5 grid and includes numFolderRows and numFolderColumns in the dump string

Fix: 265139500
Test: DeviceProfileDumpTest
Change-Id: I09fe3eac8113a147cb895988e5424471e4e772e5
2023-02-24 14:40:50 +00:00
Alibek Manabayev 4424f6636e Merge "Extend tests to check Transient Taskbar Autohide" into tm-qpr-dev 2023-02-24 14:39:45 +00:00
Alex Chau 49863356e2 Set split button drawable to start instead of left
Fix: 269493214
Test: Check overview actions in regulard and RTL
Change-Id: Ice474294c482de8c552bda5e14efdce989fce4e7
2023-02-24 12:00:48 +00:00