One way to reproduce this issue is to run `adb shell input keyevent KEYCODE_HOME`, which happens to pause and immediately resume launcher. For example, let's say we run this while in All Apps. Because the isResumed=true comes before the state transition to Normal, we behave as if we are still going to All Apps, specifically goingToUnstashedState = false (since we stash in All Apps). To fix this, we now listen to state changes while the resume alignment animation is playing, and update it if necessary.
Also did the same correction for the gesture alignment animation, though I don't have a specific repo for that.
Finally, because there are now more triggers for alignment animations to play, we add a check to only play them if it's not animating to the same value it's already animating towards. One notable experience this improves is swiping down from All Apps to home; if you do it quick enough, the state animation ends before the taskbar unstash animation, and thus the unstash animation would cancel and start again with the full duration, making it look laggy/disjointed (this behavior existed before this change as well).
Test: TaplTestsQuickstep
Test: Go to All Apps, run `adb shell input keyevent KEYCODE_HOME`, open an app and ensure taskbar icons are visible
Test: Quick switch from home when taskbar is present in apps, but instead go to overview; ensure no jump when taskbar stashes
Test: Swipe down quickly from All Apps, ensure taskbar unstashing doesn't slow down when reaching the end of the state transition
Fixes: 214562370
Change-Id: Ie0c6140e14186e41c7e4748dc745f87349b084fe
In splitscreen overview, the pair of app icons is now always centered at
the top of the view, rather than following the divider's position.
Test: Visually tested on local P6 device
Fixes: 208648221
Change-Id: I460d06047693c9376dab8215085d54aa4164d69f
- OOP test activity has an alertTitle and shouldn't be treated as system anomaly dialog
Fix: 214558538
Test: NexusLauncherOutOfProcTests / MemoryTests
Change-Id: Ia9c330c3c3f48b43fbada40a3410ccc9fb8bfbb8
- Added ArrowPopup#OnPopupClosedCallback to automatically remove Taskbar focus when the popup closes.
Fixes: 209917078
Test: opened popup in taskbar and closed it with switch access, touching anywhere on the screen and using the back gesture. went home to check if focus was removed.
Change-Id: Ie7aafc9cf0f03fadaa44e77818508e9e1d8db610
- Somehow when home gesture's travel distance is above certain number (~2560px in the bug's case), the touch will wrongly go to the 3P launcher instead of staying in quickstep launcehr only. As it's unusal for home gesture to be so long, limiting it to half of screen height.
Bug: 214279686
Test: presbumit and TaplTestsLauncher3#testWidgets on cf_tablet
Change-Id: I1107074556aea3011b186ba34dc830dbb1445517
A request to set a new depth is ignored if the surface is currently
invalid. We should cache what was the requested value, so it will be
applied once the surface is valid again.
Test: manual
Fixes: 209028986
Change-Id: I812816da4b0139c7ea7b53a9fb00f11265ecdea8
Test: Open folder from taskbar, edit name, ensure back button displays above IME and that IME sends input to the taskbar folder name
Bug: 205803170
Change-Id: I36f6cfb835aa7da280f15ea4b0aed8923ce8a012
- Remove ActivityContext#supportsIme(), as it's always true now
- Add OnFolderStateChangedListener, which we register when clicking on a taskbar folder icon to set the window focusable/not.
- Also remove Folder.STATE_NONE and instead default to STATE_CLOSED (renamed from STATE_SMALL).
TODO: make sure back button is visible above IME (followup CL)
Test: Open a folder from taskbar while in an app, no animation jump and can change folder name
Bug: 180051157
Change-Id: I7c7847657d462c16677d66b9ffa8b6fe5f164084
- To enable homescreen restore with Launcher3/SearchLauncher dogfood, see bug for details
Bug: 210984712
Test: none
Change-Id: I398551bc6fece17aba163a27ef29c748d58ab90e
Tony Wickham
Jeremy Sim
TreeHugger Robot
Alex Chau
Schneider Victor-tulias
Bill Yi
Thales Lima
Lucas Dupin
Vadim Tryshev
Winson Chung
Jerry Chang
Vinit Nayak
Ling Wo