Commit Graph

73249 Commits

Author SHA1 Message Date
Vadim Tryshev 5e9e07e0dc Merge "Enabling wallpaper animation wait in presubmit widget tests" into main 2023-12-11 20:10:51 +00:00
Vadim Tryshev 5915443a33 Merge "Disabling leak checks in presubmits" into main 2023-12-11 19:50:20 +00:00
Sebastián Franco f217079aea Merge "Move onInitialBindComplete to ModelCallbacks" into main 2023-12-11 19:31:15 +00:00
Vadim Tryshev 8c3dbdf22a Enabling wallpaper animation wait in presubmit widget tests
This check is stable now

Bug: 313926097
Flag: N/A
Test: presubmit, postsubmit runs
Change-Id: Id6bbe5f8ca3aaae3ef025732b4d429d109b567ce
2023-12-11 10:31:20 -08:00
Vadim Tryshev 79e12b893d Disabling leak checks in presubmits
They block 36% of presubmit runs

Bug: 313501215
Test: presubmit
Flag: N/A
Change-Id: Id91e5a467dfe2485614a4ac99861670a1afaa533
2023-12-11 10:16:13 -08:00
Vadim Tryshev 04e044565d Merge "Disable alpha jump detector" into main 2023-12-11 18:07:03 +00:00
Sebastian Franco 0b461efeeb Move onInitialBindComplete to ModelCallbacks
Changes are part of go/launcher_SoR .

Flag: NA
Bug: 301108526
Test: TaplWorkspace
Change-Id: I1a12309897a04f3ae1642fcdc9f984f7f274ba13
2023-12-11 10:07:40 -06:00
Thales Lima df643c4540 Merge changes from topic "numFolderRows" into main
* changes:
  Update dump tests
  Make numFolderRows/Columns accept more values
2023-12-11 10:54:04 +00:00
Jeremy Sim d761f5c3bd Merge "App Pairs: Implement Taskbar functionality" into main 2023-12-09 02:20:45 +00:00
Vadim Tryshev 151751c014 Merge "Fixing non-sending wallpaper animation finish event" into main 2023-12-08 23:33:53 +00:00
Jeremy Sim 2987d95ba4 App Pairs: Implement Taskbar functionality
[App Pairs 8/?]

This CL adds taskbar functionality for app pairs:
- Ability to drag an app pair icon to Taskbar
- App pair launch from Home Taskbar
- App pair launch from Overview Taskbar
- App pair launch from in-app Taskbar

KNOWN ISSUES:
- Bug (b/315190686): if user is inside a running split pair and attempts to launch the same pair from an app pair icon on taskbar, Overview tiles get temporarily messed up (recoverable by leaving Overview)
- User can attempt to split with an app pair icon on the Taskbar. This should result in a "can't split with this" bounce animation on the SplitInstructionsView (to be implemented). Currently does nothing.

Bug: 274835596
Flag: ACONFIG com.android.wm.shell.enable_app_pairs DEVELOPMENT
Test: Manual
Change-Id: I5256547af236fc2deeb192d60bfe1f2b7ddc5647
2023-12-08 15:07:45 -08:00
Saumya Prakash 55fdc45ecc Merge "Ensure Taskbar stashes when launching an app from folder" into main 2023-12-08 22:59:45 +00:00
Vinit Nayak fe22e7fa4d Merge "Only launch from split taskView if it's visible to user" into main 2023-12-08 22:34:33 +00:00
Vadim Tryshev 3277cbdb17 Fixing non-sending wallpaper animation finish event
Wallpaper animation may be interrupted with an animation to go to Normal state.
Then the animation won't succeed, but it will still end.

Bug: 315074923
Flag: N/A
Test: presubmit
Change-Id: I15a106de78030f6935978539d333cc85ee95b4e7
2023-12-08 14:11:55 -08:00
Thales Lima 0c9e869a8a Update dump tests
Bug: 309800141
Test: DeviceProfileDumpTest
Test: DeviceProfileAlternativeDisplaysDumpTest
Flag: ACONFIG com.android.launcher3.enable_responsive_workspace TEAMFOOD
Change-Id: I75c6a07192f6af94adbea89a6dfdf03984272849
2023-12-08 22:00:51 +00:00
Thales Lima 1faa4edc42 Make numFolderRows/Columns accept more values
InvariantDeviceProfile hold values that are not related to current DP in use. Now other classes get the value correctly from DeviceProfile, and each posture can hold different values, making it akin to iconSize.

Fix: 309800141
Test: DeviceProfileResponsiveDumpTest
Test: DeviceProfileResponsiveAlternativeDisplaysDumpTest
Test: DeviceProfileDumpTest
Test: DeviceProfileAlternativeDisplaysDumpTest
Flag: ACONFIG com.android.launcher3.enable_responsive_workspace TEAMFOOD
Change-Id: I32295738585de67205dcd6c8942d08a3d07d169a
2023-12-08 22:00:48 +00:00
Saumya Prakash 86285d477d Ensure Taskbar stashes when launching an app from folder
We use the folder closing callback to trigger a call to stash the
taskbar if an app was launched. We can check whether an app was launched
from a folder based on whether a folder's view is open when
an app is launched. This ensures that the taskbar only stashes after the
folder is done animating.

Flag: NA
Fix: 295296529
Test: Launched an app in a folder on taskbar. Also ensured that other
taskbar behavior remains unchanged.

Change-Id: Ib5a797186978ee960e44b6b62c833eead03bccd0
2023-12-08 20:16:15 +00:00
Vadim Tryshev 5eac9a5d81 Waiting for wallpaper animation in widget tests only for Nexus Launcher and in postsubmit
This code flakes in postsubmit and presubmit, but the failure is
not reproducible in local and abtd runs. Landing the change to make postsubmit
flake; then I'll use tricks like tracing to debug the cause.

Bug: 313926097
Flag: N/A
Test: presubmit
Change-Id: I77c324d43a2400fe1015f5cd0a4729e34552687c
2023-12-08 12:06:45 -08:00
Holly Jiuyu Sun d60f56c36e Merge "[tile] Update protos." into main 2023-12-08 19:26:50 +00:00
Sebastián Franco c811263007 Merge "Moving finishBindingItems to ModelCallbacks" into main 2023-12-08 16:06:32 +00:00
Sebastián Franco 4d548b5992 Merge "Make all tapl test start with Tapl" into main 2023-12-08 15:43:47 +00:00
Jordan Silva 558e5f8d88 Merge "Fix folder icon drawable padding for responsive grid" into main 2023-12-08 11:34:23 +00:00
Thales Lima 65cc1ff5a4 Merge "Adding test for folder preview loading" into main 2023-12-08 10:15:51 +00:00
Xin Li 92dc7eca5e [automerger skipped] Merge UQ1A.231205.015 am: 861ce33a59 -s ours am: f613df2750 -s ours
am skip reason: Merged-In I91dd8b4088f02af9dc5e603853d8e26606acc38f with SHA-1 c44b3cdda9 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/25590965

Change-Id: If5344196c30aec6ca031a975533e833721db7d83
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-12-08 08:51:05 +00:00
Xin Li f613df2750 [automerger skipped] Merge UQ1A.231205.015 am: 861ce33a59 -s ours
am skip reason: Merged-In I91dd8b4088f02af9dc5e603853d8e26606acc38f with SHA-1 c44b3cdda9 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/25590965

Change-Id: I5aa12dfdfc1885337fa9a10a1cc79f44dff063d2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-12-08 08:21:18 +00:00
Fengjiang Li 83a6a2cd42 Merge "Clear mOnInitialBindListener in Launcher#onDestroy()" into main 2023-12-08 04:05:28 +00:00
Fengjiang Li 17720f1699 Clear mOnInitialBindListener in Launcher#onDestroy()
Bug: 305643224
Test: manual
Flag: N/A
Change-Id: I8c5f670dc7d42eb03e0017a11a0beca2c5005cd3
2023-12-07 17:54:29 -08:00
Xin Li 861ce33a59 Merge UQ1A.231205.015
Bug: 308969284
Merged-In: I91dd8b4088f02af9dc5e603853d8e26606acc38f
Change-Id: I7f5bca7edd18631b36f2b9213e17554cf769cbc6
2023-12-07 15:48:03 -08:00
Vadim Tryshev d7dd3ca0a4 Merge "Better diagnosing when Launcher settings popup is visible" into main 2023-12-07 23:30:25 +00:00
Vinit Nayak 14f3a795e1 Only launch from split taskView if it's visible to user
* Same logic that fullscreen tasks use to launch.
* If not on-screen it will use default fade in animation

Test: Repro-steps don't produce crash
Fixes: 313911097
Flag: None
Change-Id: I4ada7137bffc7c567e4f8184bdd65bdf9bad481e
2023-12-07 15:04:16 -08:00
Vadim Tryshev d7ef3b4486 Merge "Waiting for Launcher stop when dropping a widget that starts an activity" into main 2023-12-07 22:41:50 +00:00
Sebastian Franco 957e4e513e Make all tapl test start with Tapl
Flag: NA
Bug: 298234173
Test: only test name change
Change-Id: Ib2e67a569599568cf1e681a7f1ac44924da83b84
2023-12-07 22:27:53 +00:00
Vadim Tryshev fd07533f37 Better diagnosing when Launcher settings popup is visible
Bug: 187761685
Test: presubmit
Flag: N/A
Change-Id: I27c28ae5914b8b4d96133afafefc93f650f2eda1
2023-12-07 14:00:53 -08:00
Hyunyoung Song a6a16220d4 Merge " ALLAPPS PREINFLATION to TEAMFOOD" into main 2023-12-07 21:59:07 +00:00
Holly Sun 5225c2f870 [tile] Update protos.
Bug: 313696037
Test: manual
Flag: NA
Change-Id: Ic9e9d65b650a2e1f870359cfe59b52a138f53363
2023-12-07 13:04:23 -08:00
Sunny Goyal 522dfa139a Adding test for folder preview loading
Bug: 315352494
Test: atest FolderIconLoadTest
Flag: N/A
Change-Id: Idcef30427b8ea637eb98b1a7a0d2eda09abd0837
2023-12-07 12:11:38 -08:00
Brian Isganitis 23ef0eda05 Merge "Remove types PIN_IME_POPUP and TASKBAR_ALL_APPS from TYPE_ACCESSIBILE." into main 2023-12-07 20:09:05 +00:00
hyunyoungs 11d8641e8a ALLAPPS PREINFLATION to TEAMFOOD
This flag should be enabled again when there is guarantee that
the icons inflated in the background thread is guaranteed to be in the same
device profile as the device profile that is current on the main UI thread

Bug: 312126498
Test: manual
Flag: LEGACY ENABLE_ALL_APPS_RV_PREINFLATION TEAMFOOD
Flag: LEGACY ALL_APPS_GONE_VISIBILITY TEAMFOOD
Change-Id: I9b4dae4327d6bdee135360ca1f40bdec5234ed56
2023-12-07 12:04:10 -08:00
William Leshner 5836cec7ec Merge "Show Launcher's widget picker in an activity." into main 2023-12-07 19:23:58 +00:00
Jagrut Desai a473968d24 Merge "Fixing/Adding Support for "Move to top/left" and "Move to bottom/right" Talkback Menu Item Action" into main 2023-12-07 19:11:51 +00:00
Tony Wickham 1482ec384c Merge "Remove ENABLE_TRANSIENT_TASKBAR and long-press stash support" into main 2023-12-07 19:11:07 +00:00
Vadim Tryshev 4bd8b8c60c Merge "Partially reverting waiting for animation when setting widget result" into main 2023-12-07 17:50:35 +00:00
Sebastian Franco 6196b9067f Moving finishBindingItems to ModelCallbacks
Changes are part of go/launcher_SoR .

Flag: NA
Bug: 301108526
Test: TaplWorkspace
Change-Id: I4c35b540511c9655de1aa1fd0a808a75e7295c1b
2023-12-07 10:58:02 -06:00
Greg Kaiser d806c0abd1 Merge "Revert^3 "Refactor/clean up Overview Actions buttons"" into main 2023-12-07 14:06:19 +00:00
Greg Kaiser e8b1d45485 Revert^3 "Refactor/clean up Overview Actions buttons"
6b99fe1a00

Change-Id: I8f4054335b7bdee898ce3943f4a3798ba51c6fbc
2023-12-07 13:54:39 +00:00
Anna Zhuravleva 63d9cee7b8 Merge "Log taps on PS container buttons" into main 2023-12-07 09:56:10 +00:00
Vadim Tryshev d987586323 Disable alpha jump detector
The detector flakes, and I have no bandwidth now to take care of it.

Bug: 309014345
Test: presubmit
Flag: N/A
Change-Id: I97b02736354274a97ed0eb4eb71773a5c858cae4
2023-12-06 18:57:33 -08:00
Vadim Tryshev 4b3cc96ac2 Waiting for Launcher stop when dropping a widget that starts an activity
This will help to ensure that Launcher state has settled before continuing the test.

Bug: 313926097
Flag: N/A
Test: presubmit
Change-Id: I810c3bd1da2839a482422396536acd664f3e4b82
2023-12-06 18:46:14 -08:00
Vadim Tryshev 286581ebf2 Partially reverting waiting for animation when setting widget result
It flakes, i.e. sometimes the animation is not detected.

Bug: 313926097
Flag: N/A
Test: presubmit
Change-Id: I829e4124879c3a3abe78762a8d04fcd0494f5b1a
2023-12-06 18:15:52 -08:00
Bill Yi aa84ba761e Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2023-12-07 00:09:23 +00:00