Commit Graph

37115 Commits

Author SHA1 Message Date
Schneider Victor-tulias 5b4cf70aab Add logging to help debug invalid icon state and UI. am: 2c8966bbc8 am: 44a7bef2c3
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15889757

Change-Id: Ia79a8039f2a81f61d8a425b00cfd63bc55d588c9
2021-09-23 18:26:35 +00:00
Schneider Victor-tulias 44a7bef2c3 Add logging to help debug invalid icon state and UI. am: 2c8966bbc8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15889757

Change-Id: I038bdd61eb517a9e6d3970fe6153bbe410721fbd
2021-09-23 18:12:29 +00:00
Zak Cohen cc5cfa385b Merge "Update Overview scrim to N1 @ L35 for Dark Theme." into sc-v2-dev am: 144b5c182d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15889494

Change-Id: Iebfd45d0aa7c8b5ed85fcedc54894110754b6a76
2021-09-23 15:58:15 +00:00
Zak Cohen 144b5c182d Merge "Update Overview scrim to N1 @ L35 for Dark Theme." into sc-v2-dev 2021-09-23 15:44:06 +00:00
Steven Ng 4c9d83d6db Merge "Fix RecyclerViewFastScroller scrolling in widgets full sheet" into sc-v2-dev am: 2c4c58a14e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15871269

Change-Id: Idd623627eef21821689432b7f327d40369df83bc
2021-09-23 08:16:40 +00:00
Steven Ng 2c4c58a14e Merge "Fix RecyclerViewFastScroller scrolling in widgets full sheet" into sc-v2-dev 2021-09-23 08:05:35 +00:00
Vinit Nayak 870a105b79 Merge "Shorten and center TaskMenuView for landscape" into sc-v2-dev am: 5dded93a72
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15857414

Change-Id: Iab80cdbf68e75a16b64f4b8e9bae9a8602866cc6
2021-09-23 06:07:37 +00:00
Vinit Nayak 5dded93a72 Merge "Shorten and center TaskMenuView for landscape" into sc-v2-dev 2021-09-23 05:55:17 +00:00
Tony Wickham 06743b6818 Merge "Allow visual stashing when going to overview in tests" into sc-v2-dev am: d523841ab4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15889760

Change-Id: Iee408c6091ec44875387ba390d6f9478a0fb4ccd
2021-09-23 00:50:38 +00:00
Tony Wickham d523841ab4 Merge "Allow visual stashing when going to overview in tests" into sc-v2-dev 2021-09-23 00:39:01 +00:00
Tony Wickham 52e84a8a93 Merge "Remove nonOverlappingTaskarInsets" into sc-v2-dev am: 6b8a139581
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15875056

Change-Id: Ic5c0d9312b3467176a04e1b45ea9c0b52df10bd3
2021-09-22 22:55:10 +00:00
Tony Wickham 6b8a139581 Merge "Remove nonOverlappingTaskarInsets" into sc-v2-dev 2021-09-22 22:44:45 +00:00
Zak Cohen ebda0e4848 Update Overview scrim to N1 @ L35 for Dark Theme.
This avoids clashes with app backgrounds.

Bug: 197321290
Test: Flashed and tested in Dark Theme
Change-Id: Ie94b80ef5bf30f05834d2779f5fc9205dc03c2f4
2021-09-22 15:20:45 -07:00
Vinit Nayak 9e6a642d8b Shorten and center TaskMenuView for landscape
* The width of the task menu view for landscape
(both fake and real) is the same as the width
it would be in portrait.
* With the shorter width, we also center the
positioning of the TaskMenuView
* Note this is only for phone, large screen
changes TODO

Bug: 193432925
Test: Tested real/fake landscape + seascape,
view is centered. Portrait same as before.

Change-Id: Ide41e252a3c177c4a911aab544f78930fed2e76f
2021-09-22 14:55:29 -07:00
TreeHugger Robot 797a282642 Merge "Fix crash in Go Launcher" into sc-v2-dev am: eb2113af00
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15889274

Change-Id: Id9f717a6b4c4893246bc5ef124423a57f80e7aeb
2021-09-22 21:16:53 +00:00
TreeHugger Robot eb2113af00 Merge "Fix crash in Go Launcher" into sc-v2-dev 2021-09-22 21:06:37 +00:00
Tony Wickham 25b6d9783f Allow visual stashing when going to overview in tests
- Seprate out supportsStashing() into supportsVisualStashing() and supportsManualStashing().
- Manual stashing is when user explicitly long presses to stash, which we disable for tests.

Test: testStressSwipeToOverview
Fixes: 200273854
Change-Id: Ib07efa31a1b073de45fdcfac26215129b1b1985b
2021-09-22 13:58:10 -07:00
Schneider Victor-tulias 2c8966bbc8 Add logging to help debug invalid icon state and UI.
PackageInstallStateChangedTask had some redundant state handling that could lead to invalid states. Removed state handling (potential fix to b/198924992) along with logging to help debug b/198924992.

Test: Started and canceled an app download
Bug: 198924992
Change-Id: I8b8202ceb62a3265186d8d46a0e1be6afc83c080
(cherry picked from commit fbf4178ab7)
2021-09-22 20:53:08 +00:00
Vadim Tryshev b7d8a00e97 Merge "Revert "Removing unused tracing"" into sc-v2-dev am: f2c35587d6
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15883599

Change-Id: I632c359b9e2d699d53f3610ed8deae3911610f4e
2021-09-22 20:52:31 +00:00
Vadim Tryshev f2c35587d6 Merge "Revert "Removing unused tracing"" into sc-v2-dev 2021-09-22 20:35:06 +00:00
Schneider Victor-tulias f7cb3d3527 Merge "Add logging to help debug invalid icon state and UI." into sc-v2-dev am: f4f17df565
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15830460

Change-Id: I69648282f1134a7a04bbb49c66aa402564618216
2021-09-22 19:45:38 +00:00
Schneider Victor-tulias f4f17df565 Merge "Add logging to help debug invalid icon state and UI." into sc-v2-dev 2021-09-22 19:26:59 +00:00
Peter Kalauskas 51ad3bfdb8 Fix crash in Go Launcher
Bug: 198141465
Bug: 200747950
Test: Check that wembley is usable after unlocking
Change-Id: I37620be4f24a2f0f8f08483991fad7760415b67c
Merged-In: I37620be4f24a2f0f8f08483991fad7760415b67c
(cherry picked from commit 1beab2a3d7)
2021-09-22 19:08:35 +00:00
Jonathan Miranda 739afa1bec Merge "Play window close animation to home for most app to launcher scenarios" into sc-v2-dev am: e37b51b30f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15741392

Change-Id: I95b22ad6b05fb86707aff017eb11fca3af9f9c7d
2021-09-22 18:38:32 +00:00
Jonathan Miranda e37b51b30f Merge "Play window close animation to home for most app to launcher scenarios" into sc-v2-dev 2021-09-22 18:26:44 +00:00
Vinit Nayak 38935d3441 Merge "Show distinct TaskMenus for each task in GroupedTaskView" into sc-v2-dev am: 9693766477
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15872704

Change-Id: Ie56e8d555cb0f803c30939633dc1533b6e11f17e
2021-09-22 17:38:54 +00:00
Vinit Nayak 9693766477 Merge "Show distinct TaskMenus for each task in GroupedTaskView" into sc-v2-dev 2021-09-22 17:25:08 +00:00
Steven Ng 0e8a2ce0a9 Fix RecyclerViewFastScroller scrolling in widgets full sheet
See b/200132426 regarding to the bugs.

Test: manually tested full widgets picker scrolling on phone and 2
      panels UI.
Fix: 200132426
Change-Id: I13c7a7262e9357cf0acac1c2c7c069b2118bd527
2021-09-22 18:02:44 +01:00
Alex Chau f6e67fb067 Merge "Keep insets stable when taskbar is destroyed/recreated" into sc-v2-dev am: 8f990b94a2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15857676

Change-Id: Ied04deccc9e9ed6813831b7a25ad36380d38a783
2021-09-22 13:45:12 +00:00
Steven Ng e1cceaeb2f Merge "Allow WidgetsBottomSheet to wrap its content" into sc-v2-dev am: c137171c8d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15879754

Change-Id: Ia9c5c9a7164b81ede54df564fce1c64171d7fa06
2021-09-22 13:45:07 +00:00
Alex Chau 8f990b94a2 Merge "Keep insets stable when taskbar is destroyed/recreated" into sc-v2-dev 2021-09-22 13:34:12 +00:00
Steven Ng c137171c8d Merge "Allow WidgetsBottomSheet to wrap its content" into sc-v2-dev 2021-09-22 13:31:33 +00:00
Jon Miranda 8d3d2757e2 Play window close animation to home for most app to launcher scenarios
- Animates into icon/widget location on workspace (when applicable)
- Excludes unlock animation
- Excludes when user goes back to to All Apps state

Bug: 197656197
Bug: 197450256
Bug: 197656915
Test: go in app, swipe back to land on home
Change-Id: Icdf680bd88599f1b6288822a177087283668431c
2021-09-21 20:19:23 -07:00
Vadim Tryshev 827335f209 Revert "Removing unused tracing"
This reverts commit 1cb868e2f7.

Reason for revert: The problem still happens

Bug: 195319692
Test: presubmit
Change-Id: I468c84af743f04f440b719a561e4e5dd6adbf3b4
2021-09-22 02:58:16 +00:00
Lucas Dupin c11fdafe81 Merge "Decrease build time" into sc-v2-dev am: 4f3a750264
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15882771

Change-Id: I3cfdd8d7e1bae3683b277d4a04ce1919e9425144
2021-09-22 01:25:46 +00:00
Lucas Dupin 4f3a750264 Merge "Decrease build time" into sc-v2-dev 2021-09-22 01:14:01 +00:00
Vinit Nayak 7caf5f0ea4 Show distinct TaskMenus for each task in GroupedTaskView
* For now we only show the App Info option
for each task icon clicked for GroupedTaskView
* Have TaskMenuView operate on a specific task instead
of only a TaskView
* NOTE: getItemInfo() in TaskIdAttributeContainer needs to
dynamically call getItemInfo(Task) because at the time of
creation of the container in TaskView#bind(), the task
object provided initially is a palceholder task which only
has a taskId and no other attributes set.
getItemInfo() needs a non-null baseIntent, which the
placeholder task doesn't have.
Right fix for this is to have GestureState hold onto
multiple running tasks when in split screen that are
provided by ActivityManagerWrapper when the gesture starts
(but that change is extensive and out of scope w/ this
workaround available)

Bug: 181704764
Test: Open TaskMenuView's w/ either task icon for
GroupedTaskView, opens up corresponding tasks menu.

Change-Id: I70b7c13394ad4980cabbd611cb928bb03d8a2924
2021-09-21 17:47:54 -07:00
Lucas Dupin e3afcee01d Decrease build time
- by enabling parallel execution
- removing references to deprecated repo

Test: make
Bug: 200725337
Change-Id: I571af7a461f9a3526cc8f24142a605d51eca1386
2021-09-21 15:25:22 -07:00
TreeHugger Robot 21f2b4cc91 Merge "Adding screen record for a flake" into sc-v2-dev am: c48f770a3d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15875064

Change-Id: I16bc98a32e7b12a871617b4fd622e180c0bb6bca
2021-09-21 22:02:15 +00:00
TreeHugger Robot c48f770a3d Merge "Adding screen record for a flake" into sc-v2-dev 2021-09-21 21:49:58 +00:00
TreeHugger Robot 6f23f8db58 Merge "[Search] Sync header Y translation with AllApps y scroll" into sc-v2-dev am: 3b90e1099b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15862034

Change-Id: I3d253d4a724515b5ec9b1401959f57bb5236ce1e
2021-09-21 21:07:14 +00:00
Tony Wickham 21970ccd29 Remove nonOverlappingTaskarInsets
- Override our insets in LauncherRootView to explicitly only care about nav bar size, ignoring any insets due to taskbar.
- Previously we used nonOverlappingTaskbarInsets to belatedly subtract from measurements in e.g. DeviceProfile, but now we can revert most of those calculations since we effectively subtract taskbar insets at the root.

Test: visual in different orientations and navigation modes, and testPressHomeOnAllAppsContextMenu to ensure REQUEST_WINDOW_INSETS still works for automated tests
Fixes: 200607741
Change-Id: I8de5a268c686a1354b4beaa30e101bab6bed5af9
2021-09-21 13:52:43 -07:00
Tony Wickham 7eb5b53865 Keep insets stable when taskbar is destroyed/recreated
- Calculate nav bar insets ourselves. Currently when taskbar is going to be present, we use taskbarSize as the nav bar insets. This is consistent with other existing calculations, but going forward we should instead always use the nav bar size instead of taskbar size, given we don't want taskbar to inset launcher (since taskbar is hidden).
- Also update tappable insets to be 0 in gesture mode. Test: Swipe to all apps, ensure there's no background protection at the bottom.

Test: Rotate device, no visual jumps
Test: Stash taskbar, quick switch a couple times without settling, and swipe up to overview; no jank due to reapplyState()

Bug: 198798034
Fixes: 197232424
Fixes: 197212581
Change-Id: I4c2bb5816dbb214846bd9f2a46c6f759c0545911
2021-09-21 13:52:36 -07:00
TreeHugger Robot 3b90e1099b Merge "[Search] Sync header Y translation with AllApps y scroll" into sc-v2-dev 2021-09-21 20:51:08 +00:00
Vinit Nayak 0ada7824c1 Merge "Prevent focusing next task if focused task part of split select" into sc-v2-dev am: 5f412199ad
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15854777

Change-Id: I474126fe11984793006c8c07529c89d409621a58
2021-09-21 17:41:54 +00:00
Vinit Nayak 5f412199ad Merge "Prevent focusing next task if focused task part of split select" into sc-v2-dev 2021-09-21 17:28:01 +00:00
TreeHugger Robot 8bc27a7ee2 Merge changes I675dbe99,Ia6daa741 into sc-v2-dev am: 139dee45dd
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15862033

Change-Id: I3ef3b561f2c76e5e4c069af751477ae83e11fcb7
2021-09-21 16:52:31 +00:00
TreeHugger Robot 139dee45dd Merge changes I675dbe99,Ia6daa741 into sc-v2-dev
* changes:
  [Hotseat] Fix hotseat edu flicker
  [Hotseat] Show edu tip within screen bounds
2021-09-21 16:33:10 +00:00
Tony Wickham 922c1182e0 Merge "Take panel count into account for page indicator size" into sc-v2-dev am: be34ef61a3
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15873888

Change-Id: I68382a61ec6e2524c012391b6c8c903cd6b36dfb
2021-09-21 15:56:38 +00:00
Tony Wickham be34ef61a3 Merge "Take panel count into account for page indicator size" into sc-v2-dev 2021-09-21 15:43:54 +00:00