Pragya Bajoria
571c9b288d
Merge "Remove obsolete desktop stashing logic from platform/packages/apps/Launcher3 [5/n]" into main
2024-05-16 09:50:17 +00:00
Treehugger Robot
91ff82f9f7
Merge "Reformatting a comment." into main
2024-05-15 16:56:55 +00:00
Song Chun Fan
59fa915e9e
Merge "[Archive] Update the content description for the archived app" into main
2024-05-15 16:18:18 +00:00
Pat Manning
9775908d31
Merge "Promote all apps exit search keyboard test to presubmit." into main
2024-05-15 13:55:19 +00:00
Sam Cackett
155e558b5b
Merge "Fix crash resulting from missing entry in the taskViewIdArray" into main
2024-05-15 12:48:08 +00:00
samcackett
a24cb0e0fc
Fix crash resulting from missing entry in the taskViewIdArray
...
Bug: 338057269
Test: Manual
Flag: NA
Change-Id: Ifa99fe87423ba75f52c43248c8fd730667803d1a
2024-05-15 11:32:48 +01:00
Pragya Bajoria
d9900e0d17
Remove obsolete desktop stashing logic from platform/packages/apps/Launcher3 [5/n]
...
Bug: 309481654
Change-Id: Id7b5db662d578eb625171055d30c37cd59e7d73c
Flag: EXEMPT refactor since it is removing obsolete code with no changes to current behavior.
2024-05-15 09:16:13 +00:00
Treehugger Robot
8146b6281a
Merge "[omni] Handle touch slop for LPAA." into main
2024-05-15 04:52:13 +00:00
Jeremy Sim
2301e66b8f
[automerger skipped] Fix bug with flickering actions bar am: ee9e655c5c -s ours
...
am skip reason: Merged-In I1093363780db5e0780deda2ff14b4f7361d63940 with SHA-1 6198cf6544 is already in history
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/27324185
Change-Id: I43e9e93f01d1b6597e3db2afc2be30ad9ca38db3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2024-05-15 01:39:50 +00:00
Jeremy Sim
33062cf016
[automerger skipped] Fix bug with double-relayout of Overview Actions View am: 740a52a27c -s ours
...
am skip reason: Merged-In I1b6be4637ac8c8d424e7633c437fca376ecdd757 with SHA-1 41eadd1a91 is already in history
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/27270389
Change-Id: Ibc9e03a41b10be695e6bfc5a308329d0e05fc943
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2024-05-15 01:39:45 +00:00
Holly Sun
49dc99abb0
[omni] Handle touch slop for LPAA.
...
Only handle touch slop when the taskbar is pinned (not isTransientTaskbar).
Bug: 335018496
Test: manual
Flag: legacy CUSTOM_LPAA_THRESHOLDS disabled
Change-Id: I4dc6dba473455b02208ef254c271a767bd7c8d42
2024-05-14 16:16:02 -07:00
Brandon Dayauon
e369bd6502
Merge changes I7c303e66,Idc03b9d3 into main
...
* changes:
Add floatingMaskView when animating to mimic bottom container.
Add private_space_floating_mask_view flag.
2024-05-14 23:15:40 +00:00
Anushree Ganjam
a77c28cd78
Merge "Add 0-state web data loader logs" into main
2024-05-14 23:13:03 +00:00
Holly Jiuyu Sun
5334c82136
Merge "[omni] Dynamically configure timeout for LPAA." into main
2024-05-14 21:45:03 +00:00
Jeremy Sim
ee9e655c5c
Fix bug with flickering actions bar
...
This CL fixes a bug caused by ag/27148514. The bug occurred because:
1) The new way we use FloatProperty to set the alpha did not have a working `get()` function, so it just returned a junk value, set to `-1f` (I didn't think `get()` would ever be called meaningfully for this property).
2) However, during certain UI interactions, `RecentsView#updateActionsViewFocusedScroll()` is called many times in a loop, which repeatedly tries to re-start the fade-in animation for actions bar. Pre ag/27148514, even though the fade-in animation was called repeatedly, it would start and then immediately stop running because it realized that it was already set to the desired alpha. However now that we return a junk value for `get()`, it didn't know to skip and just ran the full fade-in animation again and again.
Fixed by refactoring FLOAT_SETTER (now ALPHA_PROPERTY) and creating a new data class, OverviewActionsAlphaProperty, that handles some of the intricacies of this increasingly complicated alpha system.
Fixes: 339545510
Test: Swipe to Overview, move tiles around, actions bar does not flicker.
Flag: ACONFIG com.android.wm.shell.enable_app_pairs NEXTFOOD
Change-Id: I1093363780db5e0780deda2ff14b4f7361d63940
Merged-In: I1093363780db5e0780deda2ff14b4f7361d63940
2024-05-14 21:10:10 +00:00
Jeremy Sim
740a52a27c
Fix bug with double-relayout of Overview Actions View
...
This CL refactors Overview Actions View so that a separate view, R.id.group_action_buttons, is used for buttons related to grouped tasks. This also changes the way visibility is handled with actions buttons -- instead of all buttons living on one bar and being toggled on and off, sometimes the whole bar is toggled on and off (to change from single task actions to group actions and vice versa).
This prevents the same view from having its visibility changed twice in in one layout and causing the wrong visibility to be rendered.
Fixes: 333844287
Test: Manual
Flag: ACONFIG com.android.wm.shell.enable_app_pairs NEXTFOOD
Change-Id: I1b6be4637ac8c8d424e7633c437fca376ecdd757
Merged-In: I1b6be4637ac8c8d424e7633c437fca376ecdd757
2024-05-14 21:09:56 +00:00
Stefan Andonian
d82bf659d3
Merge "Use ItemInfo with correct position when adding to Workspace via Accessibility." into 24D1-dev am: 531ede6f45
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/27345160
Change-Id: I934d089a73eec96c68be1520af285c443a3461c8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2024-05-14 20:25:08 +00:00
Stefan Andonian
531ede6f45
Merge "Use ItemInfo with correct position when adding to Workspace via Accessibility." into 24D1-dev
2024-05-14 20:09:21 +00:00
Holly Sun
8b38295fb2
[omni] Dynamically configure timeout for LPAA.
...
Video: https://drive.google.com/file/d/1N7qOIolcSYM9n3z40FO9O6S_IdLJav9l/view?usp=sharing
Bug: 335018496
Test: manual
Flag: legacy CUSTOM_LPAA_THRESHOLDS disabled
Change-Id: I5b0f7cc7815ecd85c51254ad34f2be521c44795c
2024-05-14 12:42:28 -07:00
Charlie Anderson
22f9e52689
[automerger skipped] Merge "Fix blank pink loading icons by ensuring that cache entry won't downgrade existing icon." into 24D1-dev am: 9f03ea256d -s ours
...
am skip reason: Merged-In I8aac643ec5ca3162cd62bf1051cc751800c626dd with SHA-1 d073ab0b39 is already in history
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/27303311
Change-Id: I5c3305484a46bc16840703323d82cf7a64feaca9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2024-05-14 19:37:28 +00:00
Charlie Anderson
8f6a97a8e1
[automerger skipped] Fix blank pink loading icons by ensuring that cache entry won't downgrade existing icon. am: 0e4ebc9ff2 -s ours
...
am skip reason: Merged-In I8aac643ec5ca3162cd62bf1051cc751800c626dd with SHA-1 d073ab0b39 is already in history
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/27303311
Change-Id: I8e5a45ccc7436c5fdf9ae8cd351827b81f57c760
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2024-05-14 19:37:24 +00:00
Charlie Anderson
9f03ea256d
Merge "Fix blank pink loading icons by ensuring that cache entry won't downgrade existing icon." into 24D1-dev
2024-05-14 19:21:06 +00:00
Charlie Anderson
8aa2898a58
Merge "Fix blank pink loading icons by ensuring that cache entry won't downgrade existing icon." into main
2024-05-14 18:57:09 +00:00
Shamali Patwa
8a5eddb923
Merge changes from topic "update-strings" into main
...
* changes:
Add comments on suggestion category related strings
Clean-up unused categories (follow up cleans up strings)
2024-05-14 18:38:54 +00:00
Stefan Andonian
68686cdfec
Use ItemInfo with correct position when adding to Workspace via Accessibility.
...
Bug: 332651703
Flag: NA
Test: Verified that the issue isn't reproducible with the fix. The issue
was 100% reproducible before.
Change-Id: I01207396e19b4f7d14d6a147e5e5fb98bae9ea99
Change-Id: I81aad9758ee33b8acc2d6a1242e54f2a47124374
(cherry picked from commit 86d3c8814b )
2024-05-14 17:11:55 +00:00
Liran Binyamin
0d8b2206af
Merge "Deflake BubbleBarViewAnimatorTest" into main
2024-05-14 16:53:28 +00:00
Pat Manning
9d1c002e48
Promote all apps exit search keyboard test to presubmit.
...
Bug: 310242894
Test: TaplKeyboardFocusTest
Change-Id: I9a803bf275b3377f0e26ea8a71c1113546a00616
2024-05-14 13:54:04 +00:00
Chris Göllner
fa09b12443
Merge "Convert SysUiState flags from int to long" into main
2024-05-14 10:44:40 +00:00
Luca Zuccarini
de2e793f53
Merge "Tune the window to icon and home scaling animation." into main
2024-05-14 09:12:24 +00:00
Orhan Uysal
3da07952c5
Merge "Disable drag from taskbar while in desktop." into main
2024-05-14 09:02:45 +00:00
Ben Lin
aca7b1cb19
Merge "Update SystemUiProxy signature." into main
2024-05-14 02:22:02 +00:00
Liran Binyamin
097261619b
Deflake BubbleBarViewAnimatorTest
...
Fix an issue where we were verifying the status of the animator on the
test thread, which may have been modified on the main thread.
100x runs: https://android-build.corp.google.com/abtd/run/L42700030003806035/
Flag: ACONFIG com.android.wm.shell.enable_bubble_bar DEVELOPMENT
Fixes: 339437686
Test: abtd link above
Change-Id: I7e0d67e6ca4b2f905ff80f317355d8d5ed0a912b
2024-05-14 00:22:00 +00:00
Shamali P
d07ed6b49b
Add comments on suggestion category related strings
...
Also, deletes unused strings.
Bug: 339570620
Test: N/A
Flag: N/A
Change-Id: I3c53f9788c9734b6962b61d2a13b4445b91892ca
2024-05-13 23:23:34 +00:00
Shamali P
4f492626bd
Clean-up unused categories (follow up cleans up strings)
...
Bug: N/A
Test: Unit tests
Flag: N/A
Change-Id: Id3bd76858d731b9e0eb977c094ebd3b19e1338ce
2024-05-13 23:13:56 +00:00
Bill Yi
ca277a0bf0
Merge "Import translations. DO NOT MERGE ANYWHERE" into main
2024-05-13 20:34:51 +00:00
Bill Yi
0e63467ae1
Merge "Import translations. DO NOT MERGE ANYWHERE" into main
2024-05-13 20:34:51 +00:00
Treehugger Robot
878a547f54
Merge "Convert GroupedTaskView to Kotlin" into main
2024-05-13 20:28:00 +00:00
Jeremy Sim
6243da4667
Merge "Fix bug with flickering actions bar" into main
2024-05-13 19:27:02 +00:00
Treehugger Robot
d931dd7d2f
[automerger skipped] Merge "Import translations. DO NOT MERGE ANYWHERE" into 24D1-dev am: 4d484ce86d -s ours
...
am skip reason: contains skip directive
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/27317538
Change-Id: I626956e8bf8bdecab62b253fcbf2862ea749ba8d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2024-05-13 18:34:41 +00:00
Bill Yi
8b8f48fcc1
[automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 0079ddf92a -s ours
...
am skip reason: contains skip directive
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/27317538
Change-Id: Ica2b5b8d9db729edb41729c0c2312ad4d7cce937
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2024-05-13 18:34:38 +00:00
Brandon Dayauon
4024e25622
[automerger skipped] Merge "Make all apps text focusable by accessibility." into 24D1-dev am: 66176c745c -s ours
...
am skip reason: Merged-In Ibabb92bd9d202221fdc9cfacb585755167898187 with SHA-1 98e150ba7a is already in history
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/27240541
Change-Id: Ice59f5940d43876d5763ca67e8298893db44f502
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2024-05-13 18:31:26 +00:00
Brandon Dayauon
79ab0a43b6
[automerger skipped] Make all apps text focusable by accessibility. am: deb2e2c35e -s ours
...
am skip reason: Merged-In Ibabb92bd9d202221fdc9cfacb585755167898187 with SHA-1 98e150ba7a is already in history
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/27240541
Change-Id: I58ed2bd5bcfb189000c0b085ffca880e22fa27dd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2024-05-13 18:31:23 +00:00
Brandon Dayauon
a4c33bfbaa
Merge "Remove comment on workProfileTest" into main
2024-05-13 18:28:06 +00:00
Treehugger Robot
4d484ce86d
Merge "Import translations. DO NOT MERGE ANYWHERE" into 24D1-dev
2024-05-13 18:16:18 +00:00
Treehugger Robot
0d4567b57b
Merge "Remove COLLECT_SEARCH_HISTORY" into main
2024-05-13 18:15:58 +00:00
Brandon Dayauon
66176c745c
Merge "Make all apps text focusable by accessibility." into 24D1-dev
2024-05-13 18:10:22 +00:00
Brandon Dayauon
1d3ddb877d
Add floatingMaskView when animating to mimic bottom container.
...
- On expand, we add the floating mask view and translate it out at the end.
- On collapse, we translate off the mask view in the beginning once the floating mask view is added
so that we can translate it in before the actual collapsing part of the animation
bug:339850589
Test manually:
https://drive.google.com/file/d/1YNc3vq9Cb5BcbcPOHp8H3lhe6KmYBdLI/view?usp=sharing
Flag:ACONFIG com.android.launcher3.private_space_floating_mask_view STAGING
Change-Id: I7c303e6629d83408bd314886fe10113246e44dcb
2024-05-13 11:08:05 -07:00
Alex Chau
74804ae560
Merge "Remove unused @ScreenRecord and @Stability for closed bug" into main
2024-05-13 18:03:27 +00:00
Charlie Anderson
0e4ebc9ff2
Fix blank pink loading icons by ensuring that cache entry won't downgrade existing icon.
...
Bug: 326607598
Test: manually tested B&R
Flag: N/A
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:d073ab0b3922eb0320a6bc2141cd4a57593a0cac )
Merged-In: I8aac643ec5ca3162cd62bf1051cc751800c626dd
Change-Id: I8aac643ec5ca3162cd62bf1051cc751800c626dd
2024-05-13 17:58:24 +00:00
Charlie Anderson
d073ab0b39
Fix blank pink loading icons by ensuring that cache entry won't downgrade existing icon.
...
Bug: 326607598
Test: manually tested B&R
Flag: N/A
Change-Id: I8aac643ec5ca3162cd62bf1051cc751800c626dd
2024-05-13 13:55:15 -04:00