Commit Graph

80222 Commits

Author SHA1 Message Date
Jordan Silva 564d64c8cc Refactor: Update the way tintAmount is propagated to TTV
- Propagate the tintAmount using the Views instead of using a Flow.

This was done to minimize the usage of Flows to propagate animations
and progress through Views. It should improve the overall performance
of UI updates

Some stats about the number of collections:
- Entering Overview: ~4 collections
- Displaying Scrim: ~32 collections
- Hiding Scrim: ~35 collections
- With 4 apps on screen: ~140 collections

Bug: 390581380
Doc: go/launcher-overview-unified-taskviewmodel
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Test: OverviewImageTest
Test: TaskViewModelTest
Change-Id: Ice68edef12c7e3b2a26107b0fc6e62578de241b4
2025-02-05 15:25:59 +00:00
Jordan Silva bc124b18b8 Remove fullscreenProgress that is not being used
This flow was previously collected by TTVM and later removed by ag/30431716.

Bug: 390581380
Doc: go/launcher-overview-unified-taskviewmodel
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Test: OverviewImageTest
Change-Id: Ie0add87740b00da7d1c5e61c048dace543c47a66
2025-02-05 14:55:08 +00:00
Lingyu Feng c36a10604c Merge "Remove unused executeForTouchInteractionService() in TouchInteractionService" into main 2025-02-04 18:07:28 -08:00
Roy Chou 5c4bb0b8ce Merge "chore(magnification): remove the PRIVATE_FLAG_EXCLUDE_FROM_SCREEN_MAGNIFICATION window flag usage in Launcher app" into main 2025-02-04 17:11:34 -08:00
Liana Kazanova (xWF) 43032a5a61 Merge "Revert "Restore Archived Pinned Shortcuts instead of removing them."" into main 2025-02-04 16:26:27 -08:00
Liana Kazanova (xWF) f5cb1b664b Revert "Restore Archived Pinned Shortcuts instead of removing them."
This reverts commit abbb991d8f.

Reason for revert: DroidMonitor: Potential culprit for Bug X - verifying through ABTD before revert submission. This is part of the standard investigation process, and does not mean your CL will be reverted.

Change-Id: Ifa241a631a1a4361623cfe0e81e31ca6b44e9d73
2025-02-04 15:37:46 -08:00
Shamali Patwa 73ce362894 Merge "Reduce the widget cell horizontal padding" into main 2025-02-04 13:56:42 -08:00
Charlie Anderson 9eb29e78b5 Merge "Restore Archived Pinned Shortcuts instead of removing them." into main 2025-02-04 13:35:30 -08:00
Ajinkya Chalke f583780e73 Merge "Add Aconfig flag for Alt + Tab KQS view on CD" into main 2025-02-04 12:50:34 -08:00
Treehugger Robot 3b11538381 Merge "Simplifying some ActivityContext and StateManager methods" into main 2025-02-04 12:16:44 -08:00
Charlie Anderson abbb991d8f Restore Archived Pinned Shortcuts instead of removing them.
Bug: 375414891
Test: ShortcutsChangedTaskTest, WorkspaceItemProcessor test and manually backing up + restoring.
Flag: com.android.launcher3.restore_archived_shortcuts

Change-Id: I798d56bc1ffef9a454e3899e4155d63f7edf39f2
2025-02-04 11:29:29 -08:00
Brandon Dayauon a0f2b0eeb0 Merge "Log work scheduler animation jank" into main 2025-02-04 10:52:19 -08:00
Sunny Goyal 1ada394e00 Simplifying some ActivityContext and StateManager methods
> Merging asContext and getContext meethod
> Simplifying some generic declaration in StateManager

Bug: 393703968
Flag: EXEMPT refactor
Test: Compilation
Change-Id: I679ac83e39b2a17f510698db15335aae8f735aad
2025-02-04 10:11:34 -08:00
Treehugger Robot d3b31eb20d Merge "Removing BaseDraggingActivity > Merging come methods to BaseActivtiy > Separating wallpaper theme implementation to an independent class" into main 2025-02-04 09:29:46 -08:00
Artsiom Mitrokhin 49909b5167 Merge "Fix taskbar flickering when clicking its bottom part" into main 2025-02-04 07:02:48 -08:00
Pat Manning 8e7130d364 Merge "Refactor TaskViewTouchController to separately handle dismiss and launch." into main 2025-02-04 03:47:03 -08:00
Treehugger Robot f86a05eee2 Merge "Fix attempt for testAddAndDeletePageAndFling" into main 2025-02-03 20:46:21 -08:00
Treehugger Robot bb7190b15a Merge "Only accessing themeManager once the device is unlocked" into main 2025-02-03 20:45:38 -08:00
Lingyu Feng 9a6a1fc4e0 Remove unused executeForTouchInteractionService() in TouchInteractionService
This CL replaces
executeForTouchInteractionService(tis -> executeForTaskbarManager()) with
executeForTaskbarManager() in TouchInteractionService, as `tis` is unused.

Bug: 391786915
Test: m
Flag: EXEMPT refactor
Change-Id: I573a1717aa237f5870157ed95fec4f864a669322
2025-02-04 12:03:40 +09:00
Sunny Goyal edc1453cf1 Removing BaseDraggingActivity
> Merging come methods to BaseActivtiy
> Separating wallpaper theme implementation to an independent class

Bug: 393703968
Flag: EXEMPT refactor
Test: Presubmit
Change-Id: I8cdb6d1520beff3f8226b62c5b7eafd48b2c674f
2025-02-03 17:23:10 -08:00
Shamali P 4ff724727a Reduce the widget cell horizontal padding
With new grid, David suggested reducing padding on widget cell to be
able to show side by side widgets as before. Widget sizes are slightly
larger in new grid.

Bug: N/A
Test: Screenshot tests
Flag: EXEMPT bugfix
Change-Id: I3b3b55930b9e4ad9064151ccfe77ba27d8289860
2025-02-04 01:07:20 +00:00
Sunny Goyal e5ab5669f7 Only accessing themeManager once the device is unlocked
Bug: 393248495
Test: atest RecentsModelTest
Flag: EXEMPT bugfix
Change-Id: I0f2868055de73c25b3eef9243ef0fccbf0383ad5
2025-02-03 16:10:52 -08:00
Brandon Dayauon 302f75ce69 Log work scheduler animation jank
bug: 392726070
Test: manual - see bug comment that shows capture perfetto
Flag: com.android.launcher3.work_scheduler_in_work_profile
Change-Id: Iebf873229a86b53062a91a58bec173c46c964ed5
2025-02-03 23:58:42 +00:00
Federico Baron 1c1b130a4b Fix attempt for testAddAndDeletePageAndFling
it looks like the issue is that the layout has a widget on the second
page leading the page count to be different than expected

Bug: 381918059
Test: TaplWorkspaceTest#testAddAndDeletePageAndFling
Flag: TEST_ONLY
Change-Id: I19e475450494a5580e8fd04d02692624c086807c
2025-02-03 23:05:51 +00:00
Matthew Mourgos 6c19792dcd Merge "Stop mouse click+drag from opening all apps" into main 2025-02-03 13:29:58 -08:00
Pat Manning c824545d07 Refactor TaskViewTouchController to separately handle dismiss and launch.
Remove use of PendingAnimation for task dismiss.

Fix: 389080698
Test: Manual.
Flag: com.android.launcher3.enable_expressive_dismiss_task_motion
Change-Id: Ifdfd7d8ef78bba5d10ff6f157635430637805584
2025-02-03 19:46:52 +00:00
Shamali Patwa a398bf4dc4 Merge "Support exclusion widget category filter in the widget picker" into main 2025-02-03 11:28:41 -08:00
Jeremy Sim 933c73ea0b Merge "Fix bug with app pair 10:90 launch" into main 2025-02-03 11:06:36 -08:00
Shamali Patwa 2b6f14b621 Merge "Fix issue that talkback announces click label on pin sheet" into main 2025-02-03 10:29:09 -08:00
Treehugger Robot 0931a36562 Merge "Log TaskThumbnailView state changes with task ID and view hashcode" into main 2025-02-03 09:32:23 -08:00
Treehugger Robot 4e376db890 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2025-02-03 09:26:40 -08:00
Treehugger Robot 661312bba9 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2025-02-03 09:26:40 -08:00
Shamali P 29715c0a00 Fix issue that talkback announces click label on pin sheet
Pin sheet doesn't support tap-to-add, so doesn't need tap announcement.

Bug: 390562493
Fix: 390562493
Test: With talkback
Flag: EXEMPT bugfix
Change-Id: Iad71248f288e73f4dfbc9077ce8a2454bb5e3e56
2025-02-03 07:00:36 -08:00
Shamali P 2e1b51c54b Support exclusion widget category filter in the widget picker
The newly added NOT_KEYGUARD category enables hosts that shows all
widgets to let widgets opt out from being displayed in keyguard like
surfaces.

Bug: 394047125
Test: Unit tests and support app
Flag: EXEMPT bugfix

Change-Id: Ibaab0c8a052700b77289cd571bca33e3d96fa09f
2025-02-03 14:33:20 +00:00
Jordan Silva d4ae2b1b8f Log TaskThumbnailView state changes with task ID and view hashcode
Fix: 392417881
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Test: Manual.
Change-Id: I17c63afb106e66d87882618580eebd5105d1cb4d
2025-02-03 13:38:37 +00:00
Ajinkya Chalke 772b851fb6 Add Aconfig flag for Alt + Tab KQS view on CD
Change-Id: Icdeebf551828975630adce05bcb1ee3f5956bf98
Flag: EXEMPT adding flag
Test: EXEMPT adding flag
Bug: 394007677
2025-02-03 03:15:38 -08:00
Alex Chau 11c035cb2f Merge "Consider tasks with INVALID_DISPLAY as it's on DEFAULT_DISPLAY" into main 2025-02-03 02:06:51 -08:00
Alex Chau 5ab6c2e68a Consider tasks with INVALID_DISPLAY as it's on DEFAULT_DISPLAY
- In the test environment, some main display tasks can have INVALID_DISPLAY (-1) as their displayId, we should consider them as main display tasks or else they'll be sorted to an unexpected section in RecentsView

Bug: 391311008
Test: TaplTestsQuickstep#testQuickSwitchFromHome
Flag: com.android.launcher3.enable_separate_external_display_tasks
Change-Id: I5a89d91e342557e114eae6796e153a160d729301
2025-02-01 10:01:44 +00:00
Treehugger Robot 85b6ba2821 Merge "Don't close Folder from system nav region while editing name" into main 2025-01-31 22:46:53 -08:00
Treehugger Robot 0012e24fbc Merge "Use launcher db icon column to load pre-archived app icons on restore, similar to Promise Icons." into main 2025-01-31 19:10:15 -08:00
Treehugger Robot 5c11f67ca3 Merge "[CD Taskbar] Refactor TaskbarManager - Make Window Contexts also follow map pattern" into main 2025-01-31 18:02:23 -08:00
Charlie Anderson 0905744966 Use launcher db icon column to load pre-archived app icons on restore, similar to Promise Icons.
- includes loading icons for AllApps as archived apps show there as well

Bug: 391913214
Flag: com.android.launcher3.restore_archived_app_icons_from_db
Test: LoaderTaskTest, LoaderCursorTest and manually doing backup + restore
Change-Id: Icc9dc292551d4a3c6ac23de89aea4cb14856744c
2025-02-01 01:11:04 +00:00
Jeremy Sim bc6df4af71 Fix bug with app pair 10:90 launch
Small fix for supporting the 10:90 split ratio. Previously, we detected the leftTop app by checking for left == 0 or top == 0; this led to a crash on app pair launch for 10:90 because, for example, the left pair's left bound was negative. Now we check for left <= 0 or top <= 0 instead.

Bug: 391866990
Flag: com.android.wm.shell.enable_flexible_two_app_split
Test: Visually correct when a 90:10 pair goes to recents and back
Change-Id: Ie22c12ea547b6d2dfeea4570ec32a79040cc45c2
2025-01-31 16:37:36 -08:00
Tony Wickham e6cb984fdf Don't close Folder from system nav region while editing name
Fixes: 359127164
Test: Manual, add language, change it from IME switcher while
editing folder name
Flag: EXEMPT bug fix

Change-Id: I275bf8ee43d591d1adce98cef99e59c9ffa2baf1
2025-02-01 00:30:45 +00:00
Treehugger Robot d038e1945c Merge "Add grid icon for wallpaper picker" into main 2025-01-31 14:33:03 -08:00
Sukesh Ram 2f74082b3b [CD Taskbar] Refactor TaskbarManager - Make Window Contexts also follow map pattern
Make Window Contexts also follow map pattern.

Flag: EXEMPT not adding new behavior
Bug: 391706879
Test: Manual
Change-Id: Ib0672e653b9dbfcb3597210ca244f110515cd4dc
2025-01-31 21:53:46 +00:00
Matthew Mourgos cdc67c5768 Merge "Stop mouse long press from opening workspace menu" into main 2025-01-31 12:55:09 -08:00
Treehugger Robot 634c3a0f8f Merge changes I8af39b58,I9a3e8ee2 into main
* changes:
  Finally remove `task1` and `task2` from `GroupTask`
  Remove `GroupTask.mSplitBounds`
2025-01-31 11:51:02 -08:00
Treehugger Robot 340720e8a7 Merge "Remove all external usages of GroupTask.task1/2 from Launcher3" into main 2025-01-31 11:42:55 -08:00
fbaron 9ed02b841b Add grid icon for wallpaper picker
Bug: 384938435
Test: n/a
Flag: com.android.launcher3.one_grid_specs
Change-Id: I3480244d63cd8b4796ff656245a862094a1b5854
2025-01-31 19:26:02 +00:00