helencheuk
51ec59dd1f
Disable default focus highlight for Folder to fix the incorrect border issue
...
Agreed with UX that removing visible focus on first ESC keypress is the expected behaviour
So it is disabled in this CL to avoid the square corner focus state
Bug: 329892471
Test: Manual
Flag: N/A
Change-Id: I721bf0916374842c582b6b6523cc4cd5ce78fc02
2024-03-19 18:13:24 +00:00
Fengjiang Li
c19e337202
Merge "[Predictive Back] Support WidgetsTwoPaneSheet" into main
2024-03-19 01:53:10 +00:00
Treehugger Robot
4d22811f76
Merge "Cancel animations after reading MotionPauseDetector#isPaused()" into main
2024-03-18 23:53:17 +00:00
Vinit Nayak
c2a6055768
Merge "Launch overview instance of app for taskbar in Overview" into main
2024-03-18 23:21:23 +00:00
Brian Isganitis
d1af1ec631
Merge "Support toggling Taskbar All Apps with 3P Launcher." into main
2024-03-18 23:17:55 +00:00
Fengjiang Li
c51363fc46
[Predictive Back] Support WidgetsTwoPaneSheet
...
Fix: 325930715
Test: Manual - attached video to bug
Flag: aconfig com.android.launcher3.enable_predictive_back_gesture TEAMFOOD
Change-Id: I44098de12253f803526160bce6457a940b2153c7
2024-03-18 15:31:13 -07:00
Vinit Nayak
b761e9834e
Launch overview instance of app for taskbar in Overview
...
* This only works for fullscreen tasks, app pairs aren't
properly launching yet
* We re-layer the leash to be above launcher since live tiles
are originally below
* The new task comes in from TaskAnimationManager#onTaskAppeared
Bug: 316485863
Test: Tested w/ tapping fullscreen apps in overview when
their thumbnail is scrolled off screen. Animation occurs for
both live tile and thumbnail
Change-Id: I5a3c079244a1517becb845ce25ff9f4e671383b1
2024-03-18 14:41:57 -07:00
Brian Isganitis
a54a267498
Merge "Reset stashed in Taskbar All Apps for gestures instead of IME insets." into 24D1-dev am: 0bcdcb45ba
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/26598276
Change-Id: I6176d89c097ba4927cb99d604389ce0ecd6abe34
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2024-03-18 20:03:04 +00:00
Brian Isganitis
0bcdcb45ba
Merge "Reset stashed in Taskbar All Apps for gestures instead of IME insets." into 24D1-dev
2024-03-18 19:37:02 +00:00
Tony Wickham
77802d6da4
Cancel animations after reading MotionPauseDetector#isPaused()
...
Otherwise, it clears MotionPauseDetector so isPaused returns false.
Fixes: 330186943
Flag: none
Test: manual
Change-Id: I9e0982c18cc5264a1fab53077ac551d2880a6eae
2024-03-18 19:11:57 +00:00
Liana Kazanova
7d5531757b
Merge "Revert "Add CUJ Jank interactions for App Pair saving and launching"" into main
2024-03-18 18:39:20 +00:00
Charlie Anderson
d62a9f1a6a
Merge "Asynchronously call snapToPage so Talkback correctly scrolls to added widget" into main
2024-03-18 18:37:08 +00:00
Liana Kazanova
d8d4fb4375
Revert "Add CUJ Jank interactions for App Pair saving and launching"
...
Revert submission 26567492-appPairsCUJ
Reason for revert: http://b/330185095
Reverted changes: /q/submissionid:26567492-appPairsCUJ
Change-Id: I73d29fe3618a55622e0daa22c9960e3c5783c275
2024-03-18 18:35:02 +00:00
Vinit Nayak
025b06a1a3
Merge "Add CUJ Jank interactions for App Pair saving and launching" into main
2024-03-18 18:06:21 +00:00
Federico Baron
93c58db4c5
Merge "Revert^2 "Add screenrecord for testOverviewDeadzones"" into main
2024-03-18 16:52:24 +00:00
Charlie Anderson
fbf41783fc
Asynchronously call snapToPage so Talkback correctly scrolls to added widget
...
Bug: 326269165
Test: locally tested via Talkback
Flag: N/A
Change-Id: I2be6e9758617e4eca18b3ea1ebed8189145c4108
2024-03-18 16:41:53 +00:00
Alex Chau
d5e4455aa5
Merge "Unpin desktop task in overview" into main
2024-03-18 16:10:25 +00:00
Andrew Cole
6667611f59
Merge "Moving FORCE_MONOCHROME_APP_ICONS to New Flag System" into main
2024-03-18 16:10:03 +00:00
Graciela Wissen Putri
3f46a3d562
Unpin desktop task in overview
...
Desktop task should behave like any other task in overview and should
not show up as a large tile.
Bug: 309008406
Flag: ACONFIG com.android.window.flags.enable_desktop_windowing_mode DEVELOPMENT
Test: Swipe fullscreen task into overview
Open overview from home
Swipe freeform task into overview
Test: Image test will be added in b/319237536
Change-Id: Iefca85747de7595357813d5ed999df0e4b51120a
2024-03-18 14:20:58 +00:00
Rohit Goyal
1a59da4e82
Merge "Bugfixes: Handle session failure unarchival cases so that icon and title are accurate." into 24D1-dev am: f51bd26b3d
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/26599264
Change-Id: I1451fff8e1be77d7f3bb45e1406ba48fdda1df08
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2024-03-18 13:58:54 +00:00
Rohit Goyal
f51bd26b3d
Merge "Bugfixes: Handle session failure unarchival cases so that icon and title are accurate." into 24D1-dev
2024-03-18 13:45:51 +00:00
Uwais Ashraf
bdc5e82dc4
Merge "Adding coroutines library" into main
2024-03-18 10:26:34 +00:00
Jordan Silva
5669ace402
Merge "Fix overview split task icon and app chips flipped and misaligned in fake orientation" into main
2024-03-18 09:57:03 +00:00
Uwais Ashraf
e2625dce7b
Adding coroutines library
...
Fix: 329045417
Test: Presubmit builds passing
Flag: NA
Change-Id: Ifd7f4892f68f99d700d586e78ddd102aa28ff7a0
2024-03-18 08:59:31 +00:00
Alex Buynytskyy
30c0325275
Merge "Fix NewApi warning" into main
2024-03-16 22:38:06 +00:00
Willie Koomson
078737f22b
Merge "Add tap-to-add button to widget picker" into main
2024-03-15 23:26:05 +00:00
Himanshu Gupta
13bf70c7e8
Merge "Ignoring the failing test." into main
2024-03-15 23:03:22 +00:00
Federico Baron
435084cf0d
Revert^2 "Add screenrecord for testOverviewDeadzones"
...
This reverts commit 4d1fe6b854 .
Reason for revert: issue started occurring again
Change-Id: I5a5500c42209afc6b54f7dff60a821093d45294a
2024-03-15 22:58:06 +00:00
Shamali Patwa
61adb489d1
Merge "Distribute the padding between search&rec container and tabs/applist" into main
2024-03-15 22:42:23 +00:00
Federico Baron
f8ffb4f005
Merge "Fix bug where folder with 1 icon can exist" into 24D1-dev am: 74fd490839
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/26598996
Change-Id: I3637c1e9355bedff87845e1d4301369843b20a7d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2024-03-15 22:22:14 +00:00
Sunny Goyal
12d484c380
Merge "Fixing PendingWidgets getting attached to real host" into main
2024-03-15 22:09:29 +00:00
Federico Baron
74fd490839
Merge "Fix bug where folder with 1 icon can exist" into 24D1-dev
2024-03-15 21:42:24 +00:00
Andrew Cole
16b68816ce
Moving FORCE_MONOCHROME_APP_ICONS to New Flag System
...
In order to continue work on theming all app icons we are moving the developer flag over. This is cleanup work
Bug: 270396209
Test: None
Flag: ACONFIG FLAG_FORCE_MONOCHROME_APP_ICONS disabled
Change-Id: Ia290a6761aec68eadd2e78f64ac5dbd233af6033
2024-03-15 14:19:22 -07:00
Vinit Nayak
7ce42078da
Add CUJ Jank interactions for App Pair saving and launching
...
* Added finishCallback consumer to LauncherAccessibilityDelegate
to inform when adding an item to workspace was completed.
* The logic seemed to be dependent on the parameter
"focusForAccessibility", but all callers of that are currently
passing in true
Bug: 328646540
Test: https://paste.googleplex.com/6232597136408576
Newly added CUJs showing up when playing w/ device
Change-Id: I5dce4b7e83fb17cc3a70565bfd5ce100a4cf72bb
2024-03-15 14:10:36 -07:00
Bill Yi
88fea708b2
Merge "Import translations. DO NOT MERGE ANYWHERE" into main
2024-03-15 20:30:19 +00:00
Bill Yi
6e5f97b5e5
Merge "Import translations. DO NOT MERGE ANYWHERE" into main
2024-03-15 20:30:19 +00:00
Willie Koomson
cdc26951ff
Add tap-to-add button to widget picker
...
This change introduces an "Add" button that appears when a widget
preview is clicked in the widget picker. This button disappears when the
preview is clicked again, or another preview is clicked. When the button
is pressed, it adds that widget to the picker. The add button is
available in the app-specific widget sheet as well.
Bug: 323886237
Test: Manual
Flag: ACONFIG com.android.launcher3.enable_widget_tap_to_add DEVELOPMENT
Change-Id: I86a8a4c22119960c54a885fd2efeb91916b4f9a0
2024-03-15 20:10:45 +00:00
Jordan Silva
c4ec531c9f
Fix overview split task icon and app chips flipped and misaligned in fake orientation
...
This CL fixes the app and icon chip misaligned and wrong positioned in fake landscape and seascape.
The icon chip in seascape are still in RTL and it should be address in a different bug b/326377497.
Fix: 320314835
Fix: 326383211
Fix: 326383010
Bug: 328028913
Flag: ACONFIG com.android.launcher3.enable_overview_icon_menu TEAMFOOD
Flag: ACONFIG com.android.launcher3.enable_grid_only_overview TEAMFOOD
Test: manual. instructions described in the bug report.
Test: atest LandscapePagedViewHandlerTest
Test: atest SeascapePagedViewHandlerTest
Test: atest OverviewTaskSplitImageTest
Change-Id: I9be07cc4f4cf5ee6e1da0d954ed7664d96bd330c
2024-03-15 18:29:22 +00:00
Brian Isganitis
2f9ad4645e
Reset stashed in Taskbar All Apps for gestures instead of IME insets.
...
Test: Manual
Flag: NONE
Fix: 328960039
Change-Id: I62c53c21bf850b7080e12086235cba28164f4d70
(cherry picked from commit 1956246b6e )
2024-03-15 18:13:12 +00:00
Brian Isganitis
c113b277e6
Support toggling Taskbar All Apps with 3P Launcher.
...
Taskbar All Apps exists regardless of the default launcher. Thus, we can
toggle it on large screen devices. This CL ties registering the system
action to default launcher and taskbar's enablement.
Test: adb shell input keyevent 117
Test: AllAppsActionManagerTest
Flag: LEGACY ENABLE_ALL_APPS_SEARCH_IN_TASKBAR ENABLED
Fix: 317259709
Change-Id: I26f0ed9e921beac762f3f9e6aaceb1002ad4801a
2024-03-15 13:42:10 -04:00
Sunny Goyal
d51f91a7d0
Fixing PendingWidgets getting attached to real host
...
Bug: 318539160
Flag: aconfig enable_workspace_inflation DISABLED
Test: TaplBindWidgetTest#testPendingWidget_notRestored_activeInstall
Change-Id: I013811e83b90ea32221904a27790dd677dd63b4b
2024-03-15 10:16:33 -07:00
Treehugger Robot
6300f0550d
[automerger skipped] Merge "Import translations. DO NOT MERGE ANYWHERE" into 24D1-dev am: 2edebc108a -s ours
...
am skip reason: contains skip directive
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/26595286
Change-Id: I7ae526e488a66c031da26e30f9ec0ba50d46f226
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2024-03-15 17:09:31 +00:00
Bill Yi
6df9145322
[automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 577b4e4db6 -s ours
...
am skip reason: contains skip directive
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/26595286
Change-Id: Ic9dce927cfd370bf256c0cf471f98cca71c48a90
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2024-03-15 17:09:26 +00:00
Treehugger Robot
b27dadfbc0
[automerger skipped] Merge "Import translations. DO NOT MERGE ANYWHERE" into 24D1-dev am: 1090b779e7 -s ours
...
am skip reason: contains skip directive
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/26595284
Change-Id: I346c2ed3499d8a02d1665a1c917284f34b205f56
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2024-03-15 17:09:22 +00:00
Bill Yi
67d9b98671
[automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: b71c4de721 -s ours
...
am skip reason: contains skip directive
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/26595284
Change-Id: I21ad15e7efd1b476472c2a4e0d42337e7dad15de
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2024-03-15 17:09:12 +00:00
Treehugger Robot
2edebc108a
Merge "Import translations. DO NOT MERGE ANYWHERE" into 24D1-dev
2024-03-15 16:49:43 +00:00
Treehugger Robot
1090b779e7
Merge "Import translations. DO NOT MERGE ANYWHERE" into 24D1-dev
2024-03-15 16:49:43 +00:00
fbaron
b41c826c6a
Fix bug where folder with 1 icon can exist
...
Fix: 329357132
Flag: NONE
Test: TaplDragTest
Change-Id: If381ff56e051c89e9f6162f8a44f8df9e2ae5060
(cherry picked from commit 5645c3ec55 )
2024-03-15 16:11:26 +00:00
Fengjiang Li
00711e68a5
Merge "Enable predictive back in TAPL tests" into main
2024-03-15 14:52:58 +00:00
Shamali P
02a75fc924
Distribute the padding between search&rec container and tabs/applist
...
When there are no recommendations (pre-V as well), the margins/paddings
between search container & apps list / tabs was 8dp extra.
Additionally, cleaning up -
1. requestLayout call on page switch is now not needed after limiting
the table space for recommendations in two pane picker.
2. After preview container sizes, TOP alignment actually looks a bit
better - and widget preview itself is automatically center aligned as
we club only same preview container sizes in a row now.
* http://screen/6e6YzjqXJrdZ7Bt
* http://screen/AVLpzoYSGpyr2rs
* http://screen/7xnmrtLvBMPX5iX
* http://screencast/cast/NjYyNzM4NDY3MjM4NzA3Mnw2NDY0MmU4ZC0xMw (phone)
* http://screencast/cast/NTYwMzE1NDI1ODI5NjgzMnw2NmM1MjRkZS0zNA (fold)
* http://screencast/cast/NTIzODk3NTM5MTMzNDQwMHxlYmE2NDEwNS0xZg (tablet)
Bug: 319152349
Flag: N/A
Test: Screenshot and manual
Change-Id: I164419624d02fb47e80ea844eea0ee2a869ad4df
2024-03-15 13:36:20 +00:00