Commit Graph

16456 Commits

Author SHA1 Message Date
Alex Chau b0f42f03bf Merge "Adjust height of tablet AllApps base on row height" into tm-qpr-dev 2022-08-04 13:55:06 +00:00
Pat Manning 9fd69c0d42 Remove scaling from spring loaded y translation.
Fix: 239401465
Test: manual. To follow up with screenshot test: b/241386128
Change-Id: I916fcca22f5c827e1af38a50847585afcefc330d
2022-08-04 14:53:35 +01:00
Alex Chau 206ede9c1f Adjust height of tablet AllApps base on row height
- Also used hotseatQsbHeight for AllApps QSB height as they have to match to transform between each other

Fix: 232907846
Test: manual on different tablets
Test: atest DeviceProfileTest
Change-Id: I001d0e129db2a5de6c8ace4c3302381110da03f1
2022-08-03 15:29:22 +00:00
TreeHugger Robot 98fd9c0da3 Merge "Account for span greater than 1 in getReorderRadius" into tm-qpr-dev am: 89b8f65277 am: eaeceb9b7b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19441591

Change-Id: I379fa83f94a542bc478bb659fd82b38c5eae6fa5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-03 14:49:44 +00:00
Sunny Goyal 4d83501f4a Merge "Removing unused ShadowDrawable" into tm-qpr-dev am: 41321dfe71 am: 7e0795609f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19506676

Change-Id: Ice81f1a10f5dd6be83efaa938c978310990e312b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-03 14:49:32 +00:00
Sunny Goyal f4d0a0ba70 Merge "Create less number of dot-renderers at startup" into tm-qpr-dev am: f28c428050 am: e00fc434f0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19498070

Change-Id: If53c5b0c7977b6570c14bf9aac6efe7802728f48
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-03 14:49:21 +00:00
TreeHugger Robot 89b8f65277 Merge "Account for span greater than 1 in getReorderRadius" into tm-qpr-dev 2022-08-03 14:12:45 +00:00
Sunny Goyal 41321dfe71 Merge "Removing unused ShadowDrawable" into tm-qpr-dev 2022-08-03 14:08:52 +00:00
Sunny Goyal f28c428050 Merge "Create less number of dot-renderers at startup" into tm-qpr-dev 2022-08-03 14:08:07 +00:00
Sunny Goyal ea6d59fbd4 Removing unused ShadowDrawable
Bug: 241152608
Test: Presubmit
Change-Id: Iae3b3799959dfe3457791cfac88a2cb4ac5770a4
2022-08-02 14:58:25 -07:00
Sunny Goyal 65190aef37 Create less number of dot-renderers at startup
Bug: 235568943
Test: Launcher starts and shows dots normally
Change-Id: I6958b9b98efb43aa280e6ce31af9c0c936610dea
2022-08-02 14:43:31 -07:00
Sunny Goyal c5c7da9a8b Removing some obsolete features
PROMISE_APPS_NEW_INSTALLS = true
ENABLE_QUICKSTEP_WIDGET_APP_START = true
FOLDER_NAME_SUGGEST = true
ENABLE_PREDICTION_DISMISS = true
HOTSEAT_MIGRATE_TO_FOLDER = false
ENABLE_DEEP_SHORTCUT_ICON_CACHE = true
ENABLE_THEMED_ICONS = true
ENABLE_ALL_APPS_EDU = true
EXPANDED_SMARTSPACE = false

Bug: 241141733
Test: Presubmit
Change-Id: I72c0c20ab7e214994dc3c3665c90e85d45991a7a
2022-08-02 13:38:38 -07:00
Sihua Ma 1d8b7cba31 Showing Toast message when the target package is null for the disabled shortcut
The shortcut for a certain set of apps could have their component names set to null. In this case, if we still need the package name for the shortcut, we should use the package name from the intent, which is accomplished in getTargetPackage. Additionally, if the target package is still null, we are falling back to showing the Toast messages only.

Fix: 239685630
Test: Verified that the crash no longer happens after clicking on grayed out shortcuts
Change-Id: I4de68ea1a227032e16e5c00407f75159a7aba30f
2022-08-02 11:17:29 -07:00
Vinit Nayak e677538171 Use Taskbar window for phones (only works on gesture nav) with flag am: 7db37b3d94 am: b197ea0c25
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18801667

Change-Id: If22f89319b68b9b13422a3b5e3e9ae855d22731e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-02 04:30:54 +00:00
Vinit Nayak 7db37b3d94 Use Taskbar window for phones (only works on gesture nav) with flag
* Try to avoid re-creating TaskbarActivityContext to
avoid re-inflating taskbar views
* Toggle via Flipper App (key 1101)
OR adb shell setprop persist.wm.debug.hide_navbar_window 1 && adb reboot
TODOs
* Only works for gesture nav, not 3 button
* Sampling on phone doesn't always work.

Bug: 219035565
Change-Id: I2a015f99d5f1fe86d7261eec9fd898bd4480ff9f
2022-08-01 17:48:09 -07:00
Schneider Victor-tulias fa4bca182b Merge "Add logging to help debug additional app infos being updated by CacheDataUpdatedTask" into tm-qpr-dev am: 4eec22f818 am: 187b9ef0f5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19462408

Change-Id: I862086421d6d67f229674b5ff96774149323aecf
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-01 22:43:44 +00:00
Schneider Victor-tulias 4eec22f818 Merge "Add logging to help debug additional app infos being updated by CacheDataUpdatedTask" into tm-qpr-dev 2022-08-01 21:50:09 +00:00
TreeHugger Robot ae670bdc53 Merge "Remove unused logs" into tm-qpr-dev am: f47491bdf8 am: 4397dec83d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19417493

Change-Id: I9d8343bba0e5708c0629434abf0e0319c8bf8405
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-01 21:07:33 +00:00
TreeHugger Robot f47491bdf8 Merge "Remove unused logs" into tm-qpr-dev 2022-08-01 20:29:53 +00:00
Alex Chau e62dbea9ad Merge "Refactor DeviceProfile tests based on dump() and use real device dimensions for tests." into tm-qpr-dev am: ceb2aaa9e4 am: a8b1b20f70
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19356826

Change-Id: I22e17e64a30c44e42fa17e1f130143054e30adf8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-01 18:50:08 +00:00
Pat Manning 5f74bfd76d Refactor DeviceProfile tests based on dump() and use real device dimensions for tests.
- Added roundPxValueFromFloat when converting dp/sp to px to deterministically round up values around .5

Fix: 240133465
Bug: 237542518
Test: DeviceProfileTest.kt
Change-Id: If4239f714487fe5bf2ef44274e2ce415bd75c86d
2022-08-01 17:54:43 +00:00
TreeHugger Robot e4f4ed218c Merge "Fixing search behavior in Launcher3" into tm-qpr-dev am: 8157be497d am: 3e5b0dd39d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19451873

Change-Id: Id43e98acb1065c72da88b4f8913201888dcbc940
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-07-29 21:02:01 +00:00
Sebastian Franco 6e1024e161 Account for span greater than 1 in getReorderRadius
Fix: 239963678
Test: Making sure the reorder preview is being drawn when moving a widget
Test: atest ReorderWidgets
Change-Id: Id32919821ac9177b3428261354d361c52b8f9e2d
2022-07-29 13:47:33 -07:00
Schneider Victor-tulias 1dbffe0af7 Remove unused logs
Fixes: 240173459
Test: Started launcher
Change-Id: I853d9a50a0c34a7fdda87ea20d46a9f7ac7542e3
2022-07-29 13:06:24 -07:00
TreeHugger Robot 8157be497d Merge "Fixing search behavior in Launcher3" into tm-qpr-dev 2022-07-29 19:48:34 +00:00
Jeremy Sim c9919c90a4 Merge "Update animations for TM-QPR: OverviewSplitSelect > Home transition" into tm-qpr-dev am: b7a781b599 am: 67c895776d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19224802

Change-Id: I9e684eff49cea2edce34917c02413cc1cf688f08
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-07-29 19:39:47 +00:00
Jeremy Sim c8e159d4cc Merge "Update calculation method for Overview UI placement on tablets" into tm-qpr-dev am: fe5bccbf6f am: 1b468babdc
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19289801

Change-Id: Ic97e19a97a19a1a1379c929fd8e9f5e8d0f8f77f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-07-29 19:38:59 +00:00
TreeHugger Robot 197508c120 Merge "Listen to DisplayController for ignoreAutoRotateSettings" into tm-qpr-dev am: f49287d627 am: 1ba7282333
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19429918

Change-Id: I664401712cbad5c3eb373827ae5f79dec65e6652
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-07-29 19:06:39 +00:00
Jeremy Sim b7a781b599 Merge "Update animations for TM-QPR: OverviewSplitSelect > Home transition" into tm-qpr-dev 2022-07-29 18:57:00 +00:00
Jeremy Sim fe5bccbf6f Merge "Update calculation method for Overview UI placement on tablets" into tm-qpr-dev 2022-07-29 18:56:40 +00:00
TreeHugger Robot f49287d627 Merge "Listen to DisplayController for ignoreAutoRotateSettings" into tm-qpr-dev 2022-07-29 18:05:17 +00:00
Sebastián Franco 33edba1006 Merge "[Cherry pick merge conflict] Updating visibility of some members for easier extensibility" into tm-qpr-dev 2022-07-29 17:23:46 +00:00
Alex Chau 6209af67d3 Listen to DisplayController for ignoreAutoRotateSettings
- Also skip most of initDeviceProfile/onIdpChanged if DeviceProfile didn't actually change to effectively skip the 2nd unexpected onConfigurationChangeded caused by setRequestedOrientation (b/211763738)

Test: Change display size while in app or at home screen
Fix: 240019605
Change-Id: If307742639bd269622140a7da0dc900887c67937
2022-07-29 13:09:17 +01:00
Sunny Goyal af95ddbadc Fixing search behavior in Launcher3
> Showing no-result found only when there are no results
> Removing unnecessary view inflation in RecyclerViewPool for
  various search vide types
> Removing unused market-search link and no-empty-result illustration

Bug: 240343082
Bug: 207573083
Test: Verified Launcher3
Change-Id: Ia44799cd2385ea5dc837ef25732ca237975abde7
2022-07-28 22:05:30 -07:00
Schneider Victor-tulias 62511de74e Add logging to help debug additional app infos being updated by CacheDataUpdatedTask
Bug: 239465630
Test: ran test locally.
Change-Id: I1b31cfaeb697f87acd99d787284f55d7e6b75b54
2022-07-28 23:09:39 +00:00
Jeremy Sim 1cfe6d490a Update calculation method for Overview UI placement on tablets
This update slightly changes the calculation method for Overview UI placement, in order to line up better with spec. (The previous calculation caused a small 30dp divergence on tablets.)

Bug: 236760307
Test: Manual by measuring pixels and comparing to spec
Change-Id: I94e9e7b5a6a24c37693425ac8ec71cd066003658
2022-07-28 14:05:24 -07:00
Andy Wickham dacf259451 Merge "Only bind fast scrollbar when attached if not already bound." into tm-qpr-dev am: f61e7bb4a2 am: 82f02caceb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19225719

Change-Id: I158932f262fd17610f17e9ef847cf2016798b4d5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-07-27 23:17:15 +00:00
Andy Wickham f61e7bb4a2 Merge "Only bind fast scrollbar when attached if not already bound." into tm-qpr-dev 2022-07-27 22:27:25 +00:00
Andy Wickham 87a9bf7c15 Only bind fast scrollbar when attached if not already bound.
This was overriding the previously bound RecyclerView if multiple
were attached simultaneously. Instead, the appropriate container
(All Apps / Widgets) should bind the active RecyclerView whenever
it changes, with the onAttach serving as a fallback to ensure
the scrollbar has an initial RV to avoid NPEs.

Fix: 234591523
Bug: 235476489
Test: Manually checked All Apps from Launcher and Taskbar, as well
as Widget bottom sheet. Also ran relevant Tapl tests.

Change-Id: I06e27d2f66f9778087711a566817b6806ec7218b
2022-07-27 21:02:34 +00:00
Shikha Malhotra bc9b08fdd1 [Cherry pick merge conflict] Updating visibility of some members for easier extensibility
This change is causing a merge conflict with ag/19441591. Hopefully only a cherrypick is needed.

Bug: b/218186980
Test: Manual Testing that Launcher3 compiles and works
Change-Id: Id85486ef763ce9a04b83fef44542b2eb3e0e599d
(cherry picked from commit c487e1b4c5)
2022-07-27 20:33:29 +00:00
vadimt f6ef879cf4 Moving all sources that are shared between Launcher and TAPL in one directory
This will help SysUI test team (who uses TAPL) to set up Gradle build for their tests.

Bug: 202567877, 234414088
Test: presubmit
Change-Id: I3d923ea4b54d1a4c3d2b345be09692727d30433e
2022-07-27 20:18:46 +00:00
Sukesh Ram 1ea641ae1e Merge "Fix crash on long press of prediction row icons" 2022-07-27 17:55:37 +00:00
Sukesh Ram c4430c9cd7 Fix crash on long press of prediction row icons
Changed icon long click listener to use secondary display's long
click listener instead of launcher's.

Bug: 239616635
Test: Manual
Change-Id: I9a4679ba82cacb5e2648481274876dbfc95d80ce
2022-07-27 00:05:35 +00:00
vadimt 47f347b1cf Moving all sources that are shared between Launcher and TAPL in one directory
This will help SysUI test team (who uses TAPL) to set up Gradle build for their tests.

Bug: 202567877
Test: presubmit
Change-Id: I95c267e46cf675ac44dc27b07d0a1143ab761e35
2022-07-26 15:43:00 -07:00
Schneider Victor-tulias 2d1a071f16 Merge "Fade out the taskbar icons when animating to overview in 3 button nav." into tm-qpr-dev am: f6003ff070 am: de490c6bb1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19051009

Change-Id: I3c105a7632851acbb36be8607b51c23d9d3b2a0c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-07-26 19:05:19 +00:00
Schneider Victor-tulias f6003ff070 Merge "Fade out the taskbar icons when animating to overview in 3 button nav." into tm-qpr-dev 2022-07-26 17:29:33 +00:00
TreeHugger Robot d33659576c Merge "Space out 3 button nav on taskbar" into tm-qpr-dev am: 5e6fe32818 am: 2a8906bfba
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19272533

Change-Id: I2ea492fac54d0fabf1af92500e2ad102855c4c79
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-07-26 17:21:17 +00:00
TreeHugger Robot 5e6fe32818 Merge "Space out 3 button nav on taskbar" into tm-qpr-dev 2022-07-26 16:32:06 +00:00
Alex Chau 2a9dafcce1 Merge "Revert "Move BaseActivityInterface task size methods to DevicePr..."" into tm-qpr-dev am: 66bac181ac am: eed67e721e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19398184

Change-Id: If4406214f9853f055719deda5674ea0e1fc3e958
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-07-26 10:29:02 +00:00
Alex Chau 66bac181ac Merge "Revert "Move BaseActivityInterface task size methods to DevicePr..."" into tm-qpr-dev 2022-07-26 09:36:18 +00:00