Commit Graph

16456 Commits

Author SHA1 Message Date
Schneider Victor-tulias 7ba044f10b Merge "Add gesture nav error state tracking and logging" into tm-qpr-dev am: ff5ad47a06 am: 520bf2e892
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19300928

Change-Id: I7830f925e70d89f84fce7da317403e03dacbb419
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-30 23:55:39 +00:00
Sukesh Ram 1b4869fcbc Add app predictions to secondary display app drawer & fix tab UI.
Bug: 233926067
Test: Manual
Change-Id: I2f45a4b30964b365bf149e8864a3af2ea909a237
(cherry picked from commit 9e5fe63a22)
Merged-In: I2f45a4b30964b365bf149e8864a3af2ea909a237
2022-08-30 22:30:03 +00:00
Tony Wickham c8e824dbdb Add support to Tapl to recreateTaskbar
Also moved references of "tasbkar_view" to share TASKBAR_RES_ID constant

Test: compiles; see follow up CLs
Bug: 235986838
Change-Id: I69bcfa975550e567f3daa35af8a810546297d79c
2022-08-30 13:40:45 -07:00
Schneider Victor-tulias 038922a653 Add gesture nav error state tracking and logging
- Added ActiveGestureErrorDetector
- Removed startQuickstep logs; these were confusing and not helpful in ActiveGestureLogs

Test: printed logs after several gestures
Bug: 227514916
Design: go/gesture-nav-logging
Change-Id: Ia2a7e4f90a3a371d9a92190aa66eb07acd061d6c
2022-08-30 12:18:29 -07:00
Pat Manning 7a5048297d Merge "Refactor overview progress as splash progress." into tm-qpr-dev am: b4a30ab955 am: 99bce932a2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19730966

Change-Id: I3abd3fd009ed7d6d7f4754bcece6a594bab3db61
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-30 14:17:18 +00:00
Pat Manning e63dd25a54 Use full screen width for drop target buttons to support higher screen densities from truncating text.
Scale oversized text down if after all computations it will still be truncated at higher densities.

Fix: 239401464
Test: manual. To follow up with screenshot test: b/241386128
Change-Id: Ie088d0631b0d13beb2d9f9d5396a56f7b971dee1
2022-08-30 14:57:42 +01:00
Pat Manning b4a30ab955 Merge "Refactor overview progress as splash progress." into tm-qpr-dev 2022-08-30 13:29:53 +00:00
Pat Manning 81dc9ad131 Refactor overview progress as splash progress.
This also avoids showing splash in split select state

Fix: 242284413
Test: follow up after b/238405972
Change-Id: I2e83fa3d030e8a74edb4152c472dbf02ac5a80b1
2022-08-30 11:23:08 +01:00
Sebastian Franco 47558a6201 Adding flag to improve the icons reordering on foldables
Test: compiles
Bug: 188081026
Change-Id: Ifa30bbc9ff38f2cc0f9530f3e075b5eb662f63eb
Merged-In: Ifa30bbc9ff38f2cc0f9530f3e075b5eb662f63eb
2022-08-29 22:08:20 +00:00
Sebastián Franco b35a9e51fc Merge "[Merge conflict tmp-qpr] Adding flag to improve the icons reordering on foldables" 2022-08-29 22:03:29 +00:00
Becky Qiu edea2575e6 [Toast] Add a feature flag for using app search for web zero-state.
Bug: 241001264
Test: local
Change-Id: Id4af1664253182217014a43d8f8025f1a00da291
2022-08-26 16:41:05 -07:00
Sebastian Franco ffae7d256c [Merge conflict tmp-qpr] Adding flag to improve the icons reordering on foldables
Test: compiles
Bug: 188081026
Change-Id: Ifa30bbc9ff38f2cc0f9530f3e075b5eb662f63eb
2022-08-26 00:05:27 +00:00
Schneider Victor-tulias 305a1df9d9 Merge changes I562abc6c,I7a48d960,I0916f969 into tm-qpr-dev am: 7fb96a5305 am: 2ed4c84e68
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19517498

Change-Id: If267d42f6d15fef03373ffe0c77fc1ebb1a7dd3a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-25 21:31:02 +00:00
Schneider Victor-tulias 7fb96a5305 Merge changes I562abc6c,I7a48d960,I0916f969 into tm-qpr-dev
* changes:
  Update ActiveGestureLog to store n-gestures rather than n-events.
  Add input consumer selection reason to active gesture logs
  Collapse EventLogArray into ActiveGesture log.
2022-08-25 20:42:13 +00:00
Schneider Victor-tulias 24637f50c5 Add input consumer selection reason to active gesture logs
Test: manually tried gestures in 3 button and gesture nav and checked logs
Bug: 227514916
Change-Id: I7a48d960ef5a41ddee95153fa08a2345f00cbef7
2022-08-25 10:03:30 -07:00
Schneider Victor-tulias a0cd3e0295 Collapse EventLogArray into ActiveGesture log.
EventLogArray is never used directly, only used as a super class of ActiveGestureLog. Simplifying the hierarchy to simplify follow-up changes.

Test: manually tried gestures in 3 button and gesture nav and checked logs
Bug: 227514916
Change-Id: I0916f969a776953ddc4886846ad2f4936566e7d7
2022-08-25 09:59:13 -07:00
Thales Lima 1e8b45f8f1 Extract cell horizontal space to a method
Fixes: 229100375
Test: DeviceProfileTest
Change-Id: Ia2e560b37f4e9fbff9b5c2e7c0ef3fe710e55c29
2022-08-25 11:50:59 -04:00
Brandon Dayauon c2cb9a3823 Merge "Fix jumpiness when dragging surface down and up." into tm-qpr-dev am: dc51afd920 am: 6c3f5a32aa
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19600189

Change-Id: I50d10c838e8e6291a261243898de201f3ce1bb0b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-24 05:25:07 +00:00
Pinyao Ting 292d0d3dc9 Merge "Explicit Nullbility in Launcher (Part 2)" into tm-qpr-dev am: 775b0d21dc am: ff8f09b5b5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19679564

Change-Id: I569d5e6fd9ebbcb31266c6683c129481ee3c2144
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-24 05:08:54 +00:00
Brian Isganitis 06b1d8c114 Merge "Added debug menu option for testing secondary display." into tm-qpr-dev 2022-08-23 23:57:15 +00:00
Brandon Dayauon dc51afd920 Merge "Fix jumpiness when dragging surface down and up." into tm-qpr-dev 2022-08-23 20:38:52 +00:00
Pinyao Ting 775b0d21dc Merge "Explicit Nullbility in Launcher (Part 2)" into tm-qpr-dev 2022-08-23 16:53:20 +00:00
Brandon Dayauon d4a60b394f Fix jumpiness when dragging surface down and up.
Currently the overshoot only works when you first open all apps and try
to extend the all apps to the top (making it overshoot). This pull works
when you go mFromState:Normal -> mToState:AllApps. However once the all
apps is set and you move the surface down then up..that overshoot
animation jumps AFTER your finger goes all the way up and off the
screen. At this point, once all apps is completely opened.. the states are
mFromState:AllApps -> mToState:Normal.

Now with this change, it addresses the jumpiness by considering the
current states (mFromState==AllApps) by
including the same onPull() but with different calculations

bug: 240669628
test: manual - videos included in bug thread
Change-Id: I7873f1ec22574f87fab3d2f11d1f5a5f81dfb5bc
2022-08-23 01:20:22 +00:00
Sunny Goyal 94da7bd9f3 Merge "Compressing view capture data and changing the format to avoid storing duplicate strings" into tm-qpr-dev am: 56677c50bd am: 97da32d50d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19638802

Change-Id: Id35b4b24ce569b1abe9ee4169de8e2bd4eb7af2e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-23 00:45:39 +00:00
Pinyao Ting 023b973d15 Explicit Nullbility in Launcher (Part 2)
This CL updates the nullabality on methods associated with IconCache in Launcher.

Bug: 242895652
Test: manual
Change-Id: I4832c0950141c8a52c8a9e62659ccabb082897c8
2022-08-22 17:15:44 -07:00
Sunny Goyal 56677c50bd Merge "Compressing view capture data and changing the format to avoid storing duplicate strings" into tm-qpr-dev 2022-08-23 00:10:05 +00:00
Sukesh Ram 93c710b9ac Added debug menu option for testing secondary display.
Test: manual
Fix: 233639924
Change-Id: Iaca90a1391078d56bd57fa5de097f34ec0425866
(cherry picked from commit aed1b074f3)
2022-08-22 22:25:28 +00:00
Sunny Goyal ca5761d21f Merge "Removing some obsolete features" into tm-qpr-dev am: 211496e3d8 am: a3dacac8b9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19505122

Change-Id: I8a0157caa803b2edcef458895d7e9ded06ea5fe0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-22 21:07:20 +00:00
Sunny Goyal 211496e3d8 Merge "Removing some obsolete features" into tm-qpr-dev 2022-08-22 20:27:45 +00:00
Luca Zuccarini c97195c1fc Merge "Set the default for keyboard sync to IS_STUDIO_BUILD." into tm-qpr-dev am: ee29b830b4 am: c905fd544a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19668493

Change-Id: Id3cad76e985f7b8da0f586b3b515b55b1d3b1a6e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-22 09:52:24 +00:00
Luca Zuccarini ee29b830b4 Merge "Set the default for keyboard sync to IS_STUDIO_BUILD." into tm-qpr-dev 2022-08-22 09:12:01 +00:00
Sukesh Ram b6d673ad40 Merge "Enable Pinning Deep Shortcuts in Secondary Display" 2022-08-19 23:18:52 +00:00
Sukesh Ram 353b0a914f Enable Pinning Deep Shortcuts in Secondary Display
Currently, deep shortcuts can be pinned to the workspace grid (home screen) upon long click of the icon. However, a challenge in doing so has been persistence of these shortcuts because whenever a new secondary display activity gets started, these pinned shortcut icons vanish. To address this, we store pinned shortcut data in memory which is done here via SharedPreferences.

Retrieval of this data still needs to be done as outlined here: https://docs.google.com/document/d/1wLb2h8qCPGur-VsufCH4mLnnuLDLcmMq0FrCo7ichu8/edit#heading=h.44bkbp2hiok0.

Bug: 241843710
Test: Manual
Change-Id: I709f046fac79fdfd47c3c84054173992d81757ae
2022-08-19 16:18:04 -07:00
Luca Zuccarini 78c6e3f2a4 Set the default for keyboard sync to IS_STUDIO_BUILD.
As discussed offline, I will send out an announcement in the Sysui-studio and #sysui-debug Chat Spaces to solicit bug reports.

Bug: 234812580
Test: manual
Change-Id: Id693e8ebd990b804da247d4639a2dd2d6fbdd01f
2022-08-19 19:09:15 +00:00
Sunny Goyal b2b614e169 Removing tabWidth calculation and using DeviceProfile directly
This removes some dependency on FloatingHeaderView, making it
easier to replace

Bug: 234008165
Test: Verified that the UI does not change
Change-Id: I363c98c23f84fe570ea9cb1a40128359f5b67c9f
Merged-In: I363c98c23f84fe570ea9cb1a40128359f5b67c9f
(cherry picked from commit 42b640404a)
Merged-In: I363c98c23f84fe570ea9cb1a40128359f5b67c9f
2022-08-19 18:44:02 +00:00
Sunny Goyal 86a6cb0694 Fixing tab width and panner not aligned with the all-apps icons
Bug: 234008165
Test: Verified on device
Change-Id: Ibec3eed4aef730439d79b086d6ae23b63b66361e
Merged-in: Ibec3eed4aef730439d79b086d6ae23b63b66361e
(cherry picked from commit 524f4c4fba)
Merged-In: Ibec3eed4aef730439d79b086d6ae23b63b66361e
2022-08-19 18:43:59 +00:00
Grace Han c9225b74d4 Merge "Create Flag for Region Sampling in Smartspace" into tm-qpr-dev am: 4fb9dbb9f5 am: ae351cd134
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19397546

Change-Id: I203497b28f995f4660718c85ce1e132bcd982e86
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-19 16:39:22 +00:00
Grace Han 4fb9dbb9f5 Merge "Create Flag for Region Sampling in Smartspace" into tm-qpr-dev 2022-08-19 15:59:35 +00:00
Jeremy Sim 235bd0c0d4 Merge "Revert "Update animations for TM-QPR: Overview > OverviewSplitSelect transition"" into tm-qpr-dev am: 5ea6cfdb7e am: 2351d8dee3
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19669397

Change-Id: Ie12aac6a63ff32c8fd0a443554898ba77c65d471
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-19 14:21:11 +00:00
Jeremy Sim 5ea6cfdb7e Merge "Revert "Update animations for TM-QPR: Overview > OverviewSplitSelect transition"" into tm-qpr-dev 2022-08-19 13:37:58 +00:00
Jeremy Sim 2fe7dd7306 Revert "Update animations for TM-QPR: Overview > OverviewSplitSelect transition"
This reverts commit a50bb39048.

Reason for revert: Causes a P1 bug (b/241165022).

Fixes: 241165022
Bug: 236760307
Change-Id: Icc080d9a37e26d70d0f4cf846a4fd39df3b71625
2022-08-18 21:28:54 +00:00
Sunny Goyal c9c81ef320 Compressing view capture data and changing the format to avoid
storing duplicate strings

Also starting the dump process early to avoid timeouts

Bug: 242868825
Test: Verified on web-hv UI tool
Change-Id: I9943e41426f820c9ab70d39b9f01896ed060cab4
2022-08-17 16:48:27 -07:00
Thales Lima 14c79fb2d7 Merge "Make inlineQsb a grid-option attr" into tm-qpr-dev am: 8da8198bbb am: 5915f5e8d7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19607213

Change-Id: I35fd23671b3bd0b55bc4eb250f97a50e2915daae
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-17 17:04:38 +00:00
Sunny Goyal 41b71f08ee Merge "Get elevation in time-lapse View Hierarchy capture." into tm-qpr-dev am: 1b3b71f2d7 am: a6f3a6d32e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19626512

Change-Id: I821f46e159651e633974a12a097090a3ca3f9747
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-17 16:55:56 +00:00
Thales Lima 7cb6a57fe5 Merge "Show resize handle on cancel widget drop" into tm-qpr-dev am: 3906192135 am: 1da0c0fa28
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19500455

Change-Id: I19bea834a5b6040786247d999735bbaced409822
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-17 16:41:59 +00:00
Thales Lima 5c842cde1f Merge "Make folder sizes customizable" into tm-qpr-dev am: 7b10492e88 am: f97d64e152
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19559864

Change-Id: I35b9cc3af1bd282cb2fc2389c27e8f67fbf1cb37
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-17 16:40:58 +00:00
Sihua Ma 3cedd3920d Merge "Resize preview for correct clipping" into tm-qpr-dev am: 2d675e8ab0 am: eeb46032ef
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19324973

Change-Id: I0dec5e33e09efca7afe60c7d7183025018712965
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-17 16:37:36 +00:00
Sukesh Ram e02c21259a Merge "Added Tests for Secondary Display Launcher" 2022-08-17 06:46:19 +00:00
Sukesh Ram 73c27a1fa3 Added Tests for Secondary Display Launcher
These UIAutomator tests for secondary display launcher cover app drawer, drag-n-drop functionality, app predictions, pin/unpinning icons, and correct back press behavior.

We are deviating from  go/modify-tapl due to the time constraints of this project as outlined here (https://docs.google.com/document/d/1wLb2h8qCPGur-VsufCH4mLnnuLDLcmMq0FrCo7ichu8/edit#heading=h.brf6af3bno4g).

A preliminary design document has also been created to reference for future TAPL integration (https://docs.google.com/document/d/1H642SSu5DCM_zSXTsvTWumgm3OHIxsKEXvTlTeC4y54/edit?resourcekey=0-M9sTxdyQBi8bUy5cpjmJNA#heading=h.90f2s4sc5ic9).

Before TAPL integration, we need to follow up on test rewrite to eliminate antipatterns in the following bug: b/242776943.

Bug: 241166788
Test: Run Locally, on presubmit, and on a test on a cuttlefish emulator
Change-Id: I556a47b93a7ea3b2583dbc1efd2de7623d820e2a
2022-08-16 23:20:27 +00:00
Thales Lima 8da8198bbb Merge "Make inlineQsb a grid-option attr" into tm-qpr-dev 2022-08-16 20:34:10 +00:00