Commit Graph

16456 Commits

Author SHA1 Message Date
Tony Wickham 7310bb4b5c Don't update all apps content visibility during home animation
We already set the all apps content visibility = GONE at the start of
the gesture to prevent relayouts, but when animating home we were
inadvertently changing it to INVISIBLE, causing a relayout and jank.

Bug: 140308849
Change-Id: I285746f8ac8f3f857282e22ebec8eebd0b98647f
2019-08-30 22:10:55 +00:00
Pinyao Ting c7a6c2979c migrate custom widgets in comply with plugin framework
Bug: 139888225
Change-Id: I8a3d0fe2689ad5ba24b19309728bbad0b6287f71
2019-08-30 12:06:22 -07:00
Jon Miranda 768cb139cc Fix bug where we incorrectly change the default profile id of the database.
Change-Id: I0fafc06f5e28c1fdff77003c984e686719a60cd2
2019-08-30 16:11:00 +00:00
TreeHugger Robot 5fb858e252 Merge "Fix RequestPinItemTest, broken by my manual merge." into ub-launcher3-master 2019-08-29 19:17:44 +00:00
Jon Miranda d49fe3130e [DO NOT MERGE] Fix NumberFormatException for launcher.
Fix is already in ub-launcher3-master: I5094b22ddc77c45590cea1a5f5dead0dc7580abf

Bug: 140076379
Change-Id: I01948cf71ef2e058dc1ef8c506f174856ee09e0d
2019-08-29 19:10:28 +00:00
Samuel Fufa 9fd21056c7 App shortcut overlapping app icon when selecting the app using USB mouse
Test: Manual
Bug:113287687
Change-Id: Ib02c736a312937a9b71d5168d965446b6fc5b7b7
2019-08-28 17:58:14 -07:00
Vinit Nayak b57c577669 Merge "Add unique id to trace logs through recents animations" into ub-launcher3-master 2019-08-26 22:55:01 +00:00
Vinit Nayak 9b26e63f90 Add unique id to trace logs through recents animations
Generate a 3 digit number and append it to
log statements here as well as in platform.

fixes: 134619041
Test: Inspected log output with adb shell dumpsys activity service TouchInteractionService

Change-Id: I52a76dd2950565b246384d7766fdede9e28f5bb9
2019-08-26 15:10:21 -07:00
Samuel Fufa 68c97cf5ac Sorting people by key crashes launcher
Approch: approach: filter out people with null getKey before sorting.

Bug:139436782
Change-Id: I6510a12374ff4fec02c879ff76ba42b1fcdb8281
(cherry picked from commit 8628eb9353)
2019-08-26 18:05:59 +00:00
vadimt 7468bbd2d4 Adding debug tracing for All Apps appearing instead of Overview
am: 197ae725a0

Change-Id: Iab3642e2dcb4f766d490a88aa7a481a1117b98a3
2019-08-23 20:01:22 -07:00
Becky Qiu 71959e59d2 Merge "Move swipe actions on container logging to west world." into ub-launcher3-qt-qpr1-dev
am: 6d0d8969f6

Change-Id: I2229ea7c878ac84b00110235df65ced2f9baf171
2019-08-23 20:01:05 -07:00
TreeHugger Robot 84768d83bc Merge "Dragging an icon from prediction row to workspace crashes launcher" into ub-launcher3-master 2019-08-24 01:40:26 +00:00
Samuel Fufa 08457b0017 Dragging an icon from prediction row to workspace crashes launcher
Test:Manual
Bug:139942462
Change-Id: I5c4a2ca518b08f4ccf47072f8f355e76b7da9424
2019-08-23 14:40:11 -07:00
TreeHugger Robot 300d74fcae Merge "Close shortcut menu after launching from hotseat" into ub-launcher3-master 2019-08-23 21:33:56 +00:00
vadimt 197ae725a0 Adding debug tracing for All Apps appearing instead of Overview
Bug: 139941530
Change-Id: Ia9827c6edd48c559e9602e1e37de83293517ad5e
2019-08-23 12:11:00 -07:00
TreeHugger Robot 2345e6cdc6 Merge "Mouse wheel scroll apps with work profile enabled instead of switching tabs" into ub-launcher3-master 2019-08-23 18:40:40 +00:00
TreeHugger Robot 1b8d309782 Merge "Add support for searchwidget in layout files." into ub-launcher3-master 2019-08-23 18:22:10 +00:00
Samuel Fufa 59cba191c3 Mouse wheel scroll apps with work profile enabled instead of switching tabs
Test: Manual
Bug:79164903
Change-Id: I4b382034ea5b91b24dcc158bd9fa46d64f54cc7a
2019-08-23 11:20:29 -07:00
Becky Qiu 6d0d8969f6 Merge "Move swipe actions on container logging to west world." into ub-launcher3-qt-qpr1-dev 2019-08-23 18:03:02 +00:00
Samuel Fufa ca37b8afe5 Add support for searchwidget in layout files.
Test: Manual
Bug:139703885
Change-Id: I86b36187d95bb5db59dbf6ae2e20373d23e55aa1
2019-08-23 10:58:13 -07:00
Samuel Fufa 03302548ae Close shortcut menu after launching from hotseat
+ Fixed bug where popup menu does not close when animations are disabled.

Test: Manual
Bug:123298377
Change-Id: I863241158e09a618af6243d8afd70549421013d0
2019-08-23 10:54:57 -07:00
Vadim Tryshev 29a8f130fb Merge "Not freezing All Apps during user interactions" into ub-launcher3-qt-qpr1-dev
am: 94dcb3b5bf

Change-Id: I110730f8abb1d63c363aba9939799570bea69f07
2019-08-22 17:32:16 -07:00
Vadim Tryshev 94dcb3b5bf Merge "Not freezing All Apps during user interactions" into ub-launcher3-qt-qpr1-dev 2019-08-23 00:05:38 +00:00
vadimt ce7ec2e645 Merge "Adding tracing for suspending via Wellbeing" into ub-launcher3-qt-qpr1-dev
am: 418787778b

Change-Id: Id8869a40893ef596b3ad50275d8e9bfa3fdac2c4
2019-08-22 16:35:31 -07:00
Becky Qiu f0a014d7ff Move swipe actions on container logging to west world.
Test: manual
Bug: 137777105

Log result for swiping in and out of -1 screen.
  data {
    elapsed_timestamp_nanos: 597609736235111
    atom {
      launcher_event {
        action: SWIPE_LEFT
        src_state: HOME
        dst_state: HOME
        is_swipe_up_enabled: true
      }
    }
  }

  data {
    elapsed_timestamp_nanos: 597610569783111
    atom {
      launcher_event {
        action: SWIPE_RIGHT
        src_state: HOME
        dst_state: HOME
        is_swipe_up_enabled: true
      }
    }
  }


Change-Id: Ic84d3c32d1c9f780f13ec5cd6320e9f1d610f018
2019-08-22 16:27:49 -07:00
TreeHugger Robot 418787778b Merge "Adding tracing for suspending via Wellbeing" into ub-launcher3-qt-qpr1-dev 2019-08-22 23:22:02 +00:00
vadimt 2b3303c744 Not freezing All Apps during user interactions
Extremely rarely, All Apps will get stuck in a non-updating state even
after the interaction ends.

It would be impractical to try drilling to the root cause of this,
so it's better to just allow All Apps updates while the user interacts
with it.

Bug: 139384936
Change-Id: I2ed7fb052da77a9e47ef9b9aa7800499071b98c3
2019-08-22 22:34:17 +00:00
vadimt 872cf29211 Adding tracing for suspending via Wellbeing
Bug: 139891609
Change-Id: I3ffb7941f7c4015cba3c65d87e20ccc6be920592
2019-08-22 15:30:42 -07:00
Jon Miranda 14f3936c92 Fix RequestPinItemTest, broken by my manual merge.
Bug: 139880994
Change-Id: I7f6e1dda6cf4497bccf7ea682739bacd12079d4d
2019-08-22 13:37:29 -07:00
Jon Miranda 89137e7bb8 Add support for adding promise icons for new install sessions by user.
- Added flag PROMISE_APPS_NEW_INSTALLS
- Promise icons only added if flag (above) is on, as well as the setting
  for "Add icon to Home screen"
- Maintains a list of session ids of promise icons that have been added to the
  home screen, so that if the user manually removes the icon, we do not add
  it back to the home screen when the install is completed.
- Queues all applications as promise icons, and replaces with actual
  app info when its being added to the workspace.

Bug: 135633159
Change-Id: Idf2fc9033f890afef924628b76b89ad4692f529c
Merged-In: I411db59f9bd1b346d98b9bb73f5376a5983b8de5
2019-08-22 10:42:45 -07:00
Jon Miranda c84168df80 Add support for adding promise icons for new install sessions by user.
- Added flag PROMISE_APPS_NEW_INSTALLS
- Promise icons only added if flag (above) is on, as well as the setting
  for "Add icon to Home screen"
- Maintains a list of session ids of promise icons that have been added to the
  home screen, so that if the user manually removes the icon, we do not add
  it back to the home screen when the install is completed.
- Queues all applications as promise icons, and replaces with actual
  app info when its being added to the workspace.

Bug: 135633159
Change-Id: I411db59f9bd1b346d98b9bb73f5376a5983b8de5
2019-08-22 10:28:14 -07:00
Sunny Goyal 6fe3eec95c Moving various common executors to a single location
Change-Id: I44bca49b8adb6fa22c3b48d10f674e42c28d792c
2019-08-20 14:36:17 -07:00
Samuel Fufa 6888b5ceaa Merge "Support Agassi (Search Engine choice) in Android R" into ub-launcher3-master 2019-08-16 21:57:58 +00:00
Pinyao Ting d88f63bbed add null check when accessing target component from iteminfo
Bug: 139540363
Change-Id: I25d0100077de67b085c27b5ef91e22c6ac1ad959
Merged-In: I25d0100077de67b085c27b5ef91e22c6ac1ad959
2019-08-16 21:50:21 +00:00
Samuel Fufa 9ec8cfa269 Support Agassi (Search Engine choice) in Android R
Test:
1) set your preferred search provider using `adb shell settings put global SEARCH_PROVIDER_PACKAGE_NAME <value>`.(eg: com.duckduckgo.mobile.android)
2) install the package name and confirm search widget on launcher is updated
3) uninstalled the package and confirm widget is replaced with placeholder on launcher.

Bug:137653564
Change-Id: I8904d5915a8c03ea6068fb5950af15ca786b8ad7
2019-08-16 14:46:00 -07:00
Pinyao Ting 2f9019e56c add null check when accessing target component from iteminfo
Bug: 139540363
Change-Id: I25d0100077de67b085c27b5ef91e22c6ac1ad959
2019-08-16 14:25:31 -07:00
Hyunyoung Song 27df700f05 Merge "Make TogglableFlag backed by DeviceConfig for e2e testing" into ub-launcher3-qt-qpr1-dev
am: 96eba3aea6

Change-Id: I738256f1623119a61197c03008e098b066161542
2019-08-15 16:03:32 -07:00
Hyunyoung Song 96eba3aea6 Merge "Make TogglableFlag backed by DeviceConfig for e2e testing" into ub-launcher3-qt-qpr1-dev 2019-08-15 22:25:33 +00:00
Hyunyoung Song d4204437de Make TogglableFlag backed by DeviceConfig for e2e testing
Bug: 138964490

TL;DR;; need this to be part of QQ1 or QD1 to verify if DeviceConfig
can be supported for launcher toggleableFlags.

Not handled in this CL:
- When flag is locally modified, that will override the flag value
How that scenario is handled should be discussed separately and is not
within scope of this CL.

Change-Id: I2e6694a40bee9202ed0b0d559e3b5607634071bf
2019-08-15 14:02:28 -07:00
Samuel Fufa 84245e84c8 Default name's language of folder won't change after changing the system language
Test: Manual - Create unnamed folder and change system language. Folder
name should pickup new language.
Bug:78611156
Change-Id: Ie06baebe5b9a64e91630c581b75b674f363b9973
2019-08-15 09:56:12 -07:00
TreeHugger Robot 46463f6a19 Merge "Adding support for storing keywords in iconCache" into ub-launcher3-qt-qpr1-dev 2019-08-14 23:08:43 +00:00
TreeHugger Robot 4c19f94181 Merge "Adding app search improvement flag" into ub-launcher3-qt-qpr1-dev 2019-08-14 23:08:43 +00:00
Sunny Goyal 934ebd087b Adding support for storing keywords in iconCache
Change-Id: I1183e63a6556ebfb3eee5df23d149e09728193a9
Merged-In: I1183e63a6556ebfb3eee5df23d149e09728193a9
(cherry picked from commit e529a86fbd)
2019-08-14 22:12:49 +00:00
Samuel Fufa 8628eb9353 Sorting people by key crashes launcher
Approch: approach: filter out people with null getKey before sorting.

Bug:139436782
Change-Id: I6510a12374ff4fec02c879ff76ba42b1fcdb8281
2019-08-14 15:12:43 -07:00
Alex Mang 713cd6fd56 Adding app search improvement flag
Bug: 125027540
Change-Id: I68fd7710b108e9f2fa1f5ff335326585a92deb23
Merged-In: I68fd7710b108e9f2fa1f5ff335326585a92deb23
(cherry picked from commit d27e31995b)
2019-08-14 21:58:57 +00:00
TreeHugger Robot 23582eb7c0 Merge "Refactoring some folder binding logic:" into ub-launcher3-master 2019-08-14 21:10:20 +00:00
yingleiw 6f703ccff5 Add directional accessibility page actions to PagedView
am: 02cc848896

Change-Id: Ide8077d5996de0faaec6d1ef0afee0e0e639d889
2019-08-14 13:09:36 -07:00
Becky Qiu 1289197487 Merge "Log the event for swiping up to dismiss a task in Overview." into ub-launcher3-qt-qpr1-dev
am: 22edac9bf5

Change-Id: Iae05c668fecf84c79086cfb6821e9644ac08bb71
2019-08-14 13:09:14 -07:00
Sunny Goyal 11a50747ed Refactoring some folder binding logic:
> Moving grid calcutation in a separate class
> Moving content saving logic to folder instead of relying on item bind

Bug: 139051851
Change-Id: I81b226dbebe13652482a767c992e8cc8f4f35a60
2019-08-14 12:03:09 -07:00
yingleiw 02cc848896 Add directional accessibility page actions to PagedView
For PagedView, when isPageOrderFlipped is true, it means the LTR mode is
flipped. For the "recents" in launcher, isPageOrderFlipped is true.
However, this doesn't affect the directional page operations since
scrollLeft()/Right() already has correct Rtl considerations. See
b/78788182 for more information on the LTR mode.

Test: Tested with the "recents" in launcher. Verified that page left
action always move pages to the right (so that the next page from the
left side shows), and page right actions always move pages to the left
(so that the next page from the right side shows). Also tested with the
home screen 1/2, 2/2 paging.
Bug: 136277517

Change-Id: I965d651c37d258eaa8ea347d1ad6f698f9b590bf
2019-08-14 18:05:08 +00:00