Commit Graph

16456 Commits

Author SHA1 Message Date
Winson Chung 9a82ca3054 Merge changes I4532e429,I532645de into ub-launcher3-qt-future-dev
am: 478414a7c3

Change-Id: Ic9af7149c297e23fd8c3645fd0a83dd5f45e0cce
2019-09-09 14:51:52 -07:00
Jonathan Miranda 735d1fe124 Merge "Add tests for play promise icons." into ub-launcher3-qt-qpr1-dev 2019-09-09 21:44:15 +00:00
Winson Chung 478414a7c3 Merge changes I4532e429,I532645de into ub-launcher3-qt-future-dev
* changes:
  Defer listening on widget host until after the state transition ends
  Migrate to using DefaultDisplay
2019-09-09 21:39:18 +00:00
vadimt fe42dc3ac5 Merge "Support for getting Launcher Pss by tests" into ub-launcher3-qt-qpr1-dev am: 01f8fb9132
am: a6650287b7

Change-Id: Ie1edad2925040d46a1d38e937bd9e73c70f5ede0
2019-09-09 14:24:20 -07:00
vadimt bed2fa8787 Merge "Add tracing for non-dragging icon" into ub-launcher3-qt-qpr1-dev am: 243dd30da3
am: b51136af52

Change-Id: Idd704e3b004e69b7aa2f37bd99217c2898b7b427
2019-09-09 14:23:55 -07:00
Tony Wickham 6b9ee0115e Merge "Properly prevent All Apps relayouts by avoiding scrollToPosition" into ub-launcher3-qt-qpr1-dev am: d785fc289c
am: 0d37f05a12

Change-Id: I0de3e9df3118440627cd3e57527c683ffc4c9254
2019-09-09 14:23:43 -07:00
vadimt 917af15bb0 Merge "Removing flinging via UI Automator" into ub-launcher3-qt-qpr1-dev am: e1335c2359
am: fb10f07e56

Change-Id: I395a70e247f5d9182b54f91577f0e802b90554a0
2019-09-09 14:22:47 -07:00
vadimt a6650287b7 Merge "Support for getting Launcher Pss by tests" into ub-launcher3-qt-qpr1-dev
am: 01f8fb9132

Change-Id: I36a1309b24a94dafe5203287e07595d60622c158
2019-09-09 14:18:14 -07:00
vadimt b51136af52 Merge "Add tracing for non-dragging icon" into ub-launcher3-qt-qpr1-dev
am: 243dd30da3

Change-Id: I6ec07b275fc322730c1d31179c957d5aeb0f8077
2019-09-09 14:17:45 -07:00
Tony Wickham 0d37f05a12 Merge "Properly prevent All Apps relayouts by avoiding scrollToPosition" into ub-launcher3-qt-qpr1-dev
am: d785fc289c

Change-Id: I69738f5d9c1f77195f2f82f963958d3cc741e9af
2019-09-09 14:17:33 -07:00
vadimt fb10f07e56 Merge "Removing flinging via UI Automator" into ub-launcher3-qt-qpr1-dev
am: e1335c2359

Change-Id: Iad5c6c0bf74ac223cc60b64fa7a15dae544d500f
2019-09-09 14:16:47 -07:00
TreeHugger Robot 0a07dfa25d Merge "resolve merge conflicts of 1bd96b1e96 to ub-launcher3-qt-future-dev" into ub-launcher3-qt-future-dev 2019-09-09 20:47:27 +00:00
Sunny Goyal ba02fa4585 Lazily binding folder pages and icons
am: ac6f69f78d

Change-Id: Id85dad476f49244c711c687d5a95d36197034946
2019-09-09 12:42:30 -07:00
Samuel Fufa 6d86a14d81 Merge "Add nullcheck for VelocityTracker" into ub-launcher3-master 2019-09-09 17:49:35 +00:00
Winson Chung ef52876739 Defer listening on widget host until after the state transition ends
Bug: 140246642
Change-Id: I4532e4298f04ff5c6dea04ccda89320995cadb80
2019-09-09 10:24:53 -07:00
Winson Chung 13c1c2cd65 Migrate to using DefaultDisplay
- Remove extra binder calls to get the default display

Bug: 140633033
Change-Id: I532645deac101a6065d90484b87a67b67aa717f5
2019-09-09 10:21:28 -07:00
vadimt 2bad570b40 Support for getting Launcher Pss by tests
Bug: 139137636
Change-Id: I8cad7dec07ce400cf927e3fc2ba9904fef942d9a
2019-09-06 16:50:51 -07:00
Samuel Fufa 6ef5b8abf4 Add nullcheck for VelocityTracker
Bug:134712476
Change-Id:I7834507a4e9aadf4d89c0ed6f3eba812df7425cd
2019-09-06 15:02:03 -07:00
Jon Miranda 4b9edfbbe5 Add tests for play promise icons.
Bug: 139021165
Change-Id: Ie1a049b283b70f6bd22b43c09aef263282cb0f56
Merged-In: I45469b7523d8aea12c34d460c7b69c571a415675
2019-09-06 21:57:04 +00:00
Samuel Fufa d3720c210b App title in Widget list shouldn't be actionable by a11y methods
Bug:139913027
Test:Manual
Change-Id: I2a5d5551d09ee2bc96444164ed77225a3b4a829a
2019-09-06 13:21:56 -07:00
Jon Miranda a87abbad31 resolve merge conflicts of 1bd96b1e96 to ub-launcher3-qt-future-dev
Test: I solemnly swear I tested this conflict resolution.
Bug: None
Change-Id: Ide6c914d4e69eb4fa70d6634780324cd45a21610
2019-09-06 11:35:34 -07:00
Jon Miranda f5197fce3d Add tests for play promise icons.
Bug: 139021165
Change-Id: I45469b7523d8aea12c34d460c7b69c571a415675
2019-09-05 15:45:51 -07:00
TreeHugger Robot 243dd30da3 Merge "Add tracing for non-dragging icon" into ub-launcher3-qt-qpr1-dev 2019-09-05 21:57:01 +00:00
Tony Wickham d785fc289c Merge "Properly prevent All Apps relayouts by avoiding scrollToPosition" into ub-launcher3-qt-qpr1-dev 2019-09-05 21:27:41 +00:00
vadimt 30618db33f Add tracing for non-dragging icon
Bug: 138729456
Change-Id: Ib18f1544f2520509bd982f032bf3ed0c72ca9529
2019-09-05 14:08:39 -07:00
Sunny Goyal ac6f69f78d Lazily binding folder pages and icons
Folders are bound before they are opened and unbound on close. This
allows us to recycle the views in folders

Bug: 139051851
Change-Id: Ic1ed3265c0f583af54d73dab6f2751bc95266ea9
2019-09-05 17:17:11 +00:00
TreeHugger Robot e1335c2359 Merge "Removing flinging via UI Automator" into ub-launcher3-qt-qpr1-dev 2019-09-05 00:13:30 +00:00
vadimt 758a1d983d Removing flinging via UI Automator
UI Automator loses events. Switching to the homemade scrolling.

Bug: 138729157
Change-Id: Ib09bd5714e83eadfc65b54202867bf375e6b47c5
2019-09-04 16:35:19 -07:00
TreeHugger Robot 1bd96b1e96 Merge "Update app open/close animations." into ub-launcher3-qt-qpr1-dev 2019-09-04 22:33:33 +00:00
Jon Miranda 9b78e190fa Update app open/close animations.
- For app open, the icon text remains where it is and only the icon moves.
- Similarly for app close, the icon text remains where it is and fades in
  with the rest of the other icons text.

- With this change, the original view is always "VISIBLE"
  (if BubbleTextView/FolderIcon) but we hide certain elements.

Added video to bug.

Bug: 137200188
Bug: 139885365
Change-Id: I3d20c5f05bc7c0b9d052d8074ac3bfc21531c83d
Merged-In: I3d20c5f05bc7c0b9d052d8074ac3bfc21531c83d
2019-09-04 21:45:05 +00:00
TreeHugger Robot 18c691404f Merge "Update app open/close animations." into ub-launcher3-master 2019-09-04 21:37:26 +00:00
Samuel Fufa c04780c13f Merge "Don't persist invalid previews to cache" into ub-launcher3-master 2019-09-04 20:53:29 +00:00
Jon Miranda dff0de4730 Update app open/close animations.
- For app open, the icon text remains where it is and only the icon moves.
- Similarly for app close, the icon text remains where it is and fades in
  with the rest of the other icons text.

- With this change, the original view is always "VISIBLE"
  (if BubbleTextView/FolderIcon) but we hide certain elements.

Added video to bug.

Bug: 137200188
Bug: 139885365
Change-Id: I3d20c5f05bc7c0b9d052d8074ac3bfc21531c83d
2019-09-04 13:03:18 -07:00
Samuel Fufa 15357968db Don't persist invalid previews to cache
Test: Manual
Bug:137404499
Change-Id: I04a3a0e081fcb8de45601f028398670e7542ed22
2019-09-04 10:01:52 -07:00
Tony Wickham bfdeda96e6 Properly prevent All Apps relayouts by avoiding scrollToPosition
Calling scrollToPosition on RecyclerView internally calls
requestLayout() (to cacluate where to scroll and then go there).
Therefore, we should avoid calling that whenever possible, especially
during transitions. In particular, we can optimize scrollToTop() to not
scrollToPosition() if we are already at the top.

This makes some other workarounds unnecessary, namely setting All Apps
to GONE during system gestures.

Test: Open an app, swipe up, ensure AllAppsRecyclerView doesn't get
onLayout().  If we had scrolled to an app first, we get one layout
in prepareRecentsUi(), but not during the transition.

Bug: 140308849
Change-Id: I62ee341bf5893c121cfc013cc6542559f79d2a42
2019-09-03 16:16:54 -07:00
Andy Wickham 1f3b82ba6e Marks ScrimView unimportant for accessibility when Widgets screen is opened. am: c40872b913
am: 42cbb23d0d

Change-Id: I3f52c9905e73547fa885de33159f75d5fa4e5cb7
2019-09-03 15:35:26 -07:00
Andy Wickham 42cbb23d0d Marks ScrimView unimportant for accessibility when Widgets screen is opened.
am: c40872b913

Change-Id: Ic078f5dd44e57883041433ad001ed4fa684dcba2
2019-09-03 15:29:25 -07:00
Andy Wickham c40872b913 Marks ScrimView unimportant for accessibility when Widgets screen is opened.
This prevents it from holding focus while the Widgets screen is visible
(after using Widgets action from the All Apps caret thingy).

Test: Manually followed steps provided in bug, and issue not seen after this change.
Fixes: 139918680
Change-Id: I280ac97fb7ff9fa67f1c6a1ce9cdfa9e451231eb
2019-09-03 21:20:22 +00:00
Jon Miranda 0b439b446d Merge "Only add promise icon if icon is provided in the SessionInfo." into ub-launcher3-qt-qpr1-dev am: 505a88140e
am: 3105f80e64

Change-Id: Ic8d685a5f9a9f2b2ede483402d6c80e40ec9cdc4
2019-09-03 11:24:46 -07:00
Sunny Goyal f6d5c67402 Merge "Fix bug where we incorrectly change the default profile id of the database." into ub-launcher3-qt-qpr1-dev am: a42681f6d2
am: 71834aa186

Change-Id: Id5169fab20896a5e24e8856b714edc1b5cc738ad
2019-09-03 11:24:14 -07:00
Jon Miranda 3105f80e64 Merge "Only add promise icon if icon is provided in the SessionInfo." into ub-launcher3-qt-qpr1-dev
am: 505a88140e

Change-Id: I1bb3883810bde87ffc3b69b154f2f886c09e6e85
2019-09-03 11:17:48 -07:00
Sunny Goyal 71834aa186 Merge "Fix bug where we incorrectly change the default profile id of the database." into ub-launcher3-qt-qpr1-dev
am: a42681f6d2

Change-Id: I05ca0e24324272e06087221fbbb50a6dbef7ed4f
2019-09-03 11:17:14 -07:00
TreeHugger Robot 505a88140e Merge "Only add promise icon if icon is provided in the SessionInfo." into ub-launcher3-qt-qpr1-dev 2019-09-03 16:27:11 +00:00
Pinyao Ting c2c4d8358c Merge "migrate custom widgets in comply with plugin framework" into ub-launcher3-master 2019-09-03 16:23:37 +00:00
Sunny Goyal a42681f6d2 Merge "Fix bug where we incorrectly change the default profile id of the database." into ub-launcher3-qt-qpr1-dev 2019-09-03 16:23:18 +00:00
Jon Miranda a8c7c0b713 Only add promise icon if icon is provided in the SessionInfo.
- In some cases, SessionInfo is created without an icon until later on
  in the install process. This prevents promise icons with default Android
  logo from appearing.
- This will also prevent apps without a launching activity from appearing
  as a promise icon and then disappearing when the app is installed.

Bug: 135633159
Change-Id: I30adde8bf2cf583bffca8ed878f9cc20d6d41a13
2019-09-03 08:13:09 -07:00
vadimt 7e6ba0e5bf Merge "Adding tracing for mismatch between current and stable states" into ub-launcher3-qt-qpr1-dev
am: 78ebf57e9f

Change-Id: Ifac50ddd7ad0a689722e4911a735cf2d503d177a
2019-08-30 18:10:34 -07:00
TreeHugger Robot 78ebf57e9f Merge "Adding tracing for mismatch between current and stable states" into ub-launcher3-qt-qpr1-dev 2019-08-31 00:55:55 +00:00
vadimt 7bfc820d0c Adding tracing for mismatch between current and stable states
Bug: 140311911
Change-Id: Ie6196015a3f1b35b1403a12540ff7e3290f8cb3d
2019-08-30 17:13:43 -07:00
Tony Wickham 4feff8ba95 Don't update all apps content visibility during home animation
am: 7310bb4b5c

Change-Id: I92382497e4444e2ca1d1951c44646bc5047a6f36
2019-08-30 16:22:51 -07:00