Commit Graph

16456 Commits

Author SHA1 Message Date
TreeHugger Robot c7d601e923 Merge "TAPL: logging incoming intents" into ub-launcher3-master 2019-12-18 02:58:28 +00:00
Automerger Merge Worker 30f232de4c Fix shortcut componentname in workspace layout logging am: b9ba427576
Change-Id: I6ffef9cc9dabb32e1d6b1a16e7011d3c9b6b9c3b
2019-12-17 23:31:48 +00:00
Hyunyoung Song b9ba427576 Fix shortcut componentname in workspace layout logging
Bug: 146172747
Test: $ adb shell dumpsys activity provider com.google.android.apps.nexuslauncher/com.android.launcher3.LauncherProvider --proto --debug
SHORTCUT, package=com.android.vending, component=VIEW_MY_DOWNLOADS, grid(3,4), span(1,1), pageIdx=0 user=0


Change-Id: Ic8537d499d66675fbe190f137b50fb693d6c21d5
2019-12-17 05:25:35 +00:00
vadimt baf5fbbe58 TAPL: logging incoming intents
Even though ActivityTaskManager already logs intents, logging this will
simplify flake/error investigations that are considered to be too
time-consuming.

Also, this will make it possible in future to programmatically detect
whether the bug is introduced by the system or Launcher.

Bug: 133010698
Change-Id: I7dcadd95baa23f29bb661d6b42280bd2a2f0e099
2019-12-16 18:56:09 -08:00
TreeHugger Robot c16667032a Merge "Logging state change events when in test to simplify diagnosing" into ub-launcher3-master 2019-12-16 23:40:40 +00:00
TreeHugger Robot bdfa251d67 Merge "Add boolean to differentiate icons from workprofile" into ub-launcher3-master 2019-12-16 20:31:33 +00:00
TreeHugger Robot 03b14a6d44 Merge "Generating state-changed-to-home event for Widgets->Home transition" into ub-launcher3-master 2019-12-14 03:21:09 +00:00
Tony Wickham 899557c048 Add null check before updating NotificationItemView
It's possible that the notifications were removed between the popup opening
and updating its UI. In that case, mNotificationItemView will be null.

Bug: 146152941
Change-Id: I60b44ea6d766720613cf2f25481fa3fc17cab6af
2019-12-13 15:23:21 -08:00
vadimt f0c80528ab Starting swipe-to-all-apps outside of areas triggering long-press
I suspect that some tests using TAPL run under pressure (mem or CPU,
created either intentionally or as a result of a leak somewhere)
where test process may generate a pause between DOWN and MOVE events
enough to be recognized as a long tap, which opens a context menu
instead of swiping.

While the clean solution is b/140252325, this is a workaround.

Bug: 144853809
Change-Id: I135eaee608270b7e60bb072cb360632763cbe5c5
2019-12-12 16:27:25 -08:00
vadimt 5995e60d90 Logging state change events when in test to simplify diagnosing
Change-Id: I48f741802696f7ef1764a5745ae6243c407a19cc
2019-12-11 17:53:03 -08:00
vadimt 9f48a8ec3b Generating state-changed-to-home event for Widgets->Home transition
This event is required by TAPL is is not currently generated by
Launcher3.

Change-Id: Ibf38b6779cc8d0d6a62d415d07c874d00956435a
2019-12-11 17:24:59 -08:00
TreeHugger Robot 98833d525c Merge "Updating some non-final static objects" into ub-launcher3-master 2019-12-11 22:07:53 +00:00
TreeHugger Robot 41dd48a718 Merge "Diagnosing the reason for opening context menu" into ub-launcher3-master 2019-12-11 21:29:38 +00:00
Sunny Goyal 73b5a27b14 Updating some non-final static objects
Updating various static objects to use a standard pattern so that
it is easier to track and cleanup those objects

Bug: 141376165
Change-Id: Ia539cbfa338d544dddad771c5027b6748762768b
2019-12-11 13:22:58 -08:00
TreeHugger Robot 4f37a5e268 Merge "Removing static instances of UserManagerCompat and AppWidgetManager" into ub-launcher3-master 2019-12-11 18:41:04 +00:00
Sunny Goyal 337c81f664 Removing static instances of UserManagerCompat and AppWidgetManager
> Changing the lifecycle to follow other static objects in Launcher
> Removing compat interface and inlining everything to helpers

Bug: 141376165
Change-Id: I82bd5db1969101de9a7eac77f32728d70195bb35
2019-12-11 10:03:19 -08:00
Samuel Fufa 78e7e5fcaa Add boolean to differentiate icons from workprofile
Bug:145825382
Test:Manual
Change-Id: I95e0cfe48b4a397eb54455374f11c7ea14c028f6
2019-12-10 13:33:37 -08:00
Pinyao Ting 9c592e210e perform accessbility focus when the recyclerview doesn't gain focus
after fragment replacement in SettingsActivity

Bug: 145475911
Test: Settings -> App & Notifications -> Default Apps -> Enable Talkback
-> Gear Button next to Home app -> About -> Verify Talkback reads the
first item in the page

Change-Id: I100e646ad2aba0081b48b86ec408ce8e76a80713
Merged-In: I100e646ad2aba0081b48b86ec408ce8e76a80713
(cherry picked from commit 865dc9b3b1)
2019-12-10 11:28:50 -08:00
Zak Cohen e895869f47 Overview actions - adds feature flag and base class for Overview Actions.
Adds ENABLE_OVERVIEW_ACTIONS feature flag and base factory. Requires an
implementation in overlay to show any actions.

Test: run locally with flag on and off.
Bug: 145628186

Change-Id: I1c36330464cc01e1e987ebfea1a9f451067598a5
2019-12-09 16:43:54 -08:00
TreeHugger Robot 0aa4bfebcf Merge "fix app crash on settings for launcher" into ub-launcher3-master 2019-12-09 23:26:28 +00:00
Tracy Zhou c19d7783aa Merge "Render user's actual workspace in ThemePicker preview (Part 1)" into ub-launcher3-master 2019-12-09 23:04:17 +00:00
Pinyao Ting 80634893ab fix app crash on settings for launcher
Bug: 145941320
Test: Settings -> Apps & notifications -> Default apps -> Gear button
next to Home app -> Click on every item and make sure it doesn't crash

Change-Id: Ibad2ebf0c53a58a04327d0323f83de27efd8fda8
2019-12-09 14:39:09 -08:00
Automerger Merge Worker 7891a71d5f Persist predicted items when dragged to workspace am: 02c794578c
Change-Id: I63c93b16f549fb974c7c0e6c86f0939aff8c7b70
2019-12-09 22:31:38 +00:00
Tracy Zhou 44fa2940cd Render user's actual workspace in ThemePicker preview (Part 1)
This change takes care of icon rendering. Further work still needs to be done for folders and widgets.

Test: Go to grid options, choose a different grid option, and see user's workspace rendered in the preview
Bug: 144052839
Change-Id: I696153dec1d1f08c5ac82d0c75be5740325c0fc4
2019-12-09 14:06:38 -08:00
TreeHugger Robot 432e0513d1 Merge "perform accessbility focus when the recyclerview doesn't gain focus after fragment replacement in SettingsActivity" into ub-launcher3-master 2019-12-09 22:05:43 +00:00
vadimt bc5d7e68e8 Diagnosing the reason for opening context menu
Adding it permanently. System tests using TAPL sometimes run into
mysterious hard-to-diagnose problems (like, a menu opens for no apparent
reason), so we'll need to keep diags like this forever.

Change-Id: I25fcab94931fa4f6e1bda34d5705de5dd411188a
2019-12-09 13:53:05 -08:00
TreeHugger Robot ebc50f3095 Merge "Moving some tests to robolectric" into ub-launcher3-master 2019-12-09 20:04:35 +00:00
TreeHugger Robot ecd7cc0e4c Merge "migrate from deprecated fragment api to latest" into ub-launcher3-master 2019-12-09 19:45:29 +00:00
Sunny Goyal 4b5b0eb60d Moving some tests to robolectric
> Adding support for simulating model load

Bug: 130562632
Change-Id: I1de8c0abe2e74d4e7e47e18914316c339920609a
2019-12-09 11:17:12 -08:00
TreeHugger Robot 32e8a96ee2 Merge "allow smart folder to support more than 2 items" into ub-launcher3-master 2019-12-06 05:29:24 +00:00
TreeHugger Robot 56c9c86fe9 Merge "Removing custom activity dump logic" into ub-launcher3-master 2019-12-05 20:34:54 +00:00
Pinyao Ting eacbdd3cde allow smart folder to support more than 2 items
Bug: 144975153
Test: Manual
Change-Id: Ib5ff34863312d8b8da7615371e353bb697261790
2019-12-05 11:35:14 -08:00
Pinyao Ting 865dc9b3b1 perform accessbility focus when the recyclerview doesn't gain focus
after fragment replacement in SettingsActivity

Bug: 145475911
Test: Settings -> App & Notifications -> Default Apps -> Enable Talkback
-> Gear Button next to Home app -> About -> Verify Talkback reads the
first item in the page

Change-Id: I100e646ad2aba0081b48b86ec408ce8e76a80713
2019-12-05 11:04:20 -08:00
Pinyao Ting 8b7483810a migrate from deprecated fragment api to latest
Bug: 145475911
Test: Settings -> App & Notifications -> Default Apps -> Gear Button
next to Home app -> Verify everything works

Change-Id: Icad09230e00991da91dd0b3f870ab46edc04d1a3
2019-12-05 10:59:01 -08:00
Samuel Fufa 02c794578c Persist predicted items when dragged to workspace
Bug: 143787549
Test: Manual
Change-Id: Ieff0ede4072a2a9a87a62b06ad846eedfe97583f
2019-12-04 14:21:12 -08:00
Samuel Fufa 3a39a25d1c Ignore predicted items when items are drag over them
Bug:145565886
Test:Manual
Change-Id: I727975234d36ef2cba0d58ba1df6886e09157ce6
2019-12-04 12:13:46 -08:00
TreeHugger Robot e1187e6d98 Merge "Dedupe Items on Workspace for hotseat prediction" into ub-launcher3-master 2019-12-04 02:39:36 +00:00
Samuel Fufa 2f0b2d3b4e Dedupe Items on Workspace for hotseat prediction
Bug:145236832
Test:Manual
Change-Id: I46da38998486c7f58aca829d33b42cbb04da515a
2019-12-03 14:39:12 -08:00
Zak Cohen f9e73a01a6 Update FeatureFlags documentation.
Test: comment change
Change-Id: I25f99150f467e4e65d4969ad20a91f18743eceb0
2019-12-03 12:00:44 -08:00
Sunny Goyal ec30c5ed51 Merge "Adding utility class to load customization resources for easier prototype" into ub-launcher3-master 2019-11-28 00:23:37 +00:00
TreeHugger Robot 51a5bf15ab Merge "Hybrid hotseat predicted icon visuals" into ub-launcher3-master 2019-11-26 20:13:09 +00:00
Samuel Fufa 1e2d004dd5 Hybrid hotseat predicted icon visuals
Bug:142753423
Test: Manual
Change-Id: I6f056aaec905c8ca357b7cf78a657cdaac84e2f1
2019-11-25 17:35:05 -08:00
Sunny Goyal fca20151b0 Removing custom activity dump logic
Change-Id: I37c339be205a4e35227986544d36ca03b1ae4ba4
2019-11-25 11:18:28 -08:00
Hyunyoung Song 5fcd8f9647 Provide up to 3 folder name suggestions to active IME
Bug: 144973594

Change-Id: I92078fffd68a1230fd87d2387404c8a2fed55bc0
2019-11-22 08:19:17 +00:00
Jon Miranda a3ea27de39 Fix bug where icon remains invisible after returning home.
- The bug is caused by cancelling of the RectFSpringAnim before the
  StaggeredWorkspaceAnim has started.
- Instead of having logic in StaggeredWorkspaceAnim control the visibility
  of the icon, we instead maintain all the visibility within the
  FloatingIconView class itself.

Bug: 142120338
Change-Id: I94f3a066d395f9c3b97dc6ee9fc836e9401650a5
Merged-In: I082291ca9b288f57701cc00d61a9b3a84da8b084
2019-11-21 22:16:36 +00:00
Jon Miranda ad7e30f5d7 Fix bug where icon remains invisible after returning home.
- The bug is caused by cancelling of the RectFSpringAnim before the
  StaggeredWorkspaceAnim has started.
- Instead of having logic in StaggeredWorkspaceAnim control the visibility
  of the icon, we instead maintain all the visibility within the
  FloatingIconView class itself.

Bug: 142120338
Change-Id: I082291ca9b288f57701cc00d61a9b3a84da8b084
2019-11-20 13:17:51 -08:00
TreeHugger Robot f3761296a1 Merge "Fix recents scale sometimes lagging behind window scale" into ub-launcher3-qt-future-dev 2019-11-20 19:02:45 +00:00
Tony Wickham ced2347289 Merge "Improve quick switch from home by tracking both x and y motion" into ub-launcher3-qt-future-dev 2019-11-20 18:46:50 +00:00
Tony Wickham 09c09bba1e Fix recents scale sometimes lagging behind window scale
We were previously offsetting the launcher animation progress based
on when we got onGestureStart, which meant it would lag behind if
onGestureStart came late. Now that we track the window instead of
the launcher shelf, and we don't show the launcher animation right
away in fully gestural mode anyway, we should remove this to ensure
the launcher part of the animation always lines up with the app
window.

We also reapply state whenever predictions are enabled, e.g. when
launcher starts after being force stopped, and previously this was
canceling the existing state animation. We don't want to do that
because predictions can be enabled at any point on a cold start,
and cancelling the existing state animation means that RecentsView
shows up in fullscreen and not attached to the app window for the
duration of the gesture.

Bug: 144454486
Change-Id: I65a2c71c9acd2f5345941ea2cff7d32c04b7be3f
Merged-In: I65a2c71c9acd2f5345941ea2cff7d32c04b7be3f
2019-11-20 18:05:06 +00:00
Tony Wickham ff828d2f24 Merge "Fix recents scale sometimes lagging behind window scale" into ub-launcher3-master 2019-11-20 05:07:12 +00:00