Commit Graph

16456 Commits

Author SHA1 Message Date
TreeHugger Robot 92b0b1d0a1 Merge "Add spring to workspace scale when going from Hint state to Normal state." into ub-launcher3-rvc-dev 2020-06-19 01:28:25 +00:00
Samuel Fufa 1d08cc681c Follow up for ag/11916646
- Fixes launcher breakage

Bug: 159170242
Change-Id: Ib21bfee8d5f63d31a8807ad87ac47d600fb62e7a
2020-06-18 17:57:39 -07:00
Jon Miranda 271638574f Add spring to workspace scale when going from Hint state to Normal state.
Bug: 151768994
Change-Id: If03d39e5ef6319355a7691d60fc0152de2fc3cec
2020-06-18 17:53:07 -07:00
TreeHugger Robot c471a9a6bb Merge "Show a snackbar on predicted icon longpress" into ub-launcher3-rvc-dev 2020-06-18 23:34:58 +00:00
TreeHugger Robot e49de265da Merge "Deprecates LAUNCHER_ALL_APPS_RANKED event." into ub-launcher3-rvc-dev 2020-06-18 23:28:35 +00:00
Samuel Fufa cb771349da convert HOTSEAT_MIGRATE_TO_FOLDER to DebugFlag
Bug: 159282737
Change-Id: Ided5ff36ee9c8792b9d9942814af15ac4c7ed7db
2020-06-18 15:08:19 -07:00
thiruram ffb55ddece Deprecates LAUNCHER_ALL_APPS_RANKED event.
LauncherUiChanged.rank field is repurposed to store all apps rank.

Change-Id: Iabad98312589d8f53b6547433540f3ec9dff0b3f
2020-06-18 15:08:16 -07:00
Samuel Fufa 44c1b5e03d Show a snackbar on predicted icon longpress
The first time a user long presses a predicted icon, suppress drag/drop and show a snackbar about app predictions.

Bug: 159170242
Test: Manual
Change-Id: I5f853a9774b38ad9fad22ff55feff417a801f52c
2020-06-18 10:57:32 -07:00
Hyunyoung Song 714659f6d0 Add LAUNCHER_WORKSPACE_SNAPSHOT event_id
Bug: 159210161
Change-Id: Ie8e843ee10bf4ab0761232a3e61eb28e487666ab
2020-06-17 22:39:36 -07:00
Becky Qiu 6fb99518ef [Overview Actions] Add overview actions events.
Event IDs were generated by command line on my workstation by uieventscli.
Manually added to StatsLogManager.

Test: local
Bug: 158477117
Change-Id: Ia237d1d9b1d5a52767cac44ab0b4a6d2500b9686
2020-06-18 03:04:45 +00:00
Miranda Kephart 1bb17f2658 Merging from ub-launcher3-rvc-dev @ build 6595814 am: efdc4e2318 am: 9cb1795a71 am: ad4bd43b8f am: 9269333de9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11885879

Change-Id: Ie7d2e841b2d41504e07633f116d80b4e3adde59f
2020-06-17 20:49:31 +00:00
TreeHugger Robot 1f325ab01e Merge "Don't reset RecentsView in onIdpChanged()" into ub-launcher3-rvc-dev 2020-06-17 18:15:39 +00:00
thiruram c6a38ba5d8 Replaces StatsLogManager.log with StatsLogManager.logger()
Bug: 159170445
Change-Id: Ice6c8a9ae30d8e6b3843bfe42926053849bf9fe0
2020-06-17 17:32:54 +00:00
thiruram d8405a63d2 Replace StatsLogManager with builder pattern.
Follow up CLs will remove the deprecating log methods and update their references.

Bug: 159170445
Change-Id: I5dfd30209eeba561df1b528a6305ca5923ba42a2
2020-06-17 08:46:43 -07:00
Tony Wickham f2b8c927a9 Merge "Fix qsb when flinging to home during gesture to overview from home" into ub-launcher3-rvc-dev 2020-06-16 22:12:28 +00:00
TreeHugger Robot a36605ee90 Merge "Preventing parallel motion event dispatching from view system and event proxy" into ub-launcher3-rvc-dev 2020-06-16 18:20:51 +00:00
Samuel Fufa dc122e816a Merge "[WW logging] Log rankings for app launches" into ub-launcher3-rvc-dev 2020-06-16 04:41:54 +00:00
Tony Wickham 80846543b5 Fix qsb when flinging to home during gesture to overview from home
- AllAppsTransitionController should not animate alphas for atomic
  components even when failing fast (we already had this check for
  the normal flow where mProgress != targetProgress).
- Don't set state to NORMAL until both the workspace stagger anim
  and overview peek anim are finished

Test: swipe up and hold from the nav bar on the home screen, then,
without lifting finger, fling upwards to return home; ensure qsb
springs in staggered formation with rest of workspace, and alpha
matches accordingly

Bug: 154637581
Change-Id: Iafeaeac50ee8bce05492628d443c3ca4ab3d26df
2020-06-15 19:27:45 -05:00
Samuel Fufa e9c4f401bd [WW logging] Log rankings for app launches
Bug: 158219113
Change-Id: Ib6db4e73e48ff27ca9d3a5348eea42e1f534dba1
2020-06-15 17:17:47 -07:00
Hyunyoung Song 730c238b8d Call displayCompletions couple frames after selectAll is called
Bug: 158710542

Change-Id: I295adce9d84bb82c4af27b7e54693ce4c64004cc
2020-06-15 13:54:54 -07:00
Tony Wickham 9459f3101f Don't reset RecentsView in onIdpChanged()
Resetting unloads visible task data and thus will leave recents
blank if overview state is enabled. Instead, unload and reload
visible task data to take new icon shape into account.

(The reason we're getting onIdpChanged() on nav bar mode change
is because the change in nav bar height causes the computed icon
size to change very slightly.)

Also fix InvariantDeviceProfile copy constructor by copying
iconBitmapSize.

Test:
- Change between 0 button and 3 button nav modes, verify recents
  doesn't appear blank
- Change icon shape in Styles and Wallpapers and go to recents,
  verify icon shape is reflected in task icons

Bug: 156354328
Change-Id: Ife29f51e85814ff483d055005fa2645135d5ec3d
2020-06-15 14:02:12 -05:00
Sunny Goyal b10e865e48 Preventing parallel motion event dispatching from view system and event proxy
1) When view system is already dispatching an event, proxy-dispatch is restricted
   to gesture only and follow the gesture dispatching rule.
2) If a full-proxy-dispatch is going on, and view-dispatch comes in, view-dispatch
   takes over and proxy-dispatch is cancelled.
3) During gesture-only proxy dispatch, if view-dispatch already started a gesture,
   proxy dispatch is ignored. Otherwise view-dispatch is restricted to non-gesture
   dispatching only (and proxy-dispatch is already restricted to gesture only).

Bug: 158130948
Change-Id: Ied351663e16beda5acf49a52bdefea881c18b9cf
2020-06-15 11:50:54 -07:00
thiruram 8da127f175 Updates StatsLogManager to log LauncherAtom.ItemInfo directly.
This method is requied for logging tap on QSB with just container info.

Bug: 154717227

Change-Id: I0c61c86724b4faafe4073a578b92a654ca23727a
2020-06-14 02:02:08 +00:00
TreeHugger Robot 161ed5ad9b Merge "Announce folder content size with folder title" into ub-launcher3-rvc-dev 2020-06-12 21:55:33 +00:00
Tony Wickham d2d9837b3e Merge "Skip fling anim if it is a no-op, to save a frame of aniamtion" into ub-launcher3-rvc-dev 2020-06-12 21:10:29 +00:00
Tony Wickham 5112cdd30b Skip fling anim if it is a no-op, to save a frame of aniamtion
Bug: 158701272
Change-Id: Id2bc502d1caaeefeca339d5e5ad355ad8ba6d7ec
2020-06-12 14:23:46 -05:00
TreeHugger Robot a41762f846 Merge "Adding a new attribute to speficy folder label directly in layout" into ub-launcher3-rvc-dev 2020-06-12 18:48:51 +00:00
TreeHugger Robot e3a51fec39 Merge "Fixing sysui visibility changing multiple times on startup" into ub-launcher3-rvc-dev 2020-06-12 18:45:41 +00:00
Samuel Fufa 1150ab3825 Announce folder content size with folder title
Bug: 144094885
Test: Manual
Change-Id: I340f9292b62163e1d72778024f1765c7618084c2
2020-06-12 11:25:32 -07:00
Hyunyoung Song 13c2bc7303 LAUNCHER_APP_LAUNCH_TAP should log correctly for icons inside folder
Bug: 137777105

Change-Id: I5c1552481fc1b788ba41c57bfe97f126f55e5b16
2020-06-11 23:51:17 -07:00
TreeHugger Robot 368621a4bb Merge "ADD NPE check before shortcut key creation." into ub-launcher3-rvc-dev 2020-06-11 23:00:05 +00:00
TreeHugger Robot 4aef742314 Merge "Reduce launcher logs in bugreports" into ub-launcher3-rvc-dev 2020-06-11 22:41:39 +00:00
Samuel Fufa adbe9b6075 ADD NPE check before shortcut key creation.
Bug: 156871815
Change-Id: I88132a51f80062eaa76da5838d20c5fe93224635
2020-06-11 15:15:02 -07:00
Samuel Fufa 852145c9b5 Reduce launcher logs in bugreports
Bug: 158216867
Test: Manual
Change-Id: I068550f2c0b233d5c7a6c4685efb36b62ced5dde
2020-06-11 15:02:58 -07:00
TreeHugger Robot 8449aeaf6e Merge "Adding tooltip for Select button." into ub-launcher3-rvc-dev 2020-06-11 21:07:39 +00:00
Sreyas da727bbb98 Adding tooltip for Select button.
Change-Id: I3a09d20b6dd26e81b8a010e2d2da52c52408e845
2020-06-11 13:29:37 -07:00
Samuel Fufa 6fd62fde91 Migrate Hotseat logging to WW
Bug: 158218197
Change-Id: I77743b78593f169ffc30f91ab9963052417dac23
2020-06-11 09:27:36 -07:00
Pinyao Ting 5c2f1a6fa4 Merging from ub-launcher3-rvc-dev @ build 6577335 am: 8020bf2f4b am: e0a0876062 am: af957e82c4 am: cd902c0fc0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11828234

Change-Id: I7def4bc74da0e4bf8ce19bd281d90945f45a6a3d
2020-06-11 09:58:01 +00:00
Tracy Zhou 3b18d41e2c Merge "Consider folder diff differently" into ub-launcher3-rvc-dev 2020-06-11 05:21:18 +00:00
TreeHugger Robot bb58efabc8 Merge "Remove unused HomeRotatedPageHandler" into ub-launcher3-rvc-dev 2020-06-11 03:10:13 +00:00
Sunny Goyal de52876a2b Fixing sysui visibility changing multiple times on startup
> During startup shelftop is updated after all-apps, causing all-apps to
set the sysuiVisibility according to it's own UI

Bug: 156422012
Change-Id: Idee06249ad45946ed0a9dc84702510ad90a305f4
2020-06-10 19:13:36 -07:00
vadimt 45564c831b Removing debug requests from non-debug test info handlers
Bug: 152629799
Bug: 153670015
Change-Id: I02776be811d1d3325b35880d19d25a6638f904ef
2020-06-10 18:48:37 -07:00
Vinit Nayak 84f30b213a Remove unused HomeRotatedPageHandler
Transfer functionality of choosing
task menu layout to PortraitPageHandler,
which is what it should have been to
begin with.

Fixes: 158484000
Change-Id: Iadda53e7e1f796c063a111823f7f6278f3fdbf58
2020-06-10 18:47:05 -07:00
TreeHugger Robot 743e25e2d2 Merge "Show discovery tip for hybrid hotseat" into ub-launcher3-rvc-dev 2020-06-10 23:22:14 +00:00
Samuel Fufa 5b2da14e72 Show discovery tip for hybrid hotseat
Doc: go/hybrid-hotseat-tips

Issue 157683315: for fully populated hotseat, count returns to home screen and show discovery tip if Tip action was not tapped.
Issue 158301717: Don't use cached items if client has predicted items.

Test: Manual
Change-Id: I4747a1148caa62a6262fb6592d5185bdf216ede6
2020-06-10 15:12:55 -07:00
thiruram ba0a6b61a3 Log folder open event into WW.
Bug: 158597506

Sample Log: https://paste.googleplex.com/5351626992779264

Change-Id: Ifb2f061924035abc84472a9a03d1b4212588428b
2020-06-10 15:00:19 -07:00
TreeHugger Robot c936fe1146 Merge "Add null check before updating animation progress" into ub-launcher3-rvc-dev 2020-06-10 21:51:45 +00:00
TreeHugger Robot 479ff47a72 Merge "Allows Accessibility to focus on specified view in AbstractFloatingView." into ub-launcher3-rvc-dev 2020-06-10 20:58:06 +00:00
Tony Wickham 779955390c Add null check before updating animation progress
Haven't been able to reproduce it locally, but seems theoretically
possible if we get an onDrag() event right after something else
cancels the animation (which clears the animation controller).

Bug: 157900227
Change-Id: Ia134aa948e62d39f71e41dd4e6b98f3227ae0522
2020-06-10 15:36:52 -05:00
Andy Wickham bc83edbf4d Allows Accessibility to focus on specified view in AbstractFloatingView.
Here, the first item in an ArrowPopup or Folder are focused on.

Note: There's another pre-existing bug where it announces
"Home screen x of y" when the floating view appears; this
change doesn't address that.

Fixes: 147470419
Change-Id: I1dc70edc21ea7c19a5742208512738d6c4a94067
2020-06-10 12:03:43 -07:00