Commit Graph

16456 Commits

Author SHA1 Message Date
Tracy Zhou a1d5ebefbf Improve grid preview performance am: b023873bc3
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12153148

Change-Id: I00c2cee5ddcbd27201de2043408109e553c3434b
2020-07-17 19:20:26 +00:00
Tracy Zhou 8c46b20958 Merge "Infinite loop when migrating calendar widget" into ub-launcher3-rvc-dev 2020-07-17 19:11:51 +00:00
Tracy Zhou 4527d2dbb2 Merge "Infinite loop when migrating calendar widget" into rvc-d1-dev 2020-07-17 19:11:05 +00:00
TreeHugger Robot 2a22f3686d Merge "Calculate all apps cell height based on actual sizes." into ub-launcher3-rvc-dev 2020-07-17 19:06:23 +00:00
Sunny Goyal 5d09b2e358 Updating some comments and variables
Change-Id: Ib3223c66e9ce187cebc6ce26a46b228f95787778
2020-07-17 18:58:49 +00:00
TreeHugger Robot 30d771860e Merge "Updating gesture tutorial home animation" into ub-launcher3-rvc-qpr-dev am: 24ddf21cea
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12117946

Change-Id: I6a86fd320482d9f3b894b8ff8eb5c7f0d5bdc9ca
2020-07-17 01:47:52 +00:00
Sunny Goyal 467aba4870 Ensuring workspace pages are offset properly in waterfall cutout am: faea66fe88
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12110121

Change-Id: I96925078c01137326fa2842dfbb5cd44b225f16b
2020-07-17 01:44:35 +00:00
TreeHugger Robot 4b1d1a0f18 Merge "Prevent showing TaskMenuView if icon isn't present" into ub-launcher3-rvc-qpr-dev 2020-07-17 00:04:41 +00:00
Sunny Goyal 852537fd98 Using StatsLog for notifyingAppPredictor
> Adding a listener in StartsLogManager for listening to events.
  This allows events to be directored to the predictor only if
  it is already running, instead of creating it.
> Unifying the event format to be same as hotseat predictor

Bug: 160748731
Change-Id: Ib00e6249ff642c030f00bcad5b748255e704d16a
2020-07-16 14:12:15 -07:00
Tony Wickham 94be66acd6 Fix tracking window being slightly off when swiping from an app
Test: swipe up from an app in landscape, seascape, and portrait,
and verify the window tracks with the finger 1:1 until pullback

Bug: 149934536
Change-Id: Ia469877e7152c8135e0b9153f69c191ba86cbd14
(cherry picked from commit f0a1b2ccd8)
2020-07-16 20:03:36 +00:00
TreeHugger Robot aea3ec064d Merge "Merging from ub-launcher3-master @ build 6682763" 2020-07-16 19:36:16 +00:00
Sunny Goyal 4ef25b0122 Merge "Fixing shortcut popop non-clicable on the icon" into ub-launcher3-rvc-qpr-dev 2020-07-16 05:58:23 +00:00
Tracy Zhou b814c3bb23 Infinite loop when migrating calendar widget
Second page can take y = 0

Fixes: 161201598
Test: manual
Change-Id: I6654db5c2c358dfb132268218dd044674e302e83
2020-07-16 05:40:37 +00:00
Tracy Zhou 85f9efa7c2 Infinite loop when migrating calendar widget
Second page can take y = 0

Fixes: 161201598
Test: manual
Change-Id: I6654db5c2c358dfb132268218dd044674e302e83
2020-07-16 05:38:00 +00:00
TreeHugger Robot d5b15bb081 Merge "Calculate all apps cell height based on actual sizes." into rvc-dev am: 8127f13231
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12152234

Change-Id: Ice2867481c5d761ef955e74671e950f89f48ea6f
2020-07-15 23:47:12 +00:00
Becky Qiu 928a421b99 Merging from ub-launcher3-master @ build 6682763
Test: manual, presubmit on the source branch
x20/teams/android-launcher/merge/ub-launcher3-master_master_6682763.html

Change-Id: Ibff46b3ef7ff89accb459db323f31179adb4ef21
2020-07-15 20:50:57 +00:00
Jon Miranda f06e1b8b93 Calculate all apps cell height based on actual sizes.
This ensures that the cell contents always fit.

Bug: 160716074
Change-Id: I3d85adec3e7e3652fe4a258bd659382a3e696211
Merged-In: I3d85adec3e7e3652fe4a258bd659382a3e696211
(cherry picked from commit 3535944395)
2020-07-15 20:43:28 +00:00
Jon Miranda c5a9ae5500 Calculate all apps cell height based on actual sizes.
This ensures that the cell contents always fit.

Bug: 160716074
Change-Id: I3d85adec3e7e3652fe4a258bd659382a3e696211
(cherry picked from commit 3535944395)
2020-07-15 20:35:57 +00:00
Tracy Zhou 4a4a3d821e Merge "Improve grid preview performance" into rvc-d1-dev am: 8951db2d23 am: 3f6c895186 am: 70daac0ccf
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12160681

Change-Id: I1b7d699e39cbc981550657add53c9b49560c477f
2020-07-15 20:31:15 +00:00
Tracy Zhou 2c0cdfb100 Improve grid preview performance am: b023873bc3
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12153148

Change-Id: Ia849496c109fc3286e2a8ec1d2fcb8f4e0c0714c
2020-07-15 19:56:14 +00:00
Tracy Zhou 92628f5305 Improve grid preview performance
After breaking down the time we spend in rendering preview under a different grid setting, I found out that we spend a huge amount of time loading the workspace. It takes a long time in non preview case (launcher workspace init), so to optimize we should try to cut down things that are not necessary for preview. Widget model loading (widget and shortcut updates) takes half of the time, and can be optimized with minimal risks / code changes.

Bug: 160662425
Test: Manual

Change-Id: I89029d0ddf6e2517077a0ba3fbbcfdcd60b268d9
2020-07-15 17:09:57 +00:00
Tracy Zhou b023873bc3 Improve grid preview performance
After breaking down the time we spend in rendering preview under a different grid setting, I found out that we spend a huge amount of time loading the workspace. It takes a long time in non preview case (launcher workspace init), so to optimize we should try to cut down things that are not necessary for preview. Widget model loading (widget and shortcut updates) takes half of the time, and can be optimized with minimal risks / code changes.

Bug: 160662425
Test: Manual

Change-Id: I89029d0ddf6e2517077a0ba3fbbcfdcd60b268d9
2020-07-14 23:30:03 +00:00
Jon Miranda ee0ebe6875 Calculate all apps cell height based on actual sizes.
This ensures that the cell contents always fit.

Bug: 160716074
Change-Id: I3d85adec3e7e3652fe4a258bd659382a3e696211
(cherry picked from commit 3535944395)
2020-07-14 22:13:41 +00:00
TreeHugger Robot 4c7ced91c0 Merge "Focuses on folder container for Accessibility when no contents to focus on." into ub-launcher3-rvc-qpr-dev 2020-07-14 16:41:25 +00:00
Andy Wickham f865551ff0 Focuses on folder container for Accessibility when no contents to focus on.
This happens when you drag an app into a folder when the current page is
already full. The new page has no apps in it until you drop the one you
want to add.

Fixes: 161040039
Change-Id: Iaa857e7a114e859fa7e6a0653028856a3a8a94a6
2020-07-13 20:56:38 -07:00
Pinyao Ting 9d51e49cec Fixes the issue Launcher state propagation is slower than onDeferredResume.
There's currently a bug prevents Launcher release drag lock for two step
widgets. Supposedly, onDeferredResume should release the drag lock; However,
in 3-button navigation mode, the transition from Overview -> Normal is
triggered in Launcher#onNewIntent, which happens after onDeferredResume.

This issue is not reproducible with gesture navigation because its
transition from Overview -> Normal is handled in NavBarToHomeTouchController

Test: manual verified with following steps
1. Enable 3-button navigation
2. Long press in WorkSpace -> Widgets
3. Drag Settings Widget to WorkSpace
4. When the config activity is shown, press "recents" button to see Overview
5. press "home" button to go back to workspace
6. repeat 2 and 3, verify the widget can be dragged
Bug: 149659788

Change-Id: I396ffa8a7db44bf3872a10de4208340a99a7efe8
(cherry picked from commit 3bf889a02f)
2020-07-13 21:46:05 +00:00
TreeHugger Robot 36a1600d66 Merge "Calculate all apps cell height based on actual sizes." into ub-launcher3-rvc-qpr-dev 2020-07-13 21:44:57 +00:00
Sunny Goyal 44a3b2030d Fixing shortcut popop non-clicable on the icon
Bug: 160819504
Change-Id: I182399aa271a2ad290c33fb39356f8f2c99e105f
2020-07-13 13:15:28 -07:00
TreeHugger Robot 0c322faedf Merge "More logging for the widgets scroll bug" into ub-launcher3-master 2020-07-10 20:42:01 +00:00
vadimt b35bdbc8ac More logging for the widgets scroll bug
Bug: 160238801
Change-Id: I198aea39ccbb3b4ab6d8696cccc868cf6465b9d2
2020-07-10 12:31:21 -07:00
Vinit Nayak 2060a4b9e1 Prevent showing TaskMenuView if icon isn't present
Also fixed another bug where the wrong layout
orientation was being applied when overview rotated
when launcher was in fixed portrait orientation.

Fixes: 160182914
Test: Tested w/ PIP, split screen,
w/o split screen w/ and w/o home rotation

Change-Id: Iccffb637ae5c22d07745f2108facd4de716dc8d3
2020-07-10 11:55:06 -07:00
Sunny Goyal ea600c70fd Creating a common method to iterate over all model items.
This would allow adding different source for model items without
modifying every model task

Bug: 160748731
Change-Id: I5a14dd761e2b8696c58dc8fec7b14077da0aced3
2020-07-10 09:56:15 -07:00
TreeHugger Robot c3c15cc946 Merge "Updating some comments and variables" into ub-launcher3-rvc-qpr-dev 2020-07-10 00:50:36 +00:00
Jon Miranda 3535944395 Calculate all apps cell height based on actual sizes.
This ensures that the cell contents always fit.

Bug: 160716074
Change-Id: I3d85adec3e7e3652fe4a258bd659382a3e696211
2020-07-09 15:00:01 -07:00
Sunny Goyal 29266c9ebe Updating some comments and variables
Change-Id: Ib3223c66e9ce187cebc6ce26a46b228f95787778
2020-07-09 12:31:49 -07:00
Sunny Goyal 6fd105b69a Updating gesture tutorial home animation
> Using a separate View as icon, instead of the taskView
> Updating swipe animation logic to abstract out FloatingIconView dependency

Change-Id: Ib466262afead11ebe4ca035d589f0382c37e3e97
2020-07-09 07:51:34 -07:00
Jon Miranda 64aefedf7e Fix bug where non-center page is visibile in HINT_STATE.
Bug: 160122854
Change-Id: I3d970e49aa891f5c9ccda60a6d6f4f73dd0a9f03
(cherry picked from commit e38322294b)
2020-07-09 00:02:43 +00:00
Sunny Goyal faea66fe88 Ensuring workspace pages are offset properly in waterfall cutout
Bug: 149224750
Change-Id: I523b09aa4cbe7710e3fd89bc716bacbafd4eadc8
2020-07-08 18:39:42 +00:00
vadimt ae76bebfed More diags for non-receiving scroll end
Bug: 160238801
Change-Id: I2e19d16e49e84e93bdf135eb97d5f033475305e8
2020-07-08 10:09:46 -07:00
TreeHugger Robot 4c40be975c Merge "Fixes the issue Launcher state propagation is slower than onDeferredResume." into ub-launcher3-master 2020-07-08 00:27:35 +00:00
TreeHugger Robot 289aca6a0e Merge "Guard swipe to notification gesture with system settings preference" 2020-07-07 02:02:11 +00:00
Jon Miranda e38322294b Fix bug where non-center page is visibile in HINT_STATE.
Bug: 160122854
Change-Id: I3d970e49aa891f5c9ccda60a6d6f4f73dd0a9f03
2020-07-06 15:38:38 -07:00
Jerry Chang 779efaca91 Guard swipe to notification gesture with system settings preference
Bug: 154080211
Test: make and install, check the gesture works as expectedly
Change-Id: Ibd6bbd595d2fba5d68e66eb54e4a7fec160b9bf8
2020-07-01 11:44:02 +08:00
Pinyao Ting 3bf889a02f Fixes the issue Launcher state propagation is slower than onDeferredResume.
There's currently a bug prevents Launcher release drag lock for two step
widgets. Supposedly, onDeferredResume should release the drag lock; However,
in 3-button navigation mode, the transition from Overview -> Normal is
triggered in Launcher#onNewIntent, which happens after onDeferredResume.

This issue is not reproducible with gesture navigation because its
transition from Overview -> Normal is handled in NavBarToHomeTouchController

Test: manual verified with following steps
1. Enable 3-button navigation
2. Long press in WorkSpace -> Widgets
3. Drag Settings Widget to WorkSpace
4. When the config activity is shown, press "recents" button to see Overview
5. press "home" button to go back to workspace
6. repeat 2 and 3, verify the widget can be dragged
Bug: 149659788

Change-Id: I396ffa8a7db44bf3872a10de4208340a99a7efe8
2020-06-30 17:00:24 -07:00
vadimt 1af70f2729 Add logging for non-sending "end scrolled" event for Widgets
Bug: 160238801
Change-Id: I60a1cb689110c5b22b0a145b3cca7d47d867005e
2020-06-30 12:36:09 -07:00
TreeHugger Robot 9f6e0f88d3 Merge "Disable auto correct/suggest on folder edit text Bug: 160075575" into ub-launcher3-rvc-dev am: fe4d64f4e3
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12031769

Change-Id: If3e3f0b4f0f33a21d8923b08f939b3f6227b494c
2020-06-29 19:51:56 +00:00
TreeHugger Robot fe4d64f4e3 Merge "Disable auto correct/suggest on folder edit text Bug: 160075575" into ub-launcher3-rvc-dev 2020-06-29 19:37:23 +00:00
Hyunyoung Song 37bda2bcc9 Disable auto correct/suggest on folder edit text
Bug: 160075575

TL;DR;; displayCompletions still work

Change-Id: I0a7cd06d25ae3976371be0707a2783702b92e8cc
2020-06-29 00:26:14 -07:00
TreeHugger Robot 434327342c Merge "During accessible drag, hover events were not properly getting dispatched to the DragAndDropAccessibilityDelegate" into rvc-dev am: 0538863c58 am: 458fef861f am: 28e8758e55 am: 72eb94ab1d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12010483

Change-Id: I1e8164d04dd80ff065e037e9d0148d801d6ee9c4
2020-06-26 22:50:46 +00:00
TreeHugger Robot 0538863c58 Merge "During accessible drag, hover events were not properly getting dispatched to the DragAndDropAccessibilityDelegate" into rvc-dev 2020-06-26 21:59:15 +00:00