Commit Graph

16456 Commits

Author SHA1 Message Date
Winson Chung f1f7b9aef9 Merge "Revert "Add logs to verify receiver is unregistered"" into sc-dev 2021-04-20 16:48:07 +00:00
Samuel Fufa 93573f0165 Merge "[Search][Keyboard] Update default allApps vertical transition inset" into sc-dev 2021-04-20 16:15:51 +00:00
TreeHugger Robot c61e393f85 Merge "Correct landscape mode color extraction rectangle" into sc-dev 2021-04-20 15:43:43 +00:00
Pierre Barbier de Reuille ca6f2475f1 Correct landscape mode color extraction rectangle
I had inverted the width and height of the screen,

Bug: 185887938
Test: Manual
Change-Id: I03889bf5e3f257414b90e992583307d61a960fe6
2021-04-20 14:59:22 +01:00
Alina Zaidi bfd56a6d59 Merge "Hide scroll bar if recycler view has no items." into sc-dev 2021-04-20 12:25:47 +00:00
Steven Ng b2c454ba15 Merge "Turn DragView into a FrameLayout" into sc-dev 2021-04-20 11:15:20 +00:00
Steven Ng 9ad5b60c6c Merge "Use availableHeightPx to calculate the max height for recommended widgets" into sc-dev 2021-04-20 10:33:32 +00:00
Alina Zaidi b89c991bab Merge "On exit search in widget picker, make recommended widgets table visible only if recommended widgets are available." into sc-dev 2021-04-20 09:54:29 +00:00
Alina Zaidi c839676fa0 Hide scroll bar if recycler view has no items.
Bug: 185873180
Test: Manually tested
Change-Id: Id0b21b264417aff19cfdcb46228bb497310ccc1b
2021-04-20 09:39:52 +01:00
Sunny Goyal 44ba9f2e14 Merge "Unifying icon loading methods" into sc-dev 2021-04-20 03:22:28 +00:00
Pinyao Ting a155f61f78 Merge "Additional debug logging to triage shortcut related issue." into sc-dev 2021-04-20 01:25:12 +00:00
Tony Wickham 8559ae324c Update TwoButtonNavbarTouchController logs
- Fix wrong bug number
- Log when we intercept and reinit to a state rather than in
  getTargetState() which is used to determine possible swipe
  directions too (which makes the logs confusing)

Test: run TaplTestsQuickstep#testOverviewActions
Bug: 177316094
Change-Id: Ibe5db6317c16c429c9c46bf237d3f8adc1458037
2021-04-19 17:40:47 -07:00
Andy Wickham 5a85912b92 Adds a flag for Smartspace feedback.
Test: Manual
Change-Id: I96dd8dad8bd2ab136960d0bebeac67b8bc00b583
2021-04-19 17:23:11 -07:00
Steven Ng 3242720ce7 Inflate LauncherAppWidgetHostView directly in DragView
Also removes AppWidgetHostViewDrawable

Bug: 183609936
Test: drag-n-drop icons, folders, widgets, shortcuts

Change-Id: I26d8b05b9f9171037f2459fa2389e7e02c8ca6dc
2021-04-20 00:26:07 +01:00
Sunny Goyal e36664d541 Turn DragView into a FrameLayout
Bug: 183609936
Test: drag-n-drop icons, folders, widgets, shortcuts
Change-Id: I030b36cd59ac6d0ced3263baca13108825ab2296
2021-04-20 00:19:06 +01:00
Steven Ng 315bef15e1 Merge "Apply color extraction when dragging" into sc-dev 2021-04-19 21:26:28 +00:00
Steven Ng 769a14ef34 Use availableHeightPx to calculate the max height for recommended widgets
heightPx doesn't take device orientation and system taskbar into account.

Bug: 185508758
Test: Open widgets tray, observe recommended widgets. Rotate the screen
      and observe recommended widgets.
Change-Id: I96f1817f96ba643e54e1d2599225254489091d03
2021-04-19 22:06:38 +01:00
Schneider Victor-tulias fb552936fd Complete gesture nav sandbox for for UXR.
- Removed All set screens altogether.
- Added "x" button to feedback view. This button now launches a dialog that allows the user to skip the tutorial.
- Added a progress tracker to the feedback view.
- Created a launch option to launch the back, home, then overview gesture tutorials in order.
- Added a button in the feedback view to progress through the tutorial.
- Updated tutorial animations to AnimatedVectorDrawables (with green accents).

Bug: 148542211

Test: manual
Change-Id: Icf3ec424141069895f97da74cd4ae881ff898d3f
2021-04-19 13:41:57 -07:00
Alina Zaidi 1869a9868c On exit search in widget picker, make recommended widgets table visible
only if recommended widgets are available.

This fixes missing scroll bar on exit search issue (b/183616305)

Bug: 183616305
Test: Manually tested
Change-Id: I3ced5fb2f833f3d34b7dfd376bb4b7c231bc28f6
2021-04-19 20:02:17 +01:00
Pinyao Ting 486ce88f18 Additional debug logging to triage shortcut related issue.
Bug: 185614138
Test: flash and verify logs shows up in bugreport
Change-Id: Ie7b45b5ffbd9ee2ed64f478647779e240f3255a7
2021-04-19 11:17:42 -07:00
Samuel Fufa 3722bb5620 [Search][Keyboard] Update default allApps vertical transition inset
Bug: 184721373
Test: Manual
Change-Id: I96c930a05055caa6ae1789c9d82810c099a0d133
2021-04-19 17:23:04 +00:00
Steven Ng a999e22560 Apply color extraction when dragging
Bug: 185795141
Test: Drag the test color extraction widget and observe the change in
      the widget background.
Change-Id: I17203fcb0d7579b1570c68f22248966c3a561c64
2021-04-19 18:19:06 +01:00
Alina Zaidi 45b8e48a69 Merge "Only setup widget adapters once after inflation" into sc-dev 2021-04-17 19:15:11 +00:00
Andy Wickham 855072cda5 Sandbox changes for use in UXR prototype.
- "All Set" screen doesn't show after Home/Overview/Back tutorials.
 - X button in top left is hidden (we'll want to move this to the
   feedback view).
 - Feedback pops in and out from the top of the screen.
 - Hand animation is replaced by video feedback at start and after
   incorrect gesture.
 - Back tutorial goes left then right, in order to match video.
 - Updated strings and marked translatable (UX-reviewed already).
 - Added Chinese translations.
 - Many other things.

Test: Manual
Change-Id: I126a3ea0dad645014fab9cdee2ed19e06a8a56e9
2021-04-16 16:54:41 -07:00
Winson Chung a1c5443a1c Revert "Add logs to verify receiver is unregistered"
Revert "Add logs to verify receiver is unregistered"

Revert submission 14193940-receiver_logs

Reason for revert: Not needed
Reverted Changes:
I67fb3d8a0:Add logs to verify receiver is unregistered
I0ab5a8199:Add logs to verify receiver is unregistered

Change-Id: I32a05ff6639a7512fac2391430dde8b939d136df
2021-04-16 21:30:34 +00:00
Steven Ng bacfccfc7d Merge "Add debug logs for widget recommendation down scale calculation" into sc-dev 2021-04-16 19:55:05 +00:00
Adam Cohen 6adae06ed2 Merge "Update drag and drop visualizations" into sc-dev 2021-04-16 18:06:54 +00:00
Steven Ng 29f6b0ba05 Add debug logs for widget recommendation down scale calculation
Bug: 185508758
Test: None
Change-Id: I0b4789075bcc5ffc26f30dcd483f7c97bee9f410
2021-04-16 18:39:45 +01:00
Steven Ng ffde1471e4 Only setup widget adapters once after inflation
Bug: 185587905
Test: Switch to a new Guest user. Then, quickly open the all widgets
      picker and scroll to the bottom. The widgets picker no longer
      scroll to top even after app icons are loaded.
Change-Id: I1ffef95af56935d101d12520a20be97931d1429d
2021-04-16 18:02:23 +01:00
Alex Chau 84a1e40912 Merge "Handle page offset for grid overview" into sc-dev 2021-04-16 14:09:33 +00:00
Steven Ng 681aa90325 Merge "Fix app widget preview layout drag-n-drop & rendering" into sc-dev 2021-04-16 12:27:15 +00:00
Cyrus Boadway 42431d5217 Merge "Use Quickstep ActivityOptions when launching activities from App Widgets" into sc-dev 2021-04-16 11:53:35 +00:00
Alex Chau 9594c6987f Handle page offset for grid overview
- Use TaskView's actual position with grid/fullscreen translation considered for taskPosition calculation
- Shift taskPosition by midpoint scroll, and no longer assumes midpoint is on middle of the screen
- Handle situation that TaskView is on left/right of midpoint, making the calculation generic to be able to handle grid situation

Bug: 175939487
Test: Launch modal view with wide/, RTL/non-RTL, orientation/simulated landscape combinations
Change-Id: Idd0cc9c5e24f453d830e1420319a38d3d784270d
2021-04-16 12:25:49 +01:00
Cyrus Boadway 0d309db47e Use Quickstep ActivityOptions when launching activities from App Widgets
Set a Quickstep specific InteractionHandler on QuickstepLauncher's
AppWidgetHost, which provides QuickstepTransitionManager-generated
ActivityOptions when starting activities from app widget interactions.

Bug: 169042867
Test: manual
Topic: quickstep-widget-app-launch
Change-Id: I231122b09aede940c047f19a5b5d1e7c562f6d3f
2021-04-16 09:42:46 +00:00
Steven Ng f089f741ad Fix app widget preview layout drag-n-drop & rendering
1. Before this CL, preview layouts are not rendered in both the
   BottomWidgetSheet and SearchPopupSheet because the preview
   width & height are not set correctly.
2. Also applies the right padding to preview layouts.

Bug: 185374336
Test: Drag-n-drop preview layout from the full widgets picker,
      the bottom widgets picker and the search widgets picker.

Change-Id: I2b6303bfe4eb86a4935a5569f6107e9d46448902
2021-04-16 10:41:33 +01:00
Sunny Goyal 9f2acdd552 Unifying icon loading methods
Bug: 183641907
Test: Presubmit
Change-Id: I255e81a128635910b531b3d00f707fa352050f2e
2021-04-15 16:48:04 -07:00
Adam Cohen f7ca3b4e3f Update drag and drop visualizations
=> Remove the bitmap-based icon outline
=> Add simple cell based location preview of drop location
=> Round corners of page outlines
=> Get rid of page background for focused page
=> Update colors to use system accent color

Bug: 185163323

Test: manual

Change-Id: Id604c59201536967e25236f305eeeb0aafc9c022
2021-04-15 12:45:24 -07:00
Becky Qiu 27e6c78fee [Overview Sharing] Add logging events for overview sharing.
Event IDs were generated by command line on my workstation using uieventscli.
Manually added events to StatsLogManager. Will be used in Overview events.

Bug: 179831990
Test: will test in overview when add to code implementation.
Change-Id: If6ad7f42c899b78b53fb4a54d33a6c8df264dff2
2021-04-15 11:58:04 -07:00
TreeHugger Robot c874ccc163 Merge "Fix regression where StaggeredWorkspaceAnim didn't respect animateScrim" into sc-dev 2021-04-15 17:39:01 +00:00
TreeHugger Robot 0ad2caeaf9 Merge "Add logs to verify receiver is unregistered" into sc-dev 2021-04-15 17:22:15 +00:00
Winson Chung 8d8383ab40 Add logs to verify receiver is unregistered
Bug: 185385047
Test: Adding logs
Change-Id: I0ab5a819902bfa4e836f59e854c53f70c4ca877b
2021-04-14 23:53:20 -07:00
Tony Wickham 01320be908 Fix regression where StaggeredWorkspaceAnim didn't respect animateScrim
Before, this happened to work because we skipped setting the scrim when
doing an atomic animation, but the atomic animation code has been
removed. Add an explicit SKIP_SCRIM config flag instead.

Test: swipe up from overview to home, ensure scrim animates nicely

Bug: 185411781
Change-Id: I7bc14a11d9d416cc7336ea29d21107dcdbdbf782
2021-04-14 14:54:44 -07:00
TreeHugger Robot 9a7281c51e Merge "Add logs to help debug TwoButtonNavBarTouchController" into sc-dev 2021-04-14 19:40:54 +00:00
Steven Ng 63365cf034 Merge "Fix drag-n-drop from the pin widget flow" into sc-dev 2021-04-14 08:47:06 +00:00
Hyunyoung Song 64afdab77c Merge "Reduce the spring effect on All Apps" into sc-dev 2021-04-14 06:01:33 +00:00
Hyunyoung Song 9e7faadba4 Reduce the spring effect on All Apps
Bug: 185290838
Test: manual
Change-Id: Ie48ae27071d113603451c4198e762f03feaaa0d6
2021-04-13 20:48:25 -07:00
Andy Wickham 3aea671e4f Merge "Updates quickswitch animation from Launcher." into sc-dev 2021-04-14 01:56:36 +00:00
Andy Wickham 3f504dcbf9 Merge "Expose the LauncherModel ModelDelegate" into sc-dev 2021-04-14 01:10:16 +00:00
Tony Wickham 7b2e3df2d7 Add logs to help debug TwoButtonNavBarTouchController
Test: TaplTestsQuickstep#testSwitchToOverview()

Bug: 13714484
Change-Id: I21740ac0fd6ddf2923fd081a00c84a463f13673b
2021-04-13 16:45:41 -07:00
Andy Wickham 18694a2545 Updates quickswitch animation from Launcher.
- Workspace/All Apps/Hotseat no longer translate down
 - Fading of these elements and scaling of Workspace are tied to the
   wallpaper depth animation
 - At any point in the drag, you can still swipe up to enter Overview

This makes it feel like the apps are tied to the wallpaper and avoids
moving them orthogonally to the finger.

It also makes the "No recent items" animation more elegant.

Demo: https://drive.google.com/file/d/1phuRCqb69vuMp3ijS6PR5lTEcBHScjie/view?usp=sharing&resourcekey=0-2HXtMLUhQ-YU53hYlYV-fQ
Demo with no recent apps: https://drive.google.com/file/d/1wjexqznxs9ZhiUtCDW4-ZK6c7hKDRaXn/view?usp=sharing&resourcekey=0-GugbpJK8_cnFbUBB2Ar30w

Fixes: 174228745
Test: Manual
Change-Id: I1574ff89a0f382b7e63bf03cf4300ec7c695cfec
2021-04-13 15:35:46 -07:00