Commit Graph

16456 Commits

Author SHA1 Message Date
Sunny Goyal 908e3d1312 Fixing nullPointer exception when wallpaper colors is null
Bug: 186722571
Test: Presubmit
Change-Id: Iee0d15d460de47cc20395cf9f3d92784aef6268e
2021-04-30 14:18:43 -07:00
Sunny Goyal b745a2a9fd Fixing transition end not getting called if pagedView is not drawing
Bug: 186822776
Test: Manual
Change-Id: I60e9028d17f39a4ad95f9aa79f8b4be695b4ae65
2021-04-30 13:38:59 -07:00
TreeHugger Robot f9f506ca7e Merge "Update drop target styling based for BC." into sc-dev 2021-04-30 16:46:53 +00:00
Alina Zaidi b42513fbc5 Merge "Fix some bugs in widget pickers." into sc-dev 2021-04-30 09:19:07 +00:00
Alina Zaidi 2b5124ec41 Fix some bugs in widget pickers.
- Update color of Educational tip view contents. Background colorAccentSecondary
in NexusLauncher above S, colorAccent otherwise (b/185834169)
- Update widget picker search bar color and its text font and color. (b/186423026)
- Update button padding and text in pin widget picker. (b/182994384, b/183601584)

Bug: 185834169
Bug: 186423026
Bug: 182994384
Bug: 183601584
Test: Manually tested
Change-Id: I36cd3ed2285677d0c164db8f57f6c90a5f247982
2021-04-30 07:52:23 +01:00
TreeHugger Robot 3395d1de7a Merge "Arrow popup - adjust margin to account for RTL and LTR." into sc-dev 2021-04-30 00:05:27 +00:00
Adam Cohen 0c4d278ed2 Don't fade out active page outline during drag-and-drop
=> Keep page backgrounds stable and only slightly modify the alpha + add stroke for active page
=> Don't shrink cell outlines to be too small (issue in hotseat on some devices)
=> Reduce cell radius to 22dp

Bug: 185163323
Test: manual

Change-Id: Ic17999f5672a3355dceeb25af923f02e960389d9
2021-04-29 23:09:56 +00:00
Zak Cohen 284b6ed6a7 Arrow popup - adjust margin to account for RTL and LTR.
Bug: 185887218
Test: Local in ltr and rtl
Change-Id: I50d1e9dbc64dc02f31661d91a6c9a90e4383c5c7
2021-04-29 15:34:29 -07:00
TreeHugger Robot 44e6fb6ed4 Merge "Calling pageTransisionEnd only after edgeEffect finishes" into sc-dev 2021-04-29 22:15:41 +00:00
TreeHugger Robot 14e2070709 Merge "Replace conversations widget app icon" into sc-dev 2021-04-29 22:15:21 +00:00
Sunny Goyal 05b59c080f Calling pageTransisionEnd only after edgeEffect finishes
Bug: 186605795
Test: Presubmit
Change-Id: I2b46d0b0a47c68038f300e71ab89bd7e5a5e3895
2021-04-29 13:56:08 -07:00
Steven Ng 1140f84b6f Replace conversations widget app icon
Test: Open full widgets picker and observe the expected icon for
      the conversations category.
Bug: 184878454
Change-Id: I580b0148d39c8dd004113c8f966135b22165a329
2021-04-29 17:46:29 +01:00
Yogisha Dixit a3a6f51b12 Update drop target styling based for BC.
Spec: https://docs.google.com/presentation/d/1UxdDh8EFhPbdRWRwzjbpgL-j02ew4Ew3eG3XBCeoYdo/edit#slide=id.vXfwHn8

Demo: https://drive.google.com/file/d/1ZIa3Dgo85vdVkfPm7aGJDyctZQR_c8Xx/view?usp=sharing

Test: manual
Bug: 184713740
Change-Id: I17dbbf1f7bbc40939cfc0fedb506a35f39ecc2e3
2021-04-29 09:18:05 +00:00
TreeHugger Robot e1a2ea769f Merge "Remove debugging logs from the full widgets picker" into sc-dev 2021-04-29 08:33:36 +00:00
TreeHugger Robot 5354abb0e7 Merge "[Overview Sharing] Turn on the feature flag for overview sharing." into sc-dev 2021-04-29 00:20:47 +00:00
Shan Huang 64fc7543f0 Merge "Updated launcher text shadow values." into sc-dev 2021-04-29 00:16:47 +00:00
Becky Qiu a6cec336ff [Overview Sharing] Turn on the feature flag for overview sharing.
Bug: 186670923
Test: manual
Change-Id: I57514cde11dc3315c8671c286a6963d29cf346e1
2021-04-28 15:20:49 -07:00
TreeHugger Robot 127714094a Merge "Change TaskIconMenu to lay out vertically" into sc-dev 2021-04-28 20:16:43 +00:00
Vinit Nayak 4cc0dbb552 Change TaskIconMenu to lay out vertically
Still lays out horizontally when in phone
landscape.
TODO(b/186583656), need to center view.
Also have all layout be dynamic instead of having
some cases be in XML and some in code.

Bug: 181704764
Test: Task menu visible with all options in
portrait/landscape tablet
portrait phone
fake/real landscape phone

Change-Id: I3632eeb174f3e4baf2c9d69d51c1815c3c512e59
2021-04-28 11:47:08 -07:00
Steven Ng 3417c1d22b Remove debugging logs from the full widgets picker
Test: None
Bug: 185508758
Change-Id: I2958118abc9d4f3778aaf6c3e3df01b0712354dc
2021-04-28 19:27:40 +01:00
TreeHugger Robot 04a194fca0 Merge "[AA+] Add SearchResult type to ItemInfo attributes." into sc-dev 2021-04-28 18:16:54 +00:00
Steven Ng 84298b3998 Add a flag to enable custom local filter for recommended widgets
Test: Run WidgetsPredictionUpdateTaskTest
Bug: 186648032
Change-Id: I2bd5e2c81f971e0a40a4b05c8cab2a7adb171f96
2021-04-28 18:47:33 +01:00
Winson Chung 4dd75b334f Merge "Prevent multiple calls to finish on the recents controller" into sc-dev 2021-04-28 17:22:19 +00:00
thiruram 1987a42d3c [AA+] Add SearchResult type to ItemInfo attributes.
Bug: 186169419
Test: Manual
Change-Id: I9ea707e135eda163dfb3f12f48f4f0c37e6c044e
2021-04-28 09:36:05 -07:00
TreeHugger Robot 6bb0844766 Merge "Remove shadow on folder icon." into sc-dev 2021-04-28 15:11:16 +00:00
Alina Zaidi e5bd97c5f8 Merge "Always check for availability of widgets before changing visibility of recycler view and no widgets view." into sc-dev 2021-04-28 11:48:57 +00:00
Alina Zaidi 9f531ee6c4 Always check for availability of widgets before changing visibility of
recycler view and no widgets view.


Bug: 186117900
Test: Tested manually
Change-Id: I57ac95fee935a54ce70f5793f0b0686b549cbf9e
2021-04-28 10:36:46 +01:00
TreeHugger Robot 11ec51c48c Merge "Correct the preview generation for App Widgets." into sc-dev 2021-04-28 09:35:56 +00:00
Steven Ng 26524eced6 Merge "Fix WidgetsBottomSheet inset bug after orientation change" into sc-dev 2021-04-28 09:04:52 +00:00
Pierre Barbier de Reuille 813856ab80 Correct the preview generation for App Widgets.
If the App Widget provider doesn't define a preview, we generate one. We
needed to update it to include the correct corner radius and remove the
shadow (as Material Next doesn't use shadows).

Fix: 184610987
Test: Manually using Youtube Music
Change-Id: Id6b88821ab1b406f1c40d94f6c50e133eb7fa808
2021-04-28 09:25:14 +01:00
Winson Chung fb45e57ac1 Prevent multiple calls to finish on the recents controller
Bug: 186246362
Test: Verify from logs that we don't finish the controller
      multiple times
Change-Id: I8d40a756216133b8a278a28b822cf75c6e2a3046
2021-04-27 21:20:24 -07:00
TreeHugger Robot 69cb35a85a Merge "Some overview scrim and status bar color adjustments" into sc-dev 2021-04-28 03:23:13 +00:00
TreeHugger Robot 45167d6030 Merge "Removing dependency on wallpaper colors and using theme resources" into sc-dev 2021-04-28 03:00:17 +00:00
Tony Wickham b482188775 Some overview scrim and status bar color adjustments
- Replace UI_STATE_OVERVIEW with UI_STATE_FULLSCREEN_TASK. Overview no
  longer needs it's own status bar treatment as it's handled by
  ScrimView already. So remove instances of UI_STATE_OVERVIEW and
  replace some with UI_STATE_FULLSCREEN_TASK if a TaskView is behind
  the status bar.
- Add ScrimView to fallback recents activity.
- Remove scrim from Background state, don't fade it in until the
  gesture ends to RECENTS.

Test: watch scrim and status bar colors during the following
- Swipe up to home (no scrim, status bar matches task at first but
  then wallpaper once task isn't overlapping status bar)
- Swipe up to overview (no scrim until let go to overview, status
  bar matches task at first, then wallpaper after not overlapping,
  then scrim once it's 90% opacity)
- Quick switch from home (scrim fades in, status bar matches once
  it reaches 90% opacity)
- Quick switch from app (no scrim, status bar matches center task)
- Repeat above for 3P launcher and 2 button mode

Fixes: 185681676
Fixes: 185286870
Change-Id: I9e5c292cc734e714169b9cc8268e8dad4e868aca
2021-04-27 17:44:30 -07:00
TreeHugger Robot 222b4757f5 Merge "Allow Workspace Scrim to be colored per state" into sc-dev 2021-04-28 00:10:26 +00:00
Becky Qiu 3374033fa9 Merge "Revert "[Overview Sharing] Enable overview sharing for Droidfood."" into sc-dev 2021-04-28 00:09:55 +00:00
Becky Qiu 2eea322788 Revert "[Overview Sharing] Enable overview sharing for Droidfood."
This reverts commit f2efcb53d0.

Reason for revert: might break presubmit because of memory leak. see b/186579113

Change-Id: I7dfb303b7c4d0c9a8914f05f04b955e9f53c62c8
2021-04-27 23:50:02 +00:00
Sunny Goyal 4ed0fb5074 Removing dependency on wallpaper colors and using theme resources
Bug: 184676715
Test: Manual
Change-Id: Ie9a9a784c4a8a8cd484bfd8ea463deedcd4deed6
2021-04-27 16:29:08 -07:00
Steven Ng 6fe7df3fa8 Fix WidgetsBottomSheet inset bug after orientation change
Reset the inset upon orientation change

Test: Open bottom widgets picker. Rotate the screen from portrait
      to landscape and then back to portrait. Observe the correct
      inset is set.
Bug: 183601302
Change-Id: I88432a49b2601df843fe33911fd7acdde66d06c4
2021-04-27 22:11:42 +01:00
Zak Cohen 4d35ac3020 Allow Workspace Scrim to be colored per state
Make it possible to set the color of workspace scrim to a different color
per state. Motivated by making Overview Scrim and All Apps scrims different
colors.

Bug: 186253733
Test: Local build and flash
Change-Id: Id7c38ce3c9173308eedfcb7592ececa7bd6bf220
2021-04-27 14:04:46 -07:00
Becky Qiu 81d943d31b Merge "[Overview Sharing] Enable overview sharing for Droidfood." into sc-dev 2021-04-27 19:23:04 +00:00
Steven Ng f4bd91f0ab Merge "Add a11y action for expand / collapse items in WidgetsFullSheet" into sc-dev 2021-04-27 16:28:11 +00:00
Steven Ng fd68f757c8 Add a11y action for expand / collapse items in WidgetsFullSheet
Test: Enable talkback. When focusing on a collapsed item, it announces
      Collapsed "App Name" "n widgets/shortcuts". Action available. Use
      tap with 3 fingers to view. 3 fingers tap > Action > Expand.
      Widgets are expanded.
      When focusing on an expanded item, it announces
      Expanded "App Name" "n widgets/shortcuts". Action available. Use
      tap with 3 fingers to view. 3 fingers tap > Action > Collapse.
      Widgets are collapsed.
Bug: 183120145
Change-Id: Ibbb6025b929c141aa9e2fd2c72dce314e8be837e
2021-04-27 16:28:00 +00:00
Cyrus Boadway 5f35ff021d Merge changes I65d2b1bc,I35bf9cb4 into sc-dev
* changes:
  Animate App Widget activity launch from Quickstep launchers
  Add a mechanism to temporarily defer App Widget updates
2021-04-27 10:17:00 +00:00
TreeHugger Robot c2f4f0de02 Merge "Include recommended widgets table vertical padding in the height estimation" into sc-dev 2021-04-27 08:57:32 +00:00
TreeHugger Robot 1b195c9ff4 Merge "Revert "[Search][Motion] Separate AllApps scrim and content interpolation"" into sc-dev 2021-04-27 01:46:44 +00:00
Zak Cohen 079003b44d Revert "[Search][Motion] Separate AllApps scrim and content interpolation"
This reverts commit 8c383f97e4.

Reason for revert: ScrimView is used in multiple places, Overview is broken by this change.

Change-Id: Ie395e2d94feaca4c9365bb5da68e9dc219990e03
2021-04-26 23:59:07 +00:00
Jonathan Miranda 19c1b86bc3 Merge "Use separate color for popup when on top of another surface (folder/all apps)." into sc-dev 2021-04-26 23:59:04 +00:00
Jon Miranda 72ec557ee7 Remove shadow on folder icon.
Bug: 175329686
Test: manual, verify no shadow on folder icon background
Change-Id: I8ec9ac55ca4fd48155f017376c5bcd6043771d2a
2021-04-26 18:40:03 -04:00
Jon Miranda a3c8662a56 Use separate color for popup when on top of another surface (folder/all apps).
This ensures the two surfaces contrast.

Bug: 175329686
Test: long press on item in folder
Change-Id: Ic2ac9c433ce219452024071388fa0cfb51487fb6
2021-04-26 17:59:21 -04:00