Commit Graph

14731 Commits

Author SHA1 Message Date
Tony Wickham b6f593042d Don't rely on QuickstepLauncher instance for tests
Instead, bind to TouchInteractionService and use that binder to call into taskbar.

Test: TaplTestsTaskbar
Bug: 235986838
Change-Id: I222522bc53c9d1698542fbae52c37889f14abf41
2022-08-29 17:27:27 -07:00
Brian Isganitis 5208317c64 Merge "Add doc clarifying Taskabr icon alpha consumer purpose." into tm-qpr-dev am: a4636922a6 am: e5f48d27db
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19040760

Change-Id: I4b1c43eb7e117f655e1a19664b8875ffb8179a80
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-29 21:44:42 +00:00
Brian Isganitis e5f48d27db Merge "Add doc clarifying Taskabr icon alpha consumer purpose." into tm-qpr-dev am: a4636922a6
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19040760

Change-Id: Iffa23a000164d0dd70e1dc1589cd6d6559814230
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-29 21:13:21 +00:00
Brian Isganitis a4636922a6 Merge "Add doc clarifying Taskabr icon alpha consumer purpose." into tm-qpr-dev 2022-08-29 20:54:07 +00:00
Brian Isganitis 2303eb0aac Simplify calculateEndTarget logic.
This method has grown quite large and has a lot of if-else nesting. We
can address these readability issues by defining some helper methods for
specific cases (e.g. flingY and non-fling).

Bug: 222117127
Test: Manual
Change-Id: Ia6012dbcee9a842b4b5bd2ffdb9aea978cfdfc26
2022-08-29 20:47:32 +00:00
Bill Yi 0940c2d92c Merge "Import translations. DO NOT MERGE ANYWHERE" into tm-qpr-dev 2022-08-27 23:25:04 +00:00
Brian Isganitis dc643f9bea Add doc clarifying Taskabr icon alpha consumer purpose.
The motivation ternary `alpha > 0 ? 0 : 1` was not immediately clear, so adding some clarification for future readers.

Test: No
Change-Id: I558e86153e68572a519317dba7fbba180cb5678e
Fix: 239074423
2022-08-27 20:46:49 +00:00
Thales Lima f688f1388f Merge "Add screen recording to flaky test" 2022-08-27 01:53:03 +00:00
Bill Yi 90b0be5994 Merge "Import translations. DO NOT MERGE ANYWHERE" 2022-08-26 18:49:50 +00:00
Alex Chau 543857f496 Add screen recording to flaky test
- Also updated bug id for a ScreenRecord

Test: presubmit
Bug: 242163205
Bug: 241821721
Fix: 242163245
Change-Id: I43ff9fca285649933a100e4a02c660087308a7ac
2022-08-26 18:36:33 +01:00
Alex Chau 20eb0e3f67 Replace shelf height with keep clear areas registration in Launcher.
This affects Hotseat only for now. Taskbar will be occluded when unstashed.

When in gesture nav and with auto-enter pip, we need to pre-register the Hotseat
keep clear areas, as otherwise the event appears after the animator is started
and current logic doesn't allow to update those destination bounds in the animator.

Test: manually, existing tests pass
Bug: 183746978

Change-Id: I4d97ca77225d3502acac1fb6b5e3eff3e81285ed
2022-08-25 22:52:17 +00:00
Schneider Victor-tulias 305a1df9d9 Merge changes I562abc6c,I7a48d960,I0916f969 into tm-qpr-dev am: 7fb96a5305 am: 2ed4c84e68
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19517498

Change-Id: If267d42f6d15fef03373ffe0c77fc1ebb1a7dd3a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-25 21:31:02 +00:00
Schneider Victor-tulias 2ed4c84e68 Merge changes I562abc6c,I7a48d960,I0916f969 into tm-qpr-dev am: 7fb96a5305
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19517498

Change-Id: I21769aa2d541176fb63faceb55043dfccee1a693
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-25 21:02:03 +00:00
Schneider Victor-tulias 7fb96a5305 Merge changes I562abc6c,I7a48d960,I0916f969 into tm-qpr-dev
* changes:
  Update ActiveGestureLog to store n-gestures rather than n-events.
  Add input consumer selection reason to active gesture logs
  Collapse EventLogArray into ActiveGesture log.
2022-08-25 20:42:13 +00:00
Bill Yi 4bf2ba3909 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I863080296dc2f570776996e1fc700d152622282b
2022-08-25 11:19:29 -07:00
Schneider Victor-tulias 976fdbe623 Update ActiveGestureLog to store n-gestures rather than n-events.
Test: printed logs after several gestures
Bug: 227514916
Change-Id: I562abc6c5c43e53a53b085234b0be01dae90ac06
2022-08-25 17:05:01 +00:00
Schneider Victor-tulias 24637f50c5 Add input consumer selection reason to active gesture logs
Test: manually tried gestures in 3 button and gesture nav and checked logs
Bug: 227514916
Change-Id: I7a48d960ef5a41ddee95153fa08a2345f00cbef7
2022-08-25 10:03:30 -07:00
Schneider Victor-tulias a0cd3e0295 Collapse EventLogArray into ActiveGesture log.
EventLogArray is never used directly, only used as a super class of ActiveGestureLog. Simplifying the hierarchy to simplify follow-up changes.

Test: manually tried gestures in 3 button and gesture nav and checked logs
Bug: 227514916
Change-Id: I0916f969a776953ddc4886846ad2f4936566e7d7
2022-08-25 09:59:13 -07:00
Bill Yi 4374fc5fb0 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Ifdddfb5419dfc5e88939f25cc12d87f5b9f85728
2022-08-24 22:08:35 -07:00
Sunny Goyal 4b0dc5b562 Inlining BaseQuickstepLauncher to QuickstepLauncher am: d6801af69a am: 85c106aba1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19668510

Change-Id: If899cc781782346d4aedd1562033c774171388fa
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-24 23:21:10 +00:00
Sunny Goyal 85c106aba1 Inlining BaseQuickstepLauncher to QuickstepLauncher am: d6801af69a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19668510

Change-Id: I576f4f3a586b159b552d301aa9084ece2565c8f6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-24 22:56:19 +00:00
Sunny Goyal d6801af69a Inlining BaseQuickstepLauncher to QuickstepLauncher
Bug: 243022799
Test: Presubmit
Change-Id: I3706fc1f10d88ea73bd873c7e94c3e78795791eb
2022-08-24 12:51:21 -07:00
Evan Rosky 2cfc8abceb Merge "Use SysUI/Shell's transaction apply token in Launcher" 2022-08-24 15:02:47 +00:00
Pat Manning 53d750e427 Launch tasks before testing switch to overview.
Bug: 238461210
Test: TaplTestsQuickstep#testSwitchToOverview
Change-Id: I0033b8b33371a01165c595ae66826bef5699eddb
2022-08-24 12:25:00 +00:00
Jeff Chang 7cffefbe9b Merge "Launch split task with correct UserHandle" into tm-qpr-dev am: 831f5ee748 am: ede6d7b35c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19668512

Change-Id: I64778a8e2f7930a5a132c897e3dee6dbd2532e36
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-24 08:52:12 +00:00
Jeff Chang ede6d7b35c Merge "Launch split task with correct UserHandle" into tm-qpr-dev am: 831f5ee748
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19668512

Change-Id: Ic8ebe6eed9db0eae534c7b3b710e8abf490b7312
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-24 08:23:25 +00:00
Jeff Chang 831f5ee748 Merge "Launch split task with correct UserHandle" into tm-qpr-dev 2022-08-24 07:48:09 +00:00
Nataniel Borges d49770c716 Merge "Fix testDisableRotationCheck" 2022-08-24 07:13:49 +00:00
Winson Chung 19da9249dc Merge "Defer adding surface changed callback until view root is valid" into tm-qpr-dev am: c04576ad6e am: 9411d64586
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19628908

Change-Id: I8bb7d072097f0b1b22fac5f63ea8e525e3b88af5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-24 05:27:03 +00:00
Pinyao Ting 292d0d3dc9 Merge "Explicit Nullbility in Launcher (Part 2)" into tm-qpr-dev am: 775b0d21dc am: ff8f09b5b5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19679564

Change-Id: I569d5e6fd9ebbcb31266c6683c129481ee3c2144
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-24 05:08:54 +00:00
Jeff Chang 9f27fa3687 Launch split task with correct UserHandle
PendingIntent#getActivity gets the owner UserHandle from the app
context. That makes the activity launch fail since the app only exists
in the work profile environment(secondary user).

This CL gets the correct Userhandle from Launcher and use
PendingIntent#getActivityAsUser to launch split task.

Bug: 242039471
Test: Launch Google chat by shortcut to enter split (work-profile)
Change-Id: Ie1db8a858bf9cee700cb3ff3a9e607a5d1dbad30
2022-08-24 10:39:04 +08:00
Evan Rosky 6e326cf205 Use SysUI/Shell's transaction apply token in Launcher
Launcher and SysUI/Shell have a lot of interactions
that require careful synchronization and ordering (at-least
with shell-transitions). As a result, they need to share
the same apply token or else some operations can end up
out-of-order despite being applied in-order.

Bug: 242193885
Test: Open an app, quickswitch repeatedly.
Change-Id: I4cbe8b5db28516db7a08b4022f1199f3f6b89591
2022-08-24 00:06:18 +00:00
Winson Chung 9411d64586 Merge "Defer adding surface changed callback until view root is valid" into tm-qpr-dev am: c04576ad6e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19628908

Change-Id: I8f43ab2e866c34ccddd4c802c4892714160a66f5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-23 23:03:18 +00:00
Winson Chung c04576ad6e Merge "Defer adding surface changed callback until view root is valid" into tm-qpr-dev 2022-08-23 21:32:48 +00:00
Pinyao Ting ff8f09b5b5 Merge "Explicit Nullbility in Launcher (Part 2)" into tm-qpr-dev am: 775b0d21dc
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19679564

Change-Id: Id2c74d88f52aa1dd9b0c22738f7f36c2b4d7afdf
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-23 20:54:35 +00:00
Nataniel Borges 8fe224c90a Fix testDisableRotationCheck
Move it to the NexusLauncherTests and launch app before rotation check

Bug: 241017339
Test: testDisableRotationCheck
Change-Id: Ia9b5d6738a8c725c68bb6422ab44cbed5ecbc0a6
2022-08-23 18:32:40 +00:00
Pinyao Ting 775b0d21dc Merge "Explicit Nullbility in Launcher (Part 2)" into tm-qpr-dev 2022-08-23 16:53:20 +00:00
TreeHugger Robot 39d5f1661f Merge "Import translations. DO NOT MERGE ANYWHERE" into tm-qpr-dev 2022-08-23 05:46:40 +00:00
Pinyao Ting 023b973d15 Explicit Nullbility in Launcher (Part 2)
This CL updates the nullabality on methods associated with IconCache in Launcher.

Bug: 242895652
Test: manual
Change-Id: I4832c0950141c8a52c8a9e62659ccabb082897c8
2022-08-22 17:15:44 -07:00
Sunny Goyal ca5761d21f Merge "Removing some obsolete features" into tm-qpr-dev am: 211496e3d8 am: a3dacac8b9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19505122

Change-Id: I8a0157caa803b2edcef458895d7e9ded06ea5fe0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-22 21:07:20 +00:00
Sunny Goyal a3dacac8b9 Merge "Removing some obsolete features" into tm-qpr-dev am: 211496e3d8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19505122

Change-Id: I55e7b6d0fe88daa964216fb58700f3ba0671f30d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-22 20:46:31 +00:00
Sunny Goyal 211496e3d8 Merge "Removing some obsolete features" into tm-qpr-dev 2022-08-22 20:27:45 +00:00
Schneider Victor-tulias 146b86fc31 Finish recents animation to the matching state.
ResetGestureInputConsumer was defaulting to finising the recents animation to app when the the state was set to home. This created a situation where the taskbar could become invisible. Updated ResetGestureInputConsumer to check the state.

Fixes: 241204341
Test: tested on a large screen device using the repro steps
Change-Id: If5c109810ae2882f8cdfc0248939feb7c0c53d0d
2022-08-22 10:44:05 -07:00
Bill Yi 93a2a5bcc4 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I1e65168784aa0fe89867f03f065ea8d973afd19b
2022-08-21 23:16:21 -07:00
Bill Yi 9092ef2227 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I7ff6db96a4819dc741c0fad9bfe6365f11604f7a
2022-08-21 23:15:39 -07:00
Bill Yi a1185c5274 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I2a6ffec908adcd335edec9cfdaac7738c1329c91
2022-08-21 23:14:59 -07:00
Ats Jenk 84fb0cf390 Merge "Hide freeform button from app menu in recents" into tm-qpr-dev am: 5db5015fe2 am: a2c0473d94
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19681296

Change-Id: I9886b4c60c692bb8a9cd1030ebbc3a70317162d7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-20 01:19:18 +00:00
Ats Jenk a2c0473d94 Merge "Hide freeform button from app menu in recents" into tm-qpr-dev am: 5db5015fe2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19681296

Change-Id: I0f2b88e81688fd47519a3bed9d78cf97cc01d827
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-20 00:59:28 +00:00
Ats Jenk 5db5015fe2 Merge "Hide freeform button from app menu in recents" into tm-qpr-dev 2022-08-20 00:37:56 +00:00
Ats Jenk 6b31ed99d9 Hide freeform button from app menu in recents
When desktop windowing prototype is enabled, we should only be able to
switch apps to freeform mode via the quick tile.
Disabling other routes to put individual apps to freeform.

Test: visually verified that freeform button is not visible when desktop
windowing prototype flag is enabled
Bug: 242906219

Change-Id: Ib1ce75969b67f30d82262927e2e4113fab2c4956
2022-08-19 12:35:26 -07:00