PawletOS/Lawnchair
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
60,459 Commits 1 Branch 0 Tags
4f69ca52efa7a94de67a2b9c4956e233dfb23d92
Commit Graph

14731 Commits

Author SHA1 Message Date
Jeremy Sim b33471a21f Fix bug with Launcher animation canceling, esp. around OverviewSplitSelect 
This commit fixes a bug where the user could cancel animations when transitioning between Launcher states, potentially resulting in a state where Overview elements (task thumbnails etc.) were wrongly hidden or invisible.

The bug occurred because functions such as createInitialSplitSelectAnimation() and createAtomicAnimation() did not carry out any cleanup upon animation failure. This resulted in RecentsView potentially being in a polluted state for the next launch.

Bug was fixed by adding cleanup routines to two onAnimationEnd listeners.

Fixes: 242715097
Test: Manual
Change-Id: I05415ecf515e247aa535e3ca8371e540c3189b01
 2022-09-01 20:51:53 -07:00
Hyunyoung Song 6464249302 Merge "Update container for ItemInfo." into tm-qpr-dev am: c9be6ca870 am: 04e4550c3c 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19683198

Change-Id: Ia80d2af49bb8f311b987b5da60d8f5ba00143240
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-09-02 00:46:55 +00:00
Hyunyoung Song 04e4550c3c Merge "Update container for ItemInfo." into tm-qpr-dev am: c9be6ca870 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19683198

Change-Id: Ic75175db0b441047e2831921d8076524d6011139
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-09-02 00:05:01 +00:00
Hyunyoung Song c9be6ca870 Merge "Update container for ItemInfo." into tm-qpr-dev 2022-09-01 23:38:36 +00:00
Sukesh Ram 82da9fc5be Made getOnBoardingPrefs @Nullable & avoid NPE 
Bug: 236679197
Test: Manual
Change-Id: I3cbb0891cbfcf7cab956a4e05a28dbbcc2b33e19
(cherry picked from commit c0650e7725)
 2022-09-01 22:20:35 +00:00
Evan Rosky 6daf573a85 Merge "Only animate to hotseat when launcher is on home screen" into tm-qpr-dev am: eaaf065b73 am: 9d95abe6b0 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19775938

Change-Id: I56505b93a08e44495512067ed682fb0e8aab57b4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-09-01 22:07:28 +00:00
Evan Rosky 9d95abe6b0 Merge "Only animate to hotseat when launcher is on home screen" into tm-qpr-dev am: eaaf065b73 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19775938

Change-Id: Ibb18c2fc6551a46f892616aebcf3da725ec5fc73
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-09-01 21:36:53 +00:00
Evan Rosky eaaf065b73 Merge "Only animate to hotseat when launcher is on home screen" into tm-qpr-dev 2022-09-01 21:11:01 +00:00
Alex Chau 3193522616 Change wallpaper depth value in AllApps bottomsheet 
- Cap AllApps wallpaper zoom to workspaceContentScale rather than all the way to max depth (config_wallpaperMaxScale)
- Changed both workspace scale and depth interpolator to correlate with AllApps threshold

Bug: 240580498
Test: manual
Change-Id: I0342a37c72206268dcffc5697a212704a41b020f
 2022-09-01 21:26:30 +01:00
Hyunyoung Song a0de27c120 Merge "Fix blurry wallpaper when user locks on all apps surface" into tm-qpr-dev am: 0397cb0ce7 am: b8be0b7594 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19806634

Change-Id: I2aa6182f90da775239ad1c27ab518614386bb759
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-09-01 19:57:06 +00:00
Holly Sun 03caf49826 Update container for ItemInfo. 
See https://docs.google.com/document/d/1eAxQ9p263FI8-ZdkOsiQoarhpwm9aOdncqfJUD42o1Q/edit?resourcekey=0-GJyyDut-Tfy29akzHyoz0Q for the debugging process.
Test: see video https://drive.google.com/file/d/1qpD7070v0qOaBEuYS0WoZauawyhL54MQ/view
Fix: 234848972

Change-Id: I2ed5d24d11ab2081c6faa5d040d72a9d1646e5ca
 2022-09-01 12:10:31 -07:00
Sunny Goyal f2c6bf8346 Moving view capture dump to a service to allow longer timeout 
Bug: 243827665
Test: Verified on device
Change-Id: I7273cc14d86620b52aaf71c7ea293bd643d881f9
 2022-09-01 11:57:23 -07:00
Hyunyoung Song b8be0b7594 Merge "Fix blurry wallpaper when user locks on all apps surface" into tm-qpr-dev am: 0397cb0ce7 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19806634

Change-Id: Ia9f84387ebaff817c76ca2c03c4f6e0af044db3d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-09-01 16:19:32 +00:00
Hyunyoung Song 0397cb0ce7 Merge "Fix blurry wallpaper when user locks on all apps surface" into tm-qpr-dev 2022-09-01 15:50:39 +00:00
Pat Manning ee1caf18c6 Merge "Undim kids nav icons on a11y focus and click." into tm-qpr-dev am: e51e6446ad am: ff3accd144 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19659547

Change-Id: Ie1d9cf06bf012a9ae596ff1e7cc1240ae50b7e90
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-09-01 14:46:18 +00:00
Pat Manning d8d75c104d Merge "Update grouped task view thumbnail splash interpolation to match regular task." into tm-qpr-dev am: a3ebbbeba5 am: 0934cb2770 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19803194

Change-Id: Iab0a378396176f019bd42d700ef36dce13c1a16a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-09-01 14:45:51 +00:00
Pat Manning ff3accd144 Merge "Undim kids nav icons on a11y focus and click." into tm-qpr-dev am: e51e6446ad 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19659547

Change-Id: Ie92bbffbd6061bdd145e2b8dd256ab6b8f2580b4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-09-01 14:14:29 +00:00
Pat Manning 0934cb2770 Merge "Update grouped task view thumbnail splash interpolation to match regular task." into tm-qpr-dev am: a3ebbbeba5 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19803194

Change-Id: I76d48324383cb78c1ee32b858607b354980e4841
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-09-01 14:12:52 +00:00
Pat Manning e51e6446ad Merge "Undim kids nav icons on a11y focus and click." into tm-qpr-dev 2022-09-01 14:01:57 +00:00
Pat Manning a3ebbbeba5 Merge "Update grouped task view thumbnail splash interpolation to match regular task." into tm-qpr-dev 2022-09-01 13:30:33 +00:00
Pat Manning 401f6bb0d4 Undim kids nav icons on a11y focus and click. 
Fix: 241298057
Test: manual
Change-Id: I9a330bde4641a01b4d19dc83c8f25f56a69328c8
 2022-09-01 12:42:04 +01:00
hyunyoungs 91ca748819 Fix blurry wallpaper when user locks on all apps surface 
Bug: 242746421
Test: manual

TL;DR;;
setState toState= NORMAL called when locking screen on ALLAPPS screen
but mSurface==null
hence depth is not reset to NORMAL state

Change-Id: I26a37f7de8b0ecd481b36eebf07e1b79f8b0035c
 2022-08-31 22:05:45 -07:00
Tony Wickham 2be2312543 Merge changes Ie55bd70e,I69bcfa97,I222522bc into tm-qpr-dev am: d833fe4a12 am: 94894d8d88 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19472817

Change-Id: Ib419b6f6fad396917f5b477e5c20ca5bd425a165
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-09-01 01:43:50 +00:00
Tony Wickham 94894d8d88 Merge changes Ie55bd70e,I69bcfa97,I222522bc into tm-qpr-dev am: d833fe4a12 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19472817

Change-Id: I1081a062754ca9862e9705fa193d6dc736e59620
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-09-01 01:14:18 +00:00
Tony Wickham d833fe4a12 Merge changes Ie55bd70e,I69bcfa97,I222522bc into tm-qpr-dev 
* changes:
  Fix taskbar stash state not persisting properly across recreate
  Add support to Tapl to recreateTaskbar
  Don't rely on QuickstepLauncher instance for tests
 2022-09-01 00:52:54 +00:00
Evan Rosky 10c1c017c9 Only animate to hotseat when launcher is on home screen 
Was assuming that resume == home-screen; however, in shell
transitions, launcher is resumed while overview is active,
so make sure it is both resumed AND "isTaskbarAligned"
before making the to-hotseat animation

Bug: 241800590
Test: Open an app, long-press taskbar to stash, long-press again
      to unstash
Change-Id: I117afcb006c363e50205f27f014ffc30d6f2896a
 2022-08-31 22:53:02 +00:00
Pat Manning 038e112e9d Update grouped task view thumbnail splash interpolation to match regular task. 
Follow-up to ag/19730966

Fix: 244433374
Test: follow up after b/238405972
Change-Id: I5c3c05dd51234b568e8f99c075e0f3384bca4741
 2022-08-31 18:10:11 +01:00
Brian Isganitis 1e2fde5232 Merge "Snap to last task if swiping down at a greater Y than X velocity." into tm-qpr-dev am: 5166c5da3f am: b28748f662 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19290025

Change-Id: I32fdcd76559f05ecd0f6d890f49f62ea532bccae
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-08-31 03:16:14 +00:00
Brian Isganitis b28748f662 Merge "Snap to last task if swiping down at a greater Y than X velocity." into tm-qpr-dev am: 5166c5da3f 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19290025

Change-Id: I8a378f907e50aa952dd5354111cea993fb55137d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-08-31 02:46:49 +00:00
Brian Isganitis 5166c5da3f Merge "Snap to last task if swiping down at a greater Y than X velocity." into tm-qpr-dev 2022-08-31 02:14:38 +00:00
TreeHugger Robot 788b348806 Merge "Add app predictions to secondary display app drawer & fix tab UI." into tm-qpr-dev am: bcbba897fc 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19789528

Change-Id: Ic1610d88641265842348e5955d0debe85f78c6b2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-08-31 00:33:22 +00:00
TreeHugger Robot bcbba897fc Merge "Add app predictions to secondary display app drawer & fix tab UI." into tm-qpr-dev 2022-08-31 00:01:21 +00:00
Schneider Victor-tulias 7ba044f10b Merge "Add gesture nav error state tracking and logging" into tm-qpr-dev am: ff5ad47a06 am: 520bf2e892 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19300928

Change-Id: I7830f925e70d89f84fce7da317403e03dacbb419
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-08-30 23:55:39 +00:00
Schneider Victor-tulias 520bf2e892 Merge "Add gesture nav error state tracking and logging" into tm-qpr-dev am: ff5ad47a06 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19300928

Change-Id: I6a0eee06b8aee5e8c1a4fd7574b3d5466dd93254
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-08-30 23:11:17 +00:00
Schneider Victor-tulias ff5ad47a06 Merge "Add gesture nav error state tracking and logging" into tm-qpr-dev 2022-08-30 22:42:46 +00:00
Sukesh Ram 1b4869fcbc Add app predictions to secondary display app drawer & fix tab UI. 
Bug: 233926067
Test: Manual
Change-Id: I2f45a4b30964b365bf149e8864a3af2ea909a237
(cherry picked from commit 9e5fe63a22)
Merged-In: I2f45a4b30964b365bf149e8864a3af2ea909a237
 2022-08-30 22:30:03 +00:00
Brian Isganitis 14aa82a02a Merge "Simplify calculateEndTarget logic." into tm-qpr-dev am: 168482688a am: f898db348a 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19283295

Change-Id: Id8c0372759306567ed50b2d3e33cdbb060c7f65d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-08-30 21:13:38 +00:00
Brian Isganitis c043d45c42 Snap to last task if swiping down at a greater Y than X velocity. 
If you swipe down slightly diagonally, it will almost always be treated as a swipe to the next task rather than a return to the current task. If we are swiping down and the Y velocity is grater, we should snap to the current task instead.

Test: Manually in fully gestural mode.
Bug: 222117127
Change-Id: I8c3cd483f7ceefe0de1e24b6e98918b12428ed10
 2022-08-30 20:59:40 +00:00
Tony Wickham e74569e935 Fix taskbar stash state not persisting properly across recreate 
Because we check supportsVisualStashing() in
TaskbarStashController#init(), we need to avoid using
TaskbarUIController to provide that value since TaskbarUIController
isn't initialized until a bit later than the other controllers. So I
moved the logic from supportsVisualStashing() back to
TaskbarStashController, but still allow TaskbarUIController to override
it (e.g. for DesktopTaskbarUIController).

After that fix, I noticed that force stopping launcher (to test the fix)
would briefly show the taskbar background before resetting the stashed
state. This is also due to LauncherTaskbarUIController not being ready
immediately, since that's what sets FLAG_IN_APP due to launcher being
paused. To work around this, I set FLAG_IN_APP to true by default in
TaskbarStashController#init(), since that is the most common case, and
taskbar background/stashed handle isn't shown on home anyway.

Test: Force stop launcher while taskbar is stashed, verify it recreates
as stashed without background flicker; same when changing wallpaper
color on home or in app; also tested when taskbar isn't stashed and in 3
button mode for good measure
Test: testHideTaskbarPersistsOnRecreate
Fixes: 235986838

Change-Id: Ie55bd70e8288d5ad7433dde970f18c176831d747
 2022-08-30 13:42:04 -07:00
Brian Isganitis f898db348a Merge "Simplify calculateEndTarget logic." into tm-qpr-dev am: 168482688a 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19283295

Change-Id: Ibcb77046543c1faf45652eccf6082382a8b3c27a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-08-30 20:41:54 +00:00
Tony Wickham c8e824dbdb Add support to Tapl to recreateTaskbar 
Also moved references of "tasbkar_view" to share TASKBAR_RES_ID constant

Test: compiles; see follow up CLs
Bug: 235986838
Change-Id: I69bcfa975550e567f3daa35af8a810546297d79c
 2022-08-30 13:40:45 -07:00
Brian Isganitis 168482688a Merge "Simplify calculateEndTarget logic." into tm-qpr-dev 2022-08-30 20:09:10 +00:00
Schneider Victor-tulias 038922a653 Add gesture nav error state tracking and logging 
- Added ActiveGestureErrorDetector
- Removed startQuickstep logs; these were confusing and not helpful in ActiveGestureLogs

Test: printed logs after several gestures
Bug: 227514916
Design: go/gesture-nav-logging
Change-Id: Ia2a7e4f90a3a371d9a92190aa66eb07acd061d6c
 2022-08-30 12:18:29 -07:00
Pat Manning 7a5048297d Merge "Refactor overview progress as splash progress." into tm-qpr-dev am: b4a30ab955 am: 99bce932a2 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19730966

Change-Id: I3abd3fd009ed7d6d7f4754bcece6a594bab3db61
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-08-30 14:17:18 +00:00
Pat Manning 99bce932a2 Merge "Refactor overview progress as splash progress." into tm-qpr-dev am: b4a30ab955 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19730966

Change-Id: I7f1f488f8b0e284e0ac7ba4de1b68561a825fd8c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-08-30 13:47:22 +00:00
Pat Manning b4a30ab955 Merge "Refactor overview progress as splash progress." into tm-qpr-dev 2022-08-30 13:29:53 +00:00
Pat Manning 5cf4d207f2 Merge "Launch tasks before testing switch to overview." into tm-qpr-dev am: 8463ab771e am: d6f5350f26 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19719106

Change-Id: I508373ba1b659b8cf108521e309568289d9be7f1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-08-30 12:14:19 +00:00
Pat Manning d6f5350f26 Merge "Launch tasks before testing switch to overview." into tm-qpr-dev am: 8463ab771e 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19719106

Change-Id: I0775d5238bf510f3daa0c65df4b87dfff1280a81
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-08-30 11:44:29 +00:00
Pat Manning 81dc9ad131 Refactor overview progress as splash progress. 
This also avoids showing splash in split select state

Fix: 242284413
Test: follow up after b/238405972
Change-Id: I2e83fa3d030e8a74edb4152c472dbf02ac5a80b1
 2022-08-30 11:23:08 +01:00
Pat Manning 8463ab771e Merge "Launch tasks before testing switch to overview." into tm-qpr-dev 2022-08-30 10:10:45 +00:00