Commit Graph

12138 Commits

Author SHA1 Message Date
Vinit Nayak 42fd4441a3 Run animation for liveTile before trying to launch it
* If current TaskView is running live tiles, animate directly
when toggling recents button instead of trying to
launch the task

Fixes: 240231324
Test: Launching a single GroupedTaskView from overview
launches as expected in 3 button.
Tested adjacent launches as well.

Change-Id: I6c060d918d3ae08bee9da1ad9507bb25cf445b96
2022-09-07 15:33:35 -07:00
Ats Jenk 461c3b3bd0 Filter out active freeform tasks from recents
Freeform tasks will show up as a separate, single tile in recents.
Filtering them out right now.

Bug: 244348395
Test: atest RecentTasksControllerTest RecentTasksListTest
Change-Id: Ifb197031076a8d8934cea78c6b68cb059477a81a
2022-09-07 15:32:02 -07:00
Schneider Victor-tulias a602a0a895 Add error detection for aborting the recents scrolling during transition to home
Bug: 227514916
Test: swiped to overview, to home and quick switch and checked the logs
Change-Id: Ie02d3933e2fb05eedd9c264a381329bc04feac2d
2022-09-07 14:16:08 -07:00
Jeremy Sim 7af10ad02c Prevent Overview Actions from appearing during split from home
Overview Actions will no longer erroneously appear when initiating a split from home.

The bug occurred because split from home causes an irregular state where the user is in split select, yet there is still a focused (main) task in Overview. Overview Actions did not anticipate this state and had no case to handle it.

Fixed by adding a check to Overview Actions so that they will never show when split selection is active.

Fixes: 244499708
Test: Manual
Change-Id: Idf1762c306dceb5048cefec8fa68ac9ca5468379
2022-09-07 12:13:47 -07:00
Alex Chau 17b18bbd8c Merge "Use real IDP in DeviceProfileTest" into tm-qpr-dev am: 0f1001c7b1 am: 2cda6fee53
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19717456

Change-Id: I640a82ccc8be13a2ff1779f915aa946c841bea6a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-07 15:07:29 +00:00
Alex Chau 2cda6fee53 Merge "Use real IDP in DeviceProfileTest" into tm-qpr-dev am: 0f1001c7b1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19717456

Change-Id: I8b6e68788cde685ee9ed66786714d836b4ffaa13
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-07 14:25:43 +00:00
Alex Chau 0f1001c7b1 Merge "Use real IDP in DeviceProfileTest" into tm-qpr-dev 2022-09-07 13:45:16 +00:00
Alex Chau e818bcb997 Use real IDP in DeviceProfileTest
- Mock WindowManagerProxy instead of IDP in DeviceProfileTest
- Extracted NavigationMode to standalone class
- Moved parseNavigationMode to WindowManagerProxy so it can be mocked
- Moved DeviceProfileTest to internal repo

Bug: 242086027
Test: DeviceProfileTest
Change-Id: Ia5a43293b1380f04d786d2adf8503cfd10f7674a
2022-09-07 10:35:21 +01:00
Sunny Goyal 3fccc4ab9f Merge "Moving view capture dump to a service to allow longer timeout" into tm-qpr-dev am: 7a6c610626 am: fad9fc1c6a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19746954

Change-Id: Iaa5ec82d7e74a8e0b33e12c7a43f4eb78941a441
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-07 05:43:03 +00:00
Sunny Goyal fad9fc1c6a Merge "Moving view capture dump to a service to allow longer timeout" into tm-qpr-dev am: 7a6c610626
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19746954

Change-Id: I725789d75f5596ae9b2efb6c48264f54360d81c2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-07 05:12:54 +00:00
Sunny Goyal 7a6c610626 Merge "Moving view capture dump to a service to allow longer timeout" into tm-qpr-dev 2022-09-07 04:47:19 +00:00
Schneider Victor-tulias bc5815d89d Merge "Expand on gesture navigation error detection." into tm-qpr-dev am: 2ae4420a12 am: 38fb33bfca
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19671572

Change-Id: I34a81001da26c18a810aaf6b02e202b506791cc0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-06 18:35:47 +00:00
Schneider Victor-tulias 38fb33bfca Merge "Expand on gesture navigation error detection." into tm-qpr-dev am: 2ae4420a12
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19671572

Change-Id: I13e9d67e843c657263578943efa35769ed7b7300
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-06 18:05:47 +00:00
TreeHugger Robot 45a39e360b Merge "Made getOnBoardingPrefs @Nullable & avoid NPE" into tm-qpr-dev am: db32818a4e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19818711

Change-Id: Iff335f7db89bec9675d0028953fb47d3359d103e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-06 18:05:39 +00:00
Schneider Victor-tulias 2ae4420a12 Merge "Expand on gesture navigation error detection." into tm-qpr-dev 2022-09-06 17:32:02 +00:00
TreeHugger Robot db32818a4e Merge "Made getOnBoardingPrefs @Nullable & avoid NPE" into tm-qpr-dev 2022-09-06 17:29:28 +00:00
Mateusz Cicheński fc2f0a835f Merge "The shelf height was mistakenly provided as width, making it equal to 0." into tm-qpr-dev am: 77593150da am: e1b2d018ed
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19836119

Change-Id: Ic9c1cd8a0139cf4461eb73de58a77958dfdc40d5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-06 17:24:12 +00:00
Mateusz Cicheński e1b2d018ed Merge "The shelf height was mistakenly provided as width, making it equal to 0." into tm-qpr-dev am: 77593150da
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19836119

Change-Id: I13ba5ac31bcffe42270b4042a22ce212ec7482d9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-06 16:54:58 +00:00
Mateusz Cicheński 77593150da Merge "The shelf height was mistakenly provided as width, making it equal to 0." into tm-qpr-dev 2022-09-06 16:36:48 +00:00
Alex Chau 5e4d93b9dc Merge "Enable adjacent task animation for grid" into tm-qpr-dev am: cec6e2c914 am: c47cb0463c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19619264

Change-Id: I129f15c6bde07d6baa5155a4fb10d69eb03d676d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-06 16:02:46 +00:00
Alex Chau c47cb0463c Merge "Enable adjacent task animation for grid" into tm-qpr-dev am: cec6e2c914
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19619264

Change-Id: Ie22746b1f572fba7a8c11b2926559079d1d25026
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-06 15:33:07 +00:00
Alex Chau 4a206837c9 Enable adjacent task animation for grid
- Enable adjacent task animation for grid tasks
- Only parallax for focused task and only when it's fully visible

Bug: 236963497
Test: manual
Change-Id: I6c681e112f3eb2c7075bc98fab405d978f5057d1
2022-09-05 11:09:28 +01:00
Mateusz Cicheński 26db3bb62a The shelf height was mistakenly provided as width, making it equal to 0.
Bug: 244797561
Test: manually
Change-Id: I28e9c34bb0feb643c5d7b652c055d5fdceaec878
2022-09-03 04:33:18 +00:00
Schneider Victor-tulias 7ad70b6066 Expand on gesture navigation error detection.
- Added some missing error detection:
    1. screenshot capture errors
    2. recents scrolling errors
    3. end-of-gesture callbacks
- Added some more explanation for OverviewInputConsumer selection reason
- Added logging the current task's package name to help identify gestures

Bug: 227514916
Bug: 243471493
Test: Ran launcher, performed multiple gestures and checked logs
Change-Id: I8b10cc75f8640a674c6fed6b06efa4763c9635a2
2022-09-02 15:53:24 -07:00
Jeremy Sim ac2807cf43 Merge "Fix bug with Launcher animation canceling, esp. around OverviewSplitSelect" into tm-qpr-dev am: afff936235 am: 5ebdb63a9d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19659546

Change-Id: I38c4ec5d6305dd986ce785c1a01496d1147592fe
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-02 21:49:40 +00:00
Jeremy Sim 5ebdb63a9d Merge "Fix bug with Launcher animation canceling, esp. around OverviewSplitSelect" into tm-qpr-dev am: afff936235
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19659546

Change-Id: I702f1f3df37757d6c31d23b5812bf48d6a282069
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-02 21:20:15 +00:00
Tracy Zhou fe53edbbce Merge "Do not change layering for non live tile tasks rendering" into tm-qpr-dev am: 1649163334 am: 902a57c7d9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19805291

Change-Id: Ib37565c378580d75220a9fce768cbb700b456387
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-02 21:08:04 +00:00
Jeremy Sim afff936235 Merge "Fix bug with Launcher animation canceling, esp. around OverviewSplitSelect" into tm-qpr-dev 2022-09-02 20:46:41 +00:00
Tracy Zhou 902a57c7d9 Merge "Do not change layering for non live tile tasks rendering" into tm-qpr-dev am: 1649163334
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19805291

Change-Id: Ie3c2cf900931e7d70e5260a08b488aacf7a89a90
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-02 20:08:41 +00:00
Tracy Zhou 1649163334 Merge "Do not change layering for non live tile tasks rendering" into tm-qpr-dev 2022-09-02 19:18:22 +00:00
Alex Chau 1cf8d0895d Merge "Change wallpaper depth value in AllApps bottomsheet" into tm-qpr-dev am: f28c9f14a4 am: 18d7004c76
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19607219

Change-Id: Ic3f9e45cb7ea5ab0427b9b2f9250385cd283ba8d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-02 11:10:32 +00:00
Jerry Chang 454b838abe Support launching a shortcut and a task to split screen am: bf9ce9c096 am: b3ff2ee352
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19801551

Change-Id: Ifba337408874d33e9f9ba70ce351e44f4ca4ff97
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-02 11:10:11 +00:00
Alex Chau 18d7004c76 Merge "Change wallpaper depth value in AllApps bottomsheet" into tm-qpr-dev am: f28c9f14a4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19607219

Change-Id: I25a5f374d8e497cb63837cbaaad5b3c06c6b9fa6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-02 10:38:25 +00:00
Jerry Chang b3ff2ee352 Support launching a shortcut and a task to split screen am: bf9ce9c096
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19801551

Change-Id: I0eacebd6ffa421f7cb7274d50b6dc1a0f5dd9c7f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-02 10:38:15 +00:00
Alex Chau f28c9f14a4 Merge "Change wallpaper depth value in AllApps bottomsheet" into tm-qpr-dev 2022-09-02 10:06:37 +00:00
Tracy Zhou 668eec1e08 Do not change layering for non live tile tasks rendering
TaskViewSimulator#onBuildTargetParams is called for every single task rendering. Given the layering change doesn't work for the non live tile case (and we shouldn't change the layering in that case anyways), an additional check is added to prevent that from happening

Fixes: 242593058
Test: launch overview from home and app, and make sure that in both cases, task launch animation is intact
Change-Id: Ia242dc767499689547dfa8acae56d39e9b0c3189
2022-09-02 00:43:03 -07:00
Jerry Chang bf9ce9c096 Support launching a shortcut and a task to split screen
Fix: 243101552
Test: long press on a shortcut to enter split screen works
Change-Id: Icaabf2e1c8be086bd1b79e0a2cf05878767caa15
2022-09-02 06:58:08 +00:00
Mateusz Cicheński d9a065c71f Merge "Replace shelf height with keep clear areas registration in Launcher." into tm-qpr-dev am: f6b782344c am: 094c12fcfc
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19271435

Change-Id: I842c21106e9039e1af2be4e9a387341fa0360b07
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-02 05:48:53 +00:00
Mateusz Cicheński 094c12fcfc Merge "Replace shelf height with keep clear areas registration in Launcher." into tm-qpr-dev am: f6b782344c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19271435

Change-Id: I95896b43eead78c3669618d3dde44d2944e2c0cc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-02 05:29:23 +00:00
Mateusz Cicheński f6b782344c Merge "Replace shelf height with keep clear areas registration in Launcher." into tm-qpr-dev 2022-09-02 05:19:13 +00:00
Jeremy Sim b33471a21f Fix bug with Launcher animation canceling, esp. around OverviewSplitSelect
This commit fixes a bug where the user could cancel animations when transitioning between Launcher states, potentially resulting in a state where Overview elements (task thumbnails etc.) were wrongly hidden or invisible.

The bug occurred because functions such as createInitialSplitSelectAnimation() and createAtomicAnimation() did not carry out any cleanup upon animation failure. This resulted in RecentsView potentially being in a polluted state for the next launch.

Bug was fixed by adding cleanup routines to two onAnimationEnd listeners.

Fixes: 242715097
Test: Manual
Change-Id: I05415ecf515e247aa535e3ca8371e540c3189b01
2022-09-01 20:51:53 -07:00
Hyunyoung Song 6464249302 Merge "Update container for ItemInfo." into tm-qpr-dev am: c9be6ca870 am: 04e4550c3c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19683198

Change-Id: Ia80d2af49bb8f311b987b5da60d8f5ba00143240
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-02 00:46:55 +00:00
Hyunyoung Song 04e4550c3c Merge "Update container for ItemInfo." into tm-qpr-dev am: c9be6ca870
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19683198

Change-Id: Ic75175db0b441047e2831921d8076524d6011139
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-02 00:05:01 +00:00
Hyunyoung Song c9be6ca870 Merge "Update container for ItemInfo." into tm-qpr-dev 2022-09-01 23:38:36 +00:00
Sukesh Ram 82da9fc5be Made getOnBoardingPrefs @Nullable & avoid NPE
Bug: 236679197
Test: Manual
Change-Id: I3cbb0891cbfcf7cab956a4e05a28dbbcc2b33e19
(cherry picked from commit c0650e7725)
2022-09-01 22:20:35 +00:00
Evan Rosky 6daf573a85 Merge "Only animate to hotseat when launcher is on home screen" into tm-qpr-dev am: eaaf065b73 am: 9d95abe6b0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19775938

Change-Id: I56505b93a08e44495512067ed682fb0e8aab57b4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-01 22:07:28 +00:00
Evan Rosky 9d95abe6b0 Merge "Only animate to hotseat when launcher is on home screen" into tm-qpr-dev am: eaaf065b73
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19775938

Change-Id: Ibb18c2fc6551a46f892616aebcf3da725ec5fc73
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-01 21:36:53 +00:00
Evan Rosky eaaf065b73 Merge "Only animate to hotseat when launcher is on home screen" into tm-qpr-dev 2022-09-01 21:11:01 +00:00
Alex Chau 3193522616 Change wallpaper depth value in AllApps bottomsheet
- Cap AllApps wallpaper zoom to workspaceContentScale rather than all the way to max depth (config_wallpaperMaxScale)
- Changed both workspace scale and depth interpolator to correlate with AllApps threshold

Bug: 240580498
Test: manual
Change-Id: I0342a37c72206268dcffc5697a212704a41b020f
2022-09-01 21:26:30 +01:00
Hyunyoung Song a0de27c120 Merge "Fix blurry wallpaper when user locks on all apps surface" into tm-qpr-dev am: 0397cb0ce7 am: b8be0b7594
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19806634

Change-Id: I2aa6182f90da775239ad1c27ab518614386bb759
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-01 19:57:06 +00:00