Tony Huang
3fc57cb50a
Fix split divider flash if swipe again quickly
...
This bug caused by divider will be set to show when animation
cancelled, because split screen will show divider itself when
both split visible, this call might be unnecessary. Fix it by
removing these lines.
Add surface valid checking when running divider animation to
avoid crash caused if surface was released during animation.
Fix: 242823773
Bug: 246371786
Test: manual
Test: pass existing tests
Change-Id: I10aaf86e4164327b1c6c2f323c62b246c600228a
2022-09-14 15:37:02 +08:00
Sunny Goyal
bb2c85a3eb
Using Transaction directly instead of building surface params am: fd2c9eb04e
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19933596
Change-Id: I5441961aaae960333dbddd6585568412a88f52a1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-09-14 04:28:16 +00:00
Tracy Zhou
a0ca1ebd54
Merge "Fix subsequent tabbing in recents from alt tab not working" into tm-qpr-dev am: 39d9eb819c am: de315c24d8
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19938037
Change-Id: Ib92a6b7b50dd55a3bf71c7c274f4c10607090ac0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-09-13 23:49:53 +00:00
TreeHugger Robot
fcb43caf6b
Merge "Add error detection for aborting the recents scrolling during transition to home" into tm-qpr-dev am: 839297e232 am: d675769721
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19873684
Change-Id: I4e7fba7f2c510893d744317eedad78934e9b7a3c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-09-13 23:46:58 +00:00
TreeHugger Robot
fb77b34d1d
Merge "Change wallpaper depth in widget picker" into tm-qpr-dev am: 3ded296cee am: 9c43626a36
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19852193
Change-Id: Ie17c03949c3ac30156129182fec88f19cfb46e1d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-09-13 23:38:23 +00:00
Schneider Victor-tulias
350ebd8f5c
Update ActiveGestureLog to print logs from oldest to newest
...
Fixes: 227514916
Test: completed several gestures and checked the logs
Change-Id: I8dca4a75c46f7324684a3ba297d1946105825fa6
2022-09-13 15:33:55 -07:00
Schneider Victor-tulias
56fc942e48
Add onTaskAppeared error detection.
...
Bug: 246340474
Test: used several gestures normally, and reproduced b/246340474, then checked logs
Change-Id: I8cdcb9c00c5cacc7737e796dbf5adf544c0220a7
2022-09-13 15:31:06 -07:00
Sunny Goyal
fd2c9eb04e
Using Transaction directly instead of building surface params
...
Bug: 221961069
Test: Presubmit
Change-Id: I31123dff78de513addd0c851403af9097686c46e
2022-09-13 22:26:42 +00:00
Tracy Zhou
de315c24d8
Merge "Fix subsequent tabbing in recents from alt tab not working" into tm-qpr-dev am: 39d9eb819c
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19938037
Change-Id: I0947061c88148842e2a508fea76d611a1bc84f3e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-09-13 21:28:14 +00:00
Tracy Zhou
39d9eb819c
Merge "Fix subsequent tabbing in recents from alt tab not working" into tm-qpr-dev
2022-09-13 21:06:26 +00:00
TreeHugger Robot
d675769721
Merge "Add error detection for aborting the recents scrolling during transition to home" into tm-qpr-dev am: 839297e232
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19873684
Change-Id: I13328c033aec5653cf82529c4823e84df8c92592
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-09-13 20:25:50 +00:00
Vinit Nayak
2e39049bdf
Update secondary task menu check to explicitly check for phone
...
* Non grid check technically also returns
false for secondary app icon on focused task
Test: Open app menu in small and large screen
Bug: 245610772
Change-Id: Icf70c1893aba6a4a79bf51e98ac33c1d204c73c2
2022-09-13 13:22:51 -07:00
TreeHugger Robot
9c43626a36
Merge "Change wallpaper depth in widget picker" into tm-qpr-dev am: 3ded296cee
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19852193
Change-Id: I544623f2c67f846ac5e76bdb520750b5d4cdce2c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-09-13 20:15:13 +00:00
TreeHugger Robot
839297e232
Merge "Add error detection for aborting the recents scrolling during transition to home" into tm-qpr-dev
2022-09-13 19:49:44 +00:00
TreeHugger Robot
b5cd064a26
Merge "Removing UiThreadHelper and moving code to corresponding classes" into tm-qpr-dev am: 22af7c2e7e am: 93d74aa41a
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19931705
Change-Id: I39c565b0ea40b4e1c1ed2b3b908837e04817ce64
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-09-13 18:49:08 +00:00
TreeHugger Robot
3ded296cee
Merge "Change wallpaper depth in widget picker" into tm-qpr-dev
2022-09-13 18:46:53 +00:00
TreeHugger Robot
93d74aa41a
Merge "Removing UiThreadHelper and moving code to corresponding classes" into tm-qpr-dev am: 22af7c2e7e
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19931705
Change-Id: I6d342c9d59e94dc61b393bd53e84e417ccc81782
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-09-13 18:20:02 +00:00
Tracy Zhou
d0f4896c11
Fix subsequent tabbing in recents from alt tab not working
...
Fix: 242114350
Test: Alt+tab to go to overview, and then keep tabbing to switch to the previous tasks
Change-Id: I03db23aa5424e46c0eb783379b0c5e959f75507f
2022-09-13 11:01:57 -07:00
Winson Chung
240b064cdb
Fix case of gesture being stuck when the Launcher is stopped mid-gesture
...
- In rare cases, Launcher may be stopped mid-swipe up gesture which results
in two issues:
- it continues to register a page transition end callback, but because
launcher is not drawing, the page will never scroll and the callback
never happens
- in the case where the calculated end target is RECENTS, we don't
finish the recents animation (because of live tile), and since it's
still running, subsequent gestures are interpreted as continuing the
current gesture and it gets stuck
Instead in these cases we can force the gesture to resolve to LAST_TASK
(similar to the canceled gesture case), and not wait for the page to
settle.
Note, that we would prefer to fix the root issue of Launcher being
stopped, but at least this change prevents Launcher from getting into
the wrong state if so.
Bug: 246476942
Test: Repro steps from the bug
Change-Id: I59098229e5e37722e8017a2dfcb42eab6659643d
2022-09-13 06:59:34 +00:00
Alex Chau
3d2c062567
Change wallpaper depth in widget picker
...
- Also changed widget picker open/close duration, refactored the values into DeviceProfile
- Generalized MultiAdditivePropertyFactory to accept aggregator as parameter
Bug: 240580498
Test: manual
Change-Id: I6886ca514593e404b8d7b0e8ed44f20ec2b77c73
2022-09-13 12:20:56 +08:00
Andy Wickham
369c6e8be7
Reduces vertical padding of predicted apps in All Apps.
...
Rather than using the full allAppsCellHeight, manually construct
the icon + padding + text and add custom padding (8dp).
Screenshots: https://drive.google.com/drive/folders/1hgEE72PaTj60SxgfPUzQ8hGwnCOWx-Lp?resourcekey=0-TgrHKITyzIXmNAAMYpA_MA&usp=sharing
Fix: 242915342
Test: Manual inspection
Change-Id: Ic566e0f7ea7cf486054bb8fe2429ee5c53e8b174
2022-09-12 18:34:14 -07:00
Sunny Goyal
42beb544e9
Removing UiThreadHelper and moving code to corresponding classes
...
This allows for better code organization based on the code logic
Bug: 246382466
Test: Presubmit
Change-Id: I6148143a60afdd917a11587e327f5e8a4d7def9e
2022-09-12 22:14:15 +00:00
TreeHugger Robot
7ef9220555
Merge "Run animation for liveTile before trying to launch it" into tm-qpr-dev am: 7d8ba14b3c am: 8563855387
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19890490
Change-Id: I47fd27284002803817d2bd3b549cac7a78ee23fd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-09-12 20:31:37 +00:00
Vinit Nayak
ebd04c4bc1
Merge "Place TaskMenuView aligned with secondary split thumbnail" into tm-qpr-dev am: f5e5c8e1ce am: 1f97ccf5e2
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19912686
Change-Id: I11d27495a0aaa09ebcd376fd38ad96721562eb63
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-09-12 20:29:41 +00:00
TreeHugger Robot
8563855387
Merge "Run animation for liveTile before trying to launch it" into tm-qpr-dev am: 7d8ba14b3c
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19890490
Change-Id: Ia6a7f74c9a7ede2a41164fe68a271e94dcb7b724
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-09-12 19:59:16 +00:00
Vinit Nayak
1f97ccf5e2
Merge "Place TaskMenuView aligned with secondary split thumbnail" into tm-qpr-dev am: f5e5c8e1ce
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19912686
Change-Id: I40fbd2314fc02db46682e99057c365bae3973e19
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-09-12 19:58:44 +00:00
TreeHugger Robot
7d8ba14b3c
Merge "Run animation for liveTile before trying to launch it" into tm-qpr-dev
2022-09-12 18:30:47 +00:00
Vinit Nayak
f5e5c8e1ce
Merge "Place TaskMenuView aligned with secondary split thumbnail" into tm-qpr-dev
2022-09-12 18:29:22 +00:00
Sunny Goyal
cae104baaf
Merge "Removing back-button alpha animation code" into tm-qpr-dev am: 676d19c171 am: 5145e474d6
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19915471
Change-Id: Ia297ef33280ec46a6222781f43ae6dc1b813bd4e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-09-12 18:00:45 +00:00
Sunny Goyal
5145e474d6
Merge "Removing back-button alpha animation code" into tm-qpr-dev am: 676d19c171
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19915471
Change-Id: I2958d9cd87323c5a3934904120d550fbb2d2f411
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-09-12 17:16:38 +00:00
Winson Chung
252ec11e4e
Update Launcher for removed shared wrappers
...
- Launcher can reference system code directly now
Bug: 219861883
Test: Builds/Presubmit
Change-Id: I3f656b6c7fce93243ccb7591e52441e99137dec6
2022-09-12 16:04:56 +00:00
Sunny Goyal
1eb1124d82
Removing back-button alpha animation code
...
Back button is only animation in 2-button UI which is not supported anymore
Bug: 246006580
Test: Presubmit
Change-Id: I7385b07272e44c1f9f0488c158e1b4ee67060120
2022-09-09 17:15:24 -07:00
Vinit Nayak
2e4dcb16a7
Place TaskMenuView aligned with secondary split thumbnail
...
* Use consistent divider calculations in
different methods
Fixes: 245610772
Fixes: 218784487
Test: Open task menu view in split pair in landscape/
seascape/portrait, real and fake.
Change-Id: If1bbc7a0d4f1767584d0fc8cf549130f35b8e4a3
2022-09-09 11:25:08 -07:00
Vinit Nayak
bdcdcf9edd
Merge "Disable split pair long press smart actions" into tm-qpr-dev am: 5aa6deff8d am: 822e9bbf88
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19890715
Change-Id: Iec125e205e4f399c440bdc2d9ce892feeea9931a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-09-08 20:19:17 +00:00
Vinit Nayak
822e9bbf88
Merge "Disable split pair long press smart actions" into tm-qpr-dev am: 5aa6deff8d
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19890715
Change-Id: I0667bea3ba2d29a1af7b3013a6ed090bc15dd241
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-09-08 19:17:31 +00:00
Vinit Nayak
5aa6deff8d
Merge "Disable split pair long press smart actions" into tm-qpr-dev
2022-09-08 18:51:05 +00:00
Schneider Victor-tulias
b240a8d844
Merge "Add STATE_LAUNCHER_DRAWN printing" into tm-qpr-dev am: 5f4e93d669 am: 155d8027a5
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19890487
Change-Id: Ib861643b91434192071a34cbd04232bf0d02c68d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-09-08 18:49:11 +00:00
Schneider Victor-tulias
b77eca42a4
Merge "Finish recents animation to the matching state." into tm-qpr-dev am: 0b828e291c am: 364021226d
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19697943
Change-Id: Idd543141eea90d0f64c646c34d1a8eaff6ec7bbd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-09-08 18:49:03 +00:00
Schneider Victor-tulias
155d8027a5
Merge "Add STATE_LAUNCHER_DRAWN printing" into tm-qpr-dev am: 5f4e93d669
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19890487
Change-Id: I47668a9bd84a4a2550431e6fd12e370311cdadd2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-09-08 18:19:03 +00:00
Schneider Victor-tulias
364021226d
Merge "Finish recents animation to the matching state." into tm-qpr-dev am: 0b828e291c
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19697943
Change-Id: I32529fa4410c61d7c967873ca5c118fa53e7369c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-09-08 18:18:54 +00:00
Schneider Victor-tulias
5f4e93d669
Merge "Add STATE_LAUNCHER_DRAWN printing" into tm-qpr-dev
2022-09-08 18:14:20 +00:00
Schneider Victor-tulias
0b828e291c
Merge "Finish recents animation to the matching state." into tm-qpr-dev
2022-09-08 18:11:43 +00:00
Ats Jenk
c2475fa8ee
Merge "Filter out active freeform tasks from recents" into tm-qpr-dev am: accde3a686 am: df6d7ffc46
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19817526
Change-Id: I3c7b1cc360d984be60d1fd41eaeb526e543c1a35
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-09-08 16:43:03 +00:00
Ats Jenk
df6d7ffc46
Merge "Filter out active freeform tasks from recents" into tm-qpr-dev am: accde3a686
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19817526
Change-Id: I0363eefb1ff54f2d81ef28be947a1b9f4623bfae
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-09-08 16:12:48 +00:00
Ats Jenk
accde3a686
Merge "Filter out active freeform tasks from recents" into tm-qpr-dev
2022-09-08 16:07:19 +00:00
Jeremy Sim
1217f60247
Merge "Prevent Overview Actions from appearing during split from home" into tm-qpr-dev am: 8611800206 am: de313d7a44
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19833885
Change-Id: Ib96f948aabb5edb50d4032433833a5878dc20352
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-09-08 01:49:34 +00:00
Jeremy Sim
de313d7a44
Merge "Prevent Overview Actions from appearing during split from home" into tm-qpr-dev am: 8611800206
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19833885
Change-Id: Ibd280401ecd22d6289144652658b79ebcd2bd403
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-09-08 01:16:34 +00:00
Jeremy Sim
8611800206
Merge "Prevent Overview Actions from appearing during split from home" into tm-qpr-dev
2022-09-08 00:45:41 +00:00
Vinit Nayak
e6c1c0ebf6
Disable split pair long press smart actions
...
Fixes: 236891562
Test: Long press launches task on split pairs.
Fullscreen overview tasks unchanged.
Change-Id: I5ff5377ddbf2bad60b3158dfef7ed2a8073fa0c4
2022-09-07 16:29:17 -07:00
Schneider Victor-tulias
07211eaed4
Add STATE_LAUNCHER_DRAWN printing
...
Added loging to only print and/or track multistatecallback states
Bug: 227514916
Test: tried various gestures and printed logs
Change-Id: I487b09ca0660fb385c34b49523a2417f11fcde00
2022-09-07 15:46:49 -07:00