When freeform windows are shown on top of launcher, disable the swipe up
to open all apps, which would open behind these windows. This change is
inteded for the desktop form factor.
Bug: 419565477
Flag: com.android.window.flags.show_home_behind_desktop
Test: Manually swipe up on home screen with freeform windows shown.
Change-Id: I795e9e05fe39b0cf8033b51ce4369340d49ef812
Revert submission 33672643-DataDeviceProfile1
Reason for revert: Droidmonitor created revert due to b/419867875. Will be verifying through ABTD before submission.
Fix: 419867875
Reverted changes: /q/submissionid:33672643-DataDeviceProfile1
Change-Id: Icb66aefbbcee24e05806b2139923e1f2ea1c65e3
This will allow us to see the logs in Winscope, including frame by
frame to make debugging easier.
Also added a log for Launcher#onNewIntent to help with Home button.
Test: EXEMPT log only update
Bug: 417248321
Bug: 384423890
Flag: NONE log only update
Change-Id: Ib24aeb78e44ff29542eb25411c51f77dba299a2e
Previously we updated many other things, such as the buttons and RV
decorators, but the latest UX guidance is to use the same colors
when blurs are enabled or disabled, other than the panel color.
Note: When Overview blur is enabled, the activity is recreated and
this change is redundant. So this is only done if that flag is off.
Demo with home and taskbar all apps (toggling blur with adb):
https://drive.google.com/file/d/1HzveExKpAERxMVdu7JXQSYeGRwaBNR4_/view?usp=sharing&resourcekey=0-l-dGWOS6aCQjj2KStvwySA
Fix: 413229346
Flag: com.android.launcher3.all_apps_blur
Test: Manual with battery saver and `adb shell wm disable-blur 1` / 0
Change-Id: I55c9b46f0999c574c29a6ac7ae557b1e30d91d15
- When battery saver changes, WallpaperThemeManager always recreate activity to reapply theme base on wallpaper color hint changes
- Battery saver change can also result in light/dark theme changes, for which WallpaperThemeManager also recreate activity to apply theme changes
- As a result, it'll be much simpler to recreate activity whenever isBlurEnabled changes
- Exposed recreateToUpdateTheme API from WallpaperThemeManager to achieved this
- Greatly simplified Overview styling to read from styles
Reland fix:
- Removed mBlursEnabled in BaseDepthController, and only use `mCrossWindowBlursEnabled` to control swapping between blur style and fallback style
- Temporary variables like `mPauseBlurs` and `hasOpaqueBg` should only affect if blurs are applied, but not result in swapping of blur style, otherwise this cause unnecessary redraw or activity recreate
Reason for revert: reland
Reverted changes: /q/submissionid:33581402-revert-33554447-b/414789280-CTVRJLPLRT
Bug: 414789280
Test: manually toggling battery saver and light/dark theme and WallpaperThemeManagerTest
Test: PressBackFromLaunchedApp.testPressBackFromLaunchedApp
Flag: EXEMPT bugfix
Change-Id: Iac2b0c00811e0e79684da0cf77df76a120c1272a
Revert submission 33554447-b/414789280
Reason for revert: Droidmonitor created revert due to b/417614196. Will be verifying through ABTD before submission.
Fix: 417614196
Reverted changes: /q/submissionid:33554447-b/414789280
Change-Id: Idf349cd39a3f86910f597f0f9ab4d46fb03e945c
- When battery saver changes, WallpaperThemeManager always recreate activity to reapply theme base on wallpaper color hint changes
- Battery saver change can also result in light/dark theme changes, for which WallpaperThemeManager also recreate activity to apply theme changes
- As a result, it'll be much simpler to recreate activity whenever isBlurEnabled changes
- Exposed recreateToUpdateTheme API from WallpaperThemeManager to achieved this
- Greatly simplified Overview styling to read from styles
Bug: 414789280
Test: manually toggling battery saver and light/dark theme and WallpaperThemeManagerTest
Flag: com.android.launcher3.enable_overview_background_wallpaper_blur
Change-Id: I90ad724867283fe3c62a9073a6e072491533f774
1. initialize DepthController before applyStyle()
2. initialize mBlurEnabled to correct value based on mCrossWindowBlursEnabled and mPauseBlurs.
Fix: 416687465
Test: Restart launcher and go to overview both from app and home.
Flag: com.android.launcher3.enable_overview_background_wallpaper_blur
Change-Id: I018d25b66d925f201449400fc6bbb6a238a0f531
Dragging on launcher background on external display didn't do anything
because there was no StatusBarTouchController. Now by adding it to
SecondaryDragLayer, we can open the shade on external display via
launcher drag
Bug: 362719719
Bug: 416511740
Test: manual testing
Flag: EXEMPT refactor only
Change-Id: I1a587fe85bf2e7c6f212b3358646d5d282019eef
Handle go home and go back to previous screen for overview, split and full screen task
Bug: 397182595
Test: ActionCornerHandlerTest
Flag: com.android.systemui.shared.cursor_hot_corner
Change-Id: Ia928f102df6908058c02949db02a73430cea5ef1
> This allows the whole workspace model to be contained in itemIdMap instead of spread across multiple data containers
> Deprecating extraItems, all non-workspace data should use separate repositories
> Design: http://go/launchermodel-re-arch?#heading=h.5y8n4r164d5s
Bug: 390572144
Test: atest PredictionUpdateTaskTest
Flag: EXEMPT refactor
Change-Id: I886d0a8d5bbbf9f5c2054d4a2442bf03f9c4eab5
- Support for the GNC allows for some additional animations and clean up. The missing clean up was causing test failures
- Also fixing broken GNC support for split apps. Swiping up from split apps caused consistent crashes, however since the current 1P swipe to home has no special animation, updating the recents window and 3P GNC to match this.
Flag: com.android.launcher3.enable_launcher_overview_in_window
Bug: 377678992
Test: pre/postsubmit; swipe home from 1P and 3P launcher
Change-Id: Idf24d7969e76a50ff656f6644c2b568c42e409d7
1. BlurFallbackStyle/BlurStyle will now be applied in Launcher startup.
When "updateBlurStyle" is called, individual element style's swap
happens as per blur style.
2. "hasOpaqueBg" background will now be checked in "applyDepthAndBlur"
for setting the "currentBlur" value.
Bug: 409758306
Test: Manual. go to overview, enable/disable battery saver mode.
Flag: com.android.launcher3.enable_overview_background_wallpaper_blur
Change-Id: Ic9030c2b267867b9124705426dd51deb1b30ca55
We do not pause updates on tablets anyway, maintaining a separate behavior on phone is unnecessary
Bug: 339700174
Flag: EXEMPT bugfix
Test: Manually verify that the predictions update
Change-Id: Ia835e3c73dc536e0ff5b4c1f5120628a48f7723f
Test: local + unit
Bug: 392703464
Flag: com.android.launcher3.enable_overview_on_connected_displays
Change-Id: I7eb65a1d6b98703a19432b9fa24c3c4b262aa045
Bug: 409611054
Test: Presubmit, Verified "Don't suggest app" shortcut works fine for predicted apps.
Flag: EXEMPT Flag removal
Change-Id: Icb92f3519760ad0dc27e10d9690505c737b9dd25
Test: Built and ran locally, tested against various cases, verified with
logs
Flag: com.android.launcher3.enable_fallback_overview_in_window
com.android.launcher3.enable_launcher_overview_in_window
Bug: 292269949
Change-Id: If90b1f98ad18286fa0c9b9625077237823197967
- RecentsWindowManager/FallbackWindowInterface should be accessed through the respecitve REPOSITORY_INSTANCE or through Dagger
- RecentsDisplayModel is no longer needed as PerDisplayRepository manages lifecycle of all per-display objects
Fix: 410224937
Test: manual and presubmit
Flag: EXEMPT refactor
Change-Id: Iddfddbdcbe15be5075c038d98d02aa79ab55117b
1. Introduce a `groupTask` property to `TaskView` and let all the
`bind` functions take a type of `GroupTask` as the parameter
instead of a `Task`.
2. Then let `RecentsView.removeGroupTaskInternal` take the
`GroupTask` as the parameter instead of a `TaskView`.
3. Caches the `groupTask` before `removeGroupTaskInternal` then
we can avoid the corresponding `deskId` being set to invalid
on `removeViewInLayout` in the main thread, which might happen
before `removeGroupTaskInternal`.
Bug: 408032417
Test: m
Flag: EXEMPT refactor
Change-Id: I51c5b810eb63bc1267b90b915f90164f7ca3cba5
This would allow customizing the widget holder in LauncherPreview
Bug: 361850561
Test: Updated tests and presubmit
Flag: EXEMPT dagger
Change-Id: I32491169188992453693048986c57cb780fdf1d8
As seen in the bug, an exception caused rest of onDestroy to not clean
up the other objects - which could cause other leaks.
So, for somewhat non-trivial clean ups, I've wrapped them in try-catch.
This way, with Log.e we still will know about them, but not crash
destruction of activity and other clean up.
Bug: 400793700
Flag: EXEMPT BUGFIX
Test: Leak canary and studio heap dump
Change-Id: I45e7298394eafff182a2c800eebfa5f772fbe2de
Matthew Mourgos
Treehugger Robot
Will Osborn
Sebastian Franco
Tony Wickham
Priyanka Advani (xWF)
Andy Wickham
Alex Chau
Vinay Joglekar
Daniel Akinola
Helen Cheuk
Sunny Goyal
Schneider Victor-tulias
Anushree Ganjam
Randy Pfohl
minch
Shamali Patwa