Commit Graph

14722 Commits

Author SHA1 Message Date
TreeHugger Robot 4da033b59b Merge "Use a property instead of a getter function for key in BubbleBarBubble. Using a property here is more Kotlin idiomatic." into udc-dev am: 35f5bfea4c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23058990

Change-Id: Ia43c7821f7ff4de0b489b64e8bd84d15bb797e6d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-08 19:27:26 +00:00
TreeHugger Robot 35f5bfea4c Merge "Use a property instead of a getter function for key in BubbleBarBubble. Using a property here is more Kotlin idiomatic." into udc-dev 2023-05-08 18:52:25 +00:00
Schneider Victor-tulias 1e898351ea Merge "Fix null-pointers in SurfaceTransactionApplier constructor." into udc-dev am: a40de23f04
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22973611

Change-Id: I3b5ad1facf2ddf4ee7f17131f49e2f209898485c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-08 18:40:28 +00:00
Lucas Silva c499df2142 Merge "Update QuickstepTransitionManager to allow remote transitions to be overridden" into udc-dev am: 39e28c9190
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22992541

Change-Id: Idedad51ef52dfb099ec07fdc52e18f5808b5dc2d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-08 17:41:48 +00:00
Schneider Victor-tulias a40de23f04 Merge "Fix null-pointers in SurfaceTransactionApplier constructor." into udc-dev 2023-05-08 16:50:13 +00:00
Lucas Silva 39e28c9190 Merge "Update QuickstepTransitionManager to allow remote transitions to be overridden" into udc-dev 2023-05-08 14:20:36 +00:00
Mady Mellor 8b29c533ca Merge "Adds BubbleControllers to TaskbarControllers" into udc-dev am: 764608263f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22534247

Change-Id: I32c85ead8fc190796847d9fe07698bdf5a4a7753
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-06 17:59:08 +00:00
Mady Mellor 442ce74f39 Merge "Add Bubbles and BubblesListener to SystemUiProxy and use it" into udc-dev am: b7dce64db5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22534246

Change-Id: I55366cf639ea62888d1689338617944e1a5ea43a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-06 17:58:58 +00:00
Mady Mellor 764608263f Merge "Adds BubbleControllers to TaskbarControllers" into udc-dev 2023-05-06 17:22:21 +00:00
Mady Mellor b7dce64db5 Merge "Add Bubbles and BubblesListener to SystemUiProxy and use it" into udc-dev 2023-05-06 17:22:06 +00:00
Brian Isganitis fe933305c3 Merge changes I35fe528b,Ia612c1b5 into udc-dev am: 0b53332c31
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22419061

Change-Id: Ia47f7ed39378ba4bc7b37026ff8d8feecb05b093
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-06 15:31:40 +00:00
Brian Isganitis 0b53332c31 Merge changes I35fe528b,Ia612c1b5 into udc-dev
* changes:
  Don't close AFVs when opening Taskbar folder.
  Keep persistent Taskbar visible over Taskbar All Apps.
2023-05-06 14:42:54 +00:00
Winson Chung c0d4768083 Merge "Try to detect and handle delayed quickswitch task launch failure" into udc-dev am: 8e7e159645
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22841404

Change-Id: Ic56a7295e03f04c5b0f0613e9a025352929ac064
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-06 07:52:28 +00:00
Winson Chung 8e7e159645 Merge "Try to detect and handle delayed quickswitch task launch failure" into udc-dev 2023-05-06 07:12:18 +00:00
Treehugger Robot 1815a4c555 Merge "Updating SurfaceTransactionApplier to handle view not being attached" into udc-dev am: 8b0fcbffb0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23066497

Change-Id: Ie0d5beaaedb14adba33ee1f24a6c5c867b5f0780
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-06 02:38:25 +00:00
Treehugger Robot 8b0fcbffb0 Merge "Updating SurfaceTransactionApplier to handle view not being attached" into udc-dev 2023-05-06 01:57:51 +00:00
Mady Mellor c37bf46381 Adds BubbleControllers to TaskbarControllers
* BubbleControllers is optionally available (gated behind a flag).
* The bubble bar controllers follow init & onDestroy after the taskbar
  controllers.
* Adds the relevant views used by the bubble controllers to the
  transient taskbar layout.

Bug: 253318833
Test: manual, with other CLs, see go/bubble-bar-tests
Flag: WM_BUBBLE_BAR
Change-Id: I685163cdcc912768b1a720952762f4cbc602b14b
2023-05-05 17:02:38 -07:00
Winson Chung df51c1ada8 Try to detect and handle delayed quickswitch task launch failure
- The main issue arises when a task is successfully launched from
  overview, but the activity later finishes (ie. during resume) which
  prevents the usual logic of resetting Launcher to a good state
  (ie. it can get stuck in overview with a blank or empty snapshot)

  In this case, the Launch will "succeed" so that onTaskLaunchFailed
  is not called, but then also silently fail (launched task finishes
  and Launcher is again resumed) before Launcher stops, which does the
  usual resetting of the state back to normal state after quickswitching.

  This change checks for this case by listening for the activity and
  transition state, and in the case where Launcher has not been stopped
  or is resumed again after the transition finishes, returns the
  user to the default home state.

  This primarily only affects quickswitch for now, as other launch
  failures leave the user in a valid state (ie. overview) while this
  issue will leave the user in background state while quickswitching.

Bug: 268448123
Test: Quickswitch to an activity that finishes when resumed
Change-Id: I7d554f8fd521f7bc480dc06930ad91eeef0f1a1a
2023-05-05 23:55:22 +00:00
Saumya Prakash 93a0cc9f01 Merge "Remove unused Sandbox Mode in the gesture navigation tutorial" into udc-dev am: 958eabcd8f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23002490

Change-Id: I66a932e91d9969f284d6c978a3a901670acbf669
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-05 23:26:38 +00:00
Sunny Goyal 63cf4d07a8 Updating SurfaceTransactionApplier to handle view not being attached
Bug: 278833389
Test: Presubmit
Flag: N/A
Change-Id: I88c240a1a7bdfe2e68c858c30e91cc5d06bc7bcf
2023-05-05 15:57:42 -07:00
Saumya Prakash 958eabcd8f Merge "Remove unused Sandbox Mode in the gesture navigation tutorial" into udc-dev 2023-05-05 22:52:54 +00:00
Schneider Victor-tulias d86c5657e0 Fix null-pointers in SurfaceTransactionApplier constructor.
A recurring class of null pointers are caused by using views with no view root implementation in SurfaceTransactionApplier from QuickstepTransitionManager. This can happen when we use launcher views after it has been destroyed.

- No longer using mDragLayer in getFallbackClosingWindowAnimators; simply applying the transaction immediately.
- Forcefully using getFallbackClosingWindowAnimators when launcher is destroyed.

Flag: not needed
Bug: 278833389
Test: launches and closed several apps in 3-button and gesture nav mode
Change-Id: I83b3aec1488fe9666bd0301a6044a181bb05dbdd
2023-05-05 21:53:50 +00:00
Mady Mellor 50e8d0ff60 Add Bubbles and BubblesListener to SystemUiProxy and use it
Adds a method to call into WMShell to set the listener and
indicate when a bubble is shown or when the expanded state
changes.

BubbleBarController sets or clears out the listener.

BubbleBarViewController calls SystemUiProxy when bubbles are shown
or when the expanded state changes.

Bug: 253318833
Test: manual, with other CLs, see go/bubble-bar-tests
Flag: WM_BUBBLE_BAR
Change-Id: I2364b9bbdea237fc268b0999d9c896585c194a86
2023-05-05 14:18:00 -07:00
Liran Binyamin b7d3d64d68 Use a property instead of a getter function for key in BubbleBarBubble. Using a property here is more Kotlin idiomatic.
https://kotlinlang.org/docs/coding-conventions.html#functions-vs-properties
go/kotlin/practices/properties#when

Bug: 281083629
Test: Verified on a physical device
Change-Id: I4c003c6633bf1913ee5e1e86224a679ff3442e2b
2023-05-05 19:43:43 +00:00
Qiao Yang b4204df189 Merge "Revert "Revert "Listen for hover events over stashed taskbar.""" into udc-dev am: 1aee68df56
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23063440

Change-Id: Ia2eb0ba323c37ccbd6694209f35695c80e9c4a21
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-05 19:34:38 +00:00
Qiao Yang 1aee68df56 Merge "Revert "Revert "Listen for hover events over stashed taskbar.""" into udc-dev 2023-05-05 19:09:44 +00:00
Qiao Yang 2482c8dcd4 Revert "Revert "Listen for hover events over stashed taskbar.""
This reverts commit c27605099c.

Reason for revert: DroidMonitor-triggered revert due to breakage <https://android-build.googleplex.com/builds/quarterdeck?branch=git_udc-dev&target=cf_x86_64_phone-userdebug&lkgb=10076607&lkbb=10076982&fkbb=10076788>, bug <281093059>

Change-Id: I71e7fd07232c27a004243df0ffb0457fe53fe13b
2023-05-05 19:07:17 +00:00
Qiao Yang 611dca65e1 Merge "Revert "Listen for hover events over stashed taskbar."" into udc-dev am: 51669b612f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23048070

Change-Id: I7ae65fafd4fbab42b8137e25bd7b07e3ef4d94ac
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-05 18:51:15 +00:00
Qiao Yang 51669b612f Merge "Revert "Listen for hover events over stashed taskbar."" into udc-dev 2023-05-05 18:05:16 +00:00
Stefan Andonian 54eafd482c Merge "Enforce setting up SystemUIProxy on the main thread." into udc-dev am: 5882e97857
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23045938

Change-Id: Ie899a18dfcda9ea0f5bb6e7d9981f1cea87f1b99
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-05 17:55:33 +00:00
Pat Manning c27605099c Revert "Listen for hover events over stashed taskbar."
This reverts commit c5882bcdfc.

Reason for revert: b/281068877

Change-Id: I431678658fc464c995df0df5e3cac5491d91b052
2023-05-05 17:22:21 +00:00
Stefan Andonian 5882e97857 Merge "Enforce setting up SystemUIProxy on the main thread." into udc-dev 2023-05-05 16:56:10 +00:00
Brian Isganitis f3135fea05 Don't close AFVs when opening Taskbar folder.
Test: Manual
Fix: 276798702
Change-Id: I35fe528bf3ad7fb374b8d8ae83f0d525e131681e
2023-05-04 23:55:23 -04:00
Brian Isganitis 9c311b2917 Keep persistent Taskbar visible over Taskbar All Apps.
Additionally, this CL fixes some touchable insets issues with the
overlay window. Dragging and dropping is now reliable from taskbar while
All Apps or EDU is also open.

Change-Id: Ia612c1b5266a8fb2b7005a773fbd2b00ec4824db
Bug: 279465803
Bug: 275890048
Bug: 264463659
Flag: PERSISTENT_TASKBAR_OVER_TASKBAR_ALL_APPS (Teamfood)
Test: Taskbar is functional over All Apps and EDU.
2023-05-04 23:54:27 -04:00
Treehugger Robot 6d4b9b52a8 Merge "Listen for hover events over stashed taskbar." into udc-dev am: b6f64a4465
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22688404

Change-Id: I62fd6d6e1bfc420904457bd26fe1fc47a56cbc8d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-05 00:00:52 +00:00
Treehugger Robot b6f64a4465 Merge "Listen for hover events over stashed taskbar." into udc-dev 2023-05-04 23:15:44 +00:00
Brian Isganitis e273753af4 Merge "Add header protection for Taskbar All Apps search bar." into udc-dev am: 64ee67c6b5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22466105

Change-Id: I9a75961ca892b36de5bd012d76589d2c480a8324
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-04 22:58:13 +00:00
Stefan Andonian 672fa7a9a9 Enforce setting up SystemUIProxy on the main thread.
Bug: 280086782
Test: Added annotations and device did not crash under normal usage.
Change-Id: Ie587aafaaa018a3e6a5c33ca238e204f5cc0ea4e
2023-05-04 22:28:26 +00:00
Brian Isganitis 64ee67c6b5 Merge "Add header protection for Taskbar All Apps search bar." into udc-dev 2023-05-04 22:20:46 +00:00
Brian Isganitis f7c6db9021 Merge "Only close overlays onTaskMovedToFront for desktop prototype." into udc-dev am: cd7078372a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22975846

Change-Id: Ib728acfb1ad96c67fe9075495687a015d8d2d74b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-04 20:01:51 +00:00
Pat Manning c5882bcdfc Listen for hover events over stashed taskbar.
Bug: 243191650
Test: TaplTestsTaskbar
Flag: ENABLE_CURSOR_HOVER_STATES
Change-Id: Ia189ac6a6097d073c40c69ead6ecaf398d22eba8
2023-05-04 20:35:44 +01:00
Brian Isganitis cd7078372a Merge "Only close overlays onTaskMovedToFront for desktop prototype." into udc-dev 2023-05-04 18:55:42 +00:00
Schneider Victor-tulias 98f691ba84 Merge "Revert "Fix broken TaplTestsTaskbar splitscreen test cases"" into udc-dev am: d1054fd86b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22915139

Change-Id: I8af271531e8ee826d0ce704f1fb5f350bc26f2d9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-04 17:10:41 +00:00
Brian Isganitis 2ef7f5e4a2 Merge "Better handle large display and text scaling on EDU tooltip." into udc-dev am: 0c7f244f18
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22976837

Change-Id: Id1574fbb703ca0caba302bf0bca79fc400f50187
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-04 17:08:25 +00:00
Schneider Victor-tulias d1054fd86b Merge "Revert "Fix broken TaplTestsTaskbar splitscreen test cases"" into udc-dev 2023-05-04 16:55:21 +00:00
Brian Isganitis 0c7f244f18 Merge "Better handle large display and text scaling on EDU tooltip." into udc-dev 2023-05-04 16:30:07 +00:00
Tony Huang 831791047a Merge "Send divider change to launcher to animate" into udc-dev am: 2725473272
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22572268

Change-Id: Ie88f3adb739353aa899dc2f2e9c281e71e2da6d8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-04 13:19:02 +00:00
Tony Huang 2725473272 Merge "Send divider change to launcher to animate" into udc-dev 2023-05-04 13:02:53 +00:00
Pat Manning 42b438a0db Merge "Change hover state based on color selector" into udc-dev am: fb9687dded
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22612903

Change-Id: Ifb9135ecfbf3719381d04261001610b16e78345f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-04 10:30:32 +00:00
Pat Manning fb9687dded Merge "Change hover state based on color selector" into udc-dev 2023-05-04 10:17:35 +00:00