Commit Graph

60497 Commits

Author SHA1 Message Date
TreeHugger Robot 4da033b59b Merge "Use a property instead of a getter function for key in BubbleBarBubble. Using a property here is more Kotlin idiomatic." into udc-dev am: 35f5bfea4c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23058990

Change-Id: Ia43c7821f7ff4de0b489b64e8bd84d15bb797e6d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-08 19:27:26 +00:00
TreeHugger Robot 35f5bfea4c Merge "Use a property instead of a getter function for key in BubbleBarBubble. Using a property here is more Kotlin idiomatic." into udc-dev 2023-05-08 18:52:25 +00:00
Schneider Victor-tulias 1e898351ea Merge "Fix null-pointers in SurfaceTransactionApplier constructor." into udc-dev am: a40de23f04
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22973611

Change-Id: I3b5ad1facf2ddf4ee7f17131f49e2f209898485c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-08 18:40:28 +00:00
Lucas Silva c499df2142 Merge "Update QuickstepTransitionManager to allow remote transitions to be overridden" into udc-dev am: 39e28c9190
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22992541

Change-Id: Idedad51ef52dfb099ec07fdc52e18f5808b5dc2d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-08 17:41:48 +00:00
Schneider Victor-tulias a40de23f04 Merge "Fix null-pointers in SurfaceTransactionApplier constructor." into udc-dev 2023-05-08 16:50:13 +00:00
Lucas Silva 39e28c9190 Merge "Update QuickstepTransitionManager to allow remote transitions to be overridden" into udc-dev 2023-05-08 14:20:36 +00:00
Sunny Goyal 7ad98972cc Merge "Revert "Revert "Revert "Changing GridMigrationTask to use ModelDbController directly"""" into udc-dev am: 356aa61fe4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23074600

Change-Id: Ic1b6fd160cf807ecfe2759ced1168108d155ceff
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-06 19:01:49 +00:00
Sunny Goyal 356aa61fe4 Merge "Revert "Revert "Revert "Changing GridMigrationTask to use ModelDbController directly"""" into udc-dev 2023-05-06 18:19:13 +00:00
Sunny Goyal 3772b246c2 Revert "Revert "Revert "Changing GridMigrationTask to use ModelDbController directly"""
This reverts commit 8d9e468dbb.

Reason for revert: b/281179368

Change-Id: Ibfc5329f72cdbcb37d01a8bf3dac2ba0724b9faf
2023-05-06 18:18:07 +00:00
Mady Mellor 8b29c533ca Merge "Adds BubbleControllers to TaskbarControllers" into udc-dev am: 764608263f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22534247

Change-Id: I32c85ead8fc190796847d9fe07698bdf5a4a7753
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-06 17:59:08 +00:00
Mady Mellor 442ce74f39 Merge "Add Bubbles and BubblesListener to SystemUiProxy and use it" into udc-dev am: b7dce64db5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22534246

Change-Id: I55366cf639ea62888d1689338617944e1a5ea43a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-06 17:58:58 +00:00
Mady Mellor 764608263f Merge "Adds BubbleControllers to TaskbarControllers" into udc-dev 2023-05-06 17:22:21 +00:00
Mady Mellor b7dce64db5 Merge "Add Bubbles and BubblesListener to SystemUiProxy and use it" into udc-dev 2023-05-06 17:22:06 +00:00
Brian Isganitis fe933305c3 Merge changes I35fe528b,Ia612c1b5 into udc-dev am: 0b53332c31
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22419061

Change-Id: Ia47f7ed39378ba4bc7b37026ff8d8feecb05b093
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-06 15:31:40 +00:00
Brian Isganitis 0b53332c31 Merge changes I35fe528b,Ia612c1b5 into udc-dev
* changes:
  Don't close AFVs when opening Taskbar folder.
  Keep persistent Taskbar visible over Taskbar All Apps.
2023-05-06 14:42:54 +00:00
Sunny Goyal 25799faf72 Merge "Fixing WidgetBottomSheet getting cut off around insets" into udc-dev am: 3a75b494f2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23064199

Change-Id: I3339df05359eb148dd61fa6f657e01361d725665
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-06 10:16:33 +00:00
Sunny Goyal 3a75b494f2 Merge "Fixing WidgetBottomSheet getting cut off around insets" into udc-dev 2023-05-06 09:43:06 +00:00
Treehugger Robot d651c23464 Merge "Loading widget description on the background thread" into udc-dev am: 698f59ccbb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23048073

Change-Id: I92ad5867988e8cd6ef0d6cc37fd72b808b48c037
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-06 08:53:58 +00:00
Treehugger Robot 698f59ccbb Merge "Loading widget description on the background thread" into udc-dev 2023-05-06 08:19:12 +00:00
Winson Chung c0d4768083 Merge "Try to detect and handle delayed quickswitch task launch failure" into udc-dev am: 8e7e159645
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22841404

Change-Id: Ic56a7295e03f04c5b0f0613e9a025352929ac064
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-06 07:52:28 +00:00
Winson Chung 8e7e159645 Merge "Try to detect and handle delayed quickswitch task launch failure" into udc-dev 2023-05-06 07:12:18 +00:00
Fengjiang Li 91cc211e4c Merge "[3/n] Update StartupLatencyLogger's @VisibleForTesting" into udc-dev am: 9a055ee5dd
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23041780

Change-Id: I98fb7138b6bd0647ecf833fe6150d2de04a1308c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-06 04:01:10 +00:00
Fengjiang Li 9a055ee5dd Merge "[3/n] Update StartupLatencyLogger's @VisibleForTesting" into udc-dev 2023-05-06 03:32:03 +00:00
Treehugger Robot 1815a4c555 Merge "Updating SurfaceTransactionApplier to handle view not being attached" into udc-dev am: 8b0fcbffb0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23066497

Change-Id: Ie0d5beaaedb14adba33ee1f24a6c5c867b5f0780
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-06 02:38:25 +00:00
Treehugger Robot 8b0fcbffb0 Merge "Updating SurfaceTransactionApplier to handle view not being attached" into udc-dev 2023-05-06 01:57:51 +00:00
Sebastián Franco a9568ff766 Merge "Call getModelWriter() to get the newest version instead of using the old one" into udc-dev am: 5fd9a76760
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23064200

Change-Id: I5bbf1f9bc7ce2b534a5357ad6fbcb18922d7fba0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-06 00:53:44 +00:00
Sebastián Franco 5fd9a76760 Merge "Call getModelWriter() to get the newest version instead of using the old one" into udc-dev 2023-05-06 00:22:20 +00:00
Mady Mellor c37bf46381 Adds BubbleControllers to TaskbarControllers
* BubbleControllers is optionally available (gated behind a flag).
* The bubble bar controllers follow init & onDestroy after the taskbar
  controllers.
* Adds the relevant views used by the bubble controllers to the
  transient taskbar layout.

Bug: 253318833
Test: manual, with other CLs, see go/bubble-bar-tests
Flag: WM_BUBBLE_BAR
Change-Id: I685163cdcc912768b1a720952762f4cbc602b14b
2023-05-05 17:02:38 -07:00
Winson Chung df51c1ada8 Try to detect and handle delayed quickswitch task launch failure
- The main issue arises when a task is successfully launched from
  overview, but the activity later finishes (ie. during resume) which
  prevents the usual logic of resetting Launcher to a good state
  (ie. it can get stuck in overview with a blank or empty snapshot)

  In this case, the Launch will "succeed" so that onTaskLaunchFailed
  is not called, but then also silently fail (launched task finishes
  and Launcher is again resumed) before Launcher stops, which does the
  usual resetting of the state back to normal state after quickswitching.

  This change checks for this case by listening for the activity and
  transition state, and in the case where Launcher has not been stopped
  or is resumed again after the transition finishes, returns the
  user to the default home state.

  This primarily only affects quickswitch for now, as other launch
  failures leave the user in a valid state (ie. overview) while this
  issue will leave the user in background state while quickswitching.

Bug: 268448123
Test: Quickswitch to an activity that finishes when resumed
Change-Id: I7d554f8fd521f7bc480dc06930ad91eeef0f1a1a
2023-05-05 23:55:22 +00:00
Saumya Prakash 93a0cc9f01 Merge "Remove unused Sandbox Mode in the gesture navigation tutorial" into udc-dev am: 958eabcd8f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23002490

Change-Id: I66a932e91d9969f284d6c978a3a901670acbf669
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-05 23:26:38 +00:00
Sunny Goyal 2185f6f420 Loading widget description on the background thread
Bug: 281074741
Test: Varified on device
Flag: N/A
Change-Id: I6b9b13e712534bdc582b98dbfb7bdfcc40d2f19d
2023-05-05 23:15:41 +00:00
Sunny Goyal e7da062d9a Fixing WidgetBottomSheet getting cut off around insets
Bug: 265639220
Test: Verified on device
Flag: N/A
Change-Id: If595fde8e84a226aef82f41caa0be913b22d99c2
2023-05-05 23:15:31 +00:00
Sunny Goyal 63cf4d07a8 Updating SurfaceTransactionApplier to handle view not being attached
Bug: 278833389
Test: Presubmit
Flag: N/A
Change-Id: I88c240a1a7bdfe2e68c858c30e91cc5d06bc7bcf
2023-05-05 15:57:42 -07:00
Saumya Prakash 958eabcd8f Merge "Remove unused Sandbox Mode in the gesture navigation tutorial" into udc-dev 2023-05-05 22:52:54 +00:00
Sebastian Franco a64f3a6c98 Call getModelWriter() to get the newest version instead of using the old one
DropTargetHandler was calling getModelWriter() on a final variable
and the model writer it was using was and old one.

Fix: 280170665
Test: Manul test, delete widget and rotate the device, you have to do this twice.
Change-Id: I7b3ac4b272568fcc81438ffd5ac84cf7b64a62ea
2023-05-05 16:09:38 -06:00
Anushree Ganjam d1606b6e8e Merge "Introduce new Attributes to indicate data source of Toast results." into udc-dev am: b7c43c94db
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23035389

Change-Id: I8e65478cd6b6c9224ffeb3bb832edcaaa85114bc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-05 21:59:59 +00:00
Schneider Victor-tulias d86c5657e0 Fix null-pointers in SurfaceTransactionApplier constructor.
A recurring class of null pointers are caused by using views with no view root implementation in SurfaceTransactionApplier from QuickstepTransitionManager. This can happen when we use launcher views after it has been destroyed.

- No longer using mDragLayer in getFallbackClosingWindowAnimators; simply applying the transaction immediately.
- Forcefully using getFallbackClosingWindowAnimators when launcher is destroyed.

Flag: not needed
Bug: 278833389
Test: launches and closed several apps in 3-button and gesture nav mode
Change-Id: I83b3aec1488fe9666bd0301a6044a181bb05dbdd
2023-05-05 21:53:50 +00:00
Anushree Ganjam b7c43c94db Merge "Introduce new Attributes to indicate data source of Toast results." into udc-dev 2023-05-05 21:43:45 +00:00
Brandon Dayauon 9e612e6766 Merge "ENABLE_TWOLINE_ALLAPPS default true (only in teamfood)" into udc-dev am: 1ee28cd273
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22878239

Change-Id: I8045ef1412d3c1998e67284824c280f0b88f78f1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-05 21:39:49 +00:00
Mady Mellor 50e8d0ff60 Add Bubbles and BubblesListener to SystemUiProxy and use it
Adds a method to call into WMShell to set the listener and
indicate when a bubble is shown or when the expanded state
changes.

BubbleBarController sets or clears out the listener.

BubbleBarViewController calls SystemUiProxy when bubbles are shown
or when the expanded state changes.

Bug: 253318833
Test: manual, with other CLs, see go/bubble-bar-tests
Flag: WM_BUBBLE_BAR
Change-Id: I2364b9bbdea237fc268b0999d9c896585c194a86
2023-05-05 14:18:00 -07:00
Brandon Dayauon 1ee28cd273 Merge "ENABLE_TWOLINE_ALLAPPS default true (only in teamfood)" into udc-dev 2023-05-05 20:49:58 +00:00
Liran Binyamin b7d3d64d68 Use a property instead of a getter function for key in BubbleBarBubble. Using a property here is more Kotlin idiomatic.
https://kotlinlang.org/docs/coding-conventions.html#functions-vs-properties
go/kotlin/practices/properties#when

Bug: 281083629
Test: Verified on a physical device
Change-Id: I4c003c6633bf1913ee5e1e86224a679ff3442e2b
2023-05-05 19:43:43 +00:00
Sunny Goyal 88a4de4806 Merge "Simplifying widget cell layout" into udc-dev am: 2e17bcaa0b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23061041

Change-Id: I82c71a396a24144c59ac4d923ad06bd602f68500
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-05 19:36:06 +00:00
Qiao Yang b4204df189 Merge "Revert "Revert "Listen for hover events over stashed taskbar.""" into udc-dev am: 1aee68df56
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23063440

Change-Id: Ia2eb0ba323c37ccbd6694209f35695c80e9c4a21
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-05 19:34:38 +00:00
Sunny Goyal 2e17bcaa0b Merge "Simplifying widget cell layout" into udc-dev 2023-05-05 19:18:46 +00:00
Qiao Yang 1aee68df56 Merge "Revert "Revert "Listen for hover events over stashed taskbar.""" into udc-dev 2023-05-05 19:09:44 +00:00
Qiao Yang 2482c8dcd4 Revert "Revert "Listen for hover events over stashed taskbar.""
This reverts commit c27605099c.

Reason for revert: DroidMonitor-triggered revert due to breakage <https://android-build.googleplex.com/builds/quarterdeck?branch=git_udc-dev&target=cf_x86_64_phone-userdebug&lkgb=10076607&lkbb=10076982&fkbb=10076788>, bug <281093059>

Change-Id: I71e7fd07232c27a004243df0ffb0457fe53fe13b
2023-05-05 19:07:17 +00:00
Sunny Goyal 047bd38b94 Merge "Revert "Revert "Changing GridMigrationTask to use ModelDbController directly""" into udc-dev am: d17c8add74
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23035926

Change-Id: Ifbd29d09efd99bd2ab132c4018ded4c6ca925356
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-05 18:51:40 +00:00
Qiao Yang 611dca65e1 Merge "Revert "Listen for hover events over stashed taskbar."" into udc-dev am: 51669b612f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23048070

Change-Id: I7ae65fafd4fbab42b8137e25bd7b07e3ef4d94ac
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-05 18:51:15 +00:00
Sunny Goyal d17c8add74 Merge "Revert "Revert "Changing GridMigrationTask to use ModelDbController directly""" into udc-dev 2023-05-05 18:21:04 +00:00