Commit Graph

79622 Commits

Author SHA1 Message Date
Sihua Ma 4cc729ebca Remove disruptive announcement when exiting folder
Accessibility announcement needs to be disabled when folder is closing

Test: Manual
Flag: EXEMPT bug fix
Fix: 383248901
Change-Id: Ie6077a1214c234946bc9fb59ce54dfa7107188bd
2024-12-20 22:06:38 +00:00
Jagrut Desai 636aba5acb Merge "Don't recreate taskbar in Overview" into main 2024-12-19 13:00:03 -08:00
Bill Yi e6382d45f0 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-12-19 11:40:38 -08:00
Charlie Anderson 4c89531f9d Merge "cleanup misleading logs around restore and grid migration" into main 2024-12-19 11:03:37 -08:00
Jagrut Desai 2f1c1e10de Don't recreate taskbar in Overview
This cl includes
	- when going to overview from Launcher or Desktop Mode don't recreate taskbar and keep it a same variant as the context user was in.
        - user will still be able to pin/unpin taskbar in overview, but it will be recreated to the launcher context.
	- opening app from taskbar context is now aware of if taskbar is in desktop mode and opens app in Desktop Mode when user oepn any app.
        - This cl will not include the animation when taskbar variant is changing between launcher and desktop mode.

Solution
    - if desktop tasks are visible we will open any app from taskbar context into Desktop windowing mode after launching the DesktopTaskView manually. We will launch desktop task from recentview first and upon end of recent animation we will launch the app.

Bug: 343882478
Test: Manual
Flag: com.android.window.flags.enable_desktop_windowing_mode
Change-Id: Ib67e1e7150670f901c07c2df188cde81e7d725dc
2024-12-19 10:50:20 -08:00
Treehugger Robot 1ac4d2294f Merge "Destroy dep tree on RecentsView detached. This prevents leaks." into main 2024-12-19 10:14:02 -08:00
Liran Binyamin 8b102fe820 Merge "Fix handle color when interrupting the animation" into main 2024-12-19 10:04:52 -08:00
Randy Pfohl 080fb1e483 Merge "Refactor to use a DisplayModel to host common per display objects" into main 2024-12-19 08:35:27 -08:00
Charlie Anderson 9654c08d9d cleanup misleading logs around restore and grid migration
Bug: 378684472
Test: N/A just logs
Flag: EXEMPT just logs
Change-Id: I756ef1926810852453bbc00e6dcf02eec4f8955b
2024-12-19 11:06:42 -05:00
Will Osborn 64464fa257 Merge "Don't update desktop visibility with final state until state transition has finished." into main 2024-12-19 06:49:46 -08:00
Uwais Ashraf a9d5cc877c Destroy dep tree on RecentsView detached. This prevents leaks.
Scenario 1 was already working, this CL fixes scenario 2 and leaves scenario 3 broken.

3 Scenarios:
Scenario 1 (occurs in real usage):
Launcher instance 1 init
Launcher instance 2 init
Launcher instance 1 destroy
Launcher instance 2 destroy

Scenario 2 (occurs in testStressPressHome):
Launcher instance 1 init
Launcher instance 1 destroy
Launcher instance 2 init
Launcher instance 2 destroy

Scenario 3 (does not currently happen):
Launcher instance 1 init
Launcher instance 2 init
Launcher instance 2 destroy
Launcher instance 1 destroy

Fix: 381160061
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Test: TaplStartLauncherViaGestureTests#testStressPressHome
Change-Id: I7c82ce97e7a7f0698b9adad38f59e4555f0d1bdc
2024-12-19 06:16:28 -08:00
Treehugger Robot 072c1f469f Merge "[CD Taskbar] Refactor TaskbarManager - Make mAddedWindow display-specifc" into main 2024-12-18 22:57:22 -08:00
randypfohl b479f10d45 Refactor to use a DisplayModel to host common per display objects
Test: Built and ran locally

Flag: com.android.launcher3.enable_fallback_overview_in_window

Bug:  379746094

Change-Id: I59b644f8905a3ba5af31234c4fb53709209d9d07
2024-12-18 21:52:41 -08:00
Sukesh Ram fb55f96506 [CD Taskbar] Refactor TaskbarManager - Make mAddedWindow display-specifc
Create SparseBooleanArray to ensure that with connected displays, there is support for multiple RootLayouts, which each a variable tracking whether they have been added to the window or not.

Flag: EXEMPT not adding new behavior
Bug: 384793943
Test: Manual
Change-Id: I18849d033cada181eadf89c86d3c02d87a8ee962
2024-12-18 21:10:57 -08:00
Sunny Goyal 4f20462257 Merge "Removing TisHelper dependency in taskbar Taskbar should be able to access TouchInteractionService directly" into main 2024-12-18 18:58:43 -08:00
Treehugger Robot a7bb99683d Merge "Some HSUM bug fixes" into main 2024-12-18 17:40:25 -08:00
Treehugger Robot ee2e3ba257 Merge "Use DeviceProfile in NavBarGestureHandler and EdgeBackGestureHandler for the display size" into main 2024-12-18 16:09:36 -08:00
Treehugger Robot 1ad0e1555b Merge "Migrate using TaskViewCount as the indices" into main 2024-12-18 15:43:25 -08:00
Ana Salazar Maldonado bc2b3ae3b0 Merge "Fix Title padding for the contrast tile" into main 2024-12-18 15:24:04 -08:00
Sunny Goyal ddded547bb Removing TisHelper dependency in taskbar
Taskbar should be able to access TouchInteractionService directly

Bug: 384896306
Test: Presubmit
Flag: EXEMPT bugfix
Change-Id: I2a32d3a7a2b2071645abff72c62635c6575a48a1
2024-12-18 15:02:44 -08:00
Sebastián Franco f07079d0ff Merge "Revert^2 "Making sure that test go to FixedLandscape on landscape"" into main 2024-12-18 14:16:08 -08:00
Anushree Ganjam 59137e44e2 Merge "Update the All apps label to "Apps list"" into main 2024-12-18 14:07:36 -08:00
Sunny Goyal 21a84af378 Merge "Fixing module inheritence when overriding Launcher component" into main 2024-12-18 13:54:30 -08:00
Vinit Nayak 9f4ab8b89a Merge "Hide App Chip for smaller app in 90:10 flex split" into main 2024-12-18 12:00:48 -08:00
Sunny Goyal 211f74608a Some HSUM bug fixes
Bug: 383952735
Bug: 384136644
Test: Presubmit
Flag: EXEMPT bugfix
Change-Id: I705d79d008100edd3fcf6fcac4524c204fd4ea30
2024-12-18 11:16:26 -08:00
Sunny Goyal 60bad051c4 Fixing module inheritence when overriding Launcher component
Bug: 361850561
Flag: EXEMPT dagger migration
Test: Presubmit
Change-Id: I1f726e9895f6872d0294a11ab0c52c6c619c2a3f
2024-12-18 10:38:00 -08:00
minch 55c301add0 Migrate using TaskViewCount as the indices
Do not rely on `getTaskViewCount` as the index information.
- Remove the use of the deprecated function `obtain` as well.

Flag: EXEMPT as no functionality changes
Bug: 379942019
Test: Enabled TalkBack on Tangor and entered overview with multiple
      opened apps, verified the information as below:
      1. The number of children pronounced by TalkBack is the number
         of RecentsView children.
      2. Talkback starts from the leftmost visible TaskView, which
         matches the logic that we added the TaskView in reverse order
         to the accessibility children list.
      3. Scrolled inside RecentsView, and checked the from and end
         indices of the a11 event are the same as before.
Change-Id: Ib3c37422ba940aed6c124a8cc0d4732144783d45
2024-12-18 16:46:46 +00:00
Saumya Prakash 1bcaab81e3 Merge "Close the multi instance menu when other things open" into main 2024-12-18 07:38:26 -08:00
Schneider Victor-Tulias 0b2c37ed72 Use DeviceProfile in NavBarGestureHandler and EdgeBackGestureHandler for the display size
DisplayController caches the display size, so when the user unfolds a foldable, the screen size is incorrect, which messes with the touch handling. Using DeviceProfile instead.

Flag: EXEMPT bug fix
Fixes: 361694048
Test: fold/unfold device during home/back/overview tutorial steps
Change-Id: Ie49f677f97ea5ddb0f91d2e662677edaaa81860a
2024-12-18 10:03:50 -05:00
Uwais Ashraf 7a829e98d8 Merge "Move cancellation of CoroutineScopes to bg thread as it can be slow." into main 2024-12-18 05:36:02 -08:00
Anushree Ganjam 8dae1be563 Update the All apps label to "Apps list"
Set the AccessibilityNodeInfo containerTitle to improve a11y for users
in predictionRow.

See expected behavior suggestion in  https://b.corp.google.com/issues/379640673#comment1

Video
Quickstep launcher: http://recall/-/cOtJfHR6buEyEHnRyCqzVE/eugH3ID7eenOuLwTszaLHk

Pixel launcher: http://recall/-/cOtJfHR6buEyEHnRyCqzVE/fftzwMRCy6N3o7OcwiGMdk

Bug: 379640673
Test: Manual
Flag: EXEMPT a11y bugfix
Change-Id: I23a8a142afb213c0801402a56bc134bc14f0f97d
2024-12-17 16:39:45 -08:00
Treehugger Robot a429476ec6 Merge "If Pinned Shortcuts aren't available, then check for pinned shortcuts by id/package name" into main 2024-12-17 15:38:17 -08:00
Uwais Ashraf 2470d3fdf5 Move cancellation of CoroutineScopes to bg thread as it can be slow.
Bug: 381317629
Fix: 383999850
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Test: Manual - checking perfetto traces for improvement
Test: Performance tests
Change-Id: Ic796fe578f5aa98ce060ac22341a1bcfa68061df
2024-12-17 23:33:55 +00:00
Ana Salazar Maldonado e3f421211e Fix Title padding for the contrast tile
When drawing the pill, after the pill surrounds the text, add
horizontal_padding on each side instead of round_rect_padding. This is
the correct value since it is the space between the tile and the text.

Bug: 341217082
Flag: com.android.launcher3.enable_contrast_tiles
Test: Manual, visual change
Change-Id: I48521dc05c04b561b271aa589712ed493af63189
2024-12-17 14:45:42 -08:00
Treehugger Robot 446ea7592f Merge "Let getOffsetToDismissedTask not rely on taskCount" into main 2024-12-17 14:37:52 -08:00
Vinit Nayak cf332154c1 Hide App Chip for smaller app in 90:10 flex split
Bug: 384110883
Test: Tested with both halves made smaller,
large screen and small (phone has other existing bugs).
Lanscape and portrait.
Flag: com.android.wm.shell.enable_flexible_two_app_split

Change-Id: Ib6508c7b3192cc47fc8406cdf68c826bed29de5f
2024-12-17 13:52:39 -08:00
Sebastián Franco 12c346fbab Revert^2 "Making sure that test go to FixedLandscape on landscape"
This reverts commit d98bb0b979.

Reason for revert: b/383917141

Change-Id: I503fd7136b927064a54e428e422335c06e221e2e
2024-12-17 11:19:29 -08:00
Mykola Podolian bd10730a57 Merge "Added an onClick listener to the bubble bar." into main 2024-12-17 10:36:14 -08:00
Stefan Andonian fa1b2ba983 If Pinned Shortcuts aren't available, then check for pinned shortcuts by id/package name
Bug: 356096502
Test: Verified locally that if you hard-code the PINNED shortcut query to not return data, the backup query still allows the deep shortcuts to show up on the home screen.
Flag: EXEMPT bug fix
Change-Id: I7a9b2d2c3be2ecce38a5af71951f1a12bc1c20ee
2024-12-17 18:06:48 +00:00
Sihua Ma 1386bf57b7 Merge "Attempt on deflaking FolderTest" into main 2024-12-17 09:23:06 -08:00
Will Osborn 2c658324e8 Don't update desktop visibility with final state until state transition has finished.
When exiting Overview, the Launcher.onIdpChange listener is indirectly
triggered by DesktopVisibilityController.onLauncherStateChanged because
with a desktop live tile the mode will have changed out of desktop mode.

onIdpChange is treated as a configuration change and triggers reapplyUi
which cancels currently running animations and causes the Overview->Home
animation not to run.

Bug: 378481525
Test: locally tested on TangorPro
Flag: EXEMPT bugfix
Change-Id: I1629e43d7b2fd960c5b999899b286e918a1e7aa4
2024-12-17 14:54:29 +00:00
Sihua Ma e5a3789024 Attempt on deflaking FolderTest
Test: SysUI studio
Test: atest NexusLauncherRoboTests
Flag: EXEMPT test deflake
Bug: 382305734
Change-Id: I7f66b5b8973c97f6bc03a739044fb8c90886e41e
2024-12-17 06:32:53 +00:00
Treehugger Robot d3f591f614 Merge "Prevent bad grid configuration by making sure RestoreDbTask updates IDP correctly." into main 2024-12-16 22:06:32 -08:00
Treehugger Robot 254ba3092e Merge "Handle cancelled All Apps transitions." into main 2024-12-16 19:33:00 -08:00
Bill Yi 62ca42caa6 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I1281d2102a0680883a4d15b04163e3e246315ce4
2024-12-16 17:45:40 -08:00
minch 7fc34db11b Let getOffsetToDismissedTask not rely on taskCount
This is a preparation to migrate TaskViews iteration that
rely `getTaskViewCount` to the `TaskViewsIterable` and
`TaskViewsIterator`.

Flag: EXEMPT as no functionality changes
Bug: 379942019
Test: Tested on tangor with `adb shell wm density 480` to simulate
      phone layout, and verified overview layout is correct in
      scenarios below:
      1. Dismiss the first TaskView
      2. Dismiss the last TaskView
      3. Dismiss a TaskView in the middle
      4. Click `ClearAll` button to dismiss all the TaskViews
Change-Id: Icbaf1ea706906097fc6ac60ad3e2ab17d2781284
2024-12-16 23:39:24 +00:00
mpodolian 5391e14c3e Added an onClick listener to the bubble bar.
Previously, clicks were not handled because no listener was set on the
bubble bar.

Fixes: 383622825
Test: Manual. Ensure bubbles are on the home screen and set the
navigation mode to 3-button navigation. Click on the collapsed bubble
bar and observe the bar expanding.
Flag: com.android.wm.shell.enable_bubble_bar

Change-Id: I99e1c20e40a9dd9da97b68817734c8ca1f656baa
2024-12-16 15:16:15 -08:00
Charlie Anderson 3eec1895ed Prevent bad grid configuration by making sure RestoreDbTask updates IDP correctly.
IPD#reset() was resetting the internal IDP dbFile to the factory default instead of current grid/db

This lead to LoaderTask and grid migration creating an empty DB for the wrong grid size, while the restored DB remained unused. Leading to an empty home screen because an empty DB file was used.

Bug: 377510898
Flag: EXEMPT bugfix
Test: manually testing backup & restore with various grid sizes
Change-Id: I709201e484afb8f12a4fde21198d2c5793d89ca1
2024-12-16 14:39:41 -08:00
Brandon Dayauon 9f481bb2ea Merge "Fix swipe up to home gesture when entering scheduler page" into main 2024-12-16 13:07:04 -08:00
Liran Binyamin 6592d90003 Merge "Fix bar visibility after dismissing while stashed" into main 2024-12-16 10:05:39 -08:00