Commit Graph

73841 Commits

Author SHA1 Message Date
Sunny Goyal 4b67d7f47f Adding an abort listener in app launches to clear state
Bug: 318394698
Test: Verified on device
Flag: None
Change-Id: Ib6108782429abb5dfd9c4e42246e4a93ddf10f55
2024-01-26 17:16:31 +00:00
Himanshu Gupta eaeb666e43 Merge "Separating system and user-installed apps in PS container." into main 2024-01-26 14:22:19 +00:00
Jakob Schneider fc433dd84d Merge "Test Fix: Move UnarchiveBroadcastReceiver to AndroidManifest-common to also support NexusLauncher tests." into main 2024-01-26 10:48:09 +00:00
Johannes Gallmann c9be821856 Merge "Fix TaplTestsQuickstep.testPressback failure (2)" into main 2024-01-26 08:48:41 +00:00
Himanshu Gupta 0cc11dbcac Separating system and user-installed apps in PS container.
We add a horizontal line separator in PS container which demarcates
user-installed vs system installed apps in private space.
User-installed are shown above the separator, system ones below.

UX Mock: https://www.figma.com/file/K6bIIcG882EiJNjxvSWsFT/V%E2%80%A2-Private-Space?node-id=11546%3A310574&mode=dev
Mock Image: https://photos.app.goo.gl/Wj8sJkS7P7bRbovg8
Demo video: https://photos.app.goo.gl/MBw6HpDnf6PJqUfs8

Bug: 308054233
Flag: ACONFIG com.android.launcher3.Flags.private_space_sys_apps_separation DEVELOPMENT
Test: AlphabeticalAppsListTest
Change-Id: Iad8e289c49a05ac7ef1978bd8e4ebe7aa0add0ca
2024-01-26 11:04:13 +05:30
Vinit Nayak 53eb01bcb5 Merge "Update split instructions text for contextual" into main 2024-01-25 23:25:58 +00:00
Andy Wickham af7ff56792 Merge changes from topics "awickham-api-cleanup", "keyboard-on-back" into main
* changes:
  Cleanup API checks for P, Q, and R.
  Add a WindowInsetsAnimationCallback to listen to IME changes.
  Update minSdk to 30.
2024-01-25 22:06:40 +00:00
Vinit Nayak d441d7d22e Update split instructions text for contextual
Test: Visually saw different string for contextual
Bug: 322117067
Flag: aconfig com.android.wm.shell.enable_split_contextual
Change-Id: I92b09bc47d29ba5dd83d09f78aaf8d67e855dd36
2024-01-25 13:28:06 -08:00
Tony Wickham 0961a69f61 Merge "Simplify/fix testThreeButtonsTaskbarBoundsAfterConfigChangeDuringIme" into main 2024-01-25 19:17:34 +00:00
Tony Wickham 58b3b5b52e Simplify/fix testThreeButtonsTaskbarBoundsAfterConfigChangeDuringIme
Instead of dealing with changing dark theme which can lead to races
with stale Taskbar icons, instead just go home and launch the IME
activity. This is sufficient because the taskbar height changes
when going between home and an app, and the IME will stash the
Taskbar during this transition.

Fixes: 320490387
Test: testThreeButtonsTaskbarBoundsAfterConfigChangeDuringIme
Flag: None
Change-Id: Ib5b1481751af0bf1fccda085c78174f6612441b9
2024-01-25 19:17:24 +00:00
Vinit Nayak e4826e9346 Merge "Prevent taskbar animation for contextual split from home" into main 2024-01-25 19:14:12 +00:00
Colin Cross 698a721de6 Merge "Set use_resource_processor: false" into main 2024-01-25 19:10:21 +00:00
Rohit Goyal 9977121e8e Test Fix: Move UnarchiveBroadcastReceiver to AndroidManifest-common to also support NexusLauncher tests.
* Currently unarchival tests only pass for Launcher3. We extend the broadcast receiver to AndroidManifest-common to also support NexusLauncher tests.

Test: atest TaplPromiseIconUiTest.java
Bug: 319240622
Flag: ACONFIG com.android.launcher3.enable_support_for_archiving DEVELOPMENT
Change-Id: I9be459a2a0648063d62538eed20c0a6e7644ad44
2024-01-26 00:40:17 +05:30
Brandon Dayauon b629cfef51 Merge "Change expand animation for private space container." into main 2024-01-25 18:48:31 +00:00
Sebastián Franco a808e7ea98 Merge "Moving ReorderPreviewAnimation into it's own file and rewrite to Kotlin." into main 2024-01-25 17:16:25 +00:00
Uwais Ashraf 6d4fe47e9e Merge "Set draw below recents to true when opening an app" into main 2024-01-25 08:10:44 +00:00
Himanshu Gupta d9026196d2 Merge "Restricting Accessibility flows for Private Profile." into main 2024-01-25 04:19:35 +00:00
Himanshu Gupta f591ce5f17 Restricting Accessibility flows for Private Profile.
Adding PS apps to the home screen is restricted.
This CL prevents the same from accessibility drags.

Bug: 289223923
Flag: ACONFIG com.android.launcher3.Flags.private_space_restrict_accessibility_drag DEVELOPEMENT
Test: Ran Launcher3 Tests.
Change-Id: I3e2b7b196b96a4d2ba34d8ece5fd6e0463f17253
2024-01-25 04:19:20 +00:00
Vinit Nayak febd61fb3f Prevent taskbar animation for contextual split from home
* Ideal animation TODO, this is to help
unblock for now.

Flag: Flag: ACONFIG com.android.wm.shell.enable_split_contextual DEVELOPMENT
Test: With flag on and off, from home, overview, all apps
Bug: 296351434
Change-Id: Ida743a881519796ed8ce3e5966aa708c84521c51
2024-01-24 19:46:30 -08:00
Sunny Goyal dff4231a67 Merge "Moving view inflation in Launcher to a separate class" into main 2024-01-25 01:13:12 +00:00
Saumya Prakash 12e11605fe Merge "Allow gesture tutorial to work for both orientations for square aspect ratios." into main 2024-01-25 00:48:50 +00:00
Tony Wickham ff08ceb595 Merge "Promote testQuickSwitchToPreviousAppForTablet to pre-submit" into main 2024-01-25 00:12:52 +00:00
Colin Cross f156b6bc7c Set use_resource_processor: false
These modules fail to compile when use_resource_processor is enabled
by default, disable them explicitly for now.

Bug: 319712088
Test: m javac-check
Flag: NA
Change-Id: I0f7ee108aab802ee1882f8017ea4b47346e38683
2024-01-24 15:52:06 -08:00
Saumya Prakash e3d14a686a Allow gesture tutorial to work for both orientations for square aspect ratios.
Devices with a square aspect ratio were previously seeing a prompt to rotate the screen for the gesture navigation tutorial. This change enables the tutorial for such devices but will still show the prompt to rotate the device if the aspect ratio would make the tutorial animations look wrong.

Flag: LEGACY ENABLE_NEW_GESTURE_NAV_TUTORIAL ENABLED
Fix: 321650001
Test: Tried gesture tutorial on various devices of different aspect
ratios and ensured that the prompt to rotate the device only shows up on
devices that do not have a square aspect ratio.

Change-Id: I7a6ca40e09a8202a9b54d898e0c68cc142694342
2024-01-24 23:39:39 +00:00
Sunny Goyal 4e0142328f Moving view inflation in Launcher to a separate class
Bug: 318539160
Test: Presubmit
Flag: None
Change-Id: Iacf9bec39c63cc7a31fae5628bb588ccb765663c
2024-01-24 15:06:31 -08:00
Andy Wickham b922dccbf5 Cleanup API checks for P, Q, and R.
Test: Build with gradle
Flag: NA
Change-Id: I3ef17090741d14bebd76cf09cf3dc5ac4f11e686
2024-01-24 14:58:08 -08:00
Tracy Zhou e49c26dd79 Merge "Use nearest region for all the nav buttons in 3-button folded mode" into main 2024-01-24 22:12:14 +00:00
Sebastian Franco f7654252b1 Moving ReorderPreviewAnimation into it's own file and rewrite to Kotlin.
This will make it easier to write unit testing.

Fix: 294473336
Test: manual testing
Flag: NA
Change-Id: I2d6cfd8110c5c2ef09c49150a0bd071bc948995c
2024-01-24 14:04:48 -08:00
Saumya Prakash 59b009e938 Merge "Increase Done button size to be more accessible for the gesture tutorial" into main 2024-01-24 19:35:51 +00:00
Tony Wickham a119f81854 Promote testQuickSwitchToPreviousAppForTablet to pre-submit
Fixes: 314873201
Test: testQuickSwitchToPreviousAppForTablet
Flag: None
Change-Id: I9d6b8b6aa1925f5133269a874cf7ca888c945ed3
2024-01-24 19:32:18 +00:00
Ats Jenk feb2b098cb Merge "Move bubble bar stashed handle to the left for RTL" into main 2024-01-24 19:22:58 +00:00
Tracy Zhou 9c9befae5f Use nearest region for all the nav buttons in 3-button folded mode
Bug: 230395757
Test: In 3-button folded mode, make sure that the touches that happen between nav buttons go to the nearest button. No regression in other modes.

Change-Id: Icb776a9a4ed4fc31d33dc3267c7053f2b0da0bfc
2024-01-24 11:06:01 -08:00
Sebastián Franco a37a99a156 Merge "Making sure the reorder animation goes back to the initial position." into main 2024-01-24 17:55:14 +00:00
Uwais Ashraf c69e52f70e Set draw below recents to true when opening an app
Test: Presubmits passing, checked cases manually. No automated checking
because it is an animation bug.
Fix: 316992943
Flag: NA

Change-Id: Ieb19571d081ba894842322ba77e76c31db57b98e
2024-01-24 11:56:05 +00:00
Vinit Nayak 5f3b761451 Merge "Rename isSplitSelectionEnabled() to isSplitSelectionActive()" into main 2024-01-24 05:53:44 +00:00
Holly Jiuyu Sun e5d943e848 Merge "[PS] Update resource files to include round background." into main 2024-01-24 03:53:28 +00:00
Ats Jenk e1701b05f0 Merge "Skip bubble bar arrow animation if arrow detached" into main 2024-01-24 01:23:49 +00:00
Ats Jenk 14f76fe13b Move bubble bar stashed handle to the left for RTL
When system language is set to an RTL language, we move the bubble bar
to the left.
Move the stashed bubble bar handle to the left in this case.
Tweak the bubble bar expand animation so that the bubbles expand from
the left edge.

Flag: LEGACY persist.wm.debug.bubble_bar DEVELOPMENT
Bug: 273310265
Test: repeat following steps with LTR and RTL system languages
  - add couple of bubbles to bubble bar, open an app, observe stashed
    handle on the left
  - swipe up from system navbar to show taskbar and bubble bar
  - swipe up from bubble bar handle to show bubble bar and expand it
  - drag bubble bar to dismiss target and back out and release
Change-Id: Ia3b7892bba732a5278168d63db0594087f55fad4
2024-01-23 17:16:49 -08:00
Tracy Zhou 05ca003b41 Merge "Do not enter stage split from keyboard shortcuts if the user is already in split" into main 2024-01-24 00:26:31 +00:00
Holly Jiuyu Sun 766b80bb91 Merge "[PS] Log event for private space add button click." into main 2024-01-24 00:03:21 +00:00
Andy Wickham a601341ff5 Add a WindowInsetsAnimationCallback to listen to IME changes.
This handles cases that were previously ignored, such as dismissing
the IME with the back key/gesture.

Removed extraneous manual state updates that were used for specific
cases previously. The only remaining state updates are from our
controlled IME animation in KeyboardInsetsHandler, as that correctly
handles the case where you start closing the IME but end up keeping
it open (or vice versa).

Bug: 277738379
Fix: 320659754
Test: Manually go through various IME transitions on Launcher,
open and close apps, lock/unlock, etc to verify keyboard state
is correctly updated. And verify b/320659754 steps do not repro.
Flag: NA

Change-Id: I4787afbb37eed815b909a0215d8afeb3894ab985
2024-01-23 15:56:37 -08:00
Andy Wickham b442235208 Update minSdk to 30.
Also update build.gradle to match.

Test: Build and install with gradle
Flag: NA
Change-Id: I74f2109a13cc662be2d66e472ff010a3acd139f5
2024-01-23 15:55:40 -08:00
Vinit Nayak 7c7ece3efe Rename isSplitSelectionEnabled() to isSplitSelectionActive()
Bug: 295467097
Change-Id: I5c518c3e7227c034956fb92590b7472ba4a71d39
2024-01-23 15:41:14 -08:00
Sebastian Franco e2910d84ee Making sure the reorder animation goes back to the initial position.
The animation ReorderPreviewAnimation handles two animations, one when
the mode is MODE_HINT and the other MODE_PREVIEW. The animation is
basically the same but MODE_PREVIEW ocilates to finalDelta and back
to initDelta. MODE_HINT stays in finalDelta. When finish, we have to
go back to the initial position.

This behaviour is currently done using logic, making sure the view stays
in finalDelta no matter the value of the animation, the bug is in this
logic. I think is better to do this with the current animation API by
setting setRepeatCount to 0 on the HINT case and reverting the animation
when finish so it goes back to the initial position.

This seems to have been there for a long time, at least since the
creating of git_main, but it became more aparent now. In a follow up cl
I will move this class to it's own file and into kotlin to help if there
are issues here again.

Fix: 294473336
Test: manual testing
Flag: NA
Change-Id: I4ac5de3ce8a8170944a072c6ce41c65d0963a780
2024-01-23 15:33:49 -08:00
Ats Jenk e0b2ef481c Skip bubble bar arrow animation if arrow detached
Arrow can become detached from the bubble bar background. This can
happen when bubble bar is pinned to the left and the right-most bubble
is selected. When the selected, right-most bubble is removed by drag and
dismiss, the view is removed and bubble bar background is immediately
updated. But we try to animate the arrow to the new selected position.
Before starting to animate arrow position, check if arrow position is
greater than bubble bar width. If it is, the arrow is detached and we
should not try to animate it to the new position. Just move it.

Flag: LEGACY persist.wm.debug.bubble_bar DEVELOPMENT
Bug: 273310265
Test: switch to RTL language, have 3 bubbles in bar, expand and select
  the right-most bubble, then dismiss it via drag, observe arrow jumps
  to new position and does not become detached from background
Test: switch to LTR language, try the same, 3 bubbles and dismiss the
  left-most bubble, observe arrow jumps the same and does not become
  detached
Test: select other bubbles, observe arrow position animates to the new
  position
Change-Id: I399db3c3e32b65b9125262bba0a0c32e45865bba
2024-01-23 15:18:09 -08:00
Ats Jenk 1721e8a7ae Merge "Bubble bar expland/collapse animation when on left" into main 2024-01-23 21:44:25 +00:00
Tracy Zhou 93ce09ac04 Merge "Add multitasking folks to launcher OWNERS" into main 2024-01-23 19:50:09 +00:00
Brandon Dayauon aa9005612b Change expand animation for private space container.
Only scroll to bottom. Don't use the animation.

bug: 299294792
test: manual:
video: https://drive.google.com/file/d/134Mq0MX0xauRfkNv8LGXOZgweRjqrmTa/view?usp=sharing
Flag: ACONFIG com.android.launcher3.Flags.private_space_animation TEAMFOOD
Change-Id: Ie6666638a53e334bddb1700674c2c49eb5788a06
2024-01-23 11:47:27 -08:00
Sebastián Franco 4d4c7e06eb Merge "Send ACTION_UP if there is an exception" into main 2024-01-23 18:40:53 +00:00
Sebastián Franco 4dc58c9d8b Merge "Send ACTION_POINTER_UP if there is an exception" into main 2024-01-23 18:40:33 +00:00