Commit Graph

19131 Commits

Author SHA1 Message Date
TreeHugger Robot 4ab6254bdc Merge "Adding some state for fallback recents View" into ub-launcher3-qt-dev 2019-06-05 21:40:38 +00:00
Zak Cohen 8d19146b7b Remove unused hints code.
This layout is handled by the provider of the hints now.

Bug: 132886768
Test: manual
Change-Id: Ifc0db2395a7503b1b03dcb796961ef6647c0413b
(cherry picked from commit f3231f417d)
2019-06-05 11:18:09 -07:00
Winson Chung ff9fe09b3f Merge "Use device locked input consumer when an activity is showing when locked" into ub-launcher3-qt-dev 2019-06-04 21:42:44 +00:00
TreeHugger Robot f17eb616a8 Merge "Some RecentsView layout fixes" into ub-launcher3-qt-dev 2019-06-04 21:34:19 +00:00
Sunny Goyal 1b52c7e5de Some RecentsView layout fixes
> Only creating task overlay for one view at a time
> Fixing setOverviewStateEnabled called twice when going
  between OVERVIEW and BACKGROUND state

Bug: 132815672
Bug: 122345781
Change-Id: I51ac5b0744af87194eca08e07fd2c75b8fa0d3e0
2019-06-04 14:17:30 -07:00
Winson Chung ed6a3eada7 Use device locked input consumer when an activity is showing when locked
Bug: 133871965
Change-Id: I51a32a99990813e510c757e5e295a09f041c0514
2019-06-04 10:40:31 -07:00
TreeHugger Robot 8789aa05a1 Merge "Fixing All Apps's getting stuck in a non-updating state" into ub-launcher3-qt-dev 2019-06-04 16:37:58 +00:00
vadimt 3ca5280186 Fixing All Apps's getting stuck in a non-updating state
Normally, if all apps is open, and an app installs/uninstalls/updates,
All Apps will immediately reflect this.

However, depending on something subtle in the intensity of the swipe
gesture that brought All Apps, all apps will freeze, and won't update.

This frozen state will go away after scrolling in all apps, iteration
with an icon and, generally, any tap interaction with All Apps.
Otherwise, it will stay until it's closed and opened again via a gesture
with a different pattern.

The reason is in the code that freezes All Apps updates during user
interactions with all apps.

For example, during scrolls. Or while the user holds an icon, expecting
to see a context menu; in this case an update would cause the menu to
not appear, which is somewhat annoying.

The motivation to add this code was to solve a category of lab-only
flakes when a context menu couldn't open because the lab device was busy
with post-flash activities.

The code incorrectly assumed that after ACTION_DOWN, we are guaranteed
to get either UP or CANCEL, which is wrong.

It's after *consumed* ACTION_DOWN that we'll get these events.

The fix still solves the user's and tests' problems that the code was
supposed to solve.

Bug: 134442147
Change-Id: I9db74a33ecf93b1dc6bc69df301f7f542dea2a40
2019-06-03 18:35:52 -07:00
TreeHugger Robot ce0c093133 Merge "Removing user locked change in LauncherAppState" into ub-launcher3-qt-dev 2019-06-03 23:44:58 +00:00
Sunny Goyal d17a951df8 Removing user locked change in LauncherAppState
The process will crash anyway when loading sharedPreference. So
we do not need any extra check to cause the same crash.

Bug: 134094839
Change-Id: Icfd4406ff601d6b9a75bd95ddcecb9869f7e7fa2
2019-06-03 23:19:02 +00:00
Sunny Goyal 9d8b1376e8 Adding some state for fallback recents View
Maintaining a boolean corresponding to overview or QuickSwitch which
updates the visuals for RecentsView accordingly

Bug: 134166337
Change-Id: If1aec99257de4db1796335f2cf39d2d35789915b
2019-06-03 16:00:06 -07:00
Hyunyoung Song ed45267bf9 Merge "Add shape detection logic only for circle icons" into ub-launcher3-qt-dev 2019-06-03 22:34:02 +00:00
Hyunyoung Song f69426c484 Add shape detection logic only for circle icons
b/119330044

Change-Id: I93042effa8417167d844f073275e8b941e861e60
2019-06-03 14:05:20 -07:00
Adam Cohen acdde3d750 Fix issue where Workspace scrolling doesn't work
=> The WorkspaceTouchListener was relying on receiving TOUCH_DOWN in order to
   clear its state. This is not guaranteed; ie. when touches begin above
   children of the workspace (icons or widgets)

=> Any invocation of the Workspace long press menu would trigger this issue
   and it would persist until a touch went directly onto the Workspace in a
   location without any children.

Bug 132298752

Change-Id: Id8617baaa1ce59dc84758a7c82049329323b04cc
2019-06-01 17:16:59 -06:00
TreeHugger Robot 72c6e7b736 Merge "Fix getting stuck in BackgroundAppState for 2-button mode" into ub-launcher3-qt-dev 2019-05-31 23:22:30 +00:00
Tony Wickham a04e746e84 Fix getting stuck in BackgroundAppState for 2-button mode
When ending in recents, we reapply the state - therefore, it's important
to make sure we are in OverviewState before onSwipeUpComplete(). This is
done by mLauncherTransitionController, which sets OverviewState on end.
We already force mLauncherTransitionController to end before calling
onSwipeUpComplete(), but in this case we were calling cancel() and
setting mLauncherTransitionController = null, which meant we could never
call end() on it. Instead, we should always call end() if we set it to
null.

Also ensure mLauncherTransitionController is created even if the gesture
is completed, if an existing controller isn't already running. This can
happen if you swipe up quickly enough that we get onGestureEnd before
launcher is drawn, and in that case we still want the launcher component
to animate once its ready. This is even more important for 2-button
mode, because again, we rely on mLauncherTransitionController to set the
state to OverviewState before we reapply it.

Finally, clarified some methods by renaming "swipeUp" to
"swipeUpToRecents".

Bug: 132757019
Change-Id: Ieb24a4f36a39780e5d64d7bc312791608db474d1
2019-05-31 16:11:40 -07:00
TreeHugger Robot 061c43eb4f Merge "Fixing overview scrim not initialized properly when launcher starts" into ub-launcher3-qt-dev 2019-05-31 23:01:36 +00:00
TreeHugger Robot 045dc86d9f Merge "Disable chips in qt_dev" into ub-launcher3-qt-dev 2019-05-31 22:12:40 +00:00
Perumaal S 464dda250b Disable chips in qt_dev
- Not for use in qt_r1_dev

Bug: 134164918
Change-Id: Ib49289060a39a1a5615e762a4e72b105ed166135
2019-05-31 21:28:46 +00:00
Vadim Tryshev 719908c84b Merge "More debug tracing for switching to all apps not sending the final event" into ub-launcher3-qt-dev 2019-05-31 21:20:21 +00:00
vadimt a8f77a6afd More debug tracing for switching to all apps not sending the final event
(to the test)

Bug: 134172603
Bug: 133867119
Change-Id: I00cf3a35daefa23d2e72a89d21e6ce37c8a9a46d
2019-05-31 13:34:24 -07:00
Vadim Tryshev 43522d25f2 Merge "Annotating hierarchy dump for the error description" into ub-launcher3-qt-dev 2019-05-31 18:54:02 +00:00
vadimt 8fcf7059ed Annotating hierarchy dump for the error description
Change-Id: I10285d451f4816b4988ce0645669b9ec9cceac81
2019-05-31 11:32:09 -07:00
Govinda Wasserman 164ebb2e8c Merge "Adds trigger for new gesture entrypoint to Assistant bundle" into ub-launcher3-qt-dev 2019-05-31 18:09:53 +00:00
Sunny Goyal 03d32ddb23 Fixing overview scrim not initialized properly when launcher starts
State UI depends on visible content, which can change due to predicitons.
Reapplying the state whenever then happens ensures that we are in correct
start UI

Change-Id: I9f195a92b747fda8a5b217dc960f230d7a695255
2019-05-31 11:00:35 -07:00
Tony Wickham 8765e262c2 Merge "Don't recreate the launcher animation controller if gesture ended" into ub-launcher3-qt-dev 2019-05-31 17:46:03 +00:00
Tony Wickham 436d5971b1 Don't recreate the launcher animation controller if gesture ended
This can happen if we get onApplyWindowInsets() after onGestureEnded().
In that case, we can get into some bad states because the running
animation is overwritten and thus can't be canceled.

Bug: 134096917
Bug: 133806285
Change-Id: Ic517d68a46a4446ca382445df1ba62c26e8243ad
2019-05-31 10:21:28 -07:00
Govinda Wasserman 254be7b0e4 Adds trigger for new gesture entrypoint to Assistant bundle
BUG:130186141
Change-Id: I43a4c3d3c9a46b4a1a5c53a81b037ba2be194188
FIX:130186141
2019-05-31 12:20:50 -04:00
Sunny Goyal 33838e8a2f Letting touch pass even in disabled states
In disabled states, dragLayer should not receive touch anyway. Removing
the additional check to avoid user getting stuck.

Bug: 134062513
Change-Id: Id31a31254377e9a737ecd6e9905e66c54e4eb740
2019-05-31 08:56:13 -07:00
TreeHugger Robot f36e5e002a Merge "Fixing interactive state for background states and notifying LauncherCallback accordingly" into ub-launcher3-qt-dev 2019-05-31 06:01:25 +00:00
Jon Miranda 2ff7b53ec5 Fix bug where QSB flickers on app close.
Bug: 123900446
Change-Id: I9b03b2d91d264de237328511b5406e5fcd22dbac
2019-05-30 20:53:27 -07:00
TreeHugger Robot 958cc0657f Merge "Tuning app open/close animation." into ub-launcher3-qt-dev 2019-05-31 02:04:03 +00:00
Jon Miranda b3c9077c76 Tuning app open/close animation.
* Mostly value changes.
* Added a way to round the corners during swipe up to home animation.

Bug: 123900446
Change-Id: Id61d241d919ba51ced0633585e36b7d93efe30b0
2019-05-30 18:43:22 -07:00
TreeHugger Robot ba33d1d216 Merge "If y velocity > x velocity in 2-button mode, go to recents" into ub-launcher3-qt-dev 2019-05-31 00:49:10 +00:00
Tony Wickham 1689d65ac3 If y velocity > x velocity in 2-button mode, go to recents
Also, when landing in recents, snap to the nearest page so that swipe up
consitently goes to task 0 instead of sometimes scrolling to task 1.

Bug: 133518678
Change-Id: I63a161a9f1f87266d3c3fc71c98cd5fc5e2f8874
2019-05-30 17:38:46 -07:00
Sunny Goyal f4fa4be5d6 Merge "Disabling horizontal swipes if the app has draggable content at the bottom" into ub-launcher3-qt-dev 2019-05-30 22:29:05 +00:00
Vadim Tryshev 5d7dbd914a Merge "Waiting for the recycler to populate when opening all apps" into ub-launcher3-qt-dev 2019-05-30 22:20:49 +00:00
Sunny Goyal 38d8a63d07 Disabling horizontal swipes if the app has draggable content at the bottom
Bug: 133844237
Change-Id: I67a4140d56f87c464e436d394da77127a965c3e5
2019-05-30 15:13:09 -07:00
vadimt 55da87181c Waiting for the recycler to populate when opening all apps
Change-Id: Ia6d452f9b02f02c1414eaaa9eaee9a70a4664a4a
2019-05-30 14:55:26 -07:00
Sunny Goyal e9c6f4cc69 Fixing interactive state for background states and
notifying LauncherCallback accordingly

During quick switch Launcher can get resumed only to be paused again
when launching a new app. Updating the logic for deferred resume to
account for that and moving some additional calls to deferredResume

Bug: 134062513
Change-Id: Ia607f178bc17d45d53fb032a06cd70f9abc6b513
2019-05-30 11:59:29 -07:00
Jon Miranda a1898247ca Hide original icon immediately for app close.
Bug: 123900446

Change-Id: I12d906267dafe80a9dc5d5e39452bddd95b0f748
2019-05-30 11:24:29 -07:00
TreeHugger Robot efd5f86a0a Merge "Hide original icon immediately for app close." into ub-launcher3-qt-dev 2019-05-30 18:06:24 +00:00
Vadim Tryshev 5f642bf783 Merge "Adding debug tracing for a lab-only issue" into ub-launcher3-qt-dev 2019-05-30 17:58:04 +00:00
TreeHugger Robot cae0a80c83 Merge "Disabling seamless rotation in multiwindow mode" into ub-launcher3-qt-dev 2019-05-30 17:47:51 +00:00
Vadim Tryshev 1c9b6293c8 Merge "Add debug tracing for a lab-only flake" into ub-launcher3-qt-dev 2019-05-30 17:46:10 +00:00
Sunny Goyal da14cf8b9f Disabling seamless rotation in multiwindow mode
Bug: 133765491
Change-Id: If68c709fa5b8216d63fc516f16f03bf2aa83172a
2019-05-30 10:32:11 -07:00
vadimt 26185e1fed Adding debug tracing for a lab-only issue
Task doesn't get resumed upon clicking at it.

Bug: 133765434
Change-Id: I8c5c1308041949d94c6982c78b8337ea81ad400f
2019-05-30 10:30:32 -07:00
TreeHugger Robot f07cf179dc Merge "More debug tracing for RemoteActionShortcut" into ub-launcher3-qt-dev 2019-05-30 05:40:01 +00:00
Vadim Tryshev a993c2bf52 Merge "Printing TouchInteractionService state on test failures" into ub-launcher3-qt-dev 2019-05-30 01:34:54 +00:00
vadimt 6f871d423b More debug tracing for RemoteActionShortcut
Change-Id: If7bbc0817f4a833243f46ca15dde86ffc573ab58
2019-05-29 18:33:06 -07:00