892ffb8b15
Merge "Making 2 flags read only since they are used on backup and restore" into main
2024-03-14 20:12:05 +00:00
f6fd1f3d46
Merge "Fix bug where folder with 1 icon can exist" into main
2024-03-14 20:02:04 +00:00
5ea61960ab
Making 2 flags read only since they are used on backup and restore
...
The flags are narrow_grid_restore and grid_migration_fix.
Flag: ACONFIG enable_grid_migration_fix enabled
Flag: ACONFIG enable_narrow_grid_restore enabled
Bug: 325286145
Bug: 325285743
Test: BackupAndRestoreDBSelectionTest.kt
Test: GridMigrationTest.kt
Change-Id: Ia6a439553c3c5098115144eae532342ce73be4f2
2024-03-14 17:16:51 +00:00
5645c3ec55
Fix bug where folder with 1 icon can exist
...
Fix: 329357132
Flag: NONE
Test: TaplDragTest
Change-Id: If381ff56e051c89e9f6162f8a44f8df9e2ae5060
2024-03-14 10:13:00 -07:00
719075b56c
Merge "Update min next page visible to 48dp" into main
2024-03-14 16:32:39 +00:00
69aa9a07ee
Merge "Disable two line text legacy flag." into main
2024-03-14 15:11:13 +00:00
a7bd5cf6ee
Merge changes I209e3ec7,If70df129 into main
...
* changes:
Change collapse to use adapterItems instead of getting the childCount()
Upon expanding, expand just enough so the header shows.
2024-03-13 22:49:02 +00:00
920d333e3a
Merge "In the case the gird migration goes to a taller grid keep the grid configuration" into main
2024-03-13 22:26:42 +00:00
2eaf15c37a
In the case the gird migration goes to a taller grid keep the grid configuration
...
For example going from 4x5 to 4x6 it will keep the 4x5 configuration
which fits in the 4x6 grid.
Also, it fixes GridMigrationTest which was flaky because of
how it sorted arrays.
Bug: 325286145
Flag: ACONFIG grid_migration_fix disabled
Test: NA
Change-Id: I6063e3c303320096f7429a3b1d909e107d2ef2a0
2024-03-13 11:13:38 -07:00
cf70589921
Merge "Enable tests which do not require any modification" into main
2024-03-13 15:42:07 +00:00
1a72429687
Merge changes from topic "preview-sizes" into main
...
* changes:
Limit the recommendations space in two pane picker
Update the widget previews to use the container sizes
Avoid cropping image previews.
Add preview container size helper to display previews in picker.
2024-03-13 13:32:05 +00:00
4ee1701fd1
Enable tests which do not require any modification
...
Fix: 329052420
Flag: NA
Test: Presubmits + :NexusLauncher:testGoogleWithQuickstepDebugUnitTest
Change-Id: I27e847c923076e4e978fd7359c9c62745d4f5f0a
2024-03-13 12:27:46 +00:00
927dd27ece
Update the widget previews to use the container sizes
...
Additionally, adjusts the margins on sides, to make space for displaying
multiple previews side by side.
As a result of this change, previews aren't cropped anymore (indirectly
also fixing b/317366201).
There is one more follow up pending - to limit the height of
recommendations in two pane sheet to only visible area to keep the
suggestions quick to look and concise. It will also help with better
scroll experience when size is same across pages.
* http://screencast/cast/NTQ0Njc4ODgyNjc5MTkzNnxjYzZiYTU2Ny02Yw
* http://screencast/cast/NTk4ODMyMDkxOTE1ODc4NHw3NzdlNTgxZS1kMw
* http://screencast/cast/NTYxOTc5NjIxNjM4MTQ0MHxiMjQ2Njc3OC0zOQ
* http://screencast/cast/NDk4MjIxNjI0MDEzNjE5MnxjY2IwYmIxNi00Mw
Bug: 319152349
Flag: N/A
Test: Image test and table utils test
Change-Id: I07465bd4d84597b560a2b998ff1ccbf9867c0192
2024-03-12 23:47:07 +00:00
c93f687f12
Avoid cropping image previews.
...
In most cases, cropping image-based previews to just fit width leads to
degraded UX. Instead we try to fit them to the widget size if possible.
* Before: See attached bug for examples of cropped previews.
* After: http://screen/Bg7Eoydr4qBQdVZ
Additionally center align previews vertically for non-categorized
suggestions too.
Bug: 319152349, 317366201
Flag: N/A
Test: Includes a unit test & manual with the child cls
Change-Id: I4447f99028129d5d5379ead9ca404f7a011d1551
2024-03-12 23:47:07 +00:00
a1dbbeab7e
Add preview container size helper to display previews in picker.
...
While we want previews to be displayed at true size, today, there is
less consistency among different widgets. This change is a first step
towards consistent sizes. In this change, we provide helper classes
that provide the size of the container in terms of grid spans.
Note: This does not change the size for rendering widget previews; but,
we take that original rendered preview and scale it maintaining the
aspect ratio to display it in one of closest container sizes.
Bug: 319152349
Flag: N/A
Test: Includes a unit test & manual with the child cls
Change-Id: I335373aa1be9a41fe039c98cded0113a007ad8c4
2024-03-12 23:47:07 +00:00
e9ebd2d70a
Merge "Revert^4 "Removing all restored backups except one so we don't have old backups"" into main
2024-03-12 22:00:36 +00:00
201626b553
Merge "Using LauncherApps API for PS Settings and Setup Flow." into main
2024-03-12 21:17:22 +00:00
be65a75e82
Merge "Check for null preview in WidgetItem.hasGeneratedPreview" into main
2024-03-12 19:15:59 +00:00
ad46eb75f4
Revert^4 "Removing all restored backups except one so we don't have old backups"
...
To prevent the error I introduce the method restorePreviousState().
This reverts commit 1234090589
2024-03-12 11:01:26 -07:00
0cd5024c6b
Merge "Debugging Logs for TaplTestsTransientTaskbar#testSwipeToStashAndUnstash" into main
2024-03-12 17:52:22 +00:00
7574bed02e
Merge "Update labels for the categories to match the UX writer provided strings" into main
2024-03-12 11:37:25 +00:00
8229228132
Debugging Logs for TaplTestsTransientTaskbar#testSwipeToStashAndUnstash
...
Add logging for TaplTestsTransientTaskbar#testSwipeToStashAndUnstash.
Flag: NONE
Test: Manually tested in pixel 7.
Bug: 324940434
Change-Id: I7c30fb2f3c94770fa79780d2e7748e931552ba56
2024-03-12 02:17:59 +00:00
616a1b828d
Using LauncherApps API for PS Settings and Setup Flow.
...
Bug: 310027945
Test: Launcher3 tests
Flag: ACONFIG com.android.launcher3.enable_private_space TRUNKFOOD
Change-Id: I6e04a4b0c33d4526d83b51e512e1e4372ce1cca4
2024-03-11 16:13:08 -07:00
03033273c0
Merge "Adjust mockito dependencies to make them work for Robolectric" into main
2024-03-11 22:56:04 +00:00
a64ce4eb71
Update min next page visible to 48dp
...
Fix: 326623964
Flag: NONE
Test: HomeScreenEditImageTest DeviceProfileDumpTest
Change-Id: I0a2de73589bf769eb2efb8d66d9ab3836cbee6d2
2024-03-11 22:40:40 +00:00
8a5dd1b3cf
Merge "Revert^3 "Removing all restored backups except one so we don't have old backups"" into main
2024-03-11 20:17:43 +00:00
1234090589
Revert^3 "Removing all restored backups except one so we don't have old backups"
...
This reverts commit 4b960d1f11
2024-03-11 20:15:24 +00:00
37e9aa2504
Merge "Revert^2 "Removing all restored backups except one so we don't have old backups"" into main
2024-03-11 17:09:21 +00:00
f7c9e2c112
Adjust mockito dependencies to make them work for Robolectric
...
Fix: 327257788
Flag: NA
Test: Presubmit passing
Change-Id: I1eee4fe0f79b2d22fc6bc080c8cc88c19086c7d5
2024-03-11 12:08:02 +00:00
bbdcade30d
Merge "Add testing for GridMigration." into main
2024-03-09 13:41:00 +00:00
68c18236ad
Disable two line text legacy flag.
...
Will now repurpose the twolinetoggle flag to be the flag that will
make twoline text enabled/disabled.
bug: 316027081
Test: presubmit
manually: https://screenshot.googleplex.com/BsZGCm7DrTZLwG4
Flag: com.android.launcher3.enable_twoline_toggle Staging
Change-Id: Idef427bad6551ae56b13e35393e076b8e000af5a
2024-03-08 21:32:22 -08:00
00110bce5f
Merge "Add logs for TaplAddConfigWidgetTest test" into main
2024-03-09 01:55:14 +00:00
52f2e98647
Check for null preview in WidgetItem.hasGeneratedPreview
...
AppWidgetManager.getWidgetPreview has been updated to return null
if the provider does not exist or the caller does not have permission to
access its previews. This change updates WidgetItem to check for that.
Bug: 308041327
Test: GeneratedPreviewTest#widgetItem_hasGeneratedPreview_nullPreview
Flag: ACONFIG com.android.launcher3.enable_generated_previews TRUNKFOOD
Change-Id: Ic2489c8698a81ba1bac005b2eb77348bcbfab999
2024-03-08 22:22:53 +00:00
25fc87b340
Merge "Remove expecting DOWN events in TAPL tests." into main
2024-03-08 21:43:04 +00:00
851b1f3b1c
Add testing for GridMigration.
...
Bug: 325286145
Flag: ACONFIG grid_migration_fix disabled
Test: GridMigrationTest
Change-Id: I49fd32be895f3a05204775373b9eec62d9026f3b
2024-03-08 14:46:41 -06:00
513437bdfa
Merge "Saving artifacts for failing initialization of PortraitLandscapeRunner" into main
2024-03-08 20:18:11 +00:00
20a5f4e8d1
Update labels for the categories to match the UX writer provided strings
...
Also fix issue that user was not passed when getting application info.
(error noticed by Zak)
http://screen/8fiiTSHvo2SfYdE
Bug: 318410881
Flag: N/A
Test: Unit test
Change-Id: Id85feec0d95d3d4d183a673f7eed40906b0043e2
2024-03-08 19:58:23 +00:00
4b960d1f11
Revert^2 "Removing all restored backups except one so we don't have old backups"
...
This reverts commit 3306fa5325
2024-03-08 18:53:57 +00:00
0f0c1dd30b
Merge "Revert "Removing all restored backups except one so we don't have old backups"" into main
2024-03-08 18:45:17 +00:00
3306fa5325
Revert "Removing all restored backups except one so we don't have old backups"
...
This reverts commit bd43b9344f
2024-03-08 18:42:30 +00:00
acdcaa21a0
Merge "Removing all restored backups except one so we don't have old backups" into main
2024-03-08 14:16:14 +00:00
ee39f393e7
Saving artifacts for failing initialization of PortraitLandscapeRunner
...
Test: presubmit
Flag: N/A
Bug: 321772674
Change-Id: Ifa865224ebdae160b4fbc75b587d893ac6bfd847
2024-03-07 18:28:21 -08:00
68c145a14b
Merge "Clearing All Apps Search For ALL_APPS Intent" into main
2024-03-07 22:29:31 +00:00
461038d5d5
Remove expecting DOWN events in TAPL tests.
...
ACTION_UP is always preceded by ACTION_DOWN which means when launcher
receives an UP events, down event is obviously sent.
In b/325377690 , we started seeing only in P9 devices the DOWN events didn't reach TAPL. I added InputDispatcher logs which shows both DOWN and UP events are sent by system_server to NexusLauncher.
However TAPL doesn't receive it. After spending lot of time debugging this, I think we are safe to remove DOWN event expectation in TAPL.
Bug: 325377690
Test: Manual, TAPL presubmits
Flag: NA
Change-Id: I6d3587c488d45e3dc53d2c1c4f3b6b49285eae94
2024-03-07 12:31:38 -08:00
73b07daab3
Add logs for TaplAddConfigWidgetTest test
...
Flag: NONE
Bug: 324419890
Test: Check logs when flake is reproduced
Change-Id: I2fdb1e4f96c8095a387280c79e074ee42eb0010c
2024-03-07 18:53:15 +00:00
bd43b9344f
Removing all restored backups except one so we don't have old backups
...
Adding test to make sure this is the case.
Bug: 325285743
Flag: ACONFIG narrow_grid_restore disabled
Test: BackupAndRestoreDBSelectionTest
Change-Id: I84c3a92f40598137d5c5c52d34af7583b384122c
2024-03-07 11:23:55 -06:00
d0bec45d37
Upon expanding, expand just enough so the header shows.
...
This issue only happens when there is a lot of private space apps that scrolling to the bottom
will not sure the private space header.
Formula to calculate how many rows to scroll to =
(appListHeight - privateHeaderHeight - headerProtectionHeight) / cellHeight.
bug: 299294792
Test:
manually - https://screenshot.googleplex.com/76UJPT2Jnpnp2Ab
before: it just scrolls all the way to the bottom
after: https://drive.google.com/file/d/1AbprxFm1RWTQKvpt7M4khbUfc1o6-XGF/view?usp=sharing
after PHONE WITH TABS:
2x2- https://drive.google.com/file/d/1SLPsWPHenCuZuisiS7HeEy5JwtNPeONs/view?usp=sharing
3x3- https://drive.google.com/file/d/1SK82jeNZMzFJK2odIuHnfTNLYfppne83/view?usp=sharing
4x4- https://drive.google.com/file/d/1T7EhFRq2tDv2zYIvs_FMsTKcFZXwGUaD/view?usp=sharing
4x5- https://drive.google.com/file/d/1SMUPuKjO1Yg36U6P6cDOb6dTkHn6Bh7D/view?usp=sharing
5x5- https://drive.google.com/file/d/1SJCQn1O_Yq5P7C__VUfZHc5I67CEdIpb/view?usp=sharing
AFTER PHONE NO TABS:
2x2: https://drive.google.com/file/d/1THU2xrAIt0hTmN5_GwBrgN9Lqj-W4Kfr/view?usp=sharing
3x3: https://drive.google.com/file/d/1TPTUx7PcHW3GsVwVAg_L5rCcn0QYoiY2/view?usp=sharing
4x4: https://drive.google.com/file/d/1TWVWpAX6bZp_JfFKtmXYO0askl4e5qKO/view?usp=sharing
4x5: https://drive.google.com/file/d/1TDJK-swmY3Y3C4ARH_2eljqUkBGEnD3e/view?usp=sharing
5x5- https://drive.google.com/file/d/1TBJtAynwvZrGyOc-29f637wyrJZpMXBJ/view?usp=sharing
Tablet:
landscape: https://drive.google.com/file/d/1SfyPdoUnCV7e7BWLnpxXWN2HiBOQkRo2/view?usp=sharing
portrait: https://drive.google.com/file/d/1SgZq0iE9WMvIFtc8mBb577nYlS9jBa_g/view?usp=sharing
Flag: ACONFIG com.android.launcher3.Flags.private_space_animation TRUNKFOOD
Change-Id: If70df1299572f8f2edc6376dd2a6df5d74287264
2024-03-06 18:04:09 -08:00
c6ae88f904
Use Matrix.setRectToRect() replace RectUtils.letterBox()
...
Bug: 284236964
Flag: aconfig launcher.enable_add_app_widget_via_config_activity_v2 DISABLED
Test: manual
Change-Id: Ia83f3415442c2359bffb1efcfd1ee96bf17ab9ff
2024-03-06 17:04:02 -08:00
7a4b8a4513
Further syncing Launcher3 atest XML config with the GCL one
...
Test: abtd
Flag: N/A
Bug: 271324404
Change-Id: I51f02c290fa2efba2d7dac68090105e67b017f51
2024-03-06 10:36:55 -08:00
7dea7f0b42
Merge "[2/n] Avoid flicker to drop a widget that needs a config activity" into main
2024-03-06 02:03:48 +00:00
Sebastián Franco
Federico Baron
Brandon Dayauon
Uwais Ashraf
Shamali Patwa
Himanshu Gupta
Willie Koomson
Treehugger Robot
Sukesh Ram
Anushree Ganjam
Vadim Tryshev
Fengjiang Li