Commit Graph

74673 Commits

Author SHA1 Message Date
Jakob Schneider 46df9dfec4 Fix NewApi warning
Bug: 329770619
Change-Id: I70268c0f1871e87d431c89ad057712e73051cebe
2024-03-15 11:38:53 +00:00
Colin Cross cfc013fd2d [automerger skipped] Fix more kotlin nullable errors in Launcher3 am: 70213c4c4a -s ours
am skip reason: Merged-In I88aec6fbc814be98f9ef048bbc5af889d0797970 with SHA-1 94fd07e5da is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/26586610

Change-Id: I6ac59df103f282c2e23b59f39b535f3f94d8bddb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-03-15 07:52:06 +00:00
Colin Cross 47f96771d1 [automerger skipped] Fix kotlin nullable errors in Launcher3 am: e07b293994 -s ours
am skip reason: Merged-In I26edfec35dca14abe90b08e3c74de0446eda95d2 with SHA-1 e892df24ca is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/26573403

Change-Id: I0c390a834906591b2cbb3a726d68f7b3f8469bc6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-03-15 07:51:58 +00:00
Colin Cross e69256c77b [automerger skipped] Fix kotlin nullable errors in Launcher3 am: 496b6fb7b7 -s ours
am skip reason: Merged-In I4525d0fa83a1db9cc5cff90f340fc3f863537c01 with SHA-1 70ca32bca2 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/26573402

Change-Id: I15609df5b4555289cfe008cef79cb83afb15b0eb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-03-15 07:51:44 +00:00
Fengjiang Li a34b40fa26 Merge "[Predictive Back] Support WidgetBottomSheet" into main 2024-03-15 06:54:01 +00:00
Fengjiang Li 78adef7601 Merge "[Predictive Back] Fix widget edu back swipe" into main 2024-03-15 06:53:10 +00:00
Anushree Ganjam 89b04395ff Merge "Enable Omnient master flags in client code." into 24D1-dev am: f774a101b6
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/26552350

Change-Id: I0e14a73098cb7b2dd202dc4dbd33dab73c1109ae
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-03-15 06:35:43 +00:00
Anushree Ganjam f774a101b6 Merge "Enable Omnient master flags in client code." into 24D1-dev 2024-03-15 06:09:00 +00:00
Fengjiang Li 7881183078 [Predictive Back] Fix widget edu back swipe
Fix: 329389275
Flag: aconfig com.android.launcher3.enable_predictive_back_gesture TEAMFOOD
Test: Manual - attach video to bug
Change-Id: Ia8fb438068b0d324f4a535ff9e8b05fec46138f1
2024-03-14 18:33:06 -07:00
Vinit Nayak a51a749bc9 Merge "Revert "Disable gestures when split apps are animating in from shell"" into main 2024-03-14 22:35:21 +00:00
Fengjiang Li ba8347d926 [Predictive Back] Support WidgetBottomSheet
Fix: 329713475
Flag: aconfig com.android.launcher3.enable_predictive_back_gesture TEAMFOOD
Test: Manual - attach video to bug
Change-Id: Iaa33eb55f69b572a9fb2a4fb92b763b691039dd6
2024-03-14 14:39:16 -07:00
Colin Cross 70213c4c4a Fix more kotlin nullable errors in Launcher3
Fix kotlin nullable errors that were exposed by setting the retention
of android.annotation.NonNull and android.annotation.Nullable to
class retention.

Bug: 294110802
Test: builds
Merged-In: I88aec6fbc814be98f9ef048bbc5af889d0797970
Change-Id: I158db4f57d46606d7152a438d68e2b9f4c0014d9
2024-03-14 14:12:51 -07:00
Colin Cross e07b293994 Fix kotlin nullable errors in Launcher3
Fix kotlin nullable errors that were exposed by setting the retention
of android.annotation.NonNull and android.annotation.Nullable to
class retention.

Bug: 294110802
Test: builds
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:2608381792389b60ba37c08afcea09dca3c6ff9c)
Merged-In: I26edfec35dca14abe90b08e3c74de0446eda95d2
Change-Id: I26edfec35dca14abe90b08e3c74de0446eda95d2

(cherry picked from commit e892df24ca)
Change-Id: I1099bc97725577ce34ea5b617365eaf6dec3d3be
2024-03-14 14:12:51 -07:00
Sebastián Franco 892ffb8b15 Merge "Making 2 flags read only since they are used on backup and restore" into main 2024-03-14 20:12:05 +00:00
Federico Baron f6fd1f3d46 Merge "Fix bug where folder with 1 icon can exist" into main 2024-03-14 20:02:04 +00:00
Treehugger Robot 40ccc6059a Merge "Fix KQS app launch through tapping" into main 2024-03-14 19:24:29 +00:00
Schneider Victor-tulias 08c2575802 Fix KQS app launch through tapping
KeyboardQuickSwitchView only ever has 2 direct children, and all of the task views we're actually concerned with are in a scrollview. removing the extra index handling as this is being handled properly downstream.

Flag: LEGACY ENABLE_KEYBOARD_QUICK_SWITCH ENABLED
Fixes: 328692760
Fixes: 304518513
Test: opened KQS and tapped all tasks (6 + overview)
Change-Id: I4e919cce7f1ab55822f93d34c1533062a71aa879
2024-03-14 19:18:49 +00:00
Schneider Victor-tulias 153dcde49b Merge "Update KQS task view layouts to new specs" into main 2024-03-14 19:17:33 +00:00
Vinit Nayak 13b537c461 Revert "Disable gestures when split apps are animating in from shell"
Revert submission 26481253-disableSplitAnim

Reason for revert: b/329523822

Reverted changes: /q/submissionid:26481253-disableSplitAnim

Change-Id: Iaa0f0ac2cd1bda198b0020eb7dc5785fa3504b8e
2024-03-14 18:38:53 +00:00
Sihua Ma 80a35cce2e Merge "Fix out-of-sync updates during grid change" into main 2024-03-14 18:09:15 +00:00
Pinyao Ting ebd958dc94 Merge "Remote legacy shortcut when failed to migrate" into main 2024-03-14 17:17:45 +00:00
Sebastian Franco 5ea61960ab Making 2 flags read only since they are used on backup and restore
The flags are narrow_grid_restore and grid_migration_fix.

Flag: ACONFIG enable_grid_migration_fix enabled
Flag: ACONFIG enable_narrow_grid_restore enabled
Bug: 325286145
Bug: 325285743
Test: BackupAndRestoreDBSelectionTest.kt
Test: GridMigrationTest.kt
Change-Id: Ia6a439553c3c5098115144eae532342ce73be4f2
2024-03-14 17:16:51 +00:00
fbaron 5645c3ec55 Fix bug where folder with 1 icon can exist
Fix: 329357132
Flag: NONE
Test: TaplDragTest
Change-Id: If381ff56e051c89e9f6162f8a44f8df9e2ae5060
2024-03-14 10:13:00 -07:00
Federico Baron 719075b56c Merge "Update min next page visible to 48dp" into main 2024-03-14 16:32:39 +00:00
Tony Wickham 7233d2a0e0 Merge "Avoid playing taskbar haptic when swiping up from home" into main 2024-03-14 16:20:34 +00:00
Luca Zuccarini bb937b2556 Merge "Introduce a new Home animation for workspace and the outgoing task." into main 2024-03-14 16:11:46 +00:00
Andreas Agvard 576454212c Merge "Removes recovery" into main 2024-03-14 15:51:32 +00:00
Rohit Goyal cbb8328272 Merge "Bugfix: Add null safety when accessing icon database for main activities for LoaderTask loadAllApps." into 24D1-dev am: aca99b60ab
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/26554316

Change-Id: I53fc3448db4f8fdbf861df4b6b37f4177faa815e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-03-14 15:43:11 +00:00
Rohit Goyal aca99b60ab Merge "Bugfix: Add null safety when accessing icon database for main activities for LoaderTask loadAllApps." into 24D1-dev 2024-03-14 15:22:04 +00:00
Brandon Dayauon 69aa9a07ee Merge "Disable two line text legacy flag." into main 2024-03-14 15:11:13 +00:00
Treehugger Robot 2b97a7cd13 Merge "Set next page immediately on subsequent arrow/tab presses when navigating overivew." into main 2024-03-14 12:19:17 +00:00
Luca Zuccarini c9cbc9d5a1 Introduce a new Home animation for workspace and the outgoing task.
The values are currently the same for all display and orientation
configurations, but they might change before launch.

There are a couple known imperfections:
* Swiping out of a hotseat app with very low velocity doesn't look
  great
* Sometimes, if the window movement reaches its final location faster
  than the background is done scaling, there is a small snap in icon
  position

Bug: 298089923
Flag: ACONFIG com.android.launcher3.enable_scaling_reveal_home_animation DISABLED
Test: verified with the flag on and off

Change-Id: Id54c7f0a76f62108d8b92a3b5e78634fff64dbef
2024-03-14 10:48:02 +00:00
Jordan Silva d640a152cd Merge "Converting orientation handler classes to kotlin" into main 2024-03-14 10:03:07 +00:00
Schneider Victor-tulias 06e819d61c Merge "Close the KQS view when touching the gesture nav region" into main 2024-03-14 02:35:42 +00:00
Pinyao Ting f5505bf50e Remote legacy shortcut when failed to migrate
Bug: 329421105
Test: manual
Flag: NA
Change-Id: I84071a1711a36a49ad2ef71dc017ae78e4dd1267
2024-03-13 23:48:18 +00:00
Schneider Victor-tulias 14d912b062 Close the KQS view when touching the gesture nav region
Also, stop handling KQS open/close during gestures

Flag: LEGACY ENABLE_KEYBOARD_QUICK_SWITCH ENABLED
Fixes: 328689890
Fixes: 328689534
Fixes: 328692760
Test: attempted gestures while KQS is shown. attempted KQS while attempting gestures
Change-Id: Idbd1f9cef09d9fbf611350d0847d94ccf8300369
2024-03-13 19:02:29 -04:00
Vinit Nayak 3364a1ffee Merge "Disable gestures when split apps are animating in from shell" into main 2024-03-13 22:58:16 +00:00
Brandon Dayauon a7bd5cf6ee Merge changes I209e3ec7,If70df129 into main
* changes:
  Change collapse to use adapterItems instead of getting the childCount()
  Upon expanding, expand just enough so the header shows.
2024-03-13 22:49:02 +00:00
Sebastián Franco 920d333e3a Merge "In the case the gird migration goes to a taller grid keep the grid configuration" into main 2024-03-13 22:26:42 +00:00
Sihua Ma f418b2e16d Fix out-of-sync updates during grid change
This is a combination of two issues:

1. Widget updates are not passed to the holder when the launcher binding starts
2. Updates from widgetHost.startListening() are overriden by out-of-date info

Fix: 322919716
Test: Manual
Flag: N/A
Change-Id: I9665117412c87b19ed5d98263bb4f9b8da21c5c7
2024-03-13 15:21:34 -07:00
Tony Wickham d1915657cc Avoid playing taskbar haptic when swiping up from home
Only play the haptic if the stashed value actually changed. In the
case of home-to-overview, taskbar is unstashed already.

Fixes: 314311118
Flag: none
Test: Manual, feel for haptics during home-to-overview
Change-Id: I36f70740d35bd98feafbb3980f861db16705b1da
2024-03-13 21:39:10 +00:00
Saumya Prakash 42557fe547 [automerger skipped] Merge "Ensure taskbar insets for camera cutout only apply on the needed sides" into 24D1-dev am: 8a85cb5c9b -s ours
am skip reason: Merged-In Iba766b8a19ddce37d9ca20afb0219d679ce36ace with SHA-1 ad5e4c7956 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/26559384

Change-Id: I2e9544dfa53fd20033645fd0b09e8d3638c02185
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-03-13 20:31:52 +00:00
Saumya Prakash 113655615e [automerger skipped] Ensure taskbar insets for camera cutout only apply on the needed sides am: e46e12c0f6 -s ours
am skip reason: Merged-In Iba766b8a19ddce37d9ca20afb0219d679ce36ace with SHA-1 ad5e4c7956 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/26559384

Change-Id: I14561946234210b9813c683ef5db3245a0eecb88
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-03-13 20:31:49 +00:00
Saumya Prakash 8a85cb5c9b Merge "Ensure taskbar insets for camera cutout only apply on the needed sides" into 24D1-dev 2024-03-13 20:12:47 +00:00
Winson Chung b5c4820a5b Merge "Change existing callers to use no matching id constant" into main 2024-03-13 19:11:20 +00:00
Winson Chung 30a9a212cd Change existing callers to use no matching id constant
- Otherwise it can unintentionally match a predicted icon

Fixes: 329353320
Test: None
Change-Id: I9e46126d5fe45a50d4a36140f7ce0317cd2b1b23
2024-03-13 19:11:03 +00:00
Schneider Victor-tulias dba7cbae1a Update KQS task view layouts to new specs
The small size of the screenshots and make text look odd. Implementing new UI specs to improve this.

- Updated icon position and size
- Added some blur to the thumbnail

Flag: LEGACY ENABLE_KEYBOARD_QUICK_SWITCH ENABLED
Fixes: 328259439
Fixes: 328692456
Test: opened KQS in dark and light mode
Change-Id: I2b20100ddeb562291edf5f0bacbce916002eee45
2024-03-13 15:03:45 -04:00
Jordan Silva 68d8275949 Converting orientation handler classes to kotlin
This conversion is a first step for the alignment bug fix and cleanup of the fake orientation classes. The goal is to have these classes following the new architecture using Kotlin, smaller, and testable.

Bug: 320314835
Bug: 328028913
Flag: N/A
Test: presubmit. manual.
Change-Id: If0d12ff8c69eca5528fbb6b092bddefd20bc37ba
2024-03-13 18:32:20 +00:00
Sebastian Franco 2eaf15c37a In the case the gird migration goes to a taller grid keep the grid configuration
For example going from 4x5 to 4x6 it will keep the 4x5 configuration
which fits in the 4x6 grid.

Also, it fixes GridMigrationTest which was flaky because of
how it sorted arrays.

Bug: 325286145
Flag: ACONFIG grid_migration_fix disabled
Test: NA
Change-Id: I6063e3c303320096f7429a3b1d909e107d2ef2a0
2024-03-13 11:13:38 -07:00
Pat Manning a9a11b47c3 Set next page immediately on subsequent arrow/tab presses when navigating overivew.
This allows the user to scroll as quickly as they want.

Fix: 328749622
Test: manual
Flag: NONE
Change-Id: I493841f11407e6fb9f15fd90b5a5e55fa4ed3ad3
2024-03-13 17:43:10 +00:00