Instead of instantiating a new OVerviewComponentObserver, instantiate
one in QuickstepLauncher and pass it down to relevant classes.
Test: Manual
Bug: 336155199
Flag: ACONFIG com.android.window.flags.enable_desktop_windowing_mode DEVELOPMENT
Change-Id: Ifcc40c63f0649544a92e7f6d4a00d9edcd9f7fe1
* Remove Launcher state manipulation from `DesktopVisibilityController`
* Remove Taskbar state updates for desktop mode in
`LauncherTaskbarUIController`
* Update app widget animation for Home transision
* Update `RemoteTargetGluer` remote targets setup for Dekstop mode
Bug: 309014605
Flag: ACONFIG com.android.window.flags.enable_desktop_windowing_wallpaper_activity DEVELOPMENT
Test: manual
Change-Id: Ie2a7ad214a4d4e7e642d1236f2375ba6d17f3781
Unlike normal activity, recents would receive key event from input
consumer instead of go throught ViewRootImpl, so when adapt to
predictive back API, recents should try to handle back key when receive
key event.
Flag: ACONFIG launcher.enable_predictive_back_gesture ENABLED
Bug: 333428882
Test: switch to 3-button mode, go to live tile, verify back key can
dismiss recents.
Change-Id: Ibe6d9b2475a0b89b12dc4b34251a2a92926b5a4e
Revert submission 26911513-revert-26414135-RecentsViewContainer-MEROZZOKJQ
Reason for revert: Fix for issue has been found and will be included in this revert.
Reverted changes: /q/submissionid:26911513-revert-26414135-RecentsViewContainer-MEROZZOKJQ
Change-Id: I517e7d2fc0d82d250a6ed40862dd31c194d0a302
Revert submission 26414135-RecentsViewContainer
Reason for revert: Probable culprit for b/333767026. Will be verifying through ABTD for confirmation and before submitting the revert.
Reverted changes: /q/submissionid:26414135-RecentsViewContainer
Change-Id: I25775cd6531355f1dc042ddb7a8d442ee0b36e58
This change will let us move from activity to other parent views for recent views.
Summary: In prep for new recentsview containers outside of activity we needed to decouple recentsview from activity and state.
This change will let us move from activity to other parent views for recent views.
Test: Built and tested locally for 1p and 3p launchers on tablet, and portrait modes. Verified working functionality.
Bug: 292269949
Flag: NONE
Change-Id: I5c72745f438d466362ece988c35a97d829e9c1b4
- mDesktopVisibilityController will now be null if desktop windowing flag is disabled
- As a result, all code that uses mDesktopVisibilityController no longer need to check desktop windowing flag
- DesktopTaskView/DesktopTask only populates when flag is enabled, so we don't need to check flag if we already check DesktopTaskView/DesktopTask
- Removed the flag check in SplitToWorkspaceController, as we shouldn't enable split from workspace base on desktop windowing, contextual split already have its own flag
- Also avoid creating GroupTask or DesktopTask for freeform tasks when flag is off, to avoid a crash in RecentsView
Bug: 332655617
Test: manual with desktop windowing flag on/off
Flag: ACONFIG com.android.window.flags.enable_desktop_windowing_mode DEVELOPMENT
Change-Id: I0e45f73ad2b0d99dfb4ec3215f973679ca93957c
IHomeTransitionListener was only used when the visibility state changes, but not
when the taskbar is recreated during rotation. Instead we create a static listener
to keep track of current home visibility state
Bug: 331947346
Bug: 331947116
Flag: aconfig use_activity_overlay staging
Test: Manual
Change-Id: Icf613f7fc4f78e3f76a600202687b069d53a16dd
- Use Flags.eanbleDesktopWindowingMode directly
- Also clean up unnecessary and improper flag usage
Bug: 309008406
Flag: ACONFIG com.android.window.flags.enable_desktop_windowing_mode DEVELOPMENT
Test: presubmit
Change-Id: I86ce317ce577f279d2ce819d6dc1738204c2631e
* Added finishCallback consumer to LauncherAccessibilityDelegate
to inform when adding an item to workspace was completed.
* The logic seemed to be dependent on the parameter
"focusForAccessibility", but all callers of that are currently
passing in true
Bug: 328646540
Test: https://paste.googleplex.com/6232597136408576
Newly added CUJs showing up when playing w/ device
Change-Id: Ia4944f8d23634bb92296938ea2d07a6babf6f77c
* Added finishCallback consumer to LauncherAccessibilityDelegate
to inform when adding an item to workspace was completed.
* The logic seemed to be dependent on the parameter
"focusForAccessibility", but all callers of that are currently
passing in true
Bug: 328646540
Test: https://paste.googleplex.com/6232597136408576
Newly added CUJs showing up when playing w/ device
Change-Id: I5dce4b7e83fb17cc3a70565bfd5ce100a4cf72bb
With ag/26349940 we have fixed the bug where back swipe is not working
Fix: 326118348
Test: this is the test
Flag: NONE
Change-Id: I7e826f6ba3022a04d016d4a0a2134e287d85e8be
* We weren't specifying an animation duration for the
dismiss placeholder animation, and it wasn't inheriting
from the animatorSet since that didn't have any duration
set on it.
* Now we explicitly set a duration (usually matching that of
the current launcher state config) to the timings line up
well
Test: Repro steps don't show bug. Also tested on large screen dismissing
contextual split from overview and home, seems fine
Fixes: 314860754
Change-Id: I701e4f88c1ddd92561da4fb76715a859f587c91e
The predictive back infra checks the opt-in status when a callback is registered, and drops the registration if the Application / Activity is not opted-in
Fix: 326627953
Test: manual
Flag: ACONFIG launcher.enable_predictive_back_gesture DISABLED
Change-Id: I8f2e2378d0bf966b3784cf08c12045509b6d5682
Bug: 321923510
Bug: 321968468
Flag: ACONFIG com.android.systemui.predictive_back_system_animations TEAMFOOD
Test: Manual, i.e. verifying that recents transition is not invokable during the predictive back to home animations and instead the flickerless overview transition is is invoked (same as for regular back-to-home)
Change-Id: I90029de8d0c98853d38ed8984cbe7cda3b566b5a
Updated KQS to allow launching tasks through OverviewCommandHelper to allow launching the overview task without it having focus.
Flag: LEGACY ENABLE_KEYBOARD_QUICK_SWITCH ENABLED
Fixes: 324888738
Fixes: 324904244
Test: used enter and tap to launch tasks in KQS
Change-Id: I6de38ceea22c362a52a420c8ba0165ba23e5c862
* Now we log the original source of the first selected app
as soon as the user selects it (previously we only did when user
selected second app)
* We log the item info for the second app to determine second
surface.
* Added new metrics to log after user has started a split session
and ended a split session
* We log different cancellation reasons (cancel button,
home gesture, general other app interruptions, etc).
* One KI/Bug: When the second app is selected via taskbar in
overview, the container will say hotseat because we are using
Launcher's logger and not Taskbar's. Taskbar's logger manually
overwrites the container in TaskbarActivityContext, we may be
able to make something hacky that can allow us to overwrite, but
that'll have to be a separate change
Bug: 322551862
Test: Logged metrics manually with event and itemInfo
Change-Id: I177623fd00ce62acf2d4ee983b58561d8c946d59
* If we're in split selection state we disable the following
- G icon on PSB
- Lens icon on PSB
- Smartspace
- Widgets
Bug: 295467097
Test: Enter split contextual and observe split instructions
view going boing when tapping on unsupported target
Flag: com.android.wm.shell.enable_split_contextual
Change-Id: Ia7783472f3de9359c2784788be5f35596cbc8deb
This reverts commit febd61fb3f.
Reason for revert: b/323418145, testing to see if this is the culprit
Change-Id: Ie72ce0d24c6008e93340c1868b18bce68902c7cc
* Ideal animation TODO, this is to help
unblock for now.
Flag: Flag: ACONFIG com.android.wm.shell.enable_split_contextual DEVELOPMENT
Test: With flag on and off, from home, overview, all apps
Bug: 296351434
Change-Id: Ida743a881519796ed8ce3e5966aa708c84521c51
fbaron
Orhan Uysal
Brandon Dayauon
Ivan Tkachenko
wilsonshih
Randy Pfohl
Priyanka Advani
Alina Zaidi
Anushree Ganjam
Alex Chau
Sunny Goyal
Vinit Nayak
Liana Kazanova
Fengjiang Li
Schneider Victor-tulias
Johannes Gallmann