Commit Graph

80132 Commits

Author SHA1 Message Date
Sunny Goyal 430fd3104f Not calling updateCallback in constructor as it can cause initialization error
Bug: 390930809
Flag: EXEMPT bugfix
Test: atest ActiveTrackpadListTest
Change-Id: Ifb14e2949f1f399fbb8b63f493f96d0dd54cc081
2025-01-30 13:25:04 -08:00
Treehugger Robot 473bd5c0a0 Merge "Unifying various model update callbacks into one" into main 2025-01-29 16:05:25 -08:00
Anushree Ganjam dc53407678 Merge "Remove flag_check.py, we now have flag directive check in gerrit presubmit." into main 2025-01-29 13:33:25 -08:00
Treehugger Robot a804d02912 Merge "Refactor: Extract Thumbnail and sysUiStatusNavFlags from TaskContainerVM" into main 2025-01-29 12:04:37 -08:00
Treehugger Robot 66e62820bc Merge "Add debugging logs to understand why addView gets IllegalArgumentException" into main 2025-01-29 10:58:19 -08:00
Sunny Goyal e1e6f7a024 Merge "Using roundIconRes for loading appInfo icon if launcher's icon is round" into main 2025-01-29 10:51:09 -08:00
Sunny Goyal 8141a71281 Merge "Fixing icon shape not properly clipped" into main 2025-01-29 10:43:46 -08:00
Jordan Silva 39549a3843 Refactor: Extract Thumbnail and sysUiStatusNavFlags from TaskContainerVM
Moves the sysUiStatusNavFlags from TaskContainer to TaskView to align it
 with the new thumbnail architecture. This change allows for better
 management and access of this information within the TaskView.

Bug: 390581380
Doc: go/launcher-overview-unified-taskviewmodel
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Test: GetSysUiStatusNavFlagsUseCaseTest
Test: GetTaskUseCaseTest
Test: TaskUiStateMapperTest
Test: TaskViewModelTest
Change-Id: Ic285e41620350dbd3e975b6223e6b7d4cd62d3c0
2025-01-29 17:57:18 +00:00
Sebastián Franco cf060a9871 Merge "Remove screen record annotation from passing test" into main 2025-01-29 09:42:33 -08:00
Sunny Goyal 4c261f7343 Fixing icon shape not properly clipped
> Using ShapeDelegate for icon clipping
> Creating ShapeDelegate based on the current icon shape
> Defining different shape delegates for icon and folder
> Updating preview rendering to use dagger graph
> Adding tests for all icon shapes

Bug: 392145015
Test: atest IconShapesProviderTest
Flag: com.android.launcher3.enable_launcher_icon_shapes

Change-Id: Ic9f287e2a6fef2aad18ba224404de58a64da0bb3
2025-01-29 16:24:38 +00:00
Will Osborn 94a2f2acec Merge "Fix RecentsAnimationListener callback type to match Sys UI type" into main 2025-01-29 06:51:45 -08:00
Sunny Goyal 2fac3efc38 Using roundIconRes for loading appInfo icon if launcher's icon is round
Bug: 392145015
Flag: EXEMPT not-supported during overlay change
Test: Verified manually on device
Change-Id: I7aa571e12318c28f8ff373c19a84d4856c57d6c5
2025-01-29 01:14:18 -08:00
Treehugger Robot 1cbb8fefe6 Merge "Fix errorprone warnings" into main am: 8a281b4ef8 am: b6e2e21180
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/3464325

Change-Id: Ibaff978fb28561a2743e989cf7817277f7defcf6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2025-01-28 20:03:07 -08:00
Treehugger Robot b6e2e21180 Merge "Fix errorprone warnings" into main am: 8a281b4ef8
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/3464325

Change-Id: I6aba6d6e91489d7ed319be2a76b2b1d5f850e700
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2025-01-28 19:38:45 -08:00
Treehugger Robot 8a281b4ef8 Merge "Fix errorprone warnings" into main 2025-01-28 18:56:53 -08:00
Sebastian Franco 057f613d5b Remove screen record annotation from passing test
Fix: 322823478
Fix: 331261431
Test: TaplTestsLauncher3Test
Flag: TEST_ONLY
Change-Id: I5d744b20701ae9a97c4422616f13a5faa55c6c76
2025-01-28 18:54:39 -08:00
Charlie Anderson db9bb3c869 Merge "Convert UserCache to use Dagger" into main 2025-01-28 16:15:03 -08:00
Anushree Ganjam a75d228e1f Remove flag_check.py, we now have flag directive check in gerrit presubmit.
See b/340896878  & go/flag-format-checker-design-doc & go/flag-directive-checker

Bug: 391534772
Test: Manual
Flag: EXEMPT remove flag check hook
Change-Id: I1291678e29a96bae65b63db5d6750e1b48c4601f
2025-01-28 16:03:04 -08:00
Sunny Goyal 36c3112abf Unifying various model update callbacks into one
Making the BubbleTextView.applyItem stateless so that it does not depend on the order of events

Bug: 390572144
Flag: EXEMPT refactor
Test: atest LauncherBindableItemsContainerTest
      atest BubbleTextViewTest
Change-Id: Ib9c0ac6c330d6f4e08c3db5772d35787fa056b65
2025-01-28 16:03:01 -08:00
Anushree Ganjam 79ffb0ed30 Merge "Move SettingsChangeLogger to Dagger." into main 2025-01-28 15:11:59 -08:00
Sukesh Ram d3d6ed0cb2 Add debugging logs to understand why addView gets IllegalArgumentException
Add debugging logs to understand why addView gets IllegalArgumentException

Flag: EXEMPT not adding new behavior
Bug: 391653300
Test: Manual
Change-Id: Ieeae2333dc52d3eab3a11cecc9f382d1cd73f94c
2025-01-28 14:33:26 -08:00
Treehugger Robot e97c7b2a33 Merge "Update device profile tests to account for all apps panel." into main 2025-01-28 13:27:15 -08:00
Schneider Victor-tulias c4aa8188e7 Merge changes I73042126,If7c21ab5 into main
* changes:
  Fix TaplTestsQuickstep test failures with recents window flag on
  Clean up the input stream on TAPL test failure
2025-01-28 13:20:58 -08:00
Treehugger Robot de6fea5e00 Merge "Fix hotseat issue on grid migration where extra items get removed" into main 2025-01-28 12:40:17 -08:00
Charlie Anderson e90282b317 Convert UserCache to use Dagger
Bug: 372012340
Test: Presubmit
Flag: EXEMPT Dagger Change
Change-Id: I36a0a3f56540c0515d99badc127c2ab8534e684e
2025-01-28 15:30:07 -05:00
Bill Yi 578e7f1512 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2025-01-28 11:19:28 -08:00
Bill Yi 778c28ca8b Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2025-01-28 11:19:28 -08:00
Schneider Victor-Tulias 3b71faed91 Fix TaplTestsQuickstep test failures with recents window flag on
Flag: com.android.launcher3.enable_launcher_overview_in_window
Bug: 377678992
Test: pre/postsubmit
Change-Id: I73042126e2af1ffabe8a368d8a02ae1a4552d9a2
2025-01-28 14:05:45 -05:00
Matthew Mourgos e95c163799 Merge "Add flag for mouse interaction changes" into main 2025-01-28 11:03:25 -08:00
Schneider Victor-Tulias c4b8dacd49 Clean up the input stream on TAPL test failure
If a TAPL test fails after injecting a ACTION_DOWN event, but before it had a chance to send the associated ACTION_UP event, every following test that attempts to send a ACTION_DOWN will then fail. Adding a check and clean up for this.

Flag: EXEMPT adding test failure cleanup
Fixes: 392660264
Test: TAPL tests
Change-Id: If7c21ab58a75fbcec55437ca32b7c9cd0aa8d961
2025-01-28 13:54:48 -05:00
Treehugger Robot a8145bc41f Merge "Fix RecentTasksListTest.loadTasksInBackground_freeformTask_createsDesktopTask after flipping a flag" into main 2025-01-28 10:34:58 -08:00
Gustav Sennton b15df95186 Merge "Add CUJ_DESKTOP_MODE_EXIT_MODE_ON_LAST_WINDOW_CLOSE to launcher side" into main 2025-01-28 10:32:41 -08:00
fbaron a80aed9429 Fix hotseat issue on grid migration where extra items get removed
Flag: EXEMPT bugfix
Test: n/a
Fix: 333849747
Change-Id: I6bf3b291de33930764ca8e4fac82c59c328adbde
2025-01-28 17:07:47 +00:00
Will Osborn 96397a3d30 Fix RecentsAnimationListener callback type to match Sys UI type
Test: local run on Tangor & 'adb shell input keyevent KEYCODE_APP_SWITCH'
Flag: EXEMPT bugfix
Bug: 378657004
Change-Id: I0668f135222be48377ae5a05a6d27e084ef085f9
2025-01-28 16:48:47 +00:00
Juan Sebastian Martinez d6479f1b1a Merge "Avoiding MSDL haptics when first starting a drag in workspace." into main 2025-01-28 08:45:28 -08:00
Jordan Silva 2f016c0586 Merge "Refactor: Update task container and thumbnail dimming progress" into main 2025-01-28 08:26:22 -08:00
Alex Chau 64b90c1d92 Fix RecentTasksListTest.loadTasksInBackground_freeformTask_createsDesktopTask after flipping a flag
Change-Id: I3934a37a25279af483e8e19e909c9d6d6727a891
Fix: 392853711
Test: RecentTasksListTest
Flag: EXEMPT TEST_ONLY
2025-01-28 08:25:40 -08:00
Gustav Sennton 1c84b90fe2 Add CUJ_DESKTOP_MODE_EXIT_MODE_ON_LAST_WINDOW_CLOSE to launcher side
Move the CUJ to where the actual animation is taking place, so we can
target the correct surface/leash.

Bug: 374214290
Flag: NONE jank logging
Test: manual

Change-Id: Iccb30ff7ceee84b68428606575e1b8588eeb8aa9
2025-01-28 15:22:01 +00:00
Gustav Sennton 1706f3db11 Merge "Remove old Desktop transitions flags usages" into main 2025-01-28 04:04:09 -08:00
Treehugger Robot 7f4ce77932 Merge "Separate external display tasks in Overview" into main 2025-01-28 03:19:20 -08:00
Jordan Silva beb6122fbe Refactor: Update task container and thumbnail dimming progress
This commit updates the mechanism for dimming task containers and thumbnails in the recents view. These changes simplify the dimming logic and improve the performance of the recents view. It reduces the usage of Flows to propagate progress and animation states through the views and view models.

The following changes were made:

- The `TaskThumbnailViewModel` no longer provides a dimming level.
- The `TaskViewModel` now provides a `tintAmount` flow that represents the dimming level for a task.
- The `TaskContainer` and `TaskThumbnailView` now use the `tintAmount` flow to update their dimming level.
- The `TaskContainer` now also updates the dimming level based on the menu open progress.
- The `TaskThumbnailView` now uses a `MultiPropertyFactory` to manage the dimming level, allowing it to be controlled by both the tint amount and the menu open progress.

Bug: 390581380
Doc: go/launcher-overview-unified-taskviewmodel
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Test: OverviewImageTest
Test: TaskViewModelTest
Test: TaskThumbnailViewModelImplTest
Test: TaskThumbnailViewScreenshotTest
Change-Id: I04d5dee534d56857b977d7f3ed6d4eda9f93be45
2025-01-28 10:33:36 +00:00
Thales Lima 2927a19384 Merge "Stop intercepting QuickSwitch gesture if there are no fullscreen apps open" into main 2025-01-28 02:27:21 -08:00
Anushree Ganjam 545416cc29 Move SettingsChangeLogger to Dagger.
Bug: 361850561
Test: Presubmit
Flag: EXEMPT dagger
Change-Id: I46b740b3eef97ce85ed24d695ed68c12f8e12758
2025-01-27 19:15:16 -08:00
Treehugger Robot 7db4e97a39 Merge "Hook up mAddDesktopButton with the API createDesktop" into main 2025-01-27 15:46:55 -08:00
Juan Sebastian Martinez 1dce6f2503 Avoiding MSDL haptics when first starting a drag in workspace.
The MSDL token to play haptics when dragging was being played as soon as
a widget was long-pressed but not dragged over a new drop-off location.
Haptics should only play while the UI item is being hovered over new
cells. The new condition checks if the drag cell and drag cell span are
cleared and avoids playing haptics in this initial state.

Test: manual. Verified haptics while dragging icons over Workspace and
  Hotseat only when actually dragging over new cells.
Test: manual. Verified haptics with adb shell dumpsys of Launcher and
  checking the MSDL token history.
Flag: com.android.launcher3.msdl_feedback
Bug: 376103470
Change-Id: I7b2056f1c713b65f9df37f3138c1acf3b5376822
2025-01-27 15:00:51 -08:00
Bill Yi d665df4d2e Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I0f05496044144cb34e00c6534eba32a4fa5fdabb
2025-01-27 14:53:46 -08:00
Bill Yi aa5d0faa89 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I8f6c492b85de5cdd5ee7eb66bb9d0d6fe6ee8e8e
2025-01-27 14:52:56 -08:00
Jagrut Desai b3bb1f1c4a Merge "Removing ScreenRecord from test" into main 2025-01-27 13:56:58 -08:00
Alex Chau f70cb57f04 Merge "Rename OverviewProxyService to LauncherProxyService" into main 2025-01-27 13:51:39 -08:00
minch d00382a09d Hook up mAddDesktopButton with the API createDesktop
Add the `setOnClickListener` for the `mAddDesktopButton`,
it will call the `createDesktop` API inside SystemUiProxy
to create a new Desk inside the display that the button
resides in.

Flag: com.android.window.flags.enable_multiple_desktops_frontend
      com.android.window.flags.enable_multiple_desktops_backend
Fix: 391917345
Test: Manual, make sure the callback function `createDesk` is called
      after clicking the button. No real desk will be created
      for now, as the backend hasn't been implemented yet.
Change-Id: I70417a1ce0963b9b3c109c3f3dffaab808212d23
2025-01-27 21:35:41 +00:00