Commit Graph

79020 Commits

Author SHA1 Message Date
Johannes Gallmann 3fa3085242 Merge "Polish back-to-home animation for 3-button-nav" into main 2024-11-20 20:44:34 +00:00
Artsiom Mitrokhin 8ed2ef9029 Merge "Fix the overflow button getting stuck in the dot position" into main 2024-11-20 20:38:12 +00:00
Liran Binyamin d091b42778 Merge "Interrupt bubble animation when IME is visible" into main 2024-11-20 18:45:24 +00:00
Liran Binyamin c4020486b5 Merge "Fix wrong bar state after swiping home" into main 2024-11-20 18:45:06 +00:00
Ats Jenk 2e66e32aba Merge "Apply drag elevation to bubble bar container" into main 2024-11-20 16:53:40 +00:00
Alex Chau 6ce105c269 Merge "Update corner radius calculation in TaskView" into main 2024-11-20 16:18:51 +00:00
Juan Sebastian Martinez 9241d291aa Merge "Adding MSDL history to Launcher's dump information." into main 2024-11-20 16:11:03 +00:00
Liran Binyamin 05eaeb29aa Interrupt bubble animation when IME is visible
When the IME becomes visible, interrupt the bubble animation if it's
running. This ensures that the flyout doesn't show over the IME and
is more consistent with the behavior of bubble notification when the
IME is visible.

Flag: com.android.wm.shell.enable_bubble_bar
Fixes: 378404363
Test: atest BubbleBarViewAnimatorTest
Test: manual
       - launch app
       - send bubble
       - while bubble is animating launch IME
       - observe flyout not visible over IME
Change-Id: I28390982bb41d8cc9b494395418728ff5fb373b6
2024-11-20 10:36:22 -05:00
Liran Binyamin c3b4263218 Fix wrong bar state after swiping home
Interrupt the animation when the user swipes home.

When there are no bubbles the stashed state now keeps getting
updated so that when a bubble is created we can correctly
detect stash change events.

Flag: com.android.wm.shell.enable_bubble_bar
Fixes: 378967270
Test: manual
       - dismiss bubble bar
       - launch app
       - send bubble
       - swipe home during the animation
       - observe the bar does not stash at the end
Change-Id: I2f054b7110af68f9637a4011a378ba35776b3771
2024-11-20 10:35:05 -05:00
Luca Zuccarini 9639fcc387 Merge "Hand off gesture nav animations to registered remotes." into main 2024-11-20 15:00:15 +00:00
Luca Zuccarini afd0d288e0 Merge "Animation takeovers in Predictive Back." into main 2024-11-20 14:16:25 +00:00
Alex Chau a2c1dbc611 Update corner radius calculation in TaskView
TaskThumbnailView
- Set cornerRadius directly from TaskView instead of calulating and listening from ViewModel
- Use onSizeChagned/width/height for OutlineProvider bounds, to be consistent with DesktopTaskContentView

DesktopTaskView
- Moved backgroundView inside DesktopTaskContentView, so its outline can be determiend by OutlineProvider in DesktopTaskContentView
- Update DesktopTaskContentView's cornerRadius when it changes in TaskView

Model/Data chagnes
- Removed TaskViewModel/TaskViewData and scale from RecentsViewData

TaskView
- Add a onBind method to be called after bind, for common post bind handling (e.g. update cornerRadius)

TaskViewSimualtor
- Use DesktopFullscreenDrawParams for desktop task, and moved setIsDesktopTask to CTOR so related fields can be final

Bug: 372237039
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Flag: com.android.window.flags.enable_desktop_windowing_mode
Test: TaskThumbnailViewScreenshotTest, OverviewDesktopTaskImageTest
Test: DesktopFullscreenDrawParamsTest, FullscreenDrawParamsTest, TaskThumbnailViewModelImplTest
Change-Id: If3d195ef6596aa28fce4d4875cf45423cb71811c
2024-11-20 13:55:32 +00:00
Luca Zuccarini 33dfe5e7b3 Hand off gesture nav animations to registered remotes.
This is in support of long-lived return animations in the Animation
library. Sometimes we want the home gesture to minimize the
foreground app into a custom view other than the default Launcher
behavior.

For example, ongoing call will minimize to the status bar chip, even if
the app icon is on Home. This is guaranteed to be handled is the
takeover handler is not null, and only happens in this case (which means
a custom animation has been registered and is ready to run).

Bug: 323863002
Bug: 202516970
Flag: com.android.systemui.shared.return_animation_framework_library
Flag: com.android.systemui.shared.return_animation_framework_long_lived
Test: manual and unit test included
Change-Id: Id7cd1f6e92ad3cbe3c259b3f80c753c91472b455
2024-11-20 10:31:28 +00:00
Johannes Gallmann 8f8d29888a Merge "Disable 3-button-nav buttons during back button hold" into main 2024-11-20 08:39:42 +00:00
Treehugger Robot 5b1796daeb Merge "Fix inaccurate ItemInfo.id from DatabaseHelper with AtomicInteger" into main 2024-11-20 07:05:50 +00:00
Treehugger Robot 3186a14fb4 Merge "Add unit tests for taskbar overflow" into main 2024-11-20 06:30:48 +00:00
Fengjiang Li be930c838f Fix inaccurate ItemInfo.id from DatabaseHelper with AtomicInteger
We can have both bg and UI threads accessing DatabaseHelper to read/write mMaxItemId, thus we should use AtomicInteger to avoid producing duplicated id, which will fail ModelWrite#checkItemInfoLocked

Fix: 379490918
Test: presubmit
Flag: NONE - crash fix
Change-Id: I6cebbb7e854a9eb48ff59b61f5ebba42ea449ec7
2024-11-19 21:18:26 -08:00
Toni Barzic 7a0191e753 Add unit tests for taskbar overflow
The tests verify that number of icons in the task bar does not go beyond
the intended max number, that the taskbar remains centered as it hits
max number of icons, and maintains a minimal margin to the display
edges.
Also, has a test that the max naumber of icons and the taskbar margins
adapt as bubble bar visibility chages.

Adds a TestRule to mock the recents model in the taskbar window sandbox.
The mocked recents model is used to add fake running app icons to the
taskbar.

Bug: 368119679
Test: atest TaskbarOverflowTest
Flag: EXEMPT test only

Change-Id: I8d033c3e95d7c0a4b139502cd7d70882482117c0
2024-11-20 01:48:54 +00:00
Liran Binyamin eb28585e54 Merge "Show the dot after the flyout is interrupted" into main 2024-11-20 00:17:39 +00:00
Ats Jenk 9830496276 Apply drag elevation to bubble bar container
While dragged, bubble bar needs elevation to show up above dismiss view
and dismiss view scrim.
Previously, bubble bar and dismiss view were under the same parent, drag
layer. This allowed us to position bubble bar above dismiss view by
adding elevation to it.
After introducing the bubble bar container, bubble bar is not shown on
top of dismiss view when its elevation changes. Because they are no
longer under the same parent.
Move drag elevation from bubble bar to bubble bar container. The
container and dismiss view are under the same parent.

Bug: 376140375
Test: manual, drag bubble bar or bubble, check they are above dismiss
  view and the scrim
Test: receive a new message, check that flyout is shown
Flag: com.android.wm.shell.enable_bubble_bar
Change-Id: Ie0fb677929bb2413c10b934fc8b362cde7b8cecd
2024-11-19 16:00:00 -08:00
Juan Sebastian Martinez 4c35e50dd4 Adding MSDL history to Launcher's dump information.
The history displays the latest tokens played. Useful for testing and
debugging.

Test: presubmit
Flag: NONE MSDL playback is flagged case by case.
Bug: 377496684
Change-Id: I163889ade9fe4dee7f02459d2d9d81b94197bea1
2024-11-19 15:44:39 -08:00
Artsiom Mitrokhin c5e77d9717 Fix the overflow button getting stuck in the dot position
The root cause was that there were other unaccounted code paths inside
`KeyboardQuickSwitchViewController` that were causing the KQS view
to be closed.

The fix introduces a new `onCloseStarted` callback that is called before
closing the KQS view. This allows to toggle the overflow button together
with the KQS closing animation (in case it closes with animation).

Bug: 379614917
Flag: com.android.launcher3.taskbar_overflow
Test: manual, following steps in the bug
Change-Id: I1868142c1cdba8111cb86c4c54e5b12b643732c5
2024-11-19 22:54:15 +00:00
Treehugger Robot 1efaefe9cb Merge "Add unit testing for InputConsumerUtils" into main 2024-11-19 22:31:15 +00:00
Johannes Gallmann a4b56465ee Disable 3-button-nav buttons during back button hold
Bug: 373544911
Test: TaskbarNavButtonControllerTest
Test: Manual, i.e. verify that pressing buttons in 3-button-nav while the back button is pressed does not have any effect
Flag: com.android.window.flags.predictive_back_three_button_nav
Change-Id: I5abad5f2f74d09c790380a2eeb27aff3b780b925
2024-11-19 22:11:59 +00:00
Treehugger Robot 33a9c4936b Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-11-19 21:49:29 +00:00
Treehugger Robot 30d06bba2d Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-11-19 21:49:29 +00:00
Schneider Victor-Tulias df1ac14415 Add unit testing for InputConsumerUtils
Flag: EXEMPT unit testing
Bug: 371020209
Test: InputConsumerUtilsTest
Change-Id: Ia3f9c13dae7650dc0ae37b48b1d75e84cac60142
2024-11-19 15:39:57 -05:00
Maryam Dehaini 9163f54158 Merge "Set task corner radius to match spec" into main 2024-11-19 19:00:45 +00:00
Liran Binyamin 5a45c34514 Show the dot after the flyout is interrupted
When the bubble notification animation is interrupted, we now
animate the dot back in so that it is visible.

Before this change we unsuppressed the dot which should normally
make the dot visible. The problem was that when the animation is
interrupted we immediately clear the animating bubble field but
showing the dot happens at the end of the flyout fade animation.

This change also animates the dot back in instead of setting the
scale immediately to 1.

Flag: com.android.wm.shell.enable_bubble_bar
Fixes: 379733568
Test: manual
       - launch app
       - send a bubble
       - when the flyout shows, swipe to go home
       - observe animation is cleared and dot is visible
Change-Id: Ie7a10ddf237480ac6555d5f2b40da343394ce77f
2024-11-19 13:45:39 -05:00
Brandon Dayauon 74842f0c16 Merge "Fix work tab accessbility issues." into main 2024-11-19 18:44:14 +00:00
Marzia Favaro 6db5c5a772 Merge "Enable split screen from app handle also for non-desktop devices" into main 2024-11-19 18:18:32 +00:00
Brian Isganitis 79809b448c Merge "Add annotation to simulate RTL in tests." into main 2024-11-19 16:30:34 +00:00
Juan Sebastian Martinez 3f0d356619 Merge "Adding MSDL feedback to dragging apps and widgest over drop targets." into main 2024-11-19 15:58:35 +00:00
Marzia Favaro fadf3a891c Enable split screen from app handle also for non-desktop devices
Test: manual, open menu and go to split screen
Flag: com.android.window.flags.show_app_handle_large_screens
Bug: 377689543
Change-Id: Iaf8794abc1111c4ebce9254f6f5d1bada7f57dd5
2024-11-19 15:19:34 +00:00
Johannes Gallmann 40f6f9b28a Polish back-to-home animation for 3-button-nav
Move window to the screen center when the animation is driven by a long press on the back button in 3-button-nav.

Bug: 373544911
Test: Manual, i.e. verify that app is center scaled
Flag: com.android.window.flags.predictive_back_three_button_nav
Change-Id: I8bacb923e3c81d99ddc1a8900bcc7423c8276c55
2024-11-19 14:59:14 +00:00
Liran Binyamin 275e62e946 Merge "Fix bubble animation when swiping home" into main 2024-11-19 14:34:16 +00:00
Luca Zuccarini 4a05c8b739 Animation takeovers in Predictive Back.
Bug: 323863002
Flag: EXEMPTY empty implementation
Test: NA empty implementation
Change-Id: I8a9ec1a4fb7fc400ce3c4e79ef3a234fbaf12dd0
2024-11-19 11:05:37 +00:00
Marcelo Arteiro 7cc2483b47 Merge "Fix home screen briefly flashes after setup." into main 2024-11-19 08:39:26 +00:00
Sebastián Franco 3448777679 Merge "Changing name of RowCount to GridDimension to be more general" into main 2024-11-19 05:36:43 +00:00
Bill Yi 54d198b191 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I5fbd48cc57813d4982e2f1c72f879bd442608b94
2024-11-18 20:01:02 -08:00
Bill Yi 089d2deb3c Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I15be96ff4c9728db28f0de164d5cae51a20beb81
2024-11-18 20:00:12 -08:00
Treehugger Robot 7f103a6d5c Merge "Remove any fixed landscape foldable dumps" into main 2024-11-19 02:54:46 +00:00
Federico Baron dd28335d78 Remove any fixed landscape foldable dumps
Bug: 364711064
Flag: com.android.launcher3.one_grid_specs
Test: DeviceProfileAlternativeDisplaysDumpTest
Change-Id: I71f026d34dd536cc4041e1dd36908824eb479153
2024-11-19 00:49:26 +00:00
Winson Chung 1ab7bd8357 Merge "Keep nav button container and back button stable during SUW" into main 2024-11-19 00:11:25 +00:00
Shamali Patwa f05d59cdad Merge "Update the enforce_system_radius_for_app_widgets flag's type" into main 2024-11-19 00:03:34 +00:00
Shamali Patwa 797b636491 Merge "Add container around the previews in the pin widget sheet." into main 2024-11-19 00:02:47 +00:00
Sunny Goyal 9b5b0c9598 Merge "Wait for animations before injecting input event" into main 2024-11-18 23:53:14 +00:00
Artsiom Mitrokhin ddb0546277 Merge "Use dynamic/relative sizes for taskbar overflow button" into main 2024-11-18 23:47:38 +00:00
Treehugger Robot f3b950340c Merge "Close repeatedly unclosed resources at the end of tests" into main 2024-11-18 23:21:43 +00:00
Brandon Dayauon df5e51ce34 Fix work tab accessbility issues.
The issue is that the accessibility scanner says tap target is 46dp rather than 48dp because of the 1dp padding that is added
to the viewgroup. Rather, we should delegate that 1dp to the insets of the drawable instead.

bug: 379222957
Test manually, photos:
beforeAccessibilityscanner: https://drive.google.com/file/d/1-XssMfXstpKQk5Ve7l5UCPFORtCkYluH/view?usp=sharing
before:https://drive.google.com/file/d/1rip4gIKpoOw-cCNroEjrpcJ9TMSthHhB/view?usp=sharing
after: https://drive.google.com/file/d/1dOh4yxEAPBG_pGn92yUGizTCLTTW1w2K/view?usp=sharing
Flag: NONE bug fix changing dp

Change-Id: I5ac69e5d92bbbbc3617e30801316eb04d65ace7a
2024-11-18 15:16:41 -08:00