Commit Graph

19855 Commits

Author SHA1 Message Date
Sunny Goyal 55b5e41d8a Merge "Removing Smartspace as a widget flag" into main 2025-05-05 10:01:05 -07:00
Schneider Victor-tulias a8053f8cba Merge "Support the gesture nav contract for recents in window" into main 2025-05-03 20:02:30 -07:00
Treehugger Robot 418a8e4aa9 Merge "Update All Apps divider color." into main 2025-05-02 17:43:28 -07:00
Treehugger Robot b393e253de Merge "Fix Data Import for folder-internal items" into main 2025-05-02 17:17:51 -07:00
Andy Wickham 28f422544e Update All Apps sheet interpolators.
This is a bit of a stopgap until we are able to adopt a more
versatile mechanism similar to SysUI, but here's the high level:
 - Workspace scale finishes more quickly than blur (53% vs 83% of
   the transition)
 - Closing All Apps reverses the opening interpolators (avoid blur
   disappearing too quickly).

Design intent is described in the bug.

Demo: https://drive.google.com/file/d/14Y28NeHoh_RBh3acXijhhx_ZIUK8GmYy/view?usp=drive_link&resourcekey=0-A9AUbEZcJsmP1GtSqbbrgg

Bug: 415247657
Flag: com.android.launcher3.all_apps_sheet_for_handheld
Flag: com.android.launcher3.all_apps_blur
Test: Manual
Change-Id: Iffa8e6f9dd98817899aadb3fb28fecd6c53bca7e
2025-05-02 13:36:27 -07:00
Schneider Victor-Tulias 9118d87d84 Support the gesture nav contract for recents in window
- Support for the GNC allows for some additional animations and clean up. The missing clean up was causing test failures
- Also fixing broken GNC support for split apps. Swiping up from split apps caused consistent crashes, however since the current 1P swipe to home has no special animation, updating the recents window and 3P GNC to match this.

Flag: com.android.launcher3.enable_launcher_overview_in_window
Bug: 377678992
Test: pre/postsubmit; swipe home from 1P and 3P launcher
Change-Id: Idf24d7969e76a50ff656f6644c2b568c42e409d7
2025-05-02 15:32:51 -04:00
Stefan Andonian 1725d9d75f Fix Data Import for folder-internal items
Bug: 379378706
Test: Verified this works locally.
Flag: com.android.launcher3.external_data_access
Change-Id: I0396a593bd02591ae599e0eb9b9e44922bd17960
2025-05-02 10:55:17 -07:00
Sunny Goyal 46b13eb184 Moving WorkspaceItemFactory to dagger as PredictedItemFactory so that it can be reused
Bug: 390572144
Flag: EXEMPTY refactor
Test: Presubmit
Change-Id: I41c5fea73452d7f4c1fd9980a89bcb7199eb19d7
2025-05-02 08:55:21 -07:00
Alex Chau 14f266442b Merge "Don't consider IME insets in mSystemGestureRegion" into main 2025-05-02 01:47:08 -07:00
Sunny Goyal 7a332e02aa Removing Smartspace as a widget flag
Bug: 300140279
Flag: EXEMPT removing dead code
Test: Presubmit
Change-Id: If24db0b4c2c119f5cbe1153e3d77599d12ff80a6
2025-05-01 16:00:04 -07:00
Sunny Goyal 982dafadc9 Merge "Using List instead of ArrayList in CollectionInfo to avoid typecast in subclasses" into main 2025-05-01 13:30:47 -07:00
Treehugger Robot 5d600e171d Merge "Fix folder close animation from jumping by initializing animation manager correctly." into main 2025-05-01 11:01:13 -07:00
Alex Chau 033c8535c7 Don't consider IME insets in mSystemGestureRegion
- A recent change applied IME insets equal to keyboard's height to Launcher's BaseDragLayer
- mSystemGestureRegion takes a max of both IME insets and gesture insets, and caused a bug that while a live tile have keyboard open is in Overview, bottom half of the screen ignored touches to dismiss the task
- The bug that ointroduceds IME insets consideration no longer repros, thus removing IME insets from mSystemGestureRegion to sovle the issue

Fix: 404376494
Test: manual
Flag: EXEMPT bug fix
Change-Id: I5d8861ea204df9898b10cb7ccdeba94e94e5909c
2025-05-01 15:54:06 +01:00
Andy Wickham 1e2e88a884 Update All Apps divider color.
Also update how theming is applied. We pass a ContextThemeWrapper
to relevant views to retrieve the updated colors.

Demos switching blur on and off with adb:
 - From top (QSB, handle, divider): https://drive.google.com/file/d/1FHNzp5bNbNtH8tM7rSjKELPr6hsETPST/view?usp=drive_link&resourcekey=0-JuiAUJoNh4Pe_xKa74h0-g
 - Scrolled down (header protection + private space): https://drive.google.com/file/d/1gb1GCH3tJHS7HzOjvXgrTxNQ9gfD59dw/view?usp=drive_link&resourcekey=0-AK58FpfN-sDfWhWkmqaEmA

Test: Manual
Flag: com.android.launcher3.all_apps_blur
Fix: 413143411
Change-Id: I5da3b7c38ea4f81dec1011b6cc15ad8b591c761b
2025-05-01 02:25:02 +00:00
Treehugger Robot 1ca1bf9c9d Merge "Apply fallback overview scrim, overviewactions and clearall in battery saver mode." into main 2025-04-30 19:13:54 -07:00
Treehugger Robot 3a21402211 Merge "Fix crash when previously selected shape no longer exists" into main 2025-04-30 17:13:19 -07:00
Sunny Goyal 9ec1c5f691 Using List instead of ArrayList in CollectionInfo to avoid typecast in subclasses
Bug: 390572144
Test: Presubmit
Flag: EXEMPT refactor
Change-Id: I57c1a7c0c0ea32e710e1d7c03f249f84fc937196
2025-04-30 16:07:43 -07:00
Charlie Anderson b801585f92 Fix crash when previously selected shape no longer exists
Flag: com.android.launcher3.enable_launcher_icon_shapes
Flag: com.android.systemui.shared.new_customization_picker_ui
Bug: 414860182
Test: manually flipping icon shapes flag off and opening new picker
Change-Id: I1fdb1a5f790438055fae28c65e4653d97042ea7f
2025-04-30 17:39:44 -04:00
Jagrut Desai 95ee12ff94 Merge "Auto-Stashing Functionality for Pinned Taskbar" into main 2025-04-30 13:30:06 -07:00
Charlie Anderson 5dfcbf1bb1 Fix folder close animation from jumping by initializing animation manager correctly.
Bug: 414528208
Test: creating new folder and opening/closing
Flag: EXEMPT bugfix
Change-Id: Ic9b587d170804297e6e67d673059c8a839d409bc
2025-04-30 14:53:07 -04:00
Shamali Patwa bcceb28d2e Merge "Account for cell size changes in resize frame when changing display size" into main 2025-04-30 11:16:37 -07:00
Jagrut Desai f52ffc1232 Auto-Stashing Functionality for Pinned Taskbar
This cl includes :
- Refactor to remove unpinning/pinning in desktop mode with refactor of DisplayController, TaksbarPinningController, and its tests.
- Combined the auto stashing conditions under one method shouldAllowTaskbarToAutoStash() which takes in consideration isTransientTaskbar, isInDesktop, and Always Show Taskbar option is turned on/off in desktop mode.
- enabled taksbar divider popup support in desktop mode.
- Intorduced animation for pinned taksbar when autostadhing is enabled.
- Enable to onSwipeToUnstashTaskbar for TaskbarInputStashController for pinned taksbar in desktop mode.

Test: Presubmit, Unit, Manual
Bug: 381535785
Flag: com.android.window.flags.enable_desktop_windowing_mode
Change-Id: Ie5ecf3a3c72bf8dfadf2d0c908269305fe5bad0b
2025-04-30 10:39:58 -07:00
Sunny Goyal dd367a2218 Merge "Converting BgDataModel to Kotlin" into main 2025-04-30 10:19:46 -07:00
vinayjoglekar 45cb055158 Apply fallback overview scrim, overviewactions and clearall in battery saver mode.
1. BlurFallbackStyle/BlurStyle will now be applied in Launcher startup.
   When "updateBlurStyle" is called, individual element style's swap
   happens as per blur style.
2. "hasOpaqueBg" background will now be checked in "applyDepthAndBlur"
   for setting the "currentBlur" value.

Bug: 409758306
Test: Manual. go to overview, enable/disable battery saver mode.
Flag: com.android.launcher3.enable_overview_background_wallpaper_blur
Change-Id: Ic9030c2b267867b9124705426dd51deb1b30ca55
2025-04-30 17:23:42 +01:00
Shamali P de578610a1 Account for cell size changes in resize frame when changing display size
- On display change, we don't seem to re-arrange workspace widgets
 whose current span size may no longer be a valid
- In some cases, the existing span showing on workspace is less than
the widget's min size and user is unable to resize to the correct size.
- Ideally irrespective of problem they should be able to resize to
 correct size.

This cl lets user resize to valid size. In another bug we might want to
evaluate refreshing / updating widgets on display change.

Bug: 408974387
Test: See demo
Flag: EXEMPT BUGFIX
Change-Id: I9712a20739ec8ee1de9d85f22814c7f1b3474e47
2025-04-30 02:06:05 +00:00
Sunny Goyal 036ced4703 Converting BgDataModel to Kotlin
This will allow the use of Flows in BgDataModel

Flag: EXEMPT refactor
Bug: 390572144
Test: Presubmit
Change-Id: I8fdd1635a19ae4d75260fb1ddb9cd7ab00cd0496
2025-04-29 15:37:11 -07:00
Shamali Patwa 32a30e410c Merge "Fix widget size in wallpaper preview when switching the grid" into main 2025-04-29 14:40:15 -07:00
Sebastián Franco d23b8fc142 Merge "Always change the container when dropping in icon" into main 2025-04-29 09:51:09 -07:00
Treehugger Robot 6305597a67 Merge "Update the PageIndicatorDots to track scroll progress." into main 2025-04-28 13:54:42 -07:00
Treehugger Robot 3bde3a8331 Merge "Update blur style for more things." into main 2025-04-28 13:51:25 -07:00
Shamali P 5ad55f2c68 Fix widget size in wallpaper preview when switching the grid
Currently there is a bit of inconsistency in the way grid change
happens.

1. Grid migration decides different size, inflate item uses
different, and scale is applied using yet another size.

2. also when
going from small -> medium we reload data, but if while wallpaper picker
is open, if we revert to small, it leads to a wrong state due to
inconsistencies in #1 and shows cropped widget content. Instead in this
cl, we always reload on grid update, so widgets are shown for correct
size. There is still possibility of issue if the widget didn't respond
with data - but even in public build today there are tons of issues with
widgets on changing grid.

Bug: 408934352
Flag: EXEMPT BUGFIX
Test: See demo.
Change-Id: I91741d762cbf34ab7f9e0269ea307d2aad9e0eda
2025-04-28 12:20:15 -07:00
Sebastian Franco fea773a5c2 Always change the container when dropping in icon
I was being cautios on my previous fix for this same
isse, cautios because I'm modifying an object by reference
That's why I was only updating the container when the icon being
dropped was PendingAddShortcutInfo but we can change the container
on every icon (we don't need to in the Widget case which is the
other if statement), we can be sure it is a safe operation because
we later update the info anyway rendering the previous info invalid.

Fix: 413784315
Test: WIP
Flag: EXEMPT bug fix
Change-Id: I60ecdb52be1c7bf0584cb1c74ee15b85961e5012
2025-04-28 11:57:17 -07:00
Sunny Goyal 07cfe33533 Renaming CONTAINER_PREDICTION to CONTAINER_ALL_APPS_PREDICTION
This avoids confusion with CONTAINER_HOTSEAT_PREDICTION

Bug: 390572144
Flag: EXEMPT refactor
Test: Presubmit
Change-Id: I0e110e2884dd0566bd2e621e60e7458605b9bad7
2025-04-28 09:30:12 -07:00
Pat Manning 9ee290e81f Cancel ongoing dismiss animation when Launcher state changes.
Fix: 410744889
Test: Manual
Flag: com.android.launcher3.enable_expressive_dismiss_task_motion
Change-Id: I5e81de6762e7d0ea47f8574599901aac1bb8bb77
2025-04-28 10:27:29 +01:00
Andy Wickham 6610425a1d Update blur style for more things.
- Quick Launch highlight (focusHighlight)
 - Drag bar at top of All Apps
 - Divider inside Private Space

Demo (enabling blur via adb in the middle):
https://drive.google.com/file/d/1MjYn1c1mz3m1llmJ-J6kLHUa1j3biv_H/view?usp=drive_link&resourcekey=0-6d1yf_4zDL0W9nTYe6HLNQ

Fix: 413143411
Test: Manual
Flag: com.android.launcher3.all_apps_blur
Change-Id: I37340759867aba1460fb038269d21c86e8b3c4f6
2025-04-26 01:25:05 +00:00
Treehugger Robot fe7225eace Merge "Move LauncherRestoreEventLogger to dagger" into main 2025-04-25 14:11:18 -07:00
Charlie Anderson 8d52e8749d Merge "Fix install finish animation so that icon correctly scales over the progress bar" into main 2025-04-25 13:22:15 -07:00
Treehugger Robot 703d6f6f55 Merge changes from topic "folder-arrows-pointer" into main
* changes:
  Only Show Folder Arrows if Mouse or Trackpad is Connected to Device
  Make Width Calculation Exact
2025-04-25 11:53:41 -07:00
George Lin 19345d7b39 Merge "Fix SurfaceControlViewHost holding surface view (1/4)" into main 2025-04-25 10:37:01 -07:00
Charlie Anderson c881ed65e7 Fix install finish animation so that icon correctly scales over the progress bar
- Also clean up some of the draw code

Bug: 377938340
Test: installing apps to finish
Flag: com.android.launcher3.enable_launcher_icon_shapes
Change-Id: If5e825a4bc54c62e183be980e12a0c6ee14e4dff
2025-04-25 07:20:24 -07:00
Anushree Ganjam 06bc3f5301 Move LauncherRestoreEventLogger to dagger
Helps us to delete ResourceBasedOverride class.
Delete "launcher_restore_event_logger_class" resource from config.

Bug: 361850561
Test: Presubmit
Flag: EXEMPT dagger
Change-Id: Ia11162979f016513bd09e06796346d29699b2efd
2025-04-25 01:02:28 +00:00
Stefan Andonian ad6841aaf3 Update the PageIndicatorDots to track scroll progress.
animateToPosition now only occurs if the user performs a fling.

Bug: 394355070
Test: Verified this works locally. Please see the bug for a screen recording of the working behavior.
Flag: com.android.launcher3.enable_launcher_visual_refresh
Change-Id: Ic57495e3aec00d903ed948b887723b1389337c8d
2025-04-24 14:00:31 -07:00
Stefan Andonian cffeb99122 Only Show Folder Arrows if Mouse or Trackpad is Connected to Device
Bug: 394355070
Test: Verified correct behavior locally. See screen recording on https://buganizer.corp.google.com/issues/394355070#comment28
Flag: com.android.launcher3.enable_launcher_visual_refresh
Change-Id: I7132b892b3bd8ee3af2cdca58b6e70f3a219c8f4
2025-04-24 13:59:21 -07:00
Stefan Andonian e0dffed77b Make Width Calculation Exact
Bug: 394355070
Test: Verified locally that indicator dots are not cut off with 6 pages. See screen recording on https://buganizer.corp.google.com/issues/394355070#comment28
Flag: com.android.launcher3.enable_launcher_visual_refresh
Change-Id: I5b0ac0441201e8dafcba10ff52ac24e1821815b9
2025-04-24 13:59:07 -07:00
Charlie Anderson 998d0fa210 Merge "Handle exception thrown for missing Component during restore" into main 2025-04-24 11:39:01 -07:00
George Lin ddabe29d29 Fix SurfaceControlViewHost holding surface view (1/4)
Test: Use dumpsys to check if SurfaceControlViewHost still exists
Bug: 410052692
Flag: com.android.systemui.shared.new_customization_picker_ui
Change-Id: Ibbb29445422dd37e764be2f518c9d528340cdfaa
2025-04-24 14:26:04 +00:00
Charlie Anderson 66d7ed5531 Merge "Implement specs for shaped progress bars" into main 2025-04-24 07:07:52 -07:00
Charlie Anderson 35ab082cfc Implement specs for shaped progress bars
Bug: 377938340
Flag: com.android.launcher3.enable_launcher_icon_shapes
Test: installing/unarchiving apps
Change-Id: Ifdee0dc2d2758a4a7412996442716d2a22faa8c4
2025-04-23 17:31:02 -04:00
Treehugger Robot 59e208c28e Merge "Moving various launcher binding logic, outside LauncherModel" into main 2025-04-23 12:32:54 -07:00
Treehugger Robot ab4794a638 Merge "Fixing crashes due to code 1032 SQLITE_READONLY_DBMOVED" into main 2025-04-23 12:31:46 -07:00