In TaskViewUtils, the StateManager#movetoRestState method is invoked after the recents animation finishes and before the launcher state is reapplied. The issue leading to a phantom transition is that moveToRestState initiates an animation due to RecentsWindowManager#shouldAnimateStateChange always returns true.
Connected display overview is similar to 3P recents. And thus, we follow RecentsActivity#shouldAnimateStateChange to always return false.
Test: manually click on a overview tile in the connected display. No phantom animation is observed after switching to the app.
Flag: com.android.launcher3.enable_overview_on_connected_displays
Bug: 415245440
Change-Id: I3c9600cae6ce9058749365734f433f5e3cdb9445
Basically the same places we were notifying expensive frames.
Test: forrest perf suites
Flag: com.android.launcher3.all_apps_blur
Bug: 410973453
Change-Id: Ifb8ee7010e0faacc9ccc21076fc8614f335e2863
The test don't run yet in presubmit, first I will have the NexusLauncherE2ETests
target ready and then I will add it to the presubmit.
Bug: 324261526
Flag: EXEMPT test only
Test: atest NexusLauncherE2ETests
Change-Id: I4daa204ec735456c481b0682ca518da381af7bb7
When there's no background panel, we should ensure an opaque
background scrim is used.
Fix: 414718408
Test: Manual with all_apps_blur and all_apps_sheet_for_handheld off.
Flag: EXEMPT bugfix
Change-Id: I1ac9f5f8fbb01f2c6a42e9f79823b5f293ebf709
This is a bit of a stopgap until we are able to adopt a more
versatile mechanism similar to SysUI, but here's the high level:
- Workspace scale finishes more quickly than blur (53% vs 83% of
the transition)
- Closing All Apps reverses the opening interpolators (avoid blur
disappearing too quickly).
Design intent is described in the bug.
Demo: https://drive.google.com/file/d/14Y28NeHoh_RBh3acXijhhx_ZIUK8GmYy/view?usp=drive_link&resourcekey=0-A9AUbEZcJsmP1GtSqbbrgg
Bug: 415247657
Flag: com.android.launcher3.all_apps_sheet_for_handheld
Flag: com.android.launcher3.all_apps_blur
Test: Manual
Change-Id: Iffa8e6f9dd98817899aadb3fb28fecd6c53bca7e
If the end target is null, that means the gesture did not move
enough to calculate an actual end target, and LAST_TASK is the
default for that case. We probably don't need the desktop check
specifically (could clean it up in a follow up) but since this
bug is specifically for Desktop mode I left it in for now.
Fixes: 359879541
Test: manual, tap Taskbar in Desktop and ensure no flicker
Flag: EXEMPT bugfix
Change-Id: Icc3e645819a22ed96d07a575cdccda30a5d800c1
- Support for the GNC allows for some additional animations and clean up. The missing clean up was causing test failures
- Also fixing broken GNC support for split apps. Swiping up from split apps caused consistent crashes, however since the current 1P swipe to home has no special animation, updating the recents window and 3P GNC to match this.
Flag: com.android.launcher3.enable_launcher_overview_in_window
Bug: 377678992
Test: pre/postsubmit; swipe home from 1P and 3P launcher
Change-Id: Idf24d7969e76a50ff656f6644c2b568c42e409d7
- Apply scrollOffset directly to tvs.recentsViewCroll, which already take orientationHandler into account
- Apply gridTranslationY directly to taskSecondaryTranslation, which already take orientationHandler into account
- This make sure both translations are applied after mTaskRectTransform
- Also re-calculate tvs task size after updating orientationState rotations, as the orientationHandler might be changed and affect task position
- Remove setTaskRectTranslation that is no longer used
Flag: EXEMPT bugfix
Test: manual with central/side task launching with portrait, fake landscape and 3p launcher
Bug: 410628946
Change-Id: I8ef38d193328e8a449594515403c00f517e213b3
We previously sent the top coordinate of the bubble bar to shell.
However when the screen height changes, launcher takes a bit longer
to update than shell. So instead of calculating the top coordinate
on the launcher side, we now send the amount of space between the
bubble bar and the bottom of the screen to shell, where we can offset
that as needed.
Bug: 392893178
Flag: com.android.wm.shell.enable_bubble_bar
Test: manual
- send some bubbles
- launch app
- expand
- swipe to home
- fold and unfold
Change-Id: I57b96db49dab1e2304fde8dc55a99eaaf85e40f8
- Only primary displays should use LauncherTaskbarUIController.
- This change is required for overview on connected displays to work.
Bug: 362720616
Test: m
Flag: com.android.window.flags.enable_taskbar_connected_displays
Change-Id: I6945107e6072561b1904dcafd6106d4317eaba1d
... to launch an individual task window from desktop tile in Overview
when multi-desks is enabled, until the fix for b/413378320 is landed.
Note the changes in
http://ag/q/topic:%22activate-window-from-exploded-view%22 is the right
implementation, however it will only work for multi-desks with the fix
for b/413378320 is in place.
Flag: com.android.launcher3.enable_desktop_exploded_view
Test: Manual
Bug: 413378320
Change-Id: I72914d60fb0ec2e80af6faa7441a67e743720c38
- scroll if the header is under gesture region and click in same scroll loop
Test: Local, Presubmit
Bug: 402828709
Flag: EXEMPT bugfix
Change-Id: I90a5cf2829591aafd18ef625244def2c4d9e3980
Steven Ng
Treehugger Robot
Li Lin
Sebastián Franco
Andy Wickham
Daniel Andersson
Fengjiang Li
Sunny Goyal
Bill Yi
Schneider Victor-tulias
Liran Binyamin
Ats Jenk
Tony Wickham
Suhua Lei
Xiaoqian (Daisy) Dai
Stefan Andonian
Jagrut Desai
Pat Manning
Alex Chau
Ajinkya Chalke
Vadim Tryshev